-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44501/#review127983
-----------------------------------------------------------


Ship it!




Thanks for adding the test Li!

- Sravya Tirukkovalur


On March 30, 2016, 6:06 a.m., Li Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44501/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 6:06 a.m.)
> 
> 
> Review request for sentry, Anne Yu, Hao Hao, Lenni Kuff, and Sravya 
> Tirukkovalur.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Add SSL support, print version info on Sentry Service webpage
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/pom.xml 
> bf4dfdc1de90b1018767e2a61bee970655f02682 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java
>  1bdea2c55de12a999f94ea33f8709311c7c2c7f2 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java
>  94bd2a95c77a9691cbaa578ebf417e49c339b7ed 
>   sentry-provider/sentry-provider-db/src/main/webapp/SentryService.html 
> ee112ce8d39626784d5d73ef0a4c28f43e7c4f1f 
>   sentry-provider/sentry-provider-db/src/main/webapp/css/sentry.css 
> e5b3d437406a881e78494547791e1b26bb4f2bc8 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServerWithSSL.java
>  PRE-CREATION 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java
>  e02bd8a9ffbf73424790e6a574a2976c97c94b1f 
>   sentry-provider/sentry-provider-db/src/test/resources/cacerts.jks 
> PRE-CREATION 
>   sentry-provider/sentry-provider-db/src/test/resources/keystore.jks 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44501/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Li Li
> 
>

Reply via email to