Re: Review Request 48761: SENTRY-1316 Implement Sentry leadership election

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48761/#review139195 --- Ship it! Ship It! - Hao Hao On June 22, 2016, 11:12 p.m., Co

Re: Review Request 48761: SENTRY-1316 Implement Sentry leadership election

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48761/ --- (Updated June 22, 2016, 11:12 p.m.) Review request for sentry. Changes --

Re: Review Request 48761: SENTRY-1316 Implement Sentry leadership election

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48761/#review139130 --- Ship it! Ship It! - Sravya Tirukkovalur On June 22, 2016, 7:

Re: Review Request 48761: SENTRY-1316 Implement Sentry leadership election

> On June 21, 2016, 12:55 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatus.java, > > line 75 > > > > > > May be comment on why is thi

Re: Review Request 48761: SENTRY-1316 Implement Sentry leadership election

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48761/ --- (Updated June 22, 2016, 7:42 p.m.) Review request for sentry. Bugs: SENTRY-13

Re: Review Request 48761: SENTRY-1316 Implement Sentry leadership election

> On June 21, 2016, 12:55 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatus.java, > > lines 80-84 > > > > > > Curious if there is an a

Re: Review Request 48761: SENTRY-1316 Implement Sentry leadership election

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48761/ --- (Updated June 22, 2016, 6:31 p.m.) Review request for sentry. Bugs: SENTRY-13

Re: Review Request 48761: SENTRY-1316 Implement Sentry leadership election

> On June 22, 2016, 12:45 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatus.java, > > line 33 > > > > > > Add "It handles both the HA and non-HA c

Re: Review Request 48761: SENTRY-1316 Implement Sentry leadership election

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48761/#review138965 --- Thanks Colin, great work! Leaved some comments. sentry-provider/

Re: Review Request 48761: SENTRY-1316 Implement Sentry leadership election

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48761/ --- (Updated June 21, 2016, 4:18 p.m.) Review request for sentry. Bugs: SENTRY-13

Re: Review Request 48761: SENTRY-1316 Implement Sentry leadership election

> On June 21, 2016, 12:55 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatus.java, > > line 75 > > > > > > May be comment on why is thi

Re: Review Request 48761: SENTRY-1316 Implement Sentry leadership election

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48761/#review138824 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Review Request 48761: SENTRY-1316 Implement Sentry leadership election

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48761/ --- Review request for sentry. Bugs: SENTRY-1316 https://issues.apache.org/jira