Re: Review Request 53905: SENTRY-1518: Add metrics for SentryStore transactions

2016-11-30 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53905/ --- (Updated Dec. 1, 2016, 3:08 a.m.) Review request for sentry, Colm O hEigeartaig

Re: Review Request 53905: SENTRY-1518: Add metrics for SentryStore transactions

2016-11-30 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53905/#review157504 --- Fix it, then Ship it! sentry-service/sentry-service-server/src

Re: Review Request 53905: SENTRY-1518: Add metrics for SentryStore transactions

2016-11-19 Thread Vadim Spector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53905/#review156412 --- Ship it! Ship It! - Vadim Spector On Nov. 18, 2016, 10:50 p.

Re: Review Request 53905: SENTRY-1518: Add metrics for SentryStore transactions

2016-11-18 Thread Alexander Kolbasov
> On Nov. 18, 2016, 11:59 p.m., Vadim Spector wrote: > > Since executeTransactionWithRetry() calls executeTransaction(), and both > > APIs are public, I wonder if we care about separate counters for both, to > > distinguish between intermittent and more serious failures. > > > > For the client

Re: Review Request 53905: SENTRY-1518: Add metrics for SentryStore transactions

2016-11-18 Thread Vadim Spector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53905/#review156357 --- Since executeTransactionWithRetry() calls executeTransaction(), an

Review Request 53905: SENTRY-1518: Add metrics for SentryStore transactions

2016-11-18 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53905/ --- Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, Sravya Tirukk