Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

2018-05-08 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/#review202666 --- Ship it! Assuming that changes are verified in mysql/db2/oracle

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

2018-05-08 Thread Na Li via Review Board
> On May 4, 2018, 8:21 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/resources/011-SENTRY-2154.derby.sql > > Lines 24-44 (patched) > > > > > > Lina, Is the the user privileges ar

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

2018-05-08 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/ --- (Updated May 8, 2018, 2:45 p.m.) Review request for sentry, Alexander Kolbasov,

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

2018-05-08 Thread kalyan kumar kalvagadda via Review Board
> On May 4, 2018, 8:21 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/resources/011-SENTRY-2154.derby.sql > > Lines 24-44 (patched) > > > > > > Lina, Is the the user privileges ar

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

2018-05-04 Thread Na Li via Review Board
> On May 4, 2018, 8:21 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/resources/011-SENTRY-2154.derby.sql > > Lines 24-44 (patched) > > > > > > Lina, Is the the user privileges ar

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

2018-05-04 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/#review202480 --- Ship it! Ship It! - Arjun Mishra On May 4, 2018, 7:25 p.m.,

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

2018-05-04 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/#review202475 --- sentry-provider/sentry-provider-db/src/main/resources/011-SENTRY-

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

2018-05-04 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/#review202468 --- Ship it! Thanks Lina. The patch looks good. - Sergio Pena On

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

2018-05-04 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/ --- (Updated May 4, 2018, 7:25 p.m.) Review request for sentry, Alexander Kolbasov,

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

2018-05-04 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/ --- (Updated May 4, 2018, 7:25 p.m.) Review request for sentry, Alexander Kolbasov,

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

2018-05-04 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/ --- (Updated May 4, 2018, 4:51 p.m.) Review request for sentry, Alexander Kolbasov,

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

2018-05-03 Thread Na Li via Review Board
> On May 3, 2018, 8:30 p.m., Sergio Pena wrote: > > Lina, > > > > What about the rest of the sentry-upgrade-*-2.0.0-to-2.1.0.sql files? > > Such as sentry-upgrade-postgres, sentry-upgrade-oracle, > > sentry-upgrade-mysql and sentry-upgrade-derby? The reason db2 has upgrade file sentry-upgrade

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

2018-05-03 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/#review202373 --- Lina, What about the rest of the sentry-upgrade-*-2.0.0-to-2.1.0.

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

2018-05-02 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/ --- (Updated May 3, 2018, 3:49 a.m.) Review request for sentry, Alexander Kolbasov,

Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

2018-03-23 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/ --- Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar kalvag