Re: sentry-provider-db and circular dependencies

I have done that exercise in the past as part of bigger exercise of bringing all the patches from sentry-ha branch to master. I had some issues with this refactoring change so it was not done in master. *Thanks,Kalyan Kumar Kalvagadda* | Software Engineer t. (469) 279- <00>5732

Re: sentry-provider-db and circular dependencies

In my experience IntelliJ is your friend here - it is really good at this kind of refactoring. On Wed, Apr 18, 2018 at 1:54 PM, Stephen Moist wrote: > Ok, I’ll work against that idea then with the sentry-service module. > > > On Apr 18, 2018, at 3:45 PM, Alexander Kolbasov

Re: sentry-provider-db and circular dependencies

Ok, I’ll work against that idea then with the sentry-service module. > On Apr 18, 2018, at 3:45 PM, Alexander Kolbasov wrote: > > It was done earlier as sentry-1205. The code is still in the got history. We > didn't include the change - it was too difficult to merge with ha

Re: sentry-provider-db and circular dependencies

It was done earlier as sentry-1205. The code is still in the got history. We didn't include the change - it was too difficult to merge with ha branch. > On Apr 18, 2018, at 12:57, Stephen Moist wrote: > > Great, I’ll get started on that. Is there a better name I should

Re: sentry-provider-db and circular dependencies

Great, I’ll get started on that. Is there a better name I should use or is everyone fine with sentry-main. I noticed there was a sentry-service module that is not used, perhaps that’s a bit better? > On Apr 18, 2018, at 2:05 PM, Sergio Pena wrote: > > There have

Re: sentry-provider-db and circular dependencies

There have been concerns from other teams about the sentry-provider-db as well. I think it makes sense to split it to avoid these dependencies issues. Go head, create some jiras to split them. I will recommend creating one jira per module just to keep the patch simple and easy to review. On

Re: sentry-provider-db and circular dependencies

I agree that it would be useful to break up the sentry-provider-db module in order to allow dependency chains to be more easily expressed and to decouple the SentryService entry point from the database model. Are there any concerns with the approach Steve suggested? On Wed, Apr 18, 2018 at 11:07

sentry-provider-db and circular dependencies

So looking at sentry-provider-db, it looks like it’s pretty much the main module of Sentry. It has the thrift apis, db, cli and Sentry Service. I’m running into issues with developing ABAC as we have it be it’s own module. It depends on sentry-provider-db, and then for me to add it in so