Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

2018-10-18 Thread kalyan kumar kalvagadda via Review Board
> On Oct. 11, 2018, 2:55 a.m., Na Li wrote: > > do you have measurement on how much time saved on saving big snapshot in > > parallel vs the number of threads? When multiple threads accessing the same > > table, the improvement may not be linear. > > kalyan kumar kalvagadda wrote: > Lina I

Re: Review Request 68968: SENTRY-2425: Add metric to track the time taken to update the owner privilege

2018-10-18 Thread kalyan kumar kalvagadda via Review Board
> On Oct. 11, 2018, 2:52 a.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java > > Lines 124 (patched) > > > > > > We should use different m

Re: Review Request 68968: SENTRY-2425: Add metric to track the time taken to update the owner privilege

2018-10-18 Thread kalyan kumar kalvagadda via Review Board
> On Oct. 9, 2018, 6:19 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java > > Lines 124 (patched) > > > > > > Can we have one for

Re: Review Request 68968: SENTRY-2425: Add metric to track the time taken to update the owner privilege

2018-10-18 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68968/ --- (Updated Oct. 18, 2018, 5:38 p.m.) Review request for sentry, Arjun Mishra, Na

Review Request 69074: SENTRY-2429: Transfer database owner drops table owner

2018-10-18 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69074/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pen

Re: Review Request 69074: SENTRY-2429: Transfer database owner drops table owner

2018-10-18 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69074/#review209759 --- Ship it! Ship It! - Sergio Pena On Oct. 18, 2018, 8:24 p.m.,

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

2018-10-18 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68973/#review209760 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 68968: SENTRY-2425: Add metric to track the time taken to update the owner privilege

2018-10-18 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68968/#review209762 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Review Request 69076: SENTRY-2301: Log where sentry stands in the snapshot fetching process, periodically

2018-10-18 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69076/ --- Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. Rep

Re: Review Request 69076: SENTRY-2301: Log where sentry stands in the snapshot fetching process, periodically

2018-10-18 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69076/ --- (Updated Oct. 18, 2018, 9:29 p.m.) Review request for sentry, kalyan kumar kalv