Re: Review Request 69561: SENTRY-2480: Change processDropDatabase to call removeAllPaths

2018-12-12 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69561/#review211257 --- Ship it! Looks good. Wait for the tests to complete. - kalyan

Review Request 69561: SENTRY-2480: Change processDropDatabase to call removeAllPaths

2018-12-12 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69561/ --- Review request for sentry and kalyan kumar kalvagadda. Bugs: SENTRY-2480

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-12-12 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review211255 --- Also test case to cover case when an object already exist and we

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-12-12 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review211254 ---

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-12-12 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review211251 --- Kalyan,we need to persist MAuthzPathsMapping object at the end

Re: Review Request 69501: SENTRY-2466: Create generic sentry store metrics

2018-12-12 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69501/#review211250 --- Ship it! Ship It! - Na Li On Dec. 3, 2018, 5:22 p.m., Arjun

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-12-12 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review211248 --- Fix it, then Ship it!

Re: [NOTICE] Mandatory relocation of Apache git repositories on git-wip-us.apache.org

2018-12-12 Thread Na Li
Sergio, I prefer to move it sooner. Otherwise, we could forget when busy working on other issues. Thanks, Lina On Tue, Dec 11, 2018 at 3:11 PM Sergio Pena wrote: > Hey team, the Sentry project is part of the git-wip. > Do we want to move sooner and or later? > > - Sergio > > --

Re: Review Request 69530: SENTRY-2476: Optimize deleting specific paths for objects

2018-12-12 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69530/#review211244 --- Arjun, Fix for SENTRY-2249 solves this issue. There is no new

Re: Review Request 69530: SENTRY-2476: Optimize deleting specific paths for objects

2018-12-12 Thread Arjun Mishra via Review Board
> On Dec. 11, 2018, 8:56 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 3451-3455 (patched) > > > > > >

Re: Review Request 69501: SENTRY-2466: Create generic sentry store metrics

2018-12-12 Thread Haley Reeve via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69501/#review211236 --- Ship it! Ship It! - Haley Reeve On Dec. 3, 2018, 5:22 p.m.,