Re: Review Request 63775: SENTRY-1543 dropOrRenamePrivilegeForAllRoles() has confusing code

2017-12-18 Thread Steve Moist via Review Board
> On Nov. 15, 2017, 7:11 p.m., Sergio Pena wrote: > > The subject of the review board must match the JIRA subject. You could > > either change the JIRA or the Review subject to match the correct fix. > > > > The getUniqueMSentryPrivilege() is still confusing. Any idea of the > > difference in

Re: Review Request 63775: SENTRY-1543 dropOrRenamePrivilegeForAllRoles() has confusing code

2017-11-30 Thread Steve Moist via Review Board
> On Nov. 15, 2017, 7:11 p.m., Sergio Pena wrote: > > The subject of the review board must match the JIRA subject. You could > > either change the JIRA or the Review subject to match the correct fix. > > > > The getUniqueMSentryPrivilege() is still confusing. Any idea of the > > difference in

Re: Review Request 63775: SENTRY-1543 dropOrRenamePrivilegeForAllRoles() has confusing code

2017-11-15 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63775/ --- (Updated Nov. 15, 2017, 9:47 p.m.) Review request for sentry. Summary