Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66748/#review202127 --- Ship it! Ship It! - Colm O hEigeartaigh On April 27, 2018,

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66748/ --- (Updated April 27, 2018, 3:47 p.m.) Review request for sentry. Repository:

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66748/ --- (Updated April 26, 2018, 7:38 p.m.) Review request for sentry. Repository:

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

> On April 25, 2018, 4:51 p.m., Colm O hEigeartaigh wrote: > > Why is the package name changed for GenericPrivilegeConverter.java + > > TSentryPrivilegeConverter.java? They've gone from > > "sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools" > > to

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

> On April 25, 2018, 4:51 p.m., Colm O hEigeartaigh wrote: > > Why is the package name changed for GenericPrivilegeConverter.java + > > TSentryPrivilegeConverter.java? They've gone from > > "sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools" > > to

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

> On April 25, 2018, 4:51 p.m., Colm O hEigeartaigh wrote: > > Why is the package name changed for GenericPrivilegeConverter.java + > > TSentryPrivilegeConverter.java? They've gone from > > "sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools" > > to

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66748/#review201942 --- Why is the package name changed for

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66748/ --- (Updated April 24, 2018, 7:29 p.m.) Review request for sentry. Repository:

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

> On April 23, 2018, 4:34 p.m., Colm O hEigeartaigh wrote: > > Shouldn't the location of the files be changed as well? If I apply the diff > > from this JIRA I see, for example: > > > > ./sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/ShellCommand.java > >

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

> On April 23, 2018, 4:34 p.m., Colm O hEigeartaigh wrote: > > Shouldn't the location of the files be changed as well? If I apply the diff > > from this JIRA I see, for example: > > > > ./sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/ShellCommand.java > >

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

> On April 23, 2018, 4:34 p.m., Colm O hEigeartaigh wrote: > > Shouldn't the location of the files be changed as well? If I apply the diff > > from this JIRA I see, for example: > > > > ./sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/ShellCommand.java > >

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66748/ --- (Updated April 23, 2018, 8:45 p.m.) Review request for sentry. Summary