svn commit: r1712306 - /serf/trunk/test/test_buckets.c

2015-11-03 Thread ivan
Author: ivan Date: Tue Nov 3 15:08:49 2015 New Revision: 1712306 URL: http://svn.apache.org/viewvc?rev=1712306=rev Log: * test/test_buckets.c (test_aggregate_bucket_readline): Remove unused code. Modified: serf/trunk/test/test_buckets.c Modified: serf/trunk/test/test_buckets.c URL:

svn commit: r1712307 - /serf/trunk/buckets/response_buckets.c

2015-11-03 Thread ivan
Author: ivan Date: Tue Nov 3 15:11:57 2015 New Revision: 1712307 URL: http://svn.apache.org/viewvc?rev=1712307=rev Log: Fix memory leak in serf_response_full_become_aggregate(). * buckets/response_buckets.c (serf_response_full_become_aggregate): Destroy CTX->BODY bucket if any and free

buildbot success in ASF Buildbot on serf-x64-macosx

2015-11-03 Thread buildbot
The Buildbot has detected a restored build on builder serf-x64-macosx while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx/builds/201 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build Reason: The

buildbot failure in ASF Buildbot on serf-x64-macosx

2015-11-03 Thread buildbot
The Buildbot has detected a new failure on builder serf-x64-macosx while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx/builds/200 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build Reason: The

Re: svn commit: r1712270 - in /serf/trunk: buckets/allocator.c buckets/buckets.c test/test_util.c

2015-11-03 Thread Greg Stein
On Tue, Nov 3, 2015 at 6:12 AM, wrote: >... > +++ serf/trunk/buckets/allocator.c Tue Nov 3 12:12:00 2015 > @@ -27,6 +27,8 @@ > #include "serf.h" > #include "serf_bucket_util.h" > > +#include "serf_private.h" > Is this really needed? The changes don't seem to require

svn commit: r1712271 - /serf/trunk/buckets/buckets.c

2015-11-03 Thread rhuijben
Author: rhuijben Date: Tue Nov 3 12:15:06 2015 New Revision: 1712271 URL: http://svn.apache.org/viewvc?rev=1712271=rev Log: Remove accidental garbage committed in r1712270. * buckets/buckets.c (it): Remove. Modified: serf/trunk/buckets/buckets.c Modified: serf/trunk/buckets/buckets.c

buildbot success in ASF Buildbot on serf-windows

2015-11-03 Thread buildbot
The Buildbot has detected a restored build on builder serf-windows while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-windows/builds/212 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-w2k3-ra Build Reason: The

buildbot success in ASF Buildbot on serf-x64-macosx

2015-11-03 Thread buildbot
The Buildbot has detected a restored build on builder serf-x64-macosx while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx/builds/198 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build Reason: The

buildbot success in ASF Buildbot on serf-sparc64-solaris

2015-11-03 Thread buildbot
The Buildbot has detected a restored build on builder serf-sparc64-solaris while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-sparc64-solaris/builds/177 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-sparc-solaris Build

buildbot success in ASF Buildbot on serf-x64-macosx-default-openssl

2015-11-03 Thread buildbot
The Buildbot has detected a restored build on builder serf-x64-macosx-default-openssl while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx-default-openssl/builds/184 Buildbot URL: http://ci.apache.org/ Buildslave for this Build:

buildbot success in ASF Buildbot on serf-x64-macosx-apr1.5

2015-11-03 Thread buildbot
The Buildbot has detected a restored build on builder serf-x64-macosx-apr1.5 while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx-apr1.5/builds/181 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build

svn propchange: r1712270 - svn:log

2015-11-03 Thread rhuijben
Author: rhuijben Revision: 1712270 Modified property: svn:log Modified: svn:log at Tue Nov 3 12:16:22 2015 -- --- svn:log (original) +++ svn:log Tue Nov 3 12:16:22 2015 @@ -5,5 +5,8 @@ Fix some testsuite issues when

buildbot success in ASF Buildbot on serf-x64-macosx-default-openssl

2015-11-03 Thread buildbot
The Buildbot has detected a restored build on builder serf-x64-macosx-default-openssl while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx-default-openssl/builds/182 Buildbot URL: http://ci.apache.org/ Buildslave for this Build:

buildbot failure in ASF Buildbot on serf-x64-macosx

2015-11-03 Thread buildbot
The Buildbot has detected a new failure on builder serf-x64-macosx while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx/builds/197 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build Reason: The

buildbot failure in ASF Buildbot on serf-x64-macosx-apr2.0-dev

2015-11-03 Thread buildbot
The Buildbot has detected a new failure on builder serf-x64-macosx-apr2.0-dev while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx-apr2.0-dev/builds/175 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs

svn commit: r1712312 - in /serf/trunk/test: test_buckets.c test_serf.h test_util.c

2015-11-03 Thread ivan
Author: ivan Date: Tue Nov 3 15:46:37 2015 New Revision: 1712312 URL: http://svn.apache.org/viewvc?rev=1712312=rev Log: Improve diagnostic of unfreed memory in bucket allocator in bucket tests. * test/test_serf.h (test__create_bucket_allocator): New function declaration. * test/test_util.c

buildbot failure in ASF Buildbot on serf-x64-macosx-apr2.0-dev

2015-11-03 Thread buildbot
The Buildbot has detected a new failure on builder serf-x64-macosx-apr2.0-dev while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx-apr2.0-dev/builds/181 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs

svn commit: r1712435 - in /serf/trunk: buckets/hpack_buckets.c buckets/prefix_buckets.c test/test_buckets.c

2015-11-03 Thread rhuijben
Author: rhuijben Date: Tue Nov 3 23:09:09 2015 New Revision: 1712435 URL: http://svn.apache.org/viewvc?rev=1712435=rev Log: Resolve two memory leaks found by ivan. While looking at this code also shrink the amount of memory needed at runtime while decoding http2 hpack data. *

RE: svn commit: r1712270 - in /serf/trunk: buckets/allocator.c buckets/buckets.c test/test_util.c

2015-11-03 Thread Bert Huijben
No this wasn’t needed. I first intended to add the macro there, but then I found out that it only really applied to debugging. Thanks for the review! Bert From: Greg Stein [mailto:gst...@gmail.com] Sent: dinsdag 3 november 2015 13:41 To: Bert Huijben

buildbot success in ASF Buildbot on serf-x64-macosx-apr2.0-dev

2015-11-03 Thread buildbot
The Buildbot has detected a restored build on builder serf-x64-macosx-apr2.0-dev while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx-apr2.0-dev/builds/189 Buildbot URL: http://ci.apache.org/ Buildslave for this Build:

buildbot failure in ASF Buildbot on serf-x64-macosx-apr2.0-dev

2015-11-03 Thread buildbot
The Buildbot has detected a new failure on builder serf-x64-macosx-apr2.0-dev while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx-apr2.0-dev/builds/188 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs

svn commit: r1712453 - in /serf/trunk: buckets/aggregate_buckets.c test/MockHTTPinC/MockHTTP.c test/MockHTTPinC/MockHTTP_server.c test/mock_buckets.c

2015-11-03 Thread rhuijben
Author: rhuijben Date: Wed Nov 4 01:19:55 2015 New Revision: 1712453 URL: http://svn.apache.org/viewvc?rev=1712453=rev Log: Fix several cases where we checked for APR_EAGAIN instead of APR_STATUS_IS_EAGAIN, where this last one doesn't work for socket errors on Windows. This caused the

svn commit: r1712456 - /serf/trunk/buckets/aggregate_buckets.c

2015-11-03 Thread rhuijben
Author: rhuijben Date: Wed Nov 4 02:13:20 2015 New Revision: 1712456 URL: http://svn.apache.org/viewvc?rev=1712456=rev Log: * buckets/aggregate_buckets.c (read_aggregate): Add 'magic' refill support via the hold_open callback. when reading an iovec. In the http2 usage this might just

buildbot success in ASF Buildbot on serf-x64-macosx-apr1.5

2015-11-03 Thread buildbot
The Buildbot has detected a restored build on builder serf-x64-macosx-apr1.5 while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx-apr1.5/builds/190 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build

svn commit: r1712450 - /serf/trunk/test/MockHTTPinC/MockHTTP_server.c

2015-11-03 Thread rhuijben
Author: rhuijben Date: Wed Nov 4 00:55:46 2015 New Revision: 1712450 URL: http://svn.apache.org/viewvc?rev=1712450=rev Log: Following up on r1712447, remove write buffer but add a bit more logging to the read buffer test. * test/MockHTTPinC/MockHTTP_server.c (sslCtx_t): Add retry_len to

buildbot success in ASF Buildbot on serf-x64-macosx-default-openssl

2015-11-03 Thread buildbot
The Buildbot has detected a restored build on builder serf-x64-macosx-default-openssl while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx-default-openssl/builds/195 Buildbot URL: http://ci.apache.org/ Buildslave for this Build:

svn commit: r1712455 - /serf/trunk/test/MockHTTPinC/MockHTTP_server.c

2015-11-03 Thread rhuijben
Author: rhuijben Date: Wed Nov 4 01:56:18 2015 New Revision: 1712455 URL: http://svn.apache.org/viewvc?rev=1712455=rev Log: * test/MockHTTPinC/MockHTTP_server.c (bio_apr_socket_write): Remove retry_len hack. (bio_apr_socket_read, bio_apr_socket_write): Make code more similar. Explicitly

svn commit: r1712458 - /serf/trunk/test/test_buckets.c

2015-11-03 Thread rhuijben
Author: rhuijben Date: Wed Nov 4 02:30:20 2015 New Revision: 1712458 URL: http://svn.apache.org/viewvc?rev=1712458=rev Log: Following up on r1712456, add test for refilling during hold-open. * test/test_buckets.c (append_magic): New function. (test_aggregate_buckets): Extend test.

RE: serf_bucket_copy_create() wrapped bucket ownership

2015-11-03 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: dinsdag 3 november 2015 15:01 > To: dev@serf.apache.org > Subject: serf_bucket_copy_create() wrapped bucket ownership > > Should serf_bucket_destroy() for COPY_BUCKET destroy wrapped bucket or > not? Currently

buildbot success in ASF Buildbot on serf-x64-macosx-apr2.0-dev

2015-11-03 Thread buildbot
The Buildbot has detected a restored build on builder serf-x64-macosx-apr2.0-dev while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx-apr2.0-dev/builds/182 Buildbot URL: http://ci.apache.org/ Buildslave for this Build:

svn commit: r1712320 - in /serf/trunk: buckets/copy_buckets.c test/test_buckets.c

2015-11-03 Thread ivan
Author: ivan Date: Tue Nov 3 16:22:34 2015 New Revision: 1712320 URL: http://svn.apache.org/viewvc?rev=1712320=rev Log: Destroy wrapped bucket in copy bucket. Discussion:

Re: serf_bucket_copy_create() wrapped bucket ownership

2015-11-03 Thread Ivan Zhakov
On 3 November 2015 at 17:56, Bert Huijben wrote: >> -Original Message- >> From: Ivan Zhakov [mailto:i...@visualsvn.com] >> Sent: dinsdag 3 november 2015 15:01 >> To: dev@serf.apache.org >> Subject: serf_bucket_copy_create() wrapped bucket ownership >> >> Should