Re: [PATCH] Refactoring of the bio_bucket_ctrl() function

2022-06-21 Thread Denis Kovalchuk
> > - Return values from case statements and get rid of the ret variable. The > > control flow is more explicit and clear. > > > > I personally prefer the "we return an error by default unless we > explicitly addressed the situation" attitude. So for me this part of your > patch doesn't provide an

Re: [PATCH] Refactoring of the bio_bucket_ctrl() function

2022-06-18 Thread Lieven Govaerts
Hi Denis, On Fri, 17 Jun 2022 at 14:59, Denis Kovalchuk wrote: > Hi! > > I would like to propose a refactoring of the bio_bucket_ctrl() function in > the > ssl_bucket.c file: > > - Return values from case statements and get rid of the ret variable. The > control flow is more explicit and clear.