?????? [DISCUSS] Require the review before merging the PR

2019-04-03 Thread bismy
+1 We require at least one or two reviewers review for java-chassis in practice. We can make it required by adding this configuration. -- -- ??: "zzzwjm"; : 2019??4??3??(??) 10:23 ??: "dev"; : Re: [DISCUSS] Require the

[VOTE] Release Apache ServiceComb Java-Chassis version 1.2.0

2019-04-03 Thread Mohammad Asif Siddiqui
Hello All, This is a call for a Vote to release Apache ServiceComb Java-Chassis version 1.2.0 Release Notes : https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626=12344561 Release Candidate :

Re: [DISCUSS] Require the review before merging the PR

2019-04-03 Thread wjm wjm
+1 zhang_...@boco.com.cn 于2019年4月3日周三 下午3:25写道: > +1 > > > 在 2019年4月3日,下午2:55,Zheng Feng 写道: > > > > Hi, > > > > I just wonder if we can enable this setting [1] on servicecomb-pack [2] > and > > it could be helpful when reviewing the PR. I think at least one people > > review the changes and

Re: Any Ideas for ServiceComb projects for GSOC 2019???

2019-04-03 Thread wjm wjm
java-chassis: we have provide a new module named "inspector" to inspect internal data of a microservice instance. currently we only have one feature in inspector: view/test/download schemas https://issues.apache.org/jira/browse/SCB-1188

Re: Any Ideas for ServiceComb projects for GSOC 2019???

2019-04-03 Thread Zheng Feng
Hi all, I had one from the servicecomb-pack [1] which needs to implement the LRA spec. I think the student could learn 1. cooperate with the open source community. The LRA spec [2] is under the microprofile currently. 2. strong programming skill. The other question is we have to be the mentor to

Any Ideas for ServiceComb projects for GSOC 2019???

2019-04-03 Thread Mohammad Asif Siddiqui
Hello All, As we know that Apache is an approved organization for GSOC 2019 so ServiceComb being an Apache project also has an opportunity to engage in this program. Currently we have not listed any ideas for GSOC 2019 for ServiceComb so if someone from Java-Chassis, Service-Center, Saga & Pack

Re: [VOTE] Release Apache ServiceComb Pack version 0.4.0 (RC-02)

2019-04-03 Thread Mohammad Asif Siddiqui
+1 binding Checks Done: - Hashes and Signature is good - Archive matching the Git tag - LICENSE, NOTICE exist - ASF headers present in relevant files - mvn clean install Regards Asif On Wed, Apr 3, 2019 at 1:42 PM Willem Jiang wrote: > +1. > > The git tag is right, and commits has the latest

[RESULT] [VOTE] Release Apache ServiceComb Service-Center version 1.2.0

2019-04-03 Thread Mohammad Asif Siddiqui
Hello All, We are glad to announce that ServiceComb community has approved the Apache ServiceComb Service-Center 1.2.0 release with the following results: +1 binding: 4 (Willem Jiang, Cuiyihua, Liubao, Mohammad Asif Siddiqui) We will be publishing the release binaries soon. Thanks All for your

Re: [VOTE] Release Apache ServiceComb Service-Center version 1.2.0

2019-04-03 Thread Mohammad Asif Siddiqui
+1 binding Checks Done : - Hashes and Signature is good - Archive matching the Git tag - LICENSE, NOTICE exist - ASF headers present in relevant files - Compiled code from source - Ran Test in Windows, Mac & Linux Regards Asif On 2019/03/29 07:35:01, Mohammad Asif Siddiqui

Re: [VOTE] Release Apache ServiceComb Service-Center version 1.2.0

2019-04-03 Thread Mohammad Asif Siddiqui
Hi All, This vote is closed now and we will be announcing the results shortly. Thanks All for helping to verify the release. Regards Asif On Fri, Mar 29, 2019 at 1:05 PM Mohammad Asif Siddiqui < asifdxtr...@apache.org> wrote: > Hi All, > > This is a call for a Vote to release Apache

Re: [VOTE] Release Apache ServiceComb Pack version 0.4.0 (RC-02)

2019-04-03 Thread Willem Jiang
+1. The git tag is right, and commits has the latest fix of issue we found in last round release. I verified the staging repo by running the demo test against it. The release kits looks good to me. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Tue, Apr 2, 2019 at 6:23 AM Mohammad Asif

Re: [DISCUSS] Require the review before merging the PR

2019-04-03 Thread zhang_...@boco.com.cn
+1 > 在 2019年4月3日,下午2:55,Zheng Feng 写道: > > Hi, > > I just wonder if we can enable this setting [1] on servicecomb-pack [2] and > it could be helpful when reviewing the PR. I think at least one people > review the changes and approve before merging it. We have to raise a JIRA > for the infra

Re: [DISCUSS] Require the review before merging the PR

2019-04-03 Thread Willem Jiang
+1 for it. We could start from servicecomb-pack project first. We could enable this feature for the other sub projects if it goes well. Any thoughts? Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Apr 3, 2019 at 2:56 PM Zheng Feng wrote: > > Hi, > > I just wonder if we can enable

[DISCUSS] Require the review before merging the PR

2019-04-03 Thread Zheng Feng
Hi, I just wonder if we can enable this setting [1] on servicecomb-pack [2] and it could be helpful when reviewing the PR. I think at least one people review the changes and approve before merging it. We have to raise a JIRA for the infra team to do this setting. So I post this message here to