Re: [VOTE] Release Apache ServiceComb Java-Chassis version 1.3.0

2019-11-04 Thread sen sun
+1 I checked : Hashes and signature are good. mvn clean install is ok Bin Ma 于2019年10月29日周二 下午2:22写道: > Got it. > > +1 > > Wishes & Regards > -- - > Mabin > > > > Willem Jiang < willem.ji...@gmail.com >于2019年10月29日周二上午8:02写道: > > > Hi MaBin, > > > > You just need to

Re: [DISCUSSION][Toolkit] Integrate oas-validator compliance functionality

2019-11-04 Thread Daniel Qian
Hi Ma, since we discussed about compatibility check sub command to be: cc / checkcompatibility .[1] So, we can also use cs / checkstyle here. [1]: https://lists.apache.org/thread.html/c88cda03ec52182482679bd9be36b9ad57bc8d03ee43a4912ad38d90@%3Cdev.servicecomb.apache.org%3E Daniel Qian

Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-11-04 Thread Daniel Qian
Hi Ma, got it. Bin Ma 于2019年11月5日周二 上午11:19写道: > > Hi Daniel, > > Sorry, I misread the question. > > I think it's better to support both checkcompatibility and cc as > subcommands. > > Wishes & Regards > --- > Mabin > > > > sen sun 于2019年11月5日周二 上午9:40写道: > > > I

Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-11-04 Thread Bin Ma
Hi Daniel, Sorry, I misread the question. I think it's better to support both checkcompatibility and cc as subcommands. Wishes & Regards --- Mabin sen sun 于2019年11月5日周二 上午9:40写道: > I think Ma just made an example of the option naming style instead of the >

Re: [VOTE] Release Apache ServiceComb Service-Center version 1.3.0

2019-11-04 Thread Willem Jiang
If the vote is not closed, we can still keep voting it. As Asif just update the artifacts without changing the release tag we can still use the last vote thread. Let's verify the kit as soon as possible. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Tue, Nov 5, 2019 at 1:06 AM Bin Ma

Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-11-04 Thread sen sun
I think Ma just made an example of the option naming style instead of the subcommand. I think it's a good idea to support both checkcompatibility and cc as subcommands. Daniel Qian 于2019年11月5日周二 上午7:28写道: > Hello Ma, found current cli style is . > So if we do --check-compatability then which

Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-11-04 Thread Daniel Qian
Hello Ma, found current cli style is . So if we do --check-compatability then which subcommand should we use? Bin Ma 于2019年11月5日周二 上午12:44写道: > > I recommend keeping the same as the current option naming style, > such as "-c", "-- check-compability " > > > Wishes & Regards >

Re: [VOTE] Release Apache ServiceComb Service-Center version 1.3.0

2019-11-04 Thread Bin Ma
Hi Asif, Voting time has expired and no result,maybe we should start a new voting for Service-Center version 1.3.0? Wishes & Regards --- Mabin Liubao (A) 于2019年11月4日周一 下午4:14写道: > +1 > > I have checked the release notes and binaries. Do some basic tests with >

Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-11-04 Thread Bin Ma
I recommend keeping the same as the current option naming style, such as "-c", "-- check-compability " Wishes & Regards --- Mabin Willem Jiang 于2019年11月1日周五 下午12:31写道: > I think we can support checkcompatibility and the short one cc at the same > time. > Any

Problem with implementing interface SagaMessageSender in the ServiceComb Pack

2019-11-04 Thread Zhang Lei
Hi, Team In the ServiceComb Pack, Classes RetryableMessageSender.java SagaLoadBalanceSender.java and GrpcSagaClientMessageSender.java implement the interface SagaMessageSender. I have two questions: 1. RetryableMessageSender.java unused 2. Both SagaLoadBalanceSender.java and

答复: [VOTE] Release Apache ServiceComb Service-Center version 1.3.0

2019-11-04 Thread Liubao (A)
+1 I have checked the release notes and binaries. Do some basic tests with windows version. -邮件原件- 发件人: Mohammad Asif Siddiqui [mailto:asifdxtr...@apache.org] 发送时间: 2019年10月31日 22:06 收件人: dev@servicecomb.apache.org 主题: Re: [VOTE] Release Apache ServiceComb Service-Center version 1.3.0