Re: Re: [DISCUSS]Shall we upgrade Java-chassis to support Spring Boot2

2018-07-23 Thread Bin Ma
+1 to @Kirin Wang's suggestion. start.servicecomb.io should be support Spring Boot 2 too, Chuanzhi Boke also use start.servicecomb.io to develop coursewares now. It should be created a sub-task to tracing. Best Wishes & Regards --- Mabin Kirin Wang 于2018年7月23日周一

Re: Re: [DISCUSS]Shall we upgrade Java-chassis to support Spring Boot2

2018-07-22 Thread Kirin Wang
I think we also have a sub-task of support Spring Boot 2 , which is add Spring Boot 2.X option in start.servicecomb.io . Zen Lin 于2018年7月23日周一 上午9:15写道: > +1 to Willem's suggestion. > Could someone ask yaohaishi to create a issue track for this, upgrade to > support Spring Boot2. > And when

Re: Re: [DISCUSS]Shall we upgrade Java-chassis to support Spring Boot2

2018-07-22 Thread Zen Lin
+1 to Willem's suggestion. Could someone ask yaohaishi to create a issue track for this, upgrade to support Spring Boot2. And when he find an actual issue on testing it, can create a sub issue under the issue of "upgrade to support Spring Boot2". Thus, Mabin and the users can know the detail

Re: Re: [DISCUSS]Shall we upgrade Java-chassis to support Spring Boot2

2018-07-20 Thread Willem Jiang
SCB-758 is a big task. I don't think we need to wait for it done to support Spring Boot 2.x. Yaohaishi already did some test on it, we just need to keep fix the actual issue we find my suggestion is we support Spring Boot 1.x by default, and add a Spring Boot 2.x profile to the user who want to

Re: Re: [DISCUSS]Shall we upgrade Java-chassis to support Spring Boot2

2018-07-20 Thread Bin Ma
Currently I have recommended user like Chuanzhi Boke to develop based on the spring boot1.x version to ensure that user development is not blocked. I agree with bimsy's idea,users' demands and scenes are clear,an task should be created to trace. As I know,

Re: Re: [DISCUSS]Shall we upgrade Java-chassis to support Spring Boot2

2018-07-19 Thread Willem Jiang
>From the Spring Boot2 migration guide[1], the class package and name was changed. We may need to create different module to handle the class package change issue. [1] https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.0-Migration-Guide#embedded-containers-package-structure

?????? Re: [DISCUSS]Shall we upgrade Java-chassis to support Spring Boot2

2018-07-19 Thread bismy
: "dev"; ????: Re: Re: [DISCUSS]Shall we upgrade Java-chassis to support Spring Boot2 It think we can update our bean.xml file for 4.0.xsd. If I remember right the spring namespace handler can take care of mapping http url to classpath. Willem Jiang Twitter: willemjiang Weibo: wi

Re: Re: [DISCUSS]Shall we upgrade Java-chassis to support Spring Boot2

2018-07-19 Thread Willem Jiang
It think we can update our bean.xml file for 4.0.xsd. If I remember right the spring namespace handler can take care of mapping http url to classpath. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Fri, Jul 20, 2018 at 10:36 AM, wjm wjm wrote: > about "

Re: Re: [DISCUSS]Shall we upgrade Java-chassis to support Spring Boot2

2018-07-19 Thread wjm wjm
about " classpath:org/springframework/beans/factory/xml/spring- beans-3.0.xsd" if changed to http://., and if net disconnected, then process will blocked when booting this already happened many times in our environment and customer's environment we need to make a decision of this.

Re: [DISCUSS]Shall we upgrade Java-chassis to support Spring Boot2

2018-07-19 Thread wjm wjm
not enough, must exclude old spring also 2018-07-20 6:44 GMT+08:00 Willem Jiang : > How about let user override the version of Spring Boot in their application > and give it a try. > Just like what we do with JDK9 here[1] > If there is any issue comes out, we can keep digging it. > >

Re: [DISCUSS]Shall we upgrade Java-chassis to support Spring Boot2

2018-07-19 Thread Willem Jiang
How about let user override the version of Spring Boot in their application and give it a try. Just like what we do with JDK9 here[1] If there is any issue comes out, we can keep digging it. [1]https://github.com/apache/incubator-servicecomb-saga/issues/76 Willem Jiang Twitter: willemjiang