Re: Discussion about SCB-668 reuse demo's docker-compose file to start acceptance test

2019-06-30 Thread Daniel Qian
Hi Jiang Thanks for the suggestion. If I'm not missing anything, for issue 3, that'll be acceptable to remove wait on tcp port part in the pom.xml. right? For issue 4 I think I can make use of compose file variable substitution [1] to solve this. I'll create another PR after PR for SCB-1335

Re: Discussion about SCB-668 reuse demo's docker-compose file to start acceptance test

2019-06-30 Thread Willem Jiang
Hi Daniel Thanks for the heads up of SCB-668. The original thought of SCB-668 is reuse the docker compose file. As you have mentioned there are some issues of the maven docker plugin we need to get around with. For the issue1, we could upgrade the docker plugin version to get the latest fix.

Discussion about SCB-668 reuse demo's docker-compose file to start acceptance test

2019-06-29 Thread Daniel Qian
Hi guys, I'm working on [SCB-668 Using docker-compose file to start Services from docker plugin in the Accept test] and encounter some problems so I start this mail thread to discuss about them: Problem 1: There is a bug in fabric8 dmp plugin version 0.28.0 (currently used) : If you define the