[GitHub] coveralls commented on issue #105: SCB-174 add kryo serializer

[GitBox]

coveralls commented on issue #105: SCB-174 add kryo serializer
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/105#issuecomment-355750714
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14930111/badge)](https://coveralls.io/builds/14930111)
   
   Coverage increased (+0.02%) to 94.976% when pulling 
**4110d1041ebe46eb619c122032d7e649968b200e on eric-lee-ltk:SCB-174** into 
**aae563b00e879aca15493b0275679aab3fb65b23 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang commented on a change in pull request #105: SCB-174 add kryo serializer

[GitBox]

WillemJiang commented on a change in pull request #105: SCB-174 add kryo 
serializer
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/105#discussion_r160025869
 
 

 ##
 File path: pom.xml
 ##
 @@ -329,6 +329,11 @@
 grpc-stub
 ${grpc.version}
   
+  
+com.esotericsoftware
+kryo
+4.0.1
 
 Review comment:
   How about using the ${kryo.version}?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang commented on a change in pull request #105: SCB-174 add kryo serializer

[GitBox]

WillemJiang commented on a change in pull request #105: SCB-174 add kryo 
serializer
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/105#discussion_r160025953
 
 

 ##
 File path: 
omega/omega-format/src/test/java/org/apache/servicecomb/saga/omega/format/KryoMessageFormatTest.java
 ##
 @@ -0,0 +1,59 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one or more
+ *  contributor license agreements.  See the NOTICE file distributed with
+ *  this work for additional information regarding copyright ownership.
+ *  The ASF licenses this file to You under the Apache License, Version 2.0
+ *  (the "License"); you may not use this file except in compliance with
+ *  the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+package org.apache.servicecomb.saga.omega.format;
+
+import static org.hamcrest.Matchers.is;
+import static org.junit.Assert.assertThat;
+
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+public class KryoMessageFormatTest extends MessageFormatTestBase {
+
+  @BeforeClass
+  public static void setUp() {
+format = new KryoMessageFormat();
+  }
+
+  @Test
+  @Override
 
 Review comment:
   We can remove these lines when putting the Test annotation to the base class.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

[GitBox]

WillemJiang commented on a change in pull request #492: [SCB-184]Provide 
starters for Spring Cloud to using service-center and config-center
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#discussion_r160025526
 
 

 ##
 File path: 
spring-boot-starter/spring-boot-starter-discovery/src/main/java/io/servicecomb/springboot/starter/discovery/CseRoutesProperties.java
 ##
 @@ -1,42 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package io.servicecomb.springboot.starter.discovery;
 
 Review comment:
   Why do we remove this package?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

[GitBox]

WillemJiang commented on a change in pull request #492: [SCB-184]Provide 
starters for Spring Cloud to using service-center and config-center
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#discussion_r160025475
 
 

 ##
 File path: 
spring-boot-starter/spring-boot-starter-discovery/src/main/java/io/servicecomb/springboot/starter/discovery/CseDiscoveryClientConfiguration.java
 ##
 @@ -17,33 +17,17 @@
 package io.servicecomb.springboot.starter.discovery;
 
 import org.springframework.boot.autoconfigure.AutoConfigureBefore;
-import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
 import org.springframework.cloud.client.discovery.DiscoveryClient;
 import 
org.springframework.cloud.client.discovery.noop.NoopDiscoveryClientAutoConfiguration;
-import org.springframework.cloud.netflix.zuul.filters.ZuulProperties;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
-import org.springframework.context.annotation.Primary;
-
-import io.servicecomb.core.provider.consumer.ConsumerProviderManager;
+import org.springframework.core.annotation.Order;
 
 @AutoConfigureBefore(NoopDiscoveryClientAutoConfiguration.class)
 @Configuration
 public class CseDiscoveryClientConfiguration {
-
-  @Bean
-  public CseDiscoveryProperties cseDiscoveryProperties() {
-return new CseDiscoveryProperties();
-  }
-
-  @Bean
-  @ConditionalOnBean(ZuulProperties.class)
-  public CseRoutesProperties cseRoutesProperties(ConsumerProviderManager 
manager) {
-return new CseRoutesProperties(manager);
-  }
-
   @Bean
-  @Primary
+  @Order(5000)
 
 Review comment:
   Is there any other client need to be found?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] eric-lee-ltk opened a new pull request #105: SCB-174 add kryo serializer

[GitBox]

eric-lee-ltk opened a new pull request #105: SCB-174 add kryo serializer
URL: https://github.com/apache/incubator-servicecomb-saga/pull/105
 
 
   Signed-off-by: Eric Lee 
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #490: [SCB-180] Hystrixcommand setter not set by dynamic configuration

[GitBox]

coveralls commented on issue #490: [SCB-180] Hystrixcommand setter not set by 
dynamic configuration
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/490#issuecomment-355735442
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14928625/badge)](https://coveralls.io/builds/14928625)
   
   Coverage increased (+0.001%) to 87.453% when pulling 
**e5781b42200c69ef05b18a6e40b594d2880601a9 on mojieshui:scb-180** into 
**a4720c6bf64b9b0c9769fd9031166a785fabc4cc on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services