[GitHub] coveralls commented on issue #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

coveralls commented on issue #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#issuecomment-355880899 [](ht

[GitHub] lijasonvip commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

lijasonvip commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r160050160 ## File path: dynamic-config/config-apollo/src/main/

[GitHub] yhs0092 commented on a change in pull request #493: [SCB-195] Support swagger @Api annotation to specify default tags

yhs0092 commented on a change in pull request #493: [SCB-195] Support swagger @Api annotation to specify default tags URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/493#discussion_r160087774 ## File path: swagger/swagger-generator/generator-core/src/main/ja

[GitHub] yhs0092 commented on a change in pull request #493: [SCB-195] Support swagger @Api annotation to specify default tags

yhs0092 commented on a change in pull request #493: [SCB-195] Support swagger @Api annotation to specify default tags URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/493#discussion_r160087992 ## File path: swagger/swagger-generator/generator-core/src/main/ja

[GitHub] yhs0092 commented on a change in pull request #493: [SCB-195] Support swagger @Api annotation to specify default tags

yhs0092 commented on a change in pull request #493: [SCB-195] Support swagger @Api annotation to specify default tags URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/493#discussion_r160088154 ## File path: swagger/swagger-generator/generator-core/src/test/ja

[GitHub] lijasonvip commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

lijasonvip commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r160088539 ## File path: dynamic-config/config-apollo/src/main/

[GitHub] lijasonvip commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

lijasonvip commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r160088672 ## File path: dynamic-config/config-apollo/src/main/

[GitHub] coveralls commented on issue #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

coveralls commented on issue #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#issuecomment-355906222 [](https://co

[GitHub] coveralls commented on issue #493: [SCB-195] Support swagger @Api annotation to specify default tags

coveralls commented on issue #493: [SCB-195] Support swagger @Api annotation to specify default tags URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/493#issuecomment-355906316 [](https://coveralls.io/

[GitHub] seanyinx closed pull request #105: SCB-174 add kryo serializer

seanyinx closed pull request #105: SCB-174 add kryo serializer URL: https://github.com/apache/incubator-servicecomb-saga/pull/105 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreig

[GitHub] coveralls commented on issue #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

coveralls commented on issue #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#issuecomment-355907607 [](ht

[GitHub] seanyinx opened a new pull request #107: [SCB-168] load balance

seanyinx opened a new pull request #107: [SCB-168] load balance URL: https://github.com/apache/incubator-servicecomb-saga/pull/107 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/ji

[GitHub] seanyinx closed pull request #106: SCB-193 Generating the Licenses and Notice file when building the artifacts

seanyinx closed pull request #106: SCB-193 Generating the Licenses and Notice file when building the artifacts URL: https://github.com/apache/incubator-servicecomb-saga/pull/106 This is an automated message from the Apache G

[GitHub] weichao666 commented on a change in pull request #460: [SCB-171] report type/version when register to SC

weichao666 commented on a change in pull request #460: [SCB-171] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r160096140 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistry/api

[GitHub] weichao666 commented on a change in pull request #460: [SCB-171] report type/version when register to SC

weichao666 commented on a change in pull request #460: [SCB-171] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r160096341 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistry/api

[GitHub] weichao666 commented on a change in pull request #460: [SCB-171] report type/version when register to SC

weichao666 commented on a change in pull request #460: [SCB-171] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r160096444 ## File path: service-registry/src/test/java/io/servicecomb/serviceregistry/api

[GitHub] weichao666 commented on a change in pull request #460: [SCB-171] report type/version when register to SC

weichao666 commented on a change in pull request #460: [SCB-171] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r160096624 ## File path: service-registry/src/test/java/io/servicecomb/serviceregistry/api

[GitHub] weichao666 commented on a change in pull request #460: [SCB-171] report type/version when register to SC

weichao666 commented on a change in pull request #460: [SCB-171] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r160096816 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistry/api

[GitHub] wujimin commented on issue #494: [SCB-198] fileupload in linux is too slow, use system default setting i?

wujimin commented on issue #494: [SCB-198] fileupload in linux is too slow, use system default setting i? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/494#issuecomment-355914835 default is -1, no limit -

[GitHub] coveralls commented on issue #460: [SCB-171] report type/version when register to SC

coveralls commented on issue #460: [SCB-171] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#issuecomment-355916920 [](https://coveralls.io/builds/14944347)

[GitHub] coveralls commented on issue #107: [SCB-168] load balance

coveralls commented on issue #107: [SCB-168] load balance URL: https://github.com/apache/incubator-servicecomb-saga/pull/107#issuecomment-355918254 [](https://coveralls.io/builds/14944340) Changes Unknown when pulling

[GitHub] coveralls commented on issue #495: [SCB-188] Transport optimize for reactive

coveralls commented on issue #495: [SCB-188] Transport optimize for reactive URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/495#issuecomment-355918924 [](https://coveralls.io/builds/14944452) C

[GitHub] coveralls commented on issue #460: [SCB-171] report type/version when register to SC

coveralls commented on issue #460: [SCB-171] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#issuecomment-355919559 [](https://coveralls.io/builds/14944494)

[GitHub] little-cui opened a new pull request #246: SCB-155 Optimize metric.go

little-cui opened a new pull request #246: SCB-155 Optimize metric.go URL: https://github.com/apache/incubator-servicecomb-service-center/pull/246 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issu

[GitHub] WillemJiang opened a new pull request #108: SCB-193 Clean up the project name

WillemJiang opened a new pull request #108: SCB-193 Clean up the project name URL: https://github.com/apache/incubator-servicecomb-saga/pull/108 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues

[GitHub] coveralls commented on issue #246: SCB-155 Optimize metric.go

coveralls commented on issue #246: SCB-155 Optimize metric.go URL: https://github.com/apache/incubator-servicecomb-service-center/pull/246#issuecomment-355923853 [](https://coveralls.io/builds/14944705) Coverage decre

[GitHub] codecov-io commented on issue #246: SCB-155 Optimize metric.go

codecov-io commented on issue #246: SCB-155 Optimize metric.go URL: https://github.com/apache/incubator-servicecomb-service-center/pull/246#issuecomment-355923763 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/246?src=pr&el=h1) Report > Merging [#24

[GitHub] WillemJiang commented on a change in pull request #107: [SCB-168] load balance

WillemJiang commented on a change in pull request #107: [SCB-168] load balance URL: https://github.com/apache/incubator-servicecomb-saga/pull/107#discussion_r160110501 ## File path: omega/omega-connector/omega-connector-grpc/src/main/java/org/apache/servicecomb/saga/omega/connector

[GitHub] WillemJiang commented on a change in pull request #107: [SCB-168] load balance

WillemJiang commented on a change in pull request #107: [SCB-168] load balance URL: https://github.com/apache/incubator-servicecomb-saga/pull/107#discussion_r160105090 ## File path: omega/omega-connector/omega-connector-grpc/pom.xml ## @@ -53,6 +53,21 @@ slf4j-api

[GitHub] coveralls commented on issue #108: SCB-193 Clean up the project name

coveralls commented on issue #108: SCB-193 Clean up the project name URL: https://github.com/apache/incubator-servicecomb-saga/pull/108#issuecomment-355931387 [](https://coveralls.io/builds/14945093) Coverage remained

[GitHub] WillemJiang commented on issue #480: [SCB-118] add prometheus integration impl

WillemJiang commented on issue #480: [SCB-118] add prometheus integration impl URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/480#issuecomment-355931908 Do we have integration test for it? If not please add a JIRA for it. We need to make sure the prometheus clien

[GitHub] liubao68 commented on a change in pull request #479: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load

liubao68 commented on a change in pull request #479: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/479#discussion_r160118733 ## File path: service-registry/src/main/j

[GitHub] liubao68 commented on a change in pull request #495: [SCB-188] Transport optimize for reactive

liubao68 commented on a change in pull request #495: [SCB-188] Transport optimize for reactive URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/495#discussion_r160124352 ## File path: transports/transport-highway/src/main/java/io/servicecomb/transport/highway

[GitHub] liubao68 commented on a change in pull request #495: [SCB-188] Transport optimize for reactive

liubao68 commented on a change in pull request #495: [SCB-188] Transport optimize for reactive URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/495#discussion_r160125490 ## File path: demo/perf/src/main/resources/microservice.yaml ## @@ -15,28 +15,47

[GitHub] seanyinx commented on a change in pull request #107: [SCB-168] load balance

seanyinx commented on a change in pull request #107: [SCB-168] load balance URL: https://github.com/apache/incubator-servicecomb-saga/pull/107#discussion_r160126826 ## File path: omega/omega-connector/omega-connector-grpc/src/main/java/org/apache/servicecomb/saga/omega/connector/gr

[GitHub] seanyinx commented on a change in pull request #107: [SCB-168] load balance

seanyinx commented on a change in pull request #107: [SCB-168] load balance URL: https://github.com/apache/incubator-servicecomb-saga/pull/107#discussion_r160126971 ## File path: omega/omega-connector/omega-connector-grpc/pom.xml ## @@ -53,6 +53,21 @@ slf4j-api

[GitHub] WillemJiang commented on a change in pull request #107: [SCB-168] load balance

WillemJiang commented on a change in pull request #107: [SCB-168] load balance URL: https://github.com/apache/incubator-servicecomb-saga/pull/107#discussion_r160110501 ## File path: omega/omega-connector/omega-connector-grpc/src/main/java/org/apache/servicecomb/saga/omega/connector

[GitHub] seanyinx commented on a change in pull request #107: [SCB-168] load balance

seanyinx commented on a change in pull request #107: [SCB-168] load balance URL: https://github.com/apache/incubator-servicecomb-saga/pull/107#discussion_r160126971 ## File path: omega/omega-connector/omega-connector-grpc/pom.xml ## @@ -53,6 +53,21 @@ slf4j-api

[GitHub] WillemJiang commented on a change in pull request #107: [SCB-168] load balance

WillemJiang commented on a change in pull request #107: [SCB-168] load balance URL: https://github.com/apache/incubator-servicecomb-saga/pull/107#discussion_r160110501 ## File path: omega/omega-connector/omega-connector-grpc/src/main/java/org/apache/servicecomb/saga/omega/connector

[GitHub] seanyinx commented on a change in pull request #107: [SCB-168] load balance

seanyinx commented on a change in pull request #107: [SCB-168] load balance URL: https://github.com/apache/incubator-servicecomb-saga/pull/107#discussion_r160126826 ## File path: omega/omega-connector/omega-connector-grpc/src/main/java/org/apache/servicecomb/saga/omega/connector/gr

[GitHub] coveralls commented on issue #480: [SCB-118] add prometheus integration impl

coveralls commented on issue #480: [SCB-118] add prometheus integration impl URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/480#issuecomment-355949565 [](https://coveralls.io/builds/14946266) C

[GitHub] yhs0092 commented on a change in pull request #493: [SCB-195] Support swagger @Api annotation to specify default tags

yhs0092 commented on a change in pull request #493: [SCB-195] Support swagger @Api annotation to specify default tags URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/493#discussion_r160087774 ## File path: swagger/swagger-generator/generator-core/src/main/ja

[GitHub] eric-lee-ltk opened a new pull request #109: SCB-173 mark start of saga

eric-lee-ltk opened a new pull request #109: SCB-173 mark start of saga URL: https://github.com/apache/incubator-servicecomb-saga/pull/109 Signed-off-by: Eric Lee Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [J

[GitHub] coveralls commented on issue #109: SCB-173 mark start of saga

coveralls commented on issue #109: SCB-173 mark start of saga URL: https://github.com/apache/incubator-servicecomb-saga/pull/109#issuecomment-355961661 [](https://coveralls.io/builds/14946905) Coverage increased (+0.0

[GitHub] coveralls commented on issue #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

coveralls commented on issue #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#issuecomment-355973477 [](https://co

[GitHub] coveralls commented on issue #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

coveralls commented on issue #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#issuecomment-355973875 [](https://co

[GitHub] WillemJiang closed pull request #484: [SCB-199] bug fix: consumer upload file, did not set correct boundary c?

WillemJiang closed pull request #484: [SCB-199] bug fix: consumer upload file, did not set correct boundary c? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/484 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is display

[GitHub] wujimin commented on a change in pull request #495: [SCB-188] Transport optimize for reactive

wujimin commented on a change in pull request #495: [SCB-188] Transport optimize for reactive URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/495#discussion_r160295319 ## File path: demo/perf/src/main/resources/microservice.yaml ## @@ -15,28 +15,47

[GitHub] WillemJiang commented on a change in pull request #488: [SCB-172] upgrade zipkin libraries to zipkin2

WillemJiang commented on a change in pull request #488: [SCB-172] upgrade zipkin libraries to zipkin2 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/488#discussion_r160295645 ## File path: integration-tests/pom.xml ## @@ -54,10 +54,15 @@ 0

[GitHub] wujimin commented on a change in pull request #495: [SCB-188] Transport optimize for reactive

wujimin commented on a change in pull request #495: [SCB-188] Transport optimize for reactive URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/495#discussion_r160296199 ## File path: transports/transport-highway/src/main/java/io/servicecomb/transport/highway/

[GitHub] wujimin closed pull request #493: [SCB-195] Support swagger @Api annotation to specify default tags

wujimin closed pull request #493: [SCB-195] Support swagger @Api annotation to specify default tags URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/493 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below fo

[GitHub] WillemJiang commented on issue #485: [SCB-176] Generate traceId

WillemJiang commented on issue #485: [SCB-176] Generate traceId URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/485#issuecomment-356146319 @seanyinx Could you take a look at this PR? This is an automate

[GitHub] wujimin commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

wujimin commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#discussion_r160297517 ## File path: spring-boot-starter/spring-boot-s

[GitHub] WillemJiang commented on a change in pull request #482: JAV-579 support dataStrArray

WillemJiang commented on a change in pull request #482: JAV-579 support dataStrArray URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/482#discussion_r160297961 ## File path: common/common-rest/src/test/java/io/servicecomb/common/rest/codec/param/TestCsvQueryP

[GitHub] seanyinx commented on a change in pull request #109: [WIP]SCB-173 mark start of saga

seanyinx commented on a change in pull request #109: [WIP]SCB-173 mark start of saga URL: https://github.com/apache/incubator-servicecomb-saga/pull/109#discussion_r160296257 ## File path: integration-tests/pack-tests/src/test/java/org/apache/servicecomb/saga/integration/pack/tests

[GitHub] seanyinx commented on a change in pull request #109: [WIP]SCB-173 mark start of saga

seanyinx commented on a change in pull request #109: [WIP]SCB-173 mark start of saga URL: https://github.com/apache/incubator-servicecomb-saga/pull/109#discussion_r160298115 ## File path: omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/SagaStart

[GitHub] seanyinx commented on a change in pull request #109: [WIP]SCB-173 mark start of saga

seanyinx commented on a change in pull request #109: [WIP]SCB-173 mark start of saga URL: https://github.com/apache/incubator-servicecomb-saga/pull/109#discussion_r160297296 ## File path: integration-tests/pack-tests/src/test/java/org/apache/servicecomb/saga/integration/pack/tests

[GitHub] wujimin commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

wujimin commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#discussion_r160298576 ## File path: spring-boot-starter/spring-boot-s

[GitHub] seanyinx commented on a change in pull request #109: [WIP]SCB-173 mark start of saga

seanyinx commented on a change in pull request #109: [WIP]SCB-173 mark start of saga URL: https://github.com/apache/incubator-servicecomb-saga/pull/109#discussion_r160296382 ## File path: integration-tests/pack-tests/src/test/java/org/apache/servicecomb/saga/integration/pack/tests

[GitHub] seanyinx commented on a change in pull request #109: [WIP]SCB-173 mark start of saga

seanyinx commented on a change in pull request #109: [WIP]SCB-173 mark start of saga URL: https://github.com/apache/incubator-servicecomb-saga/pull/109#discussion_r160296288 ## File path: integration-tests/pack-tests/src/test/java/org/apache/servicecomb/saga/integration/pack/tests

[GitHub] wujimin commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

wujimin commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#discussion_r160298576 ## File path: spring-boot-starter/spring-boot-s

[GitHub] WillemJiang commented on a change in pull request #495: [SCB-188] Transport optimize for reactive

WillemJiang commented on a change in pull request #495: [SCB-188] Transport optimize for reactive URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/495#discussion_r160298905 ## File path: demo/perf/src/main/resources/microservice.yaml ## @@ -15,28 +15

[GitHub] seanyinx closed pull request #108: SCB-193 Clean up the project name

seanyinx closed pull request #108: SCB-193 Clean up the project name URL: https://github.com/apache/incubator-servicecomb-saga/pull/108 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] wujimin commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

wujimin commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#discussion_r160300628 ## File path: spring-boot-starter/spring-boot-s

[GitHub] liubao68 commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

liubao68 commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#discussion_r160301598 ## File path: spring-boot-starter/spring-boot-

[GitHub] liubao68 commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

liubao68 commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#discussion_r160301732 ## File path: spring-boot-starter/spring-boot-

[GitHub] wujimin commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

wujimin commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r160302033 ## File path: pom.xml ## @@ -70,6 +70,7 @@

?????? [Discussion]Improve metrics health checker register mode

Ok , sounds good ,I will do this way~ -- -- ??: "willem.jiang";; : 2018??1??8??(??) 3:29 ??: "dev"; : Re: [Discussion]Improve metrics health checker register mode The annotation way just a common use case in Sprin

[GitHub] wujimin commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

wujimin commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r160302436 ## File path: dynamic-config/config-apollo/pom.xml

[GitHub] seanyinx commented on a change in pull request #488: [SCB-172] upgrade zipkin libraries to zipkin2

seanyinx commented on a change in pull request #488: [SCB-172] upgrade zipkin libraries to zipkin2 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/488#discussion_r160303178 ## File path: integration-tests/test-common/src/test/java/io/servicecomb/tests/tracin

Re: [Discussion]Improve metrics health checker register mode

On 2018-01-08 15:29, Willem Jiang wrote: > The annotation way just a common use case in Spring. I don't think it will > slow down your application startup processing too much. > > You don't need to do the work yourself, Spring support it out of box. > we could add @Service to specify the inst

[GitHub] wujimin closed pull request #486: [SCB-165] Service registry not given proper instances

wujimin closed pull request #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake o

[GitHub] wujimin commented on a change in pull request #482: JAV-579 support dataStrArray

wujimin commented on a change in pull request #482: JAV-579 support dataStrArray URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/482#discussion_r160083164 ## File path: swagger/swagger-generator/generator-core/src/main/java/io/servicecomb/swagger/extend/annot

[GitHub] zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r160304773 ## File path: metrics/metrics-core/src/main/java/io/servicecomb/metrics/core/publish/Def

[GitHub] zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r160304773 ## File path: metrics/metrics-core/src/main/java/io/servicecomb/metrics/core/publish/Def

[GitHub] wujimin commented on a change in pull request #479: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load

wujimin commented on a change in pull request #479: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/479#discussion_r160305752 ## File path: service-registry/src/main/ja

[GitHub] wujimin commented on a change in pull request #479: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load

wujimin commented on a change in pull request #479: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/479#discussion_r160305864 ## File path: service-registry/src/main/ja

Re: [Discussion]Improve metrics health checker register mode

Yes that's right,if user define HealthChecker bean out of component-scan package,it won't be loaded.but I think we can do with Willem's suggestion first and improve later. -- Original -- From: "Jimin Wu";; Date: Tue, Jan 9, 2018 10:02 AM To: "dev";

[GitHub] zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r160306624 ## File path: metrics/metrics-extension/metrics-write-file/src/mai

[GitHub] wujimin commented on a change in pull request #479: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load

wujimin commented on a change in pull request #479: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/479#discussion_r160308647 ## File path: service-registry/src/main/ja

[GitHub] lijasonvip commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

lijasonvip commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r160309072 ## File path: pom.xml ## @@ -70,6 +70,7 @@

[GitHub] lijasonvip commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

lijasonvip commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r160309395 ## File path: dynamic-config/config-apollo/pom.xml #

[GitHub] coveralls commented on issue #495: [SCB-188] Transport optimize for reactive

coveralls commented on issue #495: [SCB-188] Transport optimize for reactive URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/495#issuecomment-356165065 [](https://coveralls.io/builds/14958762) C

[GitHub] yangbor commented on a change in pull request #488: [SCB-172] upgrade zipkin libraries to zipkin2

yangbor commented on a change in pull request #488: [SCB-172] upgrade zipkin libraries to zipkin2 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/488#discussion_r160310146 ## File path: integration-tests/pom.xml ## @@ -54,10 +54,15 @@ 0.6.0

[GitHub] wujimin commented on a change in pull request #479: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load

wujimin commented on a change in pull request #479: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/479#discussion_r160310091 ## File path: service-registry/src/main/ja

[GitHub] coveralls commented on issue #109: [WIP]SCB-173 mark start of saga

coveralls commented on issue #109: [WIP]SCB-173 mark start of saga URL: https://github.com/apache/incubator-servicecomb-saga/pull/109#issuecomment-356166062 [](https://coveralls.io/builds/14959910) Coverage increased

[GitHub] wujimin commented on a change in pull request #479: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load

wujimin commented on a change in pull request #479: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/479#discussion_r160310280 ## File path: service-registry/src/main/ja

[GitHub] coveralls commented on issue #480: [SCB-118] add prometheus integration impl

coveralls commented on issue #480: [SCB-118] add prometheus integration impl URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/480#issuecomment-356166297 [](https://coveralls.io/builds/14958939) C

[GitHub] wujimin commented on a change in pull request #479: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load

wujimin commented on a change in pull request #479: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/479#discussion_r160310485 ## File path: service-registry/src/main/ja

[GitHub] coveralls commented on issue #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

coveralls commented on issue #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#issuecomment-356167053 [](ht

[GitHub] seanyinx commented on a change in pull request #109: [WIP]SCB-173 mark start of saga

seanyinx commented on a change in pull request #109: [WIP]SCB-173 mark start of saga URL: https://github.com/apache/incubator-servicecomb-saga/pull/109#discussion_r160311628 ## File path: omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/Transacti

[GitHub] coveralls commented on issue #487: [SCB-166] Metrics Support HealthCheck

coveralls commented on issue #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#issuecomment-356168626 [](https://coveralls.io/builds/14959673) Cover

[GitHub] yangbor commented on a change in pull request #488: [SCB-172] upgrade zipkin libraries to zipkin2

yangbor commented on a change in pull request #488: [SCB-172] upgrade zipkin libraries to zipkin2 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/488#discussion_r160312001 ## File path: integration-tests/test-common/src/test/java/io/servicecomb/tests/tracing

[GitHub] wujimin commented on a change in pull request #460: [SCB-171] report type/version when register to SC

wujimin commented on a change in pull request #460: [SCB-171] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r160313078 ## File path: foundations/foundation-common/src/main/java/io/servicecomb/foundatio

[GitHub] coveralls commented on issue #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

coveralls commented on issue #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#issuecomment-356171113 [](https://co

[GitHub] coveralls commented on issue #480: [SCB-118] add prometheus integration impl

coveralls commented on issue #480: [SCB-118] add prometheus integration impl URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/480#issuecomment-356171408 [](https://coveralls.io/builds/14960109) C

[GitHub] lijasonvip commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

lijasonvip commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r160313445 ## File path: dynamic-config/config-apollo/src/main/

[GitHub] coveralls commented on issue #487: [SCB-166] Metrics Support HealthCheck

coveralls commented on issue #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#issuecomment-356171454 [](https://coveralls.io/builds/14960142) Cover

[GitHub] coveralls commented on issue #488: [SCB-172] upgrade zipkin libraries to zipkin2

coveralls commented on issue #488: [SCB-172] upgrade zipkin libraries to zipkin2 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/488#issuecomment-356171460 [](https://coveralls.io/builds/14960190)

[GitHub] lijasonvip commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

lijasonvip commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r160313445 ## File path: dynamic-config/config-apollo/src/main/

  1   2   >