[GitHub] codecov-io commented on issue #291: SCB-339 Exclude the version in online services calculation

[GitBox]

codecov-io commented on issue #291: SCB-339 Exclude the version in online 
services calculation
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/291#issuecomment-368204688
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/291?src=pr=h1)
 Report
   > Merging 
[#291](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/291?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/15d9ce8d6cd1b2a60911ddde6b822b7a2c7b925a?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/291/graphs/tree.svg?src=pr=GAaF7zrg8R=150=650)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/291?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #291   +/-   ##
   ===
 Coverage   70.43%   70.43%   
   ===
 Files  17   17   
 Lines3413 3413   
   ===
 Hits 2404 2404   
 Misses842  842   
 Partials  167  167
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/291?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/291/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv)
 | `71.16% <0%> (-0.17%)` | :arrow_down: |
   | 
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/291/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
 | `76.02% <0%> (+0.58%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/291?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/291?src=pr=footer).
 Last update 
[15d9ce8...e21c941](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/291?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #291: SCB-339 Exclude the version in online services calculation

[GitBox]

coveralls commented on issue #291: SCB-339 Exclude the version in online 
services calculation
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/291#issuecomment-368204725
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15712737/badge)](https://coveralls.io/builds/15712737)
   
   Coverage decreased (-0.01%) to 74.064% when pulling 
**e21c94163929d59193319cafc1d5d81db2ad87d8 on little-cui:master** into 
**15d9ce8d6cd1b2a60911ddde6b822b7a2c7b925a on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zhengyangyong commented on issue #34: replace io.servicecomb to org.apache.servicecomb

[GitBox]

zhengyangyong commented on issue #34: replace io.servicecomb to 
org.apache.servicecomb
URL: 
https://github.com/apache/incubator-servicecomb-website/pull/34#issuecomment-368736794
 
 
   We will update all version from 0.6.0-SNAPSHOT to 1.0.0-m1-SNAPSHOT later


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zhengyangyong commented on a change in pull request #34: replace io.servicecomb to org.apache.servicecomb

[GitBox]

zhengyangyong commented on a change in pull request #34: replace io.servicecomb 
to org.apache.servicecomb
URL: 
https://github.com/apache/incubator-servicecomb-website/pull/34#discussion_r170807556
 
 

 ##
 File path: _posts/cn/2017-09-14-maven-dependency-management.md
 ##
 @@ -102,7 +102,7 @@ redirect_from:
import
  
  
-   io.servicecomb
+   org.apache.servicecomb
java-chassis-dependencies
0.2.0
 
 Review comment:
   Done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #220: SC-49 Pact broker module for consumer-driven contract testing

[GitBox]

codecov-io commented on issue #220: SC-49 Pact broker module for 
consumer-driven contract testing
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/220#issuecomment-353623834
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/220?src=pr=h1)
 Report
   > Merging 
[#220](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/220?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/8d40fc3b10e99c9084a7b62504226007660ad6de?src=pr=desc)
 will **decrease** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/220/graphs/tree.svg?width=650=150=pr=GAaF7zrg8R)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/220?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#220  +/-   ##
   =
   - Coverage   70.43%   70.4%   -0.03% 
   =
 Files  17  17  
 Lines34133413  
   =
   - Hits 24042403   -1 
 Misses842 842  
   - Partials  167 168   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/220?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[server/service/service\_dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/220/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvc2VydmljZV9kZXBlbmRlbmN5Lmdv)
 | `73.04% <0%> (-0.87%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/220?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/220?src=pr=footer).
 Last update 
[8d40fc3...31be829](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/220?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #220: SC-49 Pact broker module for consumer-driven contract testing

[GitBox]

coveralls commented on issue #220: SC-49 Pact broker module for consumer-driven 
contract testing
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/220#issuecomment-353988632
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15701531/badge)](https://coveralls.io/builds/15701531)
   
   Coverage decreased (-0.2%) to 73.974% when pulling 
**31be8299b6d3768edec0612a9c513910b7c264c1 on gupadhyaya:master** into 
**8d40fc3b10e99c9084a7b62504226007660ad6de on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #560: [SCB-351] upgrade Jackson to 2.9.4 to avoid security risk

[GitBox]

coveralls commented on issue #560: [SCB-351] upgrade Jackson to 2.9.4 to avoid 
security risk
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/560#issuecomment-368504764
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15697567/badge)](https://coveralls.io/builds/15697567)
   
   Coverage increased (+0.02%) to 87.148% when pulling 
**55fec9005d89e5a309599c57c4cab215e21378c1 on 
yhs0092:upgrade_Jackson_to_2.9.4** into 
**b0f8224f78d3071fceb2d6df3eb8cd98df86a238 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yhs0092 opened a new pull request #560: [SCB-351] upgrade Jackson to 2.9.4 to avoid security risk

[GitBox]

yhs0092 opened a new pull request #560: [SCB-351] upgrade Jackson to 2.9.4 to 
avoid security risk
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/560
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   See details in https://issues.apache.org/jira/browse/SCB-351


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1

[Willem Jiang]

+1 (binding）

I checked the readme file,  running the example and verify the file signature.
They are all looks good.

Willem

On 2/26/18, Mohammad Asif Siddiqui  wrote:
> +1 Binding Vote.
>
> Checks Done:
> 1. Verify the file signature using the key over here [1].
> 2. Build code from source for both linux and windows and test basic
> functionality using the guide over here [2].
> 3. Ran the Service-Center Frontend and verified basic functionality of
> frontend in chrome browser.
> 4.  Ran RAT tool using the guide over here [3], all files have proper
> license.
> 5. Both release contain Readme, Notice, license and disclaimer.
> 6. Readme contains how to start the service-center and frontend.
>
> [1]  https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS
> [2]
> https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release
>
> [3]
> https://github.com/apache/incubator-servicecomb-service-center/tree/master/docs/release
>
>
> Regards
> Asif
>
>
> -Original Message-
> From: Mohammad Asif Siddiqui [mailto:asifdxtr...@yahoo.com.INVALID]
> Sent: 24 February 2018 PM 05:53
> To: Dev 
> Cc: Vinay Murudi ; Krishna M Kumar
> ; Sukesh A C 
> Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating)
> version 1.0.0-m1
>
> Hi All,
> This is a call for vote(second attempt) to release Apache ServiceComb
> Service-Center (Incubating) version 1.0.0-m1.
> Release Notes:
> https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md
> Release Candidate:
> https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
>
> Release Tag:
> https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1
>
> Release CommitId: 8d40fc3b10e99c9084a7b62504226007660ad6de
> Keys to Verify the Release Candidate:
> https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS
> Guide to build the release from source :
> https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release
>
> Issues fixed for the review comments which we got from last voting
> attempt:  1. Added license header in shell script.2. Updated the releases
> with apache-incubator pre-fix.3. Updated the Readme with embeded_etcd
> information.4. Updated frontend start and stop guide.5. Added RAT Report
> https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/rat-report/Rat-Report-2018-02-23.md
>
> Voting will start now (Saturday, 24th Feburary, 2018) and will remain open
> for next 72 hours, Request all PPMC members to give their vote.
> [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No opinion.[ ] -1 Do not
> release this package because
>
>
>
> With Regards  Mohammad Asif Siddiqui
>


-- 

Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

Re: Clean up the old saga modules

[Willem Jiang]

I think it depends on the user requirement.
we can keep the old code there, if the user want to use it , we can put it back.

On 2/26/18, Zheng Feng  wrote:
> It looks good. Do we want to support the old saga module in the future ?
>
> 2018-02-24 16:47 GMT+08:00 Willem Jiang :
>
>> Hi team,
>>
>> As we are planning the servicecomb-saga binary release[1], I found out
>> there are some old saga modules in the current master branch need to be
>> archived.
>>
>> My proposal is we create a branch which holds current master branch codes
>> and remove the old saga module from the master branch. After that, we
>> just
>> put the pack modules into the binary release of servicecomb-saga.
>>
>> Any thoughts？
>>
>> [1] https://issues.apache.org/jira/browse/SCB-346
>>
>> Willem Jiang
>>
>> Blog: http://willemjiang.blogspot.com (English)
>>   http://jnn.iteye.com  (Chinese)
>> Twitter: willemjiang
>> Weibo: 姜宁willem
>>
>


-- 

Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

Re: RE: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1

[bismy]

+1 buiding and run integration tests passed 


-- Original --
From: Sukesh A C 
Date: Mon,Feb 26,2018 1:47 PM
To: Mohammad Asif Siddiqui , 
dev@servicecomb.apache.org 
Cc: Vinay Murudi , Krishna M Kumar 

Subject: Re: RE: [VOTE] Release Apache ServiceComb Service-Center 
(incubating)version 1.0.0-m1



+1 Binding Vote.  

Below Checks Done:  
1. Verify the file signature.  
2. Verified release on windows for both service center and front end using java 
chassis demo.  
3. Ran the Service-Center Frontend and verified basic functionality of 
frontend.  

Thanks,
Sukesh.

-Original Message-
From: Mohammad Asif Siddiqui 
Sent: 26 February 2018 11:08
To: dev@servicecomb.apache.org
Cc: Vinay Murudi ; Krishna M Kumar 
; Sukesh A C 
Subject: RE: [VOTE] Release Apache ServiceComb Service-Center (incubating) 
version 1.0.0-m1

+1 Binding Vote.  

Checks Done:  
1. Verify the file signature using the key over here [1].  
2. Build code from source for both linux and windows and test basic 
functionality using the guide over here [2].  
3. Ran the Service-Center Frontend and verified basic functionality of frontend 
in chrome browser.  
4.  Ran RAT tool using the guide over here [3], all files have proper license.  
5. Both release contain Readme, Notice, license and disclaimer.  
6. Readme contains how to start the service-center and frontend.  

[1]  https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS   
[2]  
https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release
   
[3]  
https://github.com/apache/incubator-servicecomb-service-center/tree/master/docs/release
   

Regards  
Asif


-Original Message-
From: Mohammad Asif Siddiqui [mailto:asifdxtr...@yahoo.com.INVALID] 
Sent: 24 February 2018 PM 05:53
To: Dev 
Cc: Vinay Murudi ; Krishna M Kumar 
; Sukesh A C 
Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 
1.0.0-m1

Hi All,
This is a call for vote(second attempt) to release Apache ServiceComb 
Service-Center (Incubating) version 1.0.0-m1.
Release Notes:  
https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md
  
Release Candidate: 
https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
   
Release Tag: 
https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1
   
Release CommitId: 8d40fc3b10e99c9084a7b62504226007660ad6de 
Keys to Verify the Release Candidate: 
https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS  
Guide to build the release from source : 
https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release

Issues fixed for the review comments which we got from last voting attempt:  1. 
Added license header in shell script.2. Updated the releases with 
apache-incubator pre-fix.3. Updated the Readme with embeded_etcd information.4. 
Updated frontend start and stop guide.5. Added RAT Report 
https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/rat-report/Rat-Report-2018-02-23.md
  

Voting will start now (Saturday, 24th Feburary, 2018) and will remain open for 
next 72 hours, Request all PPMC members to give their vote.
[ ] +1 Release this package as 1.0.0-m1. [ ] +0 No opinion.[ ] -1 Do not 
release this package because



With Regards  Mohammad Asif Siddiqui