[GitHub] codecov-io commented on issue #325: SCB-472 Null point reference in zipkin plugin

2018-04-10 Thread GitBox
codecov-io commented on issue #325: SCB-472 Null point reference in zipkin plugin URL: https://github.com/apache/incubator-servicecomb-service-center/pull/325#issuecomment-380034141 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr=h1) Report

[GitHub] coveralls commented on issue #325: SCB-472 Null point reference in zipkin plugin

2018-04-10 Thread GitBox
coveralls commented on issue #325: SCB-472 Null point reference in zipkin plugin URL: https://github.com/apache/incubator-servicecomb-service-center/pull/325#issuecomment-380034081 [![Coverage Status](https://coveralls.io/builds/16433463/badge)](https://coveralls.io/builds/16433463)

[java-chassis and other]About naming conventions for Microservice Name, Schema Id and Operation Id

2018-04-10 Thread bismy
Hi All, Background: As many features depend on these name and frequently used in yamls, environment keys, and in program parsing, like in PR: https://github.com/apache/incubator-servicecomb-java-chassis/pull/577 If name conventions is not defined, this will cause a lot of compatible

[GitHub] little-cui opened a new pull request #325: SCB-472 Null point reference in zipkin plugin

2018-04-10 Thread GitBox
little-cui opened a new pull request #325: SCB-472 Null point reference in zipkin plugin URL: https://github.com/apache/incubator-servicecomb-service-center/pull/325 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[GitHub] aseTo2016 opened a new pull request #326: [SCB-473][sc]delete service, should delete dependency key

2018-04-10 Thread GitBox
aseTo2016 opened a new pull request #326: [SCB-473][sc]delete service, should delete dependency key URL: https://github.com/apache/incubator-servicecomb-service-center/pull/326 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there

[GitHub] coveralls commented on issue #325: SCB-472 Null point reference in zipkin plugin

2018-04-10 Thread GitBox
coveralls commented on issue #325: SCB-472 Null point reference in zipkin plugin URL: https://github.com/apache/incubator-servicecomb-service-center/pull/325#issuecomment-380034081 [![Coverage Status](https://coveralls.io/builds/16434632/badge)](https://coveralls.io/builds/16434632)

[GitHub] codecov-io commented on issue #325: SCB-472 Null point reference in zipkin plugin

2018-04-10 Thread GitBox
codecov-io commented on issue #325: SCB-472 Null point reference in zipkin plugin URL: https://github.com/apache/incubator-servicecomb-service-center/pull/325#issuecomment-380034141 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr=h1) Report

[GitHub] coveralls commented on issue #326: [SCB-473][sc]delete service, should delete dependency key

2018-04-10 Thread GitBox
coveralls commented on issue #326: [SCB-473][sc]delete service, should delete dependency key URL: https://github.com/apache/incubator-servicecomb-service-center/pull/326#issuecomment-380063520 [![Coverage

[GitHub] codecov-io commented on issue #326: [SCB-473][sc]delete service, should delete dependency key

2018-04-10 Thread GitBox
codecov-io commented on issue #326: [SCB-473][sc]delete service, should delete dependency key URL: https://github.com/apache/incubator-servicecomb-service-center/pull/326#issuecomment-380063602 #

[GitHub] wujimin opened a new pull request #643: [SCB-445] Delete old metrics mechanism

2018-04-10 Thread GitBox
wujimin opened a new pull request #643: [SCB-445] Delete old metrics mechanism URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/643 ![image](https://user-images.githubusercontent.com/16874843/38560809-132e6182-3d09-11e8-81d5-b8a7a6e667fd.png)

[GitHub] coveralls commented on issue #627: [SCB-292] chassis support standard parameter validation

2018-04-10 Thread GitBox
coveralls commented on issue #627: [SCB-292] chassis support standard parameter validation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#issuecomment-377222163 [![Coverage

[GitHub] WillemJiang commented on a change in pull request #639: [SCB-422] prometheus switch to new mechanism

2018-04-10 Thread GitBox
WillemJiang commented on a change in pull request #639: [SCB-422] prometheus switch to new mechanism URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/639#discussion_r180329100 ## File path:

Re: Ask for Help of ServiceComb Saga

2018-04-10 Thread Willem Jiang
Hi YangBo, You can ask Wushen for help, as he just finish the work in the Skywalking side. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Tue, Apr 10, 2018 at 11:23 AM, Yang Bo

[GitHub] wujimin closed pull request #639: [SCB-422] prometheus switch to new mechanism

2018-04-10 Thread GitBox
wujimin closed pull request #639: [SCB-422] prometheus switch to new mechanism URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/639 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

Re: Ask for Help of ServiceComb Saga

2018-04-10 Thread Willem Jiang
Hi Fengzheng, Thanks for you help, I'm really appreciate that. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Tue, Apr 10, 2018 at 2:36 PM, Zheng Feng wrote: > I'm working on

[GitHub] zhengyangyong opened a new pull request #641: add spring boot starter provider archetype

2018-04-10 Thread GitBox
zhengyangyong opened a new pull request #641: add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution

[GitHub] yangbor opened a new pull request #642: [SCB-468] Add notice for vertx 3.5.1

2018-04-10 Thread GitBox
yangbor opened a new pull request #642: [SCB-468] Add notice for vertx 3.5.1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/642 This is related to SCB-459 which upgraded vertx to 3.5.1. Follow this checklist to help us incorporate your contribution quickly and

Re: Ask for Help of ServiceComb Saga

2018-04-10 Thread Zheng Feng
I'm working on the acceptance tests. 2018-04-10 11:23 GMT+08:00 Yang Bo : > Hi, > > I'll work on the SSL support of gRPC. > > [1]https://issues.apache.org/jira/browse/SCB-342 > > On Mon, Apr 9, 2018 at 6:15 PM, 李波 wrote: > > > Hi, > > > > I will take the

[GitHub] wujimin commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-04-10 Thread GitBox
wujimin commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r180609946 ## File path:

[GitHub] liubao68 commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-04-10 Thread GitBox
liubao68 commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r180611794 ## File path:

[GitHub] little-cui closed pull request #326: SCB-473 delete service, should delete dependency key

2018-04-10 Thread GitBox
little-cui closed pull request #326: SCB-473 delete service, should delete dependency key URL: https://github.com/apache/incubator-servicecomb-service-center/pull/326 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the