[GitHub] little-cui opened a new pull request #243: SCB-181 Unused instance index key is stored in backend.

2018-01-04 Thread GitBox
little-cui opened a new pull request #243: SCB-181 Unused instance index key is stored in backend. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/243 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there

[GitHub] coveralls commented on issue #103: [SCB-167] proper connection & disconnection

2018-01-04 Thread GitBox
coveralls commented on issue #103: [SCB-167] proper connection & disconnection URL: https://github.com/apache/incubator-servicecomb-saga/pull/103#issuecomment-355492518 [![Coverage Status](https://coveralls.io/builds/14912699/badge)](https://coveralls.io/builds/14912699)

[GitHub] coveralls commented on issue #486: [SCB-165] Service registry not given proper instances

2018-01-04 Thread GitBox
coveralls commented on issue #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#issuecomment-355492490 [![Coverage

[GitHub] seanyinx commented on issue #103: [SCB-167] proper connection & disconnection

2018-01-04 Thread GitBox
seanyinx commented on issue #103: [SCB-167] proper connection & disconnection URL: https://github.com/apache/incubator-servicecomb-saga/pull/103#issuecomment-355490972 @eric-lee-ltk please review This is an automated message

[GitHub] seanyinx opened a new pull request #103: [SCB-167] proper connection & disconnection

2018-01-04 Thread GitBox
seanyinx opened a new pull request #103: [SCB-167] proper connection & disconnection URL: https://github.com/apache/incubator-servicecomb-saga/pull/103 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[GitHub] coveralls commented on issue #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
coveralls commented on issue #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#issuecomment-355486600 [![Coverage

[GitHub] zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r159816054 ## File path:

[GitHub] zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r159815856 ## File path:

[GitHub] coveralls commented on issue #102: SCB-157 Updated the pom setting for apache release

2018-01-04 Thread GitBox
coveralls commented on issue #102: SCB-157 Updated the pom setting for apache release URL: https://github.com/apache/incubator-servicecomb-saga/pull/102#issuecomment-355468256 [![Coverage Status](https://coveralls.io/builds/14911229/badge)](https://coveralls.io/builds/14911229)

[GitHub] wujimin commented on a change in pull request #482: JAV-579 support dataStrArray

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #482: JAV-579 support dataStrArray URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/482#discussion_r159804420 ## File path:

[GitHub] wujimin commented on a change in pull request #482: JAV-579 support dataStrArray

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #482: JAV-579 support dataStrArray URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/482#discussion_r159804420 ## File path:

[GitHub] zhengyangyong opened a new pull request #24: [SCB-132] Metrics MD

2018-01-04 Thread GitBox
zhengyangyong opened a new pull request #24: [SCB-132] Metrics MD URL: https://github.com/apache/incubator-servicecomb-website/pull/24 add en version and sync cn version This is an automated message from the Apache Git

[GitHub] WillemJiang commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
WillemJiang commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r159589006 ## File path:

[GitHub] WillemJiang commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
WillemJiang commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r15954 ## File path:

?????? Dynamic configuration support

2018-01-04 Thread ??????
Hi: 1. I think we best keep the old yaml config style for compatible,and if we start support the third config center like consul,more duplicate config key may import; 2. I think we can make it work like handler cse.config.provider:apollo --> apollo impl; cse.config.provider:cc -->

[GitHub] WillemJiang closed pull request #100: [SCB-100] async support

2018-01-04 Thread GitBox
WillemJiang closed pull request #100: [SCB-100] async support URL: https://github.com/apache/incubator-servicecomb-saga/pull/100 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] wujimin commented on issue #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on issue #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#issuecomment-355354274 maybe this is simpler and not depend on jackson Deprecated method: ```

[GitHub] wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r159657536 ## File path:

[GitHub] wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r159657898 ## File path:

[GitHub] wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r159657536 ## File path:

[GitHub] wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r159657096 ## File path:

[GitHub] wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r159656972 ## File path:

[GitHub] wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r159656724 ## File path:

[GitHub] wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r159656429 ## File path: pom.xml ## @@ -264,5 +264,11 @@ +

[GitHub] wujimin commented on a change in pull request #450: [JAV-429] modify the startup policy of SDK

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #450: [JAV-429] modify the startup policy of SDK URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/450#discussion_r159655423 ## File path:

[GitHub] wujimin commented on a change in pull request #450: [JAV-429] modify the startup policy of SDK

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #450: [JAV-429] modify the startup policy of SDK URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/450#discussion_r159654646 ## File path:

[GitHub] wujimin commented on issue #450: [JAV-429] modify the startup policy of SDK

2018-01-04 Thread GitBox
wujimin commented on issue #450: [JAV-429] modify the startup policy of SDK URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/450#issuecomment-355284675 too many problems. please review it yourself carefully.

[GitHub] weichao666 commented on issue #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
weichao666 commented on issue #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#issuecomment-355250323 After discussion, use ServiceComb version

[GitHub] coveralls commented on issue #486: [SCB-165] Service registry not given proper instances

2018-01-04 Thread GitBox
coveralls commented on issue #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#issuecomment-355230132 [![Coverage

[GitHub] coveralls commented on issue #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
coveralls commented on issue #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#issuecomment-355229863 [![Coverage

[GitHub] zhengyangyong commented on issue #480: [SCB-118] add prometheus integration impl

2018-01-04 Thread GitBox
zhengyangyong commented on issue #480: [SCB-118] add prometheus integration impl URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/480#issuecomment-355228165 Rebase on upstream master This is an

[GitHub] zhengyangyong commented on issue #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
zhengyangyong commented on issue #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#issuecomment-355227917 Rebase on upstream master

[GitHub] zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r159600235 ## File path:

[GitHub] zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r159600082 ## File path:

[GitHub] little-cui closed pull request #240: SCB-161 Optimize restful client.

2018-01-04 Thread GitBox
little-cui closed pull request #240: SCB-161 Optimize restful client. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/240 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] seanyinx closed pull request #98: SCB-138 use grpc bidirectional streaming to connect alpha and omega

2018-01-04 Thread GitBox
seanyinx closed pull request #98: SCB-138 use grpc bidirectional streaming to connect alpha and omega URL: https://github.com/apache/incubator-servicecomb-saga/pull/98 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the