[GitHub] WillemJiang commented on issue #301: SCB-317 Update the release scripts to replace incubator with incubating
WillemJiang commented on issue #301: SCB-317 Update the release scripts to replace incubator with incubating URL: https://github.com/apache/incubator-servicecomb-service-center/pull/301#issuecomment-372096333 @asifdxtreme I just submitted a new PR#302 for this change. Please take a look at this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #302: SCB-380 Added incubating to the release kit name
coveralls commented on issue #302: SCB-380 Added incubating to the release kit name URL: https://github.com/apache/incubator-servicecomb-service-center/pull/302#issuecomment-372096354 [](https://coveralls.io/builds/15913724) Coverage remained the same at 74.063% when pulling **300e8a6ce8a3f8c12257af60208f5adc89409a91 on SCB-380** into **7467d57e3585fbb416c8eae50ddf01eb4a8f2b7f on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #302: SCB-380 Added incubating to the release kit name
codecov-io commented on issue #302: SCB-380 Added incubating to the release kit name URL: https://github.com/apache/incubator-servicecomb-service-center/pull/302#issuecomment-372096341 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/302?src=pr&el=h1) Report > Merging [#302](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/302?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/7467d57e3585fbb416c8eae50ddf01eb4a8f2b7f?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/302?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #302 +/- ## == + Coverage 70.39% 70.41% +0.02% == Files 17 17 Lines3455 3455 == + Hits 2432 2433 +1 Misses853 853 + Partials 170 169 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/302?src=pr&el=tree) | Coverage ? | | |---|---|---| | [server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/302/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv) | `71.28% <0%> (+0.16%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/302?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/302?src=pr&el=footer). Last update [7467d57...300e8a6](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/302?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang commented on issue #302: SCB-380 Added incubating to the release kit name
WillemJiang commented on issue #302: SCB-380 Added incubating to the release kit name URL: https://github.com/apache/incubator-servicecomb-service-center/pull/302#issuecomment-372096048 NOTE, this change may affect to the docker image start up script. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang opened a new pull request #302: SCB-380 Added incubating to the release kit name
WillemJiang opened a new pull request #302: SCB-380 Added incubating to the release kit name URL: https://github.com/apache/incubator-servicecomb-service-center/pull/302 * Changed the kit name to apache-servicecomb-incubating-service-center-xxx * Reduced the binary name to service-center and frontend. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #301: SCB-317 Update the release scripts to replace incubator with incubating
coveralls commented on issue #301: SCB-317 Update the release scripts to replace incubator with incubating URL: https://github.com/apache/incubator-servicecomb-service-center/pull/301#issuecomment-372094104 [](https://coveralls.io/builds/15913521) Coverage increased (+0.05%) to 74.112% when pulling **d87c01b5fee97ca70f404d842909576f23eede68 on asifdxtreme:master** into **7467d57e3585fbb416c8eae50ddf01eb4a8f2b7f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #301: SCB-317 Update the release scripts to replace incubator with incubating
codecov-io commented on issue #301: SCB-317 Update the release scripts to replace incubator with incubating URL: https://github.com/apache/incubator-servicecomb-service-center/pull/301#issuecomment-372094088 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/301?src=pr&el=h1) Report > Merging [#301](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/301?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/7467d57e3585fbb416c8eae50ddf01eb4a8f2b7f?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/301?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #301 +/- ## === Coverage 70.39% 70.39% === Files 17 17 Lines3455 3455 === Hits 2432 2432 Misses853 853 Partials 170 170 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/301?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/301?src=pr&el=footer). Last update [7467d57...d87c01b](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/301?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asifdxtreme opened a new pull request #301: SCB-317 Update the release scripts to replace incubator with incubating
asifdxtreme opened a new pull request #301: SCB-317 Update the release scripts to replace incubator with incubating URL: https://github.com/apache/incubator-servicecomb-service-center/pull/301 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0
Hi All, We are cancelling this vote thread as some changes needs to be done in Readme for samples. We will re-intiate a separate vote thread for new release candidate. Thanks all for your support. Regards Asif On 2018/03/08 17:10:38, Mohammad Asif Siddiqui wrote: > Hi All, > > This is a call for Vote to release Apache ServiceComb Saga (Incubating) > version 0.1.0 > > Release Notes : > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12342353 > > > Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-saga/0.1.0/ > > > Staging Repo : > https://repository.apache.org/content/repositories/orgapacheservicecomb-1052/ > > > Release Tag : > https://github.com/apache/incubator-servicecomb-saga/releases/tag/0.1.0 > > Release CommitID : 63720b5afce5507db1541a5a7f704bd37bfe2758 > > Keys to verify the Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > > Voting will start now ( Thursday, 8th March, 2018) and will remain open for > next 72 hours, Request all PPMC members to give their vote > > [ ] +1 Release this package as 1.0.0-m1 > [ ] +0 No Opinion > [ ] -1 Do not release this package because > > Regards > Asif > > >
Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1
Hi All, We are cancelling this vote as some changes needs to be done in Readme for samples. We will re-intiate a separate vote thread for new release candidate. Thanks all for your support. Regards Asif On 2018/03/08 16:49:15, Mohammad Asif Siddiqui wrote: > Hi All, > > This is a call for Vote to release Apache ServiceComb Java-Chassis > (Incubating) version 1.0.0-m1 > > Release Notes : > https://github.com/apache/incubator-servicecomb-java-chassis/blob/master/etc/releaseNotes.md > > > Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/ > > > Staging Repo : > https://repository.apache.org/content/repositories/orgapacheservicecomb-1050/ > > > Release Tag : > https://github.com/apache/incubator-servicecomb-java-chassis/releases/tag/1.0.0-m1 > > > Release CommitID : c3010365254b64d344694277f777c43f5b02116c > > Keys to verify the Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > > Voting will start now ( Thursday, 8th March, 2018) and will remain open for > next 72 hours, Request all PPMC members to give their vote > > [ ] +1 Release this package as 1.0.0-m1 > [ ] +0 No Opinion > [ ] -1 Do not release this package because > > Regards > Asif > > >
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Third Attempt
Hi All, I am cancelling this vote as the release binary name needs to be changed, we will re-initiate the seperate vote thread for new release candidate. Thanks all for your support. Reagrds Asif On 2018/03/08 12:02:24, Mohammad Asif Siddiqui wrote: > Hi All, > > This is a call for Vote to release Apache ServiceComb Service-Center > (Incubating) version 1.0.0-m1 (third release candidate). > > Release Notes : > https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md > > > Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > > Release Tag : > https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 > > > > Release CommitID : b30cdce694ad0752cf6dda4c52f7fef7907d14c3 > > Keys to verify the Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > > Release Source : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/ > > > Guide to build the release from source : > https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release > > > Voting will start now ( Thursday, 8th March, 2018) and will remain open for > next 72 hours, Request all PPMC members to give their vote. > > [ ] +1 Release this package as 1.0.0-m1. > [ ] +0 No Opinion. > [ ] -1 Do not release this package because > > Regards > Asif > >
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Third Attempt
-1 The release name should contain apache-incubating name, currently its apache incubator. On 2018/03/08 12:02:24, Mohammad Asif Siddiqui wrote: > Hi All, > > This is a call for Vote to release Apache ServiceComb Service-Center > (Incubating) version 1.0.0-m1 (third release candidate). > > Release Notes : > https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md > > > Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > > Release Tag : > https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 > > > > Release CommitID : b30cdce694ad0752cf6dda4c52f7fef7907d14c3 > > Keys to verify the Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > > Release Source : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/ > > > Guide to build the release from source : > https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release > > > Voting will start now ( Thursday, 8th March, 2018) and will remain open for > next 72 hours, Request all PPMC members to give their vote. > > [ ] +1 Release this package as 1.0.0-m1. > [ ] +0 No Opinion. > [ ] -1 Do not release this package because > > Regards > Asif > >
[GitHub] WillemJiang commented on issue #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting
WillemJiang commented on issue #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/584#issuecomment-372032679 Tested on macOSX, the test was blocked when starting the contianer, so we cannot merge for 1.0.0-m1 release. I just tested docker plugin 0.23.0, the dynamic configuration integration test is passed, but for the docker plugin 0.24.0, the plugin cannot get the log input there. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang closed pull request #581: [SCB-378] add readme document for samples
WillemJiang closed pull request #581: [SCB-378] add readme document for samples URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/581 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/samples/auth-sample/README.md b/samples/auth-sample/README.md new file mode 100644 index 0..fbf78217e --- /dev/null +++ b/samples/auth-sample/README.md @@ -0,0 +1,91 @@ +## Auth-Sample + +To make sure the security between the interfaces of services, users can enable `RSA Authorizaiton` by simple configuration as below. + +## Consumer Service + +* Add dependence in pom.xml file: + + ```xml + +org.apache.servicecomb +handler-publickey-auth + + ``` + +* Add handler chain in microservice.yaml: + + ```yaml + cse: +# other configurations omitted +handler: + chain: +Consumer: + default: auth-consumer + ``` + +## Provider Service + +* Add dependence in pom.xml file: + + ```xml + +org.apache.servicecomb +handler-publickey-auth + + ``` + +* Add handler chain in microservice.yaml: + + ```yaml + cse: +# other configurations omitted +handler: + chain: +Consumer: + default: auth-provider + ``` + +## Sample Quick Start + +Auth sample use `RestTemplate` to present RSA communication between provider and consumer. + +1. Start the ServiceComb/Service Center + + - [how to start the service center](http://servicecomb.incubator.apache.org/users/setup-environment/#) + - make sure service center address is configured correctly in `microservice.yaml` file + + ```yaml + cse: + service: + registry: + address: http://127.0.0.1:30100 #service center address + ``` + +2. Start the auth-provider service + + - Start provider service by maven + + Compile the source code at root directory of ServiceComb Java Chassis, which is `incubator-servicecomb-java-chassis/`, and use `mvn exec` to execute the main class `AuthProviderMain`. + + ```bash + cd incubator-servicecomb-java-chassis/ + mvn clean install -Psamples -DskipTests #only need to install at first time. + cd samples/auth-sample/auth-provider/ + mvn exec:java -Dexec.mainClass="org.apache.servicecomb.samples.springmvc.provider.AuthProviderMain" + ``` + + - Start provider service by IDE + + Import the project by InteliJ IDEA or Eclipse, add sample module to pom.xml file in root module `incubator-servicecomb-java-chassis/pom.xml`, and add `samples` to `` block, Then find `main` function `AuthProviderMain` of provider service and `RUN` it like any other Java program. + +3. Start the auth-consumer service + + Just like how to start auth-provider service. But the main class of auth-consumer service is `AuthConsumerMain`. + + ```bash + cd samples/auth-sample/auth-consumer/ + mvn exec:java -Dexec.mainClass="org.apache.servicecomb.samples.springmvc.consumer.AuthConsumerMain" + ``` + + ? \ No newline at end of file diff --git a/samples/bmi/README.md b/samples/bmi/README.md index 481e084b2..e7a9c9e59 100644 --- a/samples/bmi/README.md +++ b/samples/bmi/README.md @@ -10,15 +10,13 @@ There are two microservices in this demo. ## Quick Start(Linux) 1. Run the service center -```bash -wget https://github.com/ServiceComb/service-center/releases/download/0.1.1/service-center-0.1.1-linux-amd64.tar.gz -tar xvf service-center-0.1.1-linux-amd64.tar.gz -(cd service-center-0.1.1-linux-amd64; bash start.sh) -``` + + [how to start service center](http://servicecomb.incubator.apache.org/users/setup-environment/#) + 2. Get the bmi demo's code ```bash -git clone https://github.com/ServiceComb/ServiceComb-Java-Chassis -cd ServiceComb-Java-Chassis/samples +git clone https://github.com/apache/incubator-servicecomb-java-chassis.git +cd incubator-servicecomb-java-chassis/samples ``` 3. Run microservices * Run the **BMI calculator service** @@ -29,4 +27,4 @@ cd ServiceComb-Java-Chassis/samples ```bash (cd bmi/webapp; mvn spring-boot:run) ``` -4. Visit the services via **http://127.0.0.1:8889**. \ No newline at end of file +4. Visit the services via **http://127.0.0.1:8889**. diff --git a/samples/codefirst-sample/README.md b/samples/codefirst-sample/README.md new file mode 100644 index 0..b756ae984 --- /dev/null +++ b/samples/codefirst-sample/README.md @@ -0,0 +1,51 @@ +## Code First Sample + +ServiceComb Java Chassis supports generating provider-service API implicitly. When the service is started, an API is automatically generated and registered to the service center. + +When you develop a microservice in transparent RPC mode, the code does not show how you want to define an API, and all generated APIs are POST methods,
[GitHub] WillemJiang commented on issue #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting
WillemJiang commented on issue #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/584#issuecomment-372032679 Tested on macOSX, the test was blocked when starting the contianer, so we cannot merge for 1.0.0-m1 release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeho0815 commented on a change in pull request #578: SCB-373 change Rest args code/encoding to HttpClientFilter/HttpServer?
jeho0815 commented on a change in pull request #578: SCB-373 change Rest args
code/encoding to HttpClientFilter/HttpServer?
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/578#discussion_r173623397
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/filter/inner/ServerRestArgsFilter.java
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.common.rest.filter.inner;
+
+import org.apache.servicecomb.common.rest.RestConst;
+import org.apache.servicecomb.common.rest.codec.RestCodec;
+import org.apache.servicecomb.common.rest.codec.produce.ProduceProcessor;
+import org.apache.servicecomb.common.rest.definition.RestOperationMeta;
+import org.apache.servicecomb.common.rest.filter.HttpServerFilter;
+import org.apache.servicecomb.core.Invocation;
+import org.apache.servicecomb.foundation.vertx.http.HttpServletRequestEx;
+import org.apache.servicecomb.foundation.vertx.http.HttpServletResponseEx;
+import org.apache.servicecomb.foundation.vertx.stream.BufferOutputStream;
+import org.apache.servicecomb.swagger.invocation.Response;
+import org.apache.servicecomb.swagger.invocation.exception.ExceptionFactory;
+import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
+
+import io.netty.buffer.Unpooled;
+
+public class ServerRestArgsFilter implements HttpServerFilter {
+
+ @Override
+ public int getOrder() {
+return -100;
+ }
+
+ @Override
+ public Response afterReceiveRequest(Invocation invocation,
HttpServletRequestEx requestEx) {
+RestOperationMeta restOperationMeta = (RestOperationMeta) requestEx
+.getAttribute(RestConst.OPERATION_PARAMETERS);
+Object[] args = RestCodec.restToArgs(requestEx, restOperationMeta);
+invocation.setSwaggerArguments(args);
+return null;
+ }
+
+ @Override
+ public void beforeSendResponse(Invocation invocation, HttpServletResponseEx
responseEx) {
+Response response = (Response)
invocation.getHandlerContext().get(RestConst.INVOCATION_HANDLER_RESPONSE);
+ProduceProcessor produceProcessor = (ProduceProcessor)
invocation.getHandlerContext()
+.get(RestConst.INVOCATION_HANDLER_PROCESSOR);
+Object body = response.getResult();
+if (response.isFailed()) {
+ body = ((InvocationException) body).getErrorData();
+}
+
+try (BufferOutputStream output = new
BufferOutputStream(Unpooled.compositeBuffer())) {
+ produceProcessor.encodeResponse(output, body);
+
+ responseEx.setBodyBuffer(output.getBuffer());
+} catch (Exception e) {
Review comment:
yes, i'll repair this
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] WillemJiang commented on issue #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting
WillemJiang commented on issue #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/584#issuecomment-372032679 Tested on macOSX, the test is blocked, so we cannot merge for 1.0.0-m1 release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #581: [SCB-378] add readme document for samples
coveralls commented on issue #581: [SCB-378] add readme document for samples URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/581#issuecomment-371753636 [](https://coveralls.io/builds/15907318) Coverage decreased (-0.02%) to 87.166% when pulling **48b97f23a530fb67f51795a5dc5edb23d1c9d9a7 on lijasonvip:sample-readme** into **17137b5905940094f804451aacc5a7c21e711aea on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lijasonvip commented on a change in pull request #581: [SCB-378] add readme document for samples
lijasonvip commented on a change in pull request #581: [SCB-378] add readme document for samples URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/581#discussion_r173617546 ## File path: samples/auth-sample/README.md ## @@ -0,0 +1,82 @@ +## Auth-Sample + +To make sure the security between the interfaces of services, users can enable `RSA Authorizaiton` by simple configuration as below. + +## Consumer Service + +* Add dependence in pom.xml file: + + ```xml + +org.apache.servicecomb +handler-publickey-auth + + ``` + +* Add handler chain in microservice.yaml: + + ```yaml + cse: +# other configurations omitted +handler: + chain: +Consumer: + default: auth-consumer + ``` + +## Provider Service + +* Add dependence in pom.xml file: + + ```xml + +org.apache.servicecomb +handler-publickey-auth + + ``` + +* Add handler chain in microservice.yaml: + + ```yaml + cse: +# other configurations omitted +handler: + chain: +Consumer: + default: auth-provider + ``` + +## Sample Quick Start + +Auth sample use `RestTemplate` to present RSA communication between provider and consumer. + +1. Start the ServiceComb/Service Center + + - [how to start the service center](http://servicecomb.incubator.apache.org/users/setup-environment/#) + - make sure service center address is configured correctly in `microservice.yaml` file + + ```yaml + cse: + service: + registry: + address: http://127.0.0.1:30100 #service center address + ``` + +2. Start the auth-provider service + + - Start provider service by mvn + + ```bash + cd incubator-servicecomb-java-chassis/ + mvn clean install -Psamples -DskipTests #only need to install at first time. Review comment: Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting
coveralls commented on issue #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/584#issuecomment-372017538 [](https://coveralls.io/builds/15907157) Coverage increased (+0.02%) to 87.206% when pulling **58e75a3f3dd410272d7c7acd6a97c91c3305b375 on zhengyangyong:SCB-382** into **17137b5905940094f804451aacc5a7c21e711aea on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhengyangyong opened a new pull request #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting
zhengyangyong opened a new pull request #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/584 ?s-on setting Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- More detail can be found : https://dmp.fabric8.io/#start-depends-on This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wujimin commented on a change in pull request #583: [SCB-381] Fix foundation-vertx UT failure
wujimin commented on a change in pull request #583: [SCB-381] Fix foundation-vertx UT failure URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/583#discussion_r173616568 ## File path: foundations/foundation-vertx/pom.xml ## @@ -53,4 +53,21 @@ foundation-test-scaffolding + + + + + +org.apache.maven.plugins +maven-surefire-plugin + + 1 + false Review comment: not a good idea should fix the root cause. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang closed pull request #583: [SCB-381] Fix foundation-vertx UT failure
WillemJiang closed pull request #583: [SCB-381] Fix foundation-vertx UT failure URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/583 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/foundations/foundation-vertx/pom.xml b/foundations/foundation-vertx/pom.xml index b60a07227..7b70dec2e 100644 --- a/foundations/foundation-vertx/pom.xml +++ b/foundations/foundation-vertx/pom.xml @@ -53,4 +53,21 @@ foundation-test-scaffolding + + + + + +org.apache.maven.plugins +maven-surefire-plugin + + 1 + false + + + + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
