[GitHub] coveralls commented on issue #609: [SCB-383] Metrics subscribe invocation life event and statistics
coveralls commented on issue #609: [SCB-383] Metrics subscribe invocation life event and statistics URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/609#issuecomment-373891384 [](https://coveralls.io/builds/16029096) Coverage increased (+0.04%) to 87.353% when pulling **c9445c3c6c089162dcea6a1751691b1da6203bb3 on wujimin:metrics-subscribe-invocation-life-event-and-statistics** into **3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wujimin opened a new pull request #609: [SCB-383] Metrics subscribe invocation life event and statistics
wujimin opened a new pull request #609: [SCB-383] Metrics subscribe invocation life event and statistics URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/609  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt
Hi All, This is a call for Vote to release Apache ServiceComb Saga (Incubating) version 0.1.0 Release Notes : https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626=12342353 Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-saga/0.1.0/ Staging Repo : https://repository.apache.org/content/repositories/orgapacheservicecomb-1166 Release Tag : https://github.com/apache/incubator-servicecomb-saga/releases/tag/0.1.0 Release CommitID : 708eec092988dfd4a5960ca5f232fb7421d5fbdd Keys to verify the Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS Voting will start now ( Saturday, 17th March, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote [ ] +1 Release this package as 0.1.0 [ ] +0 No Opinion [ ] -1 Do not release this package because Regards Asif
[VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt
Hi All, This is a call for Vote to release Apache ServiceComb Java-Chassis (Incubating) version 1.0.0-m1 Release Notes : https://github.com/apache/incubator-servicecomb-java-chassis/blob/master/etc/releaseNotes.md Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/ Staging Repo : https://repository.apache.org/content/repositories/orgapacheservicecomb-1181/ Release Tag : https://github.com/apache/incubator-servicecomb-java-chassis/releases/tag/1.0.0-m1 Release CommitID : 3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe Keys to verify the Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS Voting will start now ( Saturday, 17th March, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote [ ] +1 Release this package as 1.0.0-m1 [ ] +0 No Opinion [ ] -1 Do not release this package because Regards Asif
[VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt
Hi All, This is a call for Vote to release Apache ServiceComb Service-Center (Incubating) version 1.0.0-m1 (fourth release candidate). Release Notes : https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ Release Tag : https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539 Keys to verify the Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS Guide to build the release from source : https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release Voting will start now ( Saturday, 17th March, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote. [ ] +1 Release this package as 1.0.0-m1 [ ] +0 No Opinion [ ] -1 Do not release this package because Regards Asif
discussion: about performance metrics local log output format.
1.output will be group by transport and statusCode for consumer and producer operation is empty means this line is summary for this group 2.will add cpu/memory/gc output in the furture. cpu is only about this process, not about os level because jvm did not provide api to get os level cpu usage except invoke command and analysis the output. 3.if necessary will add configuration to filter operations, so that will not print so many informations. any suggestions? thanks.
[GitHub] WillemJiang closed pull request #43: SCB-312 added 10th live streaming materials
WillemJiang closed pull request #43: SCB-312 added 10th live streaming materials
URL: https://github.com/apache/incubator-servicecomb-website/pull/43
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/_pages/about-slides.md b/_pages/about-slides.md
index af6685a..18d4b81 100644
--- a/_pages/about-slides.md
+++ b/_pages/about-slides.md
@@ -43,3 +43,6 @@ date: 2017-06-20T11:02:20+08:00
## [ServiceComb live streaming phase
IX](http://www.itdks.com/liveevent/detail/10012), 20180208
* [Communications inside Java Chassis]({{ site.url }}{{ site.baseurl
}}/assets/slides/20180208/Communications_Inside_Java_Chassis.pdf)
+
+## [ServiceComb live streaming phase
X](http://www.itdks.com/liveevent/detail/10301), 20180315
+ * [Monitor Apache ServiceComb(incubating) using Apache SkyWalking(incubating)
APM]({{ site.url }}{{ site.baseurl
}}/assets/slides/20180315/Monitor_Apache_ServiceComb_using_Apache_Skywalking_APM.pdf)
diff --git a/_pages/cn/about-slides.md b/_pages/cn/about-slides.md
index fec99f2..2027610 100644
--- a/_pages/cn/about-slides.md
+++ b/_pages/cn/about-slides.md
@@ -43,3 +43,6 @@ date: 2017-06-20T11:02:20+08:00
## [ServiceComb 直播第九期](http://www.itdks.com/liveevent/detail/10012), 20180208
* [Java Chassis通信机制详解]({{ site.url }}{{ site.baseurl
}}/assets/slides/20180208/Communications_Inside_Java_Chassis.pdf)
+
+## [ServiceComb 直播第十期](http://www.itdks.com/liveevent/detail/10301), 20180315
+ * [使用Apache SkyWalking(incubating) APM监控Apache ServiceComb(incubating)]({{
site.url }}{{ site.baseurl
}}/assets/slides/20180315/Monitor_Apache_ServiceComb_using_Apache_Skywalking_APM.pdf)
diff --git
a/assets/slides/20180315/Monitor_Apache_ServiceComb_using_Apache_Skywalking_APM.pdf
b/assets/slides/20180315/Monitor_Apache_ServiceComb_using_Apache_Skywalking_APM.pdf
new file mode 100644
index 000..66eb08f
Binary files /dev/null and
b/assets/slides/20180315/Monitor_Apache_ServiceComb_using_Apache_Skywalking_APM.pdf
differ
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #594: [SCB-379] support AsyncRestTemplate
coveralls commented on issue #594: [SCB-379] support AsyncRestTemplate URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#issuecomment-372952656 [](https://coveralls.io/builds/16011950) Coverage increased (+0.02%) to 87.336% when pulling **680c8a63c06500bac4ab6202b9445bcd04393768 on lijasonvip:async** into **3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] little-cui closed pull request #307: [SCB-376] Optimize validate parameter log print
little-cui closed pull request #307: [SCB-376] Optimize validate parameter log
print
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/307
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pkg/validate/validate.go b/pkg/validate/validate.go
index 3a36f319..59190e3b 100644
--- a/pkg/validate/validate.go
+++ b/pkg/validate/validate.go
@@ -238,9 +238,25 @@ func (v *Validator) Validate(s interface{}) error {
}
// TODO null pointer如何校验
if field.Kind() != reflect.Ptr && !validate.Match(fi) {
- return fmt.Errorf("%s validate failed, %s",
fieldName, validate)
+ if filter(fieldName) {
+ return fmt.Errorf("invalid field: %s.%s
, %s", st.Type.Name(), fieldName, validate)
+ }
+ return fmt.Errorf("invalid field: %s.%s,
invalid value: {%v} , %s", st.Type.Name(), fieldName, fi, validate)
}
}
}
return nil
}
+
+var (
+ BLACK_LIST_FOR_PRINT = map[string]interface{} {
+ "Properties": nil,
+ }
+)
+
+func filter(fieldName string) bool {
+ if _, ok := BLACK_LIST_FOR_PRINT[fieldName]; ok {
+ return true
+ }
+ return false
+}
diff --git a/server/govern/service.go b/server/govern/service.go
index 5cc5290e..2ae05145 100644
--- a/server/govern/service.go
+++ b/server/govern/service.go
@@ -121,7 +121,7 @@ func (governService *GovernService) GetServiceDetail(ctx
context.Context, in *pb
if len(in.ServiceId) == 0 {
return {
- Response: pb.CreateResponse(scerr.ErrInvalidParams,
"Invalid requtest for getting service detail."),
+ Response: pb.CreateResponse(scerr.ErrInvalidParams,
"Invalid request for getting service detail."),
}, nil
}
diff --git a/server/service/microservices.go b/server/service/microservices.go
index d3265e52..4fe47d29 100644
--- a/server/service/microservices.go
+++ b/server/service/microservices.go
@@ -406,7 +406,7 @@ func (s *MicroServiceService) DeleteServices(ctx
context.Context, request *pb.De
}
}
- util.Logger().Infof("Batch DeleteServices serviceId = %v , result = %d,
", request.ServiceIds, responseCode)
+ util.Logger().Infof("Batch DeleteServices, count is %s, serviceId = %v
, result = %d, ", len(request.ServiceIds), request.ServiceIds, responseCode)
resp := {
Services: delServiceRspInfo,
diff --git a/server/service/microservices_test.go
b/server/service/microservices_test.go
index f5819c9e..5dd04f28 100644
--- a/server/service/microservices_test.go
+++ b/server/service/microservices_test.go
@@ -206,6 +206,39 @@ var _ = Describe("'Micro-service' service", func() {
Expect(err).To(BeNil())
Expect(resp.Response.Code).ToNot(Equal(pb.Response_SUCCESS))
})
+ It("same serviceId,different service, can not register
again,error is same as the service register twice", func() {
+ resp, err :=
serviceResource.Create(getContext(), {
+ Service: {
+ ServiceId: "same_serviceId",
+ ServiceName: "serviceA",
+ AppId: "default",
+ Version: "1.0.0",
+ Level: "FRONT",
+ Schemas: []string{
+ "",
+ },
+ Status: "UP",
+ },
+ })
+ Expect(err).To(BeNil())
+
Expect(resp.Response.Code).To(Equal(pb.Response_SUCCESS))
+
+ resp, err =
serviceResource.Create(getContext(), {
+ Service: {
+ ServiceId: "same_serviceId",
+ ServiceName: "serviceB",
+ AppId: "default",
+ Version: "1.0.0",
+ Level: "FRONT",
+
[GitHub] codecov-io commented on issue #309: SCB-389 SC does not re-create the tracing file.
codecov-io commented on issue #309: SCB-389 SC does not re-create the tracing file. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/309#issuecomment-373648086 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/309?src=pr=h1) Report > Merging [#309](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/309?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/94cea25ba55e763dbe23d0cd4a8da73e37a50539?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/309?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #309 +/- ## === Coverage 70.39% 70.39% === Files 17 17 Lines3455 3455 === Hits 2432 2432 Misses853 853 Partials 170 170 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/309?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/309/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `75.43% <0%> (-0.59%)` | :arrow_down: | | [server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/309/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `77.25% <0%> (+0.42%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/309?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/309?src=pr=footer). Last update [94cea25...af62d3e](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/309?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #309: SCB-389 SC does not re-create the tracing file.
coveralls commented on issue #309: SCB-389 SC does not re-create the tracing file. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/309#issuecomment-373648047 [](https://coveralls.io/builds/16011749) Coverage decreased (-0.05%) to 74.063% when pulling **af62d3efd0e2181462c0e9d8fc005dc0d6f7531c on little-cui:trace** into **94cea25ba55e763dbe23d0cd4a8da73e37a50539 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] little-cui opened a new pull request #309: SCB-389 SC does not re-create the tracing file.
little-cui opened a new pull request #309: SCB-389 SC does not re-create the tracing file. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/309 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lijasonvip commented on issue #594: [SCB-379] support AsyncRestTemplate
lijasonvip commented on issue #594: [SCB-379] support AsyncRestTemplate URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#issuecomment-373640313 @wujimin @liubao68. I removed wrapper and builder for `CseAsyncRestTemplate` in latest commit. Please help to review. Thx! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lijasonvip commented on issue #594: [SCB-379] support AsyncRestTemplate
lijasonvip commented on issue #594: [SCB-379] support AsyncRestTemplate URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#issuecomment-373640313 @wujimin @lihua8712051 I removed wrapper and builder for `CseAsyncRestTemplate` in latest commit. Please help to review. Thx! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lijasonvip commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate
lijasonvip commented on a change in pull request #594: [SCB-379] support
AsyncRestTemplate
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#discussion_r175023121
##
File path:
providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequest.java
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.provider.springmvc.reference.async;
+
+import java.io.OutputStream;
+import java.net.URI;
+import java.util.concurrent.CompletableFuture;
+
+import org.apache.servicecomb.common.rest.RestConst;
+import org.apache.servicecomb.core.Invocation;
+import org.apache.servicecomb.core.invocation.InvocationFactory;
+import org.apache.servicecomb.core.provider.consumer.InvokerUtils;
+import
org.apache.servicecomb.provider.springmvc.reference.CseClientHttpRequest;
+import
org.apache.servicecomb.provider.springmvc.reference.CseClientHttpResponse;
+import org.apache.servicecomb.swagger.invocation.Response;
+import org.springframework.http.HttpMethod;
+import org.springframework.http.client.AsyncClientHttpRequest;
+import org.springframework.http.client.ClientHttpResponse;
+import
org.springframework.util.concurrent.CompletableToListenableFutureAdapter;
+import org.springframework.util.concurrent.ListenableFuture;
+
+import io.netty.handler.codec.http.QueryStringDecoder;
+
+public class CseAsyncClientHttpRequest extends CseClientHttpRequest implements
AsyncClientHttpRequest {
+
+ CseAsyncClientHttpRequest() {
+ }
+
+ CseAsyncClientHttpRequest(URI uri, HttpMethod method) {
+this.setUri(uri);
+this.setMethod(method);
+ }
+
+ @Override
+ public OutputStream getBody() {
+return null;
+ }
+
+ @SuppressWarnings("unchecked")
+ private ListenableFuture invoke(Object[] args) {
+Invocation invocation =
+
InvocationFactory.forConsumer(this.getRequestMeta().getReferenceConfig(),
+this.getRequestMeta().getOperationMeta(),
+args);
+invocation.getHandlerContext().put(RestConst.REST_CLIENT_REQUEST_PATH,
+this.getPath() + "?" + this.getURI().getRawQuery());
+
+if (this.getContext() != null) {
+ invocation.addContext(this.getContext());
+}
+invocation.getHandlerContext().put(RestConst.CONSUMER_HEADER,
this.getHeaders());
+CompletableFuture completableFuture = new
CompletableFuture<>();
+InvokerUtils.reactiveInvoke(invocation, (Response response) -> {
+ if (response.isSuccessed()) {
Review comment:
fixed! exception handler and test case added.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] little-cui commented on a change in pull request #307: [SCB-376] Optimize validate parameter log print
little-cui commented on a change in pull request #307: [SCB-376] Optimize
validate parameter log print
URL:
https://github.com/apache/incubator-servicecomb-service-center/pull/307#discussion_r174658926
##
File path: pkg/validate/validate.go
##
@@ -238,7 +238,7 @@ func (v *Validator) Validate(s interface{}) error {
}
// TODO null pointer如何校验
if field.Kind() != reflect.Ptr && !validate.Match(fi) {
- return fmt.Errorf("%s validate failed, %s",
fieldName, validate)
+ return fmt.Errorf("invalid field: %s.%s,
invalid value: {%v} , %s", st.Type.Name(), fieldName, fi, validate)
Review comment:
we should not print the value in error message because of the secret risk
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
