Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

[Mahesh Raju Somalaraju]

+1 Non Binding

- Ran java-chassis demos using service-center release binary.
- Run the rat to verify the License header issue.

Thanks & Regards
-Mahesh Raju S


On Sat, Mar 17, 2018 at 12:31 AM, Mohammad Asif Siddiqui <
asifdxtr...@apache.org> wrote:

> Hi All,
>
> This is a call for Vote to release Apache ServiceComb Saga (Incubating)
> version 0.1.0
>
> Release Notes : https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12321626=12342353
>
> Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> servicecomb/incubator-servicecomb-saga/0.1.0/
>
> Staging Repo : https://repository.apache.org/content/repositories/
> orgapacheservicecomb-1166
>
> Release Tag : https://github.com/apache/incubator-servicecomb-saga/
> releases/tag/0.1.0
>
> Release CommitID : 708eec092988dfd4a5960ca5f232fb7421d5fbdd
>
> Keys to verify the Release Candidate : https://dist.apache.org/repos/
> dist/dev/incubator/servicecomb/KEYS
>
> Voting will start now ( Saturday, 17th March, 2018) and will remain open
> for next 72 hours, Request all PPMC members to give their vote
>
> [ ] +1 Release this package as 0.1.0
> [ ] +0 No Opinion
> [ ] -1 Do not release this package because
>
> Regards
> Asif
>
>

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

[Mahesh Raju Somalaraju]

+1 Non Binding

- Ran java-chassis demos using service-center release binary.
- Run the rat to verify the License header issue.

Thanks & Regards
-Mahesh Raju S


On Sat, Mar 17, 2018 at 12:22 AM, Mohammad Asif Siddiqui <
asifdxtr...@apache.org> wrote:

> Hi All,
>
> This is a call for Vote to release Apache ServiceComb Java-Chassis
> (Incubating) version 1.0.0-m1
>
> Release Notes : https://github.com/apache/incubator-servicecomb-java-
> chassis/blob/master/etc/releaseNotes.md
>
> Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/
>
> Staging Repo : https://repository.apache.org/content/repositories/
> orgapacheservicecomb-1181/
>
> Release Tag : https://github.com/apache/incubator-servicecomb-java-
> chassis/releases/tag/1.0.0-m1
>
> Release CommitID : 3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe
>
> Keys to verify the Release Candidate : https://dist.apache.org/repos/
> dist/dev/incubator/servicecomb/KEYS
>
> Voting will start now ( Saturday, 17th March, 2018) and will remain open
> for next 72 hours, Request all PPMC members to give their vote
>
> [ ] +1 Release this package as 1.0.0-m1
> [ ] +0 No Opinion
> [ ] -1 Do not release this package because
>
> Regards
> Asif
>
>

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

[Mahesh Raju Somalaraju]

+1 Non Binding

- Ran java-chassis demos using service-center release binary.
- Run the rat to verify the License header issue.

Thanks & Regards
-Mahesh Raju S

On Sat, Mar 17, 2018 at 12:08 AM, Mohammad Asif Siddiqui <
asifdxtr...@apache.org> wrote:

> Hi All,
>
> This is a call for Vote to release Apache ServiceComb Service-Center
> (Incubating) version 1.0.0-m1 (fourth release candidate).
>
> Release Notes : https://github.com/apache/incubator-servicecomb-service-
> center/blob/master/docs/release/releaseNotes.md
>
> Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
>
> Release Tag : https://github.com/apache/incubator-servicecomb-service-
> center/releases/tag/1.0.0-m1
>
> Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539
>
> Keys to verify the Release Candidate : https://dist.apache.org/repos/
> dist/dev/incubator/servicecomb/KEYS
>
> Guide to build the release from source : https://github.com/apache/
> incubator-servicecomb-service-center/tree/master/scripts/release
>
> Voting will start now ( Saturday, 17th March, 2018) and will remain open
> for next 72 hours, Request all PPMC members to give their vote.
> [ ] +1 Release this package as 1.0.0-m1
> [ ] +0 No Opinion
> [ ] -1 Do not release this package because
>
> Regards
> Asif
>
>
>

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

[bismy]

+1
run java-chassis integration tests against this candidate and all test cases 
passed.




-- Original --
From:  "Mohammad Asif Siddiqui";
Date:  Sat, Mar 17, 2018 02:38 AM
To:  "dev";

Subject:  [VOTE] Release Apache ServiceComb Service-Center (incubating) version 
1.0.0-m1 - Fourth Attempt



Hi All,  
  
This is a call for Vote to release Apache ServiceComb Service-Center 
(Incubating) version 1.0.0-m1 (fourth release candidate).  
  
Release Notes : 
https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md
  
  
Release Candidate : 
https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
  
  
Release Tag : 
https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1
 
  
Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539  
  
Keys to verify the Release Candidate : 
https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS  
  
Guide to build the release from source : 
https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release
  
  
Voting will start now ( Saturday, 17th March, 2018) and will remain open for 
next 72 hours, Request all PPMC members to give their vote.  
[ ] +1 Release this package as 1.0.0-m1  
[ ] +0 No Opinion  
[ ] -1 Do not release this package because  
  
Regards  
Asif

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

[bismy]

+1
Integrate 1.0.0-m1 to integration tests and all test case passed.




-- Original --
From:  "Mohammad Asif Siddiqui";
Date:  Sat, Mar 17, 2018 02:52 AM
To:  "dev";

Subject:  [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 
1.0.0-m1 - Second Attempt



Hi All,  
  
This is a call for Vote to release Apache ServiceComb Java-Chassis (Incubating) 
version 1.0.0-m1 
  
Release Notes : 
https://github.com/apache/incubator-servicecomb-java-chassis/blob/master/etc/releaseNotes.md
  
  
Release Candidate : 
https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/
  
  
Staging Repo : 
https://repository.apache.org/content/repositories/orgapacheservicecomb-1181/ 
  
Release Tag : 
https://github.com/apache/incubator-servicecomb-java-chassis/releases/tag/1.0.0-m1
 
  
Release CommitID : 3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe  
  
Keys to verify the Release Candidate : 
https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS  
  
Voting will start now ( Saturday, 17th March, 2018) and will remain open for 
next 72 hours, Request all PPMC members to give their vote  
  
[ ] +1 Release this package as 1.0.0-m1  
[ ] +0 No Opinion  
[ ] -1 Do not release this package because  
  
Regards  
Asif

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

[Sure]

+1 LGTM




-- Original --
From: Mohammad Asif Siddiqui 
Date: Mon,Mar 19,2018 0:25 PM
To: dev 
Subject: Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 
- Second Attempt



+1 Binding  
  
I Checked  
- incubating in name  
- hashes and signatures is good  
- DISCLAIMER/NOTICE/LICENSE exists  
- ran RAT tool  
- can make release kit from source  
- checked for archive matching git tag  
- Source file have ASF headers  
  
Regards  
Asif  


On 2018/03/16 19:01:29, Mohammad Asif Siddiqui  wrote: 
> Hi All,  
>   
> This is a call for Vote to release Apache ServiceComb Saga (Incubating) 
> version 0.1.0  
>   
> Release Notes : 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626=12342353
>   
>   
> Release Candidate : 
> https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-saga/0.1.0/
>   
>   
> Staging Repo : 
> https://repository.apache.org/content/repositories/orgapacheservicecomb-1166  
>   
> Release Tag : 
> https://github.com/apache/incubator-servicecomb-saga/releases/tag/0.1.0  
>   
> Release CommitID : 708eec092988dfd4a5960ca5f232fb7421d5fbdd  
>   
> Keys to verify the Release Candidate : 
> https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS  
>   
> Voting will start now ( Saturday, 17th March, 2018) and will remain open for 
> next 72 hours, Request all PPMC members to give their vote  
>   
> [ ] +1 Release this package as 0.1.0  
> [ ] +0 No Opinion  
> [ ] -1 Do not release this package because  
>   
> Regards  
> Asif  
> 
>

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

[Sure]

+1 LGTM




-- Original --
From: Mohammad Asif Siddiqui 
Date: Sat,Mar 17,2018 2:52 AM
To: dev 
Subject: Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) 
version 1.0.0-m1 - Second Attempt



Hi All,  
  
This is a call for Vote to release Apache ServiceComb Java-Chassis (Incubating) 
version 1.0.0-m1 
  
Release Notes : 
https://github.com/apache/incubator-servicecomb-java-chassis/blob/master/etc/releaseNotes.md
  
  
Release Candidate : 
https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/
  
  
Staging Repo : 
https://repository.apache.org/content/repositories/orgapacheservicecomb-1181/ 
  
Release Tag : 
https://github.com/apache/incubator-servicecomb-java-chassis/releases/tag/1.0.0-m1
 
  
Release CommitID : 3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe  
  
Keys to verify the Release Candidate : 
https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS  
  
Voting will start now ( Saturday, 17th March, 2018) and will remain open for 
next 72 hours, Request all PPMC members to give their vote  
  
[ ] +1 Release this package as 1.0.0-m1  
[ ] +0 No Opinion  
[ ] -1 Do not release this package because  
  
Regards  
Asif

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

[Mohammad Asif Siddiqui]

+1 Binding  
  
I Checked  
- incubating in name  
- hashes and signatures is good  
- DISCLAIMER/NOTICE/LICENSE exists  
- ran RAT tool  
- can make release kit from source  
- checked for archive matching git tag  
- Source file have ASF headers  
  
Regards  
Asif  


On 2018/03/16 19:01:29, Mohammad Asif Siddiqui  wrote: 
> Hi All,  
>   
> This is a call for Vote to release Apache ServiceComb Saga (Incubating) 
> version 0.1.0  
>   
> Release Notes : 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626=12342353
>   
>   
> Release Candidate : 
> https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-saga/0.1.0/
>   
>   
> Staging Repo : 
> https://repository.apache.org/content/repositories/orgapacheservicecomb-1166  
>   
> Release Tag : 
> https://github.com/apache/incubator-servicecomb-saga/releases/tag/0.1.0  
>   
> Release CommitID : 708eec092988dfd4a5960ca5f232fb7421d5fbdd  
>   
> Keys to verify the Release Candidate : 
> https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS  
>   
> Voting will start now ( Saturday, 17th March, 2018) and will remain open for 
> next 72 hours, Request all PPMC members to give their vote  
>   
> [ ] +1 Release this package as 0.1.0  
> [ ] +0 No Opinion  
> [ ] -1 Do not release this package because  
>   
> Regards  
> Asif  
> 
> 

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

[Mohammad Asif Siddiqui]

+1 Binding  
  
I Checked  
- incubating in name  
- hashes and signatures is good  
- DISCLAIMER/NOTICE/LICENSE exists  
- ran RAT tool  
- can make release kit from source  
- checked for archive matching git tag  
- Source file have ASF headers  
- Ran the demo's using the source archive  
  
Regards  
Asif  
  

On 2018/03/16 18:52:25, Mohammad Asif Siddiqui  wrote: 
> Hi All,  
>   
> This is a call for Vote to release Apache ServiceComb Java-Chassis 
> (Incubating) version 1.0.0-m1 
>   
> Release Notes : 
> https://github.com/apache/incubator-servicecomb-java-chassis/blob/master/etc/releaseNotes.md
>   
>   
> Release Candidate : 
> https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/
>   
>   
> Staging Repo : 
> https://repository.apache.org/content/repositories/orgapacheservicecomb-1181/ 
>   
> Release Tag : 
> https://github.com/apache/incubator-servicecomb-java-chassis/releases/tag/1.0.0-m1
>  
>   
> Release CommitID : 3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe  
>   
> Keys to verify the Release Candidate : 
> https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS  
>   
> Voting will start now ( Saturday, 17th March, 2018) and will remain open for 
> next 72 hours, Request all PPMC members to give their vote  
>   
> [ ] +1 Release this package as 1.0.0-m1  
> [ ] +0 No Opinion  
> [ ] -1 Do not release this package because  
>   
> Regards  
> Asif  
> 
> 

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

[Mohammad Asif Siddiqui]

+1 Binding  
  
I Checked  
- incubating in name  
- hashes and signatures is good  
- DISCLAIMER exists  
- can compile from source  
- checked for archive matching git tag  
- Source file have ASF headers  
- ran Integration test using release binary on windows and linux  
- ran java-chassis demo(springmvc) using service-center release binary.  
  
Regards  
Asif  

On 2018/03/16 18:38:32, Mohammad Asif Siddiqui  wrote: 
> Hi All,  
>   
> This is a call for Vote to release Apache ServiceComb Service-Center 
> (Incubating) version 1.0.0-m1 (fourth release candidate).  
>   
> Release Notes : 
> https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md
>   
>   
> Release Candidate : 
> https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
>   
>   
> Release Tag : 
> https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1
>  
>   
> Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539  
>   
> Keys to verify the Release Candidate : 
> https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS  
>   
> Guide to build the release from source : 
> https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release
>   
>   
> Voting will start now ( Saturday, 17th March, 2018) and will remain open for 
> next 72 hours, Request all PPMC members to give their vote.  
> [ ] +1 Release this package as 1.0.0-m1  
> [ ] +0 No Opinion  
> [ ] -1 Do not release this package because  
>   
> Regards  
> Asif  
>   
> 
> 

[GitHub] tianxiaoliang commented on issue #314: docker hub don't have document and simple description

[GitBox]

tianxiaoliang commented on issue #314: docker hub don't have document and 
simple description
URL: 
https://github.com/apache/incubator-servicecomb-service-center/issues/314#issuecomment-374091921
 
 
   ok, I will


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jeho0815 commented on a change in pull request #607: [SCB-406] Chassis must support standard parameter validation handler

[GitBox]

jeho0815 commented on a change in pull request #607: [SCB-406] Chassis must 
support standard parameter validation handler
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/607#discussion_r175322344
 
 

 ##
 File path: 
handlers/handler-validator/src/main/java/org/apache/servicecomb/validator/ParamValidateHandler.java
 ##
 @@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.validator;
+
+import java.lang.reflect.Field;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+import javax.validation.ConstraintViolation;
+import javax.validation.Validation;
+import javax.validation.Validator;
+
+import org.apache.servicecomb.core.Handler;
+import org.apache.servicecomb.core.Invocation;
+import org.apache.servicecomb.swagger.invocation.AsyncResponse;
+import org.apache.servicecomb.swagger.invocation.Response;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * ParamValidateHandler
+ * Handler to validate the input request parameters 
+ *
+ */
+public class ParamValidateHandler implements Handler {
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(ParamValidateHandler.class);
+
+  private static Validator validator = 
Validation.buildDefaultValidatorFactory().getValidator();
+
+  @Override
+  public void handle(Invocation invocation, AsyncResponse asyncResp) throws 
Exception {
+Object[] args = invocation.getArgs();
+boolean invalid = false;
+List errList = new ArrayList<>();
 
 Review comment:
   have you showed the example to sukesh? @wujimin 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] little-cui closed pull request #309: SCB-389 SC does not re-create the tracing file.

[GitBox]

little-cui closed pull request #309: SCB-389 SC does not re-create the tracing 
file.
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/309
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/server/plugin/infra/tracing/buildin/file_collector.go 
b/server/plugin/infra/tracing/buildin/file_collector.go
index b61b8c2e..a10fc292 100644
--- a/server/plugin/infra/tracing/buildin/file_collector.go
+++ b/server/plugin/infra/tracing/buildin/file_collector.go
@@ -51,6 +51,12 @@ func (f *FileCollector) write(batch []*zipkincore.Span) (c 
int) {
if len(batch) == 0 {
return
}
+
+   if err := f.checkFile(); err != nil {
+   util.Logger().Errorf(err, "check tracing file failed")
+   return
+   }
+
newLine := [...]byte{'\n'}
w := bufio.NewWriter(f.Fd)
for _, span := range batch {
@@ -70,6 +76,30 @@ func (f *FileCollector) write(batch []*zipkincore.Span) (c 
int) {
return
 }
 
+func (f *FileCollector) checkFile() error {
+   if util.PathExist(f.Fd.Name()) {
+   return nil
+   }
+
+   stat, err := f.Fd.Stat()
+   if err != nil {
+   return fmt.Errorf("stat %s: %s", f.Fd.Name(), err)
+   }
+
+   util.Logger().Warnf(nil, "tracing file %s does not exist, re-create 
one", f.Fd.Name())
+   fd, err := os.OpenFile(f.Fd.Name(), os.O_APPEND|os.O_CREATE|os.O_RDWR, 
stat.Mode())
+   if err != nil {
+   return fmt.Errorf("open %s: %s", f.Fd.Name(), err)
+   }
+
+   var old *os.File
+   f.Fd, old = fd, f.Fd
+   if err := old.Close(); err != nil {
+   util.Logger().Errorf(err, "close %s", f.Fd.Name())
+   }
+   return nil
+}
+
 func (f *FileCollector) loop(stopCh <-chan struct{}) {
var (
batch []*zipkincore.Span


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang commented on issue #314: docker hub don't have document and simple description

[GitBox]

WillemJiang commented on issue #314: docker hub don't have document and simple 
description
URL: 
https://github.com/apache/incubator-servicecomb-service-center/issues/314#issuecomment-374083910
 
 
   @tianxiaoliang  
   Could file a [JIRA](http://issues.apache.org/jira/browse/SCB) for it?
   BTW,  it could be great if you can submit a README file for it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

[Willem Jiang]

+1 binding.

Here are the checks that I done:

Checked the signed key and checksum.
Built the binary from source.
Verified the nexus staging repo by running the demos.


Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

On Sat, Mar 17, 2018 at 3:01 AM, Mohammad Asif Siddiqui <
asifdxtr...@apache.org> wrote:

> Hi All,
>
> This is a call for Vote to release Apache ServiceComb Saga (Incubating)
> version 0.1.0
>
> Release Notes : https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12321626=12342353
>
> Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> servicecomb/incubator-servicecomb-saga/0.1.0/
>
> Staging Repo : https://repository.apache.org/content/repositories/
> orgapacheservicecomb-1166
>
> Release Tag : https://github.com/apache/incubator-servicecomb-saga/
> releases/tag/0.1.0
>
> Release CommitID : 708eec092988dfd4a5960ca5f232fb7421d5fbdd
>
> Keys to verify the Release Candidate : https://dist.apache.org/repos/
> dist/dev/incubator/servicecomb/KEYS
>
> Voting will start now ( Saturday, 17th March, 2018) and will remain open
> for next 72 hours, Request all PPMC members to give their vote
>
> [ ] +1 Release this package as 0.1.0
> [ ] +0 No Opinion
> [ ] -1 Do not release this package because
>
> Regards
> Asif
>
>

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

[kirin wang]

+1

Checked the demo

2018-03-19 10:06 GMT+08:00 李波 :

> +1
>
>
> Checklist:
>
> Build kit from src code success.
> Running saga demo booking success
> All test were passed.
>
>
> Best
> LiBo
>
>
>
> 2018-03-19 9:58 GMT+08:00 Eric Lee :
>
> >  +1
> >
> > Checked the signed keys and checksum.
> > Checked the demo.
> > Built the code from source.
> > All unit tests, integration tests and acceptance tests are passed.
> >
> > 2018-03-19 9:27 GMT+08:00 Yang Bo :
> >
> > > +1
> > >
> > > Checks I've done:
> > >
> > > 1. Checked sha512sum and GPG signature.
> > >
> > > 2. Run rat without filter on source and binary package.
> > >
> > > 3. Checked DISCLAIMER/NOTICE/LICENSE for source and binary package.
> > >
> > > 4. Checked that no unlicensed binary files are bundled in source and
> > binary
> > > package.
> > >
> > > 5. Build from source following README.md
> > >
> > > 6. Run simple application following the booking demo.
> > >
> > >
> > >
> > > On Sat, Mar 17, 2018 at 3:01 AM, Mohammad Asif Siddiqui <
> > > asifdxtr...@apache.org> wrote:
> > >
> > > > Hi All,
> > > >
> > > > This is a call for Vote to release Apache ServiceComb Saga
> (Incubating)
> > > > version 0.1.0
> > > >
> > > > Release Notes : https://issues.apache.org/
> jira/secure/ReleaseNote.jspa
> > ?
> > > > projectId=12321626=12342353
> > > >
> > > > Release Candidate : https://dist.apache.org/repos/
> dist/dev/incubator/
> > > > servicecomb/incubator-servicecomb-saga/0.1.0/
> > > >
> > > > Staging Repo : https://repository.apache.org/content/repositories/
> > > > orgapacheservicecomb-1166
> > > >
> > > > Release Tag : https://github.com/apache/incubator-servicecomb-saga/
> > > > releases/tag/0.1.0
> > > >
> > > > Release CommitID : 708eec092988dfd4a5960ca5f232fb7421d5fbdd
> > > >
> > > > Keys to verify the Release Candidate :
> https://dist.apache.org/repos/
> > > > dist/dev/incubator/servicecomb/KEYS
> > > >
> > > > Voting will start now ( Saturday, 17th March, 2018) and will remain
> > open
> > > > for next 72 hours, Request all PPMC members to give their vote
> > > >
> > > > [ ] +1 Release this package as 0.1.0
> > > > [ ] +0 No Opinion
> > > > [ ] -1 Do not release this package because
> > > >
> > > > Regards
> > > > Asif
> > > >
> > > >
> > >
> > >
> > > --
> > > Best Regards,
> > > Yang.
> > >
> >
>

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

[kirin wang]

+1

Built the code from source.

2018-03-19 10:00 GMT+08:00 Eric Lee :

>  +1
>
> Checked the signed keys and checksum.
> Checked the samples.
> Built the code from source.
> All unit tests, integration tests are passed.
>
> 2018-03-19 9:57 GMT+08:00 Willem Jiang :
>
> > +1 binding.
> >
> > I can build the kit from source.
> > I checked the staging repo by running the Company example 1.x branch[1],
> > all test were passed.
> >
> > [1]https://github.com/ServiceComb/ServiceComb-Company-WorkShop/tree/1.x
> >
> >
> >
> > Willem Jiang
> >
> > Blog: http://willemjiang.blogspot.com (English)
> >   http://jnn.iteye.com  (Chinese)
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Sat, Mar 17, 2018 at 2:52 AM, Mohammad Asif Siddiqui <
> > asifdxtr...@apache.org> wrote:
> >
> > > Hi All,
> > >
> > > This is a call for Vote to release Apache ServiceComb Java-Chassis
> > > (Incubating) version 1.0.0-m1
> > >
> > > Release Notes : https://github.com/apache/incubator-servicecomb-java-
> > > chassis/blob/master/etc/releaseNotes.md
> > >
> > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> > > servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/
> > >
> > > Staging Repo : https://repository.apache.org/content/repositories/
> > > orgapacheservicecomb-1181/
> > >
> > > Release Tag : https://github.com/apache/incubator-servicecomb-java-
> > > chassis/releases/tag/1.0.0-m1
> > >
> > > Release CommitID : 3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe
> > >
> > > Keys to verify the Release Candidate : https://dist.apache.org/repos/
> > > dist/dev/incubator/servicecomb/KEYS
> > >
> > > Voting will start now ( Saturday, 17th March, 2018) and will remain
> open
> > > for next 72 hours, Request all PPMC members to give their vote
> > >
> > > [ ] +1 Release this package as 1.0.0-m1
> > > [ ] +0 No Opinion
> > > [ ] -1 Do not release this package because
> > >
> > > Regards
> > > Asif
> > >
> > >
> >
>

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

[李波]

+1


Checklist:

Build kit from src code success.
Running saga demo booking success
All test were passed.


Best
LiBo



2018-03-19 9:58 GMT+08:00 Eric Lee :

>  +1
>
> Checked the signed keys and checksum.
> Checked the demo.
> Built the code from source.
> All unit tests, integration tests and acceptance tests are passed.
>
> 2018-03-19 9:27 GMT+08:00 Yang Bo :
>
> > +1
> >
> > Checks I've done:
> >
> > 1. Checked sha512sum and GPG signature.
> >
> > 2. Run rat without filter on source and binary package.
> >
> > 3. Checked DISCLAIMER/NOTICE/LICENSE for source and binary package.
> >
> > 4. Checked that no unlicensed binary files are bundled in source and
> binary
> > package.
> >
> > 5. Build from source following README.md
> >
> > 6. Run simple application following the booking demo.
> >
> >
> >
> > On Sat, Mar 17, 2018 at 3:01 AM, Mohammad Asif Siddiqui <
> > asifdxtr...@apache.org> wrote:
> >
> > > Hi All,
> > >
> > > This is a call for Vote to release Apache ServiceComb Saga (Incubating)
> > > version 0.1.0
> > >
> > > Release Notes : https://issues.apache.org/jira/secure/ReleaseNote.jspa
> ?
> > > projectId=12321626=12342353
> > >
> > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> > > servicecomb/incubator-servicecomb-saga/0.1.0/
> > >
> > > Staging Repo : https://repository.apache.org/content/repositories/
> > > orgapacheservicecomb-1166
> > >
> > > Release Tag : https://github.com/apache/incubator-servicecomb-saga/
> > > releases/tag/0.1.0
> > >
> > > Release CommitID : 708eec092988dfd4a5960ca5f232fb7421d5fbdd
> > >
> > > Keys to verify the Release Candidate : https://dist.apache.org/repos/
> > > dist/dev/incubator/servicecomb/KEYS
> > >
> > > Voting will start now ( Saturday, 17th March, 2018) and will remain
> open
> > > for next 72 hours, Request all PPMC members to give their vote
> > >
> > > [ ] +1 Release this package as 0.1.0
> > > [ ] +0 No Opinion
> > > [ ] -1 Do not release this package because
> > >
> > > Regards
> > > Asif
> > >
> > >
> >
> >
> > --
> > Best Regards,
> > Yang.
> >
>

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

[Eric Lee]

 +1

Checked the signed keys and checksum.
Checked the samples.
Built the code from source.
All unit tests, integration tests are passed.

2018-03-19 9:57 GMT+08:00 Willem Jiang :

> +1 binding.
>
> I can build the kit from source.
> I checked the staging repo by running the Company example 1.x branch[1],
> all test were passed.
>
> [1]https://github.com/ServiceComb/ServiceComb-Company-WorkShop/tree/1.x
>
>
>
> Willem Jiang
>
> Blog: http://willemjiang.blogspot.com (English)
>   http://jnn.iteye.com  (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Sat, Mar 17, 2018 at 2:52 AM, Mohammad Asif Siddiqui <
> asifdxtr...@apache.org> wrote:
>
> > Hi All,
> >
> > This is a call for Vote to release Apache ServiceComb Java-Chassis
> > (Incubating) version 1.0.0-m1
> >
> > Release Notes : https://github.com/apache/incubator-servicecomb-java-
> > chassis/blob/master/etc/releaseNotes.md
> >
> > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> > servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/
> >
> > Staging Repo : https://repository.apache.org/content/repositories/
> > orgapacheservicecomb-1181/
> >
> > Release Tag : https://github.com/apache/incubator-servicecomb-java-
> > chassis/releases/tag/1.0.0-m1
> >
> > Release CommitID : 3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe
> >
> > Keys to verify the Release Candidate : https://dist.apache.org/repos/
> > dist/dev/incubator/servicecomb/KEYS
> >
> > Voting will start now ( Saturday, 17th March, 2018) and will remain open
> > for next 72 hours, Request all PPMC members to give their vote
> >
> > [ ] +1 Release this package as 1.0.0-m1
> > [ ] +0 No Opinion
> > [ ] -1 Do not release this package because
> >
> > Regards
> > Asif
> >
> >
>

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

[Eric Lee]

 +1

Checked the signed keys and checksum.
Checked the demo.
Built the code from source.
All unit tests, integration tests and acceptance tests are passed.

2018-03-19 9:27 GMT+08:00 Yang Bo :

> +1
>
> Checks I've done:
>
> 1. Checked sha512sum and GPG signature.
>
> 2. Run rat without filter on source and binary package.
>
> 3. Checked DISCLAIMER/NOTICE/LICENSE for source and binary package.
>
> 4. Checked that no unlicensed binary files are bundled in source and binary
> package.
>
> 5. Build from source following README.md
>
> 6. Run simple application following the booking demo.
>
>
>
> On Sat, Mar 17, 2018 at 3:01 AM, Mohammad Asif Siddiqui <
> asifdxtr...@apache.org> wrote:
>
> > Hi All,
> >
> > This is a call for Vote to release Apache ServiceComb Saga (Incubating)
> > version 0.1.0
> >
> > Release Notes : https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12321626=12342353
> >
> > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> > servicecomb/incubator-servicecomb-saga/0.1.0/
> >
> > Staging Repo : https://repository.apache.org/content/repositories/
> > orgapacheservicecomb-1166
> >
> > Release Tag : https://github.com/apache/incubator-servicecomb-saga/
> > releases/tag/0.1.0
> >
> > Release CommitID : 708eec092988dfd4a5960ca5f232fb7421d5fbdd
> >
> > Keys to verify the Release Candidate : https://dist.apache.org/repos/
> > dist/dev/incubator/servicecomb/KEYS
> >
> > Voting will start now ( Saturday, 17th March, 2018) and will remain open
> > for next 72 hours, Request all PPMC members to give their vote
> >
> > [ ] +1 Release this package as 0.1.0
> > [ ] +0 No Opinion
> > [ ] -1 Do not release this package because
> >
> > Regards
> > Asif
> >
> >
>
>
> --
> Best Regards,
> Yang.
>

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

[Willem Jiang]

+1 binding.

I can build the kit from source.
I checked the staging repo by running the Company example 1.x branch[1],
all test were passed.

[1]https://github.com/ServiceComb/ServiceComb-Company-WorkShop/tree/1.x



Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

On Sat, Mar 17, 2018 at 2:52 AM, Mohammad Asif Siddiqui <
asifdxtr...@apache.org> wrote:

> Hi All,
>
> This is a call for Vote to release Apache ServiceComb Java-Chassis
> (Incubating) version 1.0.0-m1
>
> Release Notes : https://github.com/apache/incubator-servicecomb-java-
> chassis/blob/master/etc/releaseNotes.md
>
> Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/
>
> Staging Repo : https://repository.apache.org/content/repositories/
> orgapacheservicecomb-1181/
>
> Release Tag : https://github.com/apache/incubator-servicecomb-java-
> chassis/releases/tag/1.0.0-m1
>
> Release CommitID : 3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe
>
> Keys to verify the Release Candidate : https://dist.apache.org/repos/
> dist/dev/incubator/servicecomb/KEYS
>
> Voting will start now ( Saturday, 17th March, 2018) and will remain open
> for next 72 hours, Request all PPMC members to give their vote
>
> [ ] +1 Release this package as 1.0.0-m1
> [ ] +0 No Opinion
> [ ] -1 Do not release this package because
>
> Regards
> Asif
>
>

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

[Willem Jiang]

+1 (binding)

Checked the signed Keys and checksum.
Checked the binary with the examples.
Run the rat to verify the License header issue.


Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

On Sat, Mar 17, 2018 at 2:38 AM, Mohammad Asif Siddiqui <
asifdxtr...@apache.org> wrote:

> Hi All,
>
> This is a call for Vote to release Apache ServiceComb Service-Center
> (Incubating) version 1.0.0-m1 (fourth release candidate).
>
> Release Notes : https://github.com/apache/incubator-servicecomb-service-
> center/blob/master/docs/release/releaseNotes.md
>
> Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
>
> Release Tag : https://github.com/apache/incubator-servicecomb-service-
> center/releases/tag/1.0.0-m1
>
> Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539
>
> Keys to verify the Release Candidate : https://dist.apache.org/repos/
> dist/dev/incubator/servicecomb/KEYS
>
> Guide to build the release from source : https://github.com/apache/
> incubator-servicecomb-service-center/tree/master/scripts/release
>
> Voting will start now ( Saturday, 17th March, 2018) and will remain open
> for next 72 hours, Request all PPMC members to give their vote.
> [ ] +1 Release this package as 1.0.0-m1
> [ ] +0 No Opinion
> [ ] -1 Do not release this package because
>
> Regards
> Asif
>
>
>

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

[Yang Bo]

+1

Checks I've done:

1. Checked sha512sum and GPG signature.

2. Run rat without filter on source and binary package.

3. Checked DISCLAIMER/NOTICE/LICENSE for source and binary package.

4. Checked that no unlicensed binary files are bundled in source and binary
package.

5. Build from source following README.md

6. Run simple application following the booking demo.



On Sat, Mar 17, 2018 at 3:01 AM, Mohammad Asif Siddiqui <
asifdxtr...@apache.org> wrote:

> Hi All,
>
> This is a call for Vote to release Apache ServiceComb Saga (Incubating)
> version 0.1.0
>
> Release Notes : https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12321626=12342353
>
> Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> servicecomb/incubator-servicecomb-saga/0.1.0/
>
> Staging Repo : https://repository.apache.org/content/repositories/
> orgapacheservicecomb-1166
>
> Release Tag : https://github.com/apache/incubator-servicecomb-saga/
> releases/tag/0.1.0
>
> Release CommitID : 708eec092988dfd4a5960ca5f232fb7421d5fbdd
>
> Keys to verify the Release Candidate : https://dist.apache.org/repos/
> dist/dev/incubator/servicecomb/KEYS
>
> Voting will start now ( Saturday, 17th March, 2018) and will remain open
> for next 72 hours, Request all PPMC members to give their vote
>
> [ ] +1 Release this package as 0.1.0
> [ ] +0 No Opinion
> [ ] -1 Do not release this package because
>
> Regards
> Asif
>
>


-- 
Best Regards,
Yang.

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

[Yang Bo]

 +1


Checks I've done:

1. Run rat without any filters.

2. Checked no images files(*.jpg,*.png) and font files (*.ttf) are included
without permission in source and binary packages.

3. Checked that no JS files distributed in Java Chassis.

4. Checked LICENSE/NOTICE/DISCLAIMER for source and binary packages.
5. Run integration tests and bmi sample.

On Sat, Mar 17, 2018 at 2:52 AM, Mohammad Asif Siddiqui <
asifdxtr...@apache.org> wrote:

> Hi All,
>
> This is a call for Vote to release Apache ServiceComb Java-Chassis
> (Incubating) version 1.0.0-m1
>
> Release Notes : https://github.com/apache/incubator-servicecomb-java-
> chassis/blob/master/etc/releaseNotes.md
>
> Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/
>
> Staging Repo : https://repository.apache.org/content/repositories/
> orgapacheservicecomb-1181/
>
> Release Tag : https://github.com/apache/incubator-servicecomb-java-
> chassis/releases/tag/1.0.0-m1
>
> Release CommitID : 3dbfb87eb6249f3ad41ea7514d1a73ec6e193bfe
>
> Keys to verify the Release Candidate : https://dist.apache.org/repos/
> dist/dev/incubator/servicecomb/KEYS
>
> Voting will start now ( Saturday, 17th March, 2018) and will remain open
> for next 72 hours, Request all PPMC members to give their vote
>
> [ ] +1 Release this package as 1.0.0-m1
> [ ] +0 No Opinion
> [ ] -1 Do not release this package because
>
> Regards
> Asif
>
>


-- 
Best Regards,
Yang.

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

[Yang Bo]

+1

1. Checked the binary and source releases' sha512sum and gpg signature.

2. Checked LICENSE/DISCLAIMER/NOTICE of binary and source release.

3. Run rat on binary and source release, some minor issues found.

4. Building from source following the README

5. Running service center and frontend according to README

6. Run service-center and frontend on windows, checked basic functionality
of frontend.

7. Run service-center and frontend on linux, run BMI sample of Java Chassis
using service-center, checked basic functionality of frontend.

8. Checked both binary and source files, no inappropriate binary files
bundled(images, fonts).


On Sat, Mar 17, 2018 at 2:38 AM, Mohammad Asif Siddiqui <
asifdxtr...@apache.org> wrote:

> Hi All,
>
> This is a call for Vote to release Apache ServiceComb Service-Center
> (Incubating) version 1.0.0-m1 (fourth release candidate).
>
> Release Notes : https://github.com/apache/incubator-servicecomb-service-
> center/blob/master/docs/release/releaseNotes.md
>
> Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
>
> Release Tag : https://github.com/apache/incubator-servicecomb-service-
> center/releases/tag/1.0.0-m1
>
> Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539
>
> Keys to verify the Release Candidate : https://dist.apache.org/repos/
> dist/dev/incubator/servicecomb/KEYS
>
> Guide to build the release from source : https://github.com/apache/
> incubator-servicecomb-service-center/tree/master/scripts/release
>
> Voting will start now ( Saturday, 17th March, 2018) and will remain open
> for next 72 hours, Request all PPMC members to give their vote.
> [ ] +1 Release this package as 1.0.0-m1
> [ ] +0 No Opinion
> [ ] -1 Do not release this package because
>
> Regards
> Asif
>
>
>


-- 
Best Regards,
Yang.

[GitHub] tianxiaoliang opened a new issue #314: docker hub don't have document and simple description

[GitBox]

tianxiaoliang opened a new issue #314: docker hub don't have document and 
simple description
URL: https://github.com/apache/incubator-servicecomb-service-center/issues/314
 
 
   Like where is API doc, how to run image, it is lacking of document
   
   https://hub.docker.com/r/servicecomb/service-center/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lexkong commented on issue #313: Routing the service-url's through api-gateway

[GitBox]

lexkong commented on issue #313: Routing the service-url's through api-gateway
URL: 
https://github.com/apache/incubator-servicecomb-service-center/issues/313#issuecomment-374013315
 
 
   @asifdxtreme thanks for you help, i use go-sdk, i checked the docs, but it 
may not solve my problem, my problem is: currently we have a gateway like tyk, 
now we want to connect to tyk as our gateway, request to gateway direct and 
then want gateway can find the endpoint according to the path pass to tyk.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lexkong commented on issue #313: Routing the service-url's through api-gateway

[GitBox]

lexkong commented on issue #313: Routing the service-url's through api-gateway
URL: 
https://github.com/apache/incubator-servicecomb-service-center/issues/313#issuecomment-374013315
 
 
   @asifdxtreme thanks for you help, i checked the docs, but it may not solve 
my problem, my problem is: currently we have a gateway like tyk, now we want to 
connect to tyk as our gateway, request to gateway direct and then want gateway 
can find the endpoint according to the path pass to tyk.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lexkong commented on issue #313: Routing the service-url's through api-gateway

[GitBox]

lexkong commented on issue #313: Routing the service-url's through api-gateway
URL: 
https://github.com/apache/incubator-servicecomb-service-center/issues/313#issuecomment-374013315
 
 
   thanks for you help, i checked the docs, but it may not solve my problem, my 
problem is: currently we have a gateway like tyk, now we want to connect to tyk 
as our gateway, request to gateway direct and then want gateway can find the 
endpoint according to the path pass to tyk.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lexkong commented on issue #313: Routing the service-url's through api-gateway

[GitBox]

lexkong commented on issue #313: Routing the service-url's through api-gateway
URL: 
https://github.com/apache/incubator-servicecomb-service-center/issues/313#issuecomment-374013315
 
 
   thanks for you help, i checked the docs, but it may not solve my problem, my 
problem is: currently we have a gateway like tyk, now we want to connect to tyk 
as our gateway, request to gateway direct and then want gateway can find the 
endpoint according tho the path pass to tyk.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] surelovemeng commented on issue #313: Routing the service-url's through api-gateway

[GitBox]

surelovemeng commented on issue #313: Routing the service-url's through 
api-gateway
URL: 
https://github.com/apache/incubator-servicecomb-service-center/issues/313#issuecomment-373989853
 
 
   you can reference to 
[dev-guide](https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/dev-guide.md).
 The guide will teach you how to SD from ServiceCenter


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asifdxtreme commented on issue #313: Routing the service-url's through api-gateway

[GitBox]

asifdxtreme commented on issue #313: Routing the service-url's through 
api-gateway
URL: 
https://github.com/apache/incubator-servicecomb-service-center/issues/313#issuecomment-373986891
 
 
   @lexkong Can you please let us know which microservice-sdk you are using? 
Currently we have 
[Java-SDK](https://github.com/apache/incubator-servicecomb-java-chassis) and 
[Go-SDK](https://github.com/ServiceComb/go-chassis) which can automatically 
interact with Service-Center and do the service-discovery and routing 
management. These two are full fledged SDK frameworks which gives you most of 
the functionality you need in any of the microservice framework. You can visit 
the website for more information http://servicecomb.incubator.apache.org/ 
   
   Anyhow if you directly want to query the API's of Service-center then you 
can use this 
[API](https://rawcdn.githack.com/ServiceComb/service-center/master/docs/api-docs.html#getServices)
 to get all the microservices list and then use the microserviceID to get the 
instance details of the microservice using this 
[API](https://rawcdn.githack.com/ServiceComb/service-center/master/docs/api-docs.html#getInstances).
   
   For full list of API's exposed by Service-Center you can look 
[here](https://rawcdn.githack.com/ServiceComb/service-center/master/docs/api-docs.html).
   
   Please let us know if this solves your problem, we will be happy to help you 
further.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asifdxtreme commented on issue #313: Routing the service-url's through api-gateway

[GitBox]

asifdxtreme commented on issue #313: Routing the service-url's through 
api-gateway
URL: 
https://github.com/apache/incubator-servicecomb-service-center/issues/313#issuecomment-373986891
 
 
   @lexhong Can you please let us know which microservice-sdk you are using? 
Currently we have 
[Java-SDK](https://github.com/apache/incubator-servicecomb-java-chassis) and 
[Go-SDK](https://github.com/ServiceComb/go-chassis) which can automatically 
interact with Service-Center and do the service-discovery and routing 
management. These two are full fledged SDK frameworks which gives you most of 
the functionality you need in any of the microservice framework. You can visit 
the website for more information http://servicecomb.incubator.apache.org/ 
   
   Anyhow if you directly want to query the API's of Service-center then you 
can use this 
[API](https://rawcdn.githack.com/ServiceComb/service-center/master/docs/api-docs.html#getServices)
 to get all the microservices list and then use the microserviceID to get the 
instance details of the microservice using this 
[API](https://rawcdn.githack.com/ServiceComb/service-center/master/docs/api-docs.html#getInstances).
   
   For full list of API's exposed by Service-Center you can look 
[here](https://rawcdn.githack.com/ServiceComb/service-center/master/docs/api-docs.html).
   
   Please let us know if this solves your problem, we will be happy to help you 
further.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asifdxtreme closed issue #312: did service center do some basic install test when developer commit code to master?

[GitBox]

asifdxtreme closed issue #312: did service center do some basic install test 
when developer commit code to master?
URL: https://github.com/apache/incubator-servicecomb-service-center/issues/312
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asifdxtreme commented on issue #312: did service center do some basic install test when developer commit code to master?

[GitBox]

asifdxtreme commented on issue #312: did service center do some basic install 
test when developer commit code to master?
URL: 
https://github.com/apache/incubator-servicecomb-service-center/issues/312#issuecomment-373986292
 
 
   Hi @lexkong 
   I have raised another issue with this question 
https://github.com/apache/incubator-servicecomb-service-center/issues/313 and 
we will track it there, since this issues is not related to Issue Title, so I 
will go ahead and close this issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asifdxtreme opened a new issue #313: Routing the service-url's through api-gateway

[GitBox]

asifdxtreme opened a new issue #313: Routing the service-url's through 
api-gateway
URL: https://github.com/apache/incubator-servicecomb-service-center/issues/313
 
 
   Issue raised by @lexkong
   my problem is, we have a api gateway, and now we want to find service from 
service center, which is from service center our api gateway can find host:port 
for the specified path such as: /calculator/bmi
   
   is there any way or docs used to connect our api gateway and service center？


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asifdxtreme closed issue #311: go build -o service-center get many errors

[GitBox]

asifdxtreme closed issue #311: go build -o service-center get many errors
URL: https://github.com/apache/incubator-servicecomb-service-center/issues/311
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asifdxtreme commented on issue #311: go build -o service-center get many errors

[GitBox]

asifdxtreme commented on issue #311: go build -o service-center get many errors
URL: 
https://github.com/apache/incubator-servicecomb-service-center/issues/311#issuecomment-373985670
 
 
   Thanks @lexkong , we will go ahead and close the issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lexkong commented on issue #311: go build -o service-center get many errors

[GitBox]

lexkong commented on issue #311: go build -o service-center get many errors
URL: 
https://github.com/apache/incubator-servicecomb-service-center/issues/311#issuecomment-373985539
 
 
   thank you! i have build it success according #312 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asifdxtreme commented on issue #311: go build -o service-center get many errors

[GitBox]

asifdxtreme commented on issue #311: go build -o service-center get many errors
URL: 
https://github.com/apache/incubator-servicecomb-service-center/issues/311#issuecomment-373985264
 
 
   Please refere to my comment on this issue 
https://github.com/apache/incubator-servicecomb-service-center/issues/312


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asifdxtreme commented on issue #312: did service center do some basic install test when developer commit code to master?

[GitBox]

asifdxtreme commented on issue #312: did service center do some basic install 
test when developer commit code to master?
URL: 
https://github.com/apache/incubator-servicecomb-service-center/issues/312#issuecomment-373984977
 
 
   @lexkong We are sorry to hear that you were not able to build the 
service-center from source.
   
   I just now tried building the service-center from source and it was success, 
below is my logs
   ```
   root1@root1-HP-EliteBook-840-G2:~/servicecomb/go/src/github.com/apache$ git 
clone https://github.com/apache/incubator-servicecomb-service-center
   Cloning into 'incubator-servicecomb-service-center'...
   remote: Counting objects: 12244, done.
   remote: Compressing objects: 100% (32/32), done.
   remote: Total 12244 (delta 11), reused 18 (delta 6), pack-reused 12206
   Receiving objects: 100% (12244/12244), 12.34 MiB | 102.00 KiB/s, done.
   Resolving deltas: 100% (5920/5920), done.
   Checking connectivity... done.
   root1@root1-HP-EliteBook-840-G2:~/servicecomb/go/src/github.com/apache$ cd 
incubator-servicecomb-service-center/
   
root1@root1-HP-EliteBook-840-G2:~/servicecomb/go/src/github.com/apache/incubator-servicecomb-service-center$
 gvt restore
   2018/03/18 15:03:36 fetching github.com/apache/thrift 
   2018/03/18 15:03:36 fetching github.com/belogik/goes 
   2018/03/18 15:03:36 fetching github.com/beorn7/perks 
   2018/03/18 15:03:36 fetching github.com/astaxie/beego 
   2018/03/18 15:03:36 fetching github.com/beego/x2j 
   2018/03/18 15:03:36 fetching github.com/ServiceComb/paas-lager 
   2018/03/18 15:03:36 fetching github.com/Shopify/sarama 
   2018/03/18 15:03:36 fetching github.com/Knetic/govaluate 
   2018/03/18 15:03:40 fetching github.com/bgentry/speakeasy 
   2018/03/18 15:03:40 fetching github.com/boltdb/bolt 
   2018/03/18 15:03:40 fetching github.com/bradfitz/gomemcache 
   2018/03/18 15:03:41 fetching github.com/casbin/casbin 
   2018/03/18 15:03:41 fetching github.com/cloudflare/golz4 
   2018/03/18 15:03:43 fetching github.com/cockroachdb/cmux 
   2018/03/18 15:03:44 fetching github.com/coreos/etcd 
   2018/03/18 15:03:44 fetching github.com/coreos/go-semver 
   2018/03/18 15:03:45 fetching github.com/coreos/go-systemd 
   2018/03/18 15:03:45 fetching github.com/coreos/pkg 
   2018/03/18 15:03:45 fetching github.com/couchbase/go-couchbase 
   2018/03/18 15:03:46 fetching github.com/couchbase/gomemcached 
   2018/03/18 15:03:48 fetching github.com/cupcake/rdb 
   2018/03/18 15:03:48 fetching github.com/davecgh/go-spew 
   2018/03/18 15:03:49 fetching github.com/dustin/go-humanize 
   2018/03/18 15:03:49 fetching github.com/eapache/go-resiliency 
   2018/03/18 15:03:51 fetching github.com/eapache/go-xerial-snappy 
   2018/03/18 15:03:52 fetching github.com/eapache/queue 
   2018/03/18 15:03:53 fetching github.com/edsrzf/mmap-go 
   2018/03/18 15:03:53 fetching github.com/garyburd/redigo 
   2018/03/18 15:03:53 fetching github.com/ghodss/yaml 
   2018/03/18 15:03:53 fetching github.com/go-logfmt/logfmt 
   2018/03/18 15:03:55 fetching github.com/gogo/protobuf 
   2018/03/18 15:03:55 fetching github.com/golang/protobuf 
   2018/03/18 15:03:56 fetching github.com/golang/snappy 
   2018/03/18 15:03:56 fetching github.com/google/btree 
   2018/03/18 15:03:56 fetching github.com/gorilla/websocket 
   2018/03/18 15:03:57 fetching github.com/hsluoyz/casbin 
   2018/03/18 15:04:00 fetching github.com/jonboulle/clockwork 
   2018/03/18 15:04:01 fetching github.com/karlseguin/ccache 
   2018/03/18 15:04:03 fetching github.com/klauspost/crc32 
   2018/03/18 15:04:03 fetching github.com/kr/pty 
   2018/03/18 15:04:06 fetching github.com/lib/pq 
   2018/03/18 15:04:07 fetching github.com/mattn/go-runewidth 
   2018/03/18 15:04:08 fetching 
github.com/matttproud/golang_protobuf_extensions 
   2018/03/18 15:04:08 fetching github.com/onsi/ginkgo 
   2018/03/18 15:04:08 fetching github.com/onsi/gomega 
   2018/03/18 15:04:11 fetching github.com/opentracing-contrib/go-observer 
   2018/03/18 15:04:11 fetching github.com/opentracing/opentracing-go 
   2018/03/18 15:04:12 fetching github.com/openzipkin/zipkin-go-opentracing 
   2018/03/18 15:04:14 fetching github.com/pelletier/go-toml 
   2018/03/18 15:04:15 fetching github.com/prometheus/client_golang 
   2018/03/18 15:04:16 fetching github.com/prometheus/client_model 
   2018/03/18 15:04:16 fetching github.com/prometheus/common 
   2018/03/18 15:04:17 fetching github.com/prometheus/procfs 
   2018/03/18 15:04:20 fetching github.com/rs/cors 
   2018/03/18 15:04:20 fetching github.com/satori/go.uuid 
   2018/03/18 15:04:21 fetching github.com/siddontang/go 
   2018/03/18 15:04:21 fetching github.com/siddontang/ledisdb 
   2018/03/18 15:04:23 fetching github.com/siddontang/rdb 
   2018/03/18 15:04:24 fetching github.com/spf13/cobra 
   2018/03/18 15:04:24 fetching github.com/spf13/pflag 
   2018/03/18 15:04:25 fetching github.com/syndtr/goleveldb 
   2018/03/18 15:04:26 fetching github.com/ugorji/go 
   2018/03/18 

[GitHub] lexkong opened a new issue #311: go build -o service-center get many errors

[GitBox]

lexkong opened a new issue #311: go build -o service-center get many errors
URL: https://github.com/apache/incubator-servicecomb-service-center/issues/311
 
 
   # github.com/coreos/etcd/clientv3
   ../../coreos/etcd/clientv3/client.go:346: cannot use c.tokenCred (type 
*authTokenCredential) as type credentials.PerRPCCredentials in argument to 
grpc.WithPerRPCCredentials:
*authTokenCredential does not implement credentials.PerRPCCredentials 
(wrong type for GetRequestMetadata method)
have GetRequestMetadata("context".Context, ...string) 
(map[string]string, error)
want 
GetRequestMetadata("github.com/coreos/etcd/vendor/golang.org/x/net/context".Context,
 ...string) (map[string]string, error)
   ../../coreos/etcd/clientv3/client.go:421: cannot use client.balancer (type 
*healthBalancer) as type grpc.Balancer in argument to grpc.WithBalancer:
*healthBalancer does not implement grpc.Balancer (wrong type for Get 
method)
have Get("context".Context, grpc.BalancerGetOptions) 
(grpc.Address, func(), error)
want 
Get("github.com/coreos/etcd/vendor/golang.org/x/net/context".Context, 
grpc.BalancerGetOptions) (grpc.Address, func(), error)
   ../../coreos/etcd/clientv3/retry.go:147: cannot use retryKVClient literal 
(type *retryKVClient) as type etcdserverpb.KVClient in return argument:
*retryKVClient does not implement etcdserverpb.KVClient (wrong type for 
Compact method)
have Compact("context".Context, 
*etcdserverpb.CompactionRequest, ...grpc.CallOption) 
(*etcdserverpb.CompactionResponse, error)
want 
Compact("github.com/coreos/etcd/vendor/golang.org/x/net/context".Context, 
*etcdserverpb.CompactionRequest, ...grpc.CallOption) 
(*etcdserverpb.CompactionResponse, error)
   ../../coreos/etcd/clientv3/retry.go:200: cannot use retryLeaseClient literal 
(type *retryLeaseClient) as type etcdserverpb.LeaseClient in return argument:
*retryLeaseClient does not implement etcdserverpb.LeaseClient (wrong 
type for LeaseGrant method)
have LeaseGrant("context".Context, 
*etcdserverpb.LeaseGrantRequest, ...grpc.CallOption) 
(*etcdserverpb.LeaseGrantResponse, error)
want 
LeaseGrant("github.com/coreos/etcd/vendor/golang.org/x/net/context".Context, 
*etcdserverpb.LeaseGrantRequest, ...grpc.CallOption) 
(*etcdserverpb.LeaseGrantResponse, error)
   ../../coreos/etcd/clientv3/retry.go:254: cannot use retryClusterClient 
literal (type *retryClusterClient) as type etcdserverpb.ClusterClient in return 
argument:
*retryClusterClient does not implement etcdserverpb.ClusterClient 
(wrong type for MemberAdd method)
have MemberAdd("context".Context, 
*etcdserverpb.MemberAddRequest, ...grpc.CallOption) 
(*etcdserverpb.MemberAddResponse, error)
want 
MemberAdd("github.com/coreos/etcd/vendor/golang.org/x/net/context".Context, 
*etcdserverpb.MemberAddRequest, ...grpc.CallOption) 
(*etcdserverpb.MemberAddResponse, error)
   ../../coreos/etcd/clientv3/retry.go:299: cannot use retryMaintenanceClient 
literal (type *retryMaintenanceClient) as type etcdserverpb.MaintenanceClient 
in return argument:
*retryMaintenanceClient does not implement 
etcdserverpb.MaintenanceClient (wrong type for Alarm method)
have Alarm("context".Context, *etcdserverpb.AlarmRequest, 
...grpc.CallOption) (*etcdserverpb.AlarmResponse, error)
want 
Alarm("github.com/coreos/etcd/vendor/golang.org/x/net/context".Context, 
*etcdserverpb.AlarmRequest, ...grpc.CallOption) (*etcdserverpb.AlarmResponse, 
error)
   ../../coreos/etcd/clientv3/retry.go:368: cannot use retryAuthClient literal 
(type *retryAuthClient) as type etcdserverpb.AuthClient in return argument:
*retryAuthClient does not implement etcdserverpb.AuthClient (wrong type 
for AuthDisable method)
have AuthDisable("context".Context, 
*etcdserverpb.AuthDisableRequest, ...grpc.CallOption) 
(*etcdserverpb.AuthDisableResponse, error)
want 
AuthDisable("github.com/coreos/etcd/vendor/golang.org/x/net/context".Context, 
*etcdserverpb.AuthDisableRequest, ...grpc.CallOption) 
(*etcdserverpb.AuthDisableResponse, error)
   # github.com/coreos/etcd/proxy/grpcproxy/adapter
   ../../coreos/etcd/proxy/grpcproxy/adapter/auth_client_adapter.go:28: cannot 
use as2ac literal (type *as2ac) as type etcdserverpb.AuthClient in return 
argument:
*as2ac does not implement etcdserverpb.AuthClient (wrong type for 
AuthDisable method)
have AuthDisable("context".Context, 
*etcdserverpb.AuthDisableRequest, ...grpc.CallOption) 
(*etcdserverpb.AuthDisableResponse, error)
want 
AuthDisable("github.com/coreos/etcd/vendor/golang.org/x/net/context".Context, 
*etcdserverpb.AuthDisableRequest, ...grpc.CallOption) 
(*etcdserverpb.AuthDisableResponse, error)
   ../../coreos/etcd/proxy/grpcproxy/adapter/chan_stream.go:151: cannot use srv 
(type