[GitHub] liubao68 commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate

2018-03-19 Thread GitBox
liubao68 commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#discussion_r175666547 ## File path: providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/spring

[SAGA] introduce the byteman to the acceptance tests

2018-03-19 Thread Zheng Feng
Hi all, I just send the PR [1] to introduce the byteman[2] to our acceptance tests. The byteman could be used to inject the fault into the java classes. The PR includes 1. unpack the byteman.jar into the ${project.output.directory}/saga which can be assembled into the docker image. 2. set the JAV

[GitHub] coveralls commented on issue #156: SCB-390 Update to introduece the byteman to the acceptance tests

2018-03-19 Thread GitBox
coveralls commented on issue #156: SCB-390 Update to introduece the byteman to the acceptance tests URL: https://github.com/apache/incubator-servicecomb-saga/pull/156#issuecomment-374489236 [![Coverage Status](https://coveralls.io/builds/16067959/badge)](https://coveralls.io/builds/16

[GitHub] zhfeng opened a new pull request #156: SCB-390 Update to introduece the byteman to the acceptance tests

2018-03-19 Thread GitBox
zhfeng opened a new pull request #156: SCB-390 Update to introduece the byteman to the acceptance tests URL: https://github.com/apache/incubator-servicecomb-saga/pull/156 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [

[VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Third Attempt

2018-03-19 Thread Mohammad Asif Siddiqui
Hi All, This is a call for Vote to release Apache ServiceComb Java-Chassis (Incubating) version 1.0.0-m1 Release Notes : https://github.com/apache/incubator-servicecomb-java-chassis/blob/master/etc/releaseNotes.md Release Candidate : https://dist.apache.org/repos/dist/dev/incubato

Re: 回复: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

2018-03-19 Thread Mohammad Asif Siddiqui
Hi All, Since the new release candidate solves the issues so we will re-initiate the voting mail for this release candidate in a seperate thread. Regards Asif On 2018/03/20 01:54:20, "郑扬勇" wrote: > Hi All: >I had checked the latest release : >Release Candidate : > h

[RESULT] [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

2018-03-19 Thread Mohammad Asif Siddiqui
Hi All, I am glad to announce that ServiceComb community has approved the Apache ServiceComb Saga(incubating) 0.1.0 release with the following results: +1 binding: 3 (Willem Jiang, Cuiyihua, Mohammad Asif Siddiqui) +1 non-binding: 5 (Yang Bo, Eric Lee, Libo, Kirin Wang, Ma BIn, Zen Lin

Re: [RESULT] [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

2018-03-19 Thread Mohammad Asif Siddiqui
Hi All, We will send this Release Candidate for IPMC approval, Once the vote passes there then we will publish the binaries. Regards Asif On 2018/03/20 02:07:58, Mohammad Asif Siddiqui wrote: > Hi All, > > I am glad to announce that ServiceComb community has approved the Apache

?????? [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

2018-03-19 Thread ??????
Hi All: Sorry this is my mistake??The new VOTE has not started yet. I withdrew my +1, thanks. -- -- ??: "??"; : 2018??3??20??(??) 9:54 ??: "dev"; : ?? [VOTE] Release Apache ServiceComb Java-Chassis (incuba

[RESULT] [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

2018-03-19 Thread Mohammad Asif Siddiqui
Hi All, I am glad to announce that ServiceComb community has approved the Apache ServiceComb Service-Center(incubating) 1.0.0-m1 release with the following results: +1 binding: 4 (Willem Jiang, Cuiyihua, Liubao, Mohammad Asif Siddiqui) +1 non-binding: 5 (Yang Bo, Eric Lee, Ma BIn, Zen

?????? [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

2018-03-19 Thread ??????
Hi All: I had checked the latest release : Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/ Staging Repo : https://repository.apache.org/content/repositories/orgapacheservicecomb-1196/ All problem had

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

2018-03-19 Thread Sure
+1 -- Original -- From: Mohammad Asif Siddiqui Date: Mon,Mar 19,2018 0:16 PM To: dev Subject: Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt +1 Binding I Checked - incubating in name - hashes and

[GitHub] codecov-io commented on issue #315: Add Dockerfile to base directory

2018-03-19 Thread GitBox
codecov-io commented on issue #315: Add Dockerfile to base directory URL: https://github.com/apache/incubator-servicecomb-service-center/pull/315#issuecomment-374225263 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/315?src=pr&el=h1) Report > Merging

[GitHub] coveralls commented on issue #315: Add Dockerfile to base directory

2018-03-19 Thread GitBox
coveralls commented on issue #315: Add Dockerfile to base directory URL: https://github.com/apache/incubator-servicecomb-service-center/pull/315#issuecomment-374225112 [![Coverage Status](https://coveralls.io/builds/16051753/badge)](https://coveralls.io/builds/16051753) Coverage

[GitHub] weichao666 commented on a change in pull request #613: [SCB-416]For load balance rule configurations, we need provider service level configuration

2018-03-19 Thread GitBox
weichao666 commented on a change in pull request #613: [SCB-416]For load balance rule configurations, we need provider service level configuration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/613#discussion_r175445652 ## File path: handlers/handler-loadba

[GitHub] asifdxtreme closed pull request #310: SCB-411 SC can not check the reduplicate endpoints when register with ID

2018-03-19 Thread GitBox
asifdxtreme closed pull request #310: SCB-411 SC can not check the reduplicate endpoints when register with ID URL: https://github.com/apache/incubator-servicecomb-service-center/pull/310 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displ

[GitHub] asifdxtreme opened a new pull request #315: Add Dockerfile to base directory

2018-03-19 Thread GitBox
asifdxtreme opened a new pull request #315: Add Dockerfile to base directory URL: https://github.com/apache/incubator-servicecomb-service-center/pull/315 Signed-off-by: asifdxtreme Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make

[GitHub] WillemJiang closed pull request #614: [SCB-417] delete useless lines in readme

2018-03-19 Thread GitBox
WillemJiang closed pull request #614: [SCB-417] delete useless lines in readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/614 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenan

[GitHub] WillemJiang commented on a change in pull request #614: [SCB-417] delete useless lines in readme

2018-03-19 Thread GitBox
WillemJiang commented on a change in pull request #614: [SCB-417] delete useless lines in readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/614#discussion_r175435491 ## File path: samples/README.md ## @@ -7,20 +7,4 @@ It's the samples of Java c

[GitHub] weichao666 commented on a change in pull request #613: [SCB-416]For load balance rule configurations, we need provider service level configuration

2018-03-19 Thread GitBox
weichao666 commented on a change in pull request #613: [SCB-416]For load balance rule configurations, we need provider service level configuration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/613#discussion_r175435231 ## File path: handlers/handler-loadba

[GitHub] WillemJiang commented on a change in pull request #614: [SCB-417] delete useless lines in readme

2018-03-19 Thread GitBox
WillemJiang commented on a change in pull request #614: [SCB-417] delete useless lines in readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/614#discussion_r175428342 ## File path: samples/README.md ## @@ -7,20 +7,4 @@ It's the samples of Java c

[GitHub] weichao666 commented on a change in pull request #613: [SCB-416]For load balance rule configurations, we need provider service level configuration

2018-03-19 Thread GitBox
weichao666 commented on a change in pull request #613: [SCB-416]For load balance rule configurations, we need provider service level configuration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/613#discussion_r175434451 ## File path: handlers/handler-loadba

[GitHub] WillemJiang closed pull request #612: [SCB-413] fix pojo consumer sample bean xml

2018-03-19 Thread GitBox
WillemJiang closed pull request #612: [SCB-413] fix pojo consumer sample bean xml URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/612 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prov

[GitHub] WillemJiang commented on a change in pull request #614: [SCB-417] delete useless lines in readme

2018-03-19 Thread GitBox
WillemJiang commented on a change in pull request #614: [SCB-417] delete useless lines in readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/614#discussion_r175428342 ## File path: samples/README.md ## @@ -7,20 +7,4 @@ It's the samples of Java c

[GitHub] asifdxtreme commented on a change in pull request #614: [SCB-417] delete useless lines in readme

2018-03-19 Thread GitBox
asifdxtreme commented on a change in pull request #614: [SCB-417] delete useless lines in readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/614#discussion_r175427311 ## File path: samples/README.md ## @@ -7,20 +7,4 @@ It's the samples of Java c

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

2018-03-19 Thread Mohammad Asif Siddiqui
Hi All, We are cancelling this vote as there are some issues which needs to be handled before the release. We will re-intiate the vote once we are done fixing it. Thanks All for your support. Regards Asif On 2018/03/16 18:52:25, Mohammad Asif Siddiqui wrote: > Hi All, >

[GitHub] zhengyangyong opened a new pull request #614: [SCB-417] delete useless lines in readme

2018-03-19 Thread GitBox
zhengyangyong opened a new pull request #614: [SCB-417] delete useless lines in readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/614 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] coveralls commented on issue #310: SCB-411 SC can not check the reduplicate endpoints when register with ID

2018-03-19 Thread GitBox
coveralls commented on issue #310: SCB-411 SC can not check the reduplicate endpoints when register with ID URL: https://github.com/apache/incubator-servicecomb-service-center/pull/310#issuecomment-373902346 [![Coverage Status](https://coveralls.io/builds/16049929/badge)](https://cove

[GitHub] codecov-io commented on issue #310: SCB-411 SC can not check the reduplicate endpoints when register with ID

2018-03-19 Thread GitBox
codecov-io commented on issue #310: SCB-411 SC can not check the reduplicate endpoints when register with ID URL: https://github.com/apache/incubator-servicecomb-service-center/pull/310#issuecomment-373902301 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pu

[GitHub] liubao68 opened a new pull request #613: [SCB-416]For load balance rule configurations, we need provider service level configuration

2018-03-19 Thread GitBox
liubao68 opened a new pull request #613: [SCB-416]For load balance rule configurations, we need provider service level configuration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/613 Follow this checklist to help us incorporate your contribution quickly and eas

[GitHub] WillemJiang closed pull request #610: [SCB-415] change cluster value from "test-cluster" to "default"

2018-03-19 Thread GitBox
WillemJiang closed pull request #610: [SCB-415] change cluster value from "test-cluster" to "default" URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/610 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] coveralls commented on issue #610: [SCB-415] change cluster value from "test-cluster" to "default"

2018-03-19 Thread GitBox
coveralls commented on issue #610: [SCB-415] change cluster value from "test-cluster" to "default" URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/610#issuecomment-374164496 [![Coverage Status](https://coveralls.io/builds/16047946/badge)](https://coveralls.io/bu

[GitHub] tianxiaoliang closed issue #314: docker hub don't have document and simple description

2018-03-19 Thread GitBox
tianxiaoliang closed issue #314: docker hub don't have document and simple description URL: https://github.com/apache/incubator-servicecomb-service-center/issues/314 This is an automated message from the Apache Git Service.

[GitHub] zhengyangyong commented on a change in pull request #612: [SCB-413] fix pojo consumer sample bean xml

2018-03-19 Thread GitBox
zhengyangyong commented on a change in pull request #612: [SCB-413] fix pojo consumer sample bean xml URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/612#discussion_r175365511 ## File path: samples/pojo-sample/pojo-consumer/src/main/resources/META-INF/spring

[GitHub] zhengyangyong commented on a change in pull request #610: [SCB-415] change cluster value from "test-cluster" to "default"

2018-03-19 Thread GitBox
zhengyangyong commented on a change in pull request #610: [SCB-415] change cluster value from "test-cluster" to "default" URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/610#discussion_r175363834 ## File path: samples/config-apollo-sample/src/main/resources/m

[GitHub] WillemJiang commented on a change in pull request #610: [SCB-415] change cluster value from "test-cluster" to "default"

2018-03-19 Thread GitBox
WillemJiang commented on a change in pull request #610: [SCB-415] change cluster value from "test-cluster" to "default" URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/610#discussion_r175362174 ## File path: samples/config-apollo-sample/src/main/resources/mic

[GitHub] WillemJiang closed pull request #611: [SCB-414] fix releaseNotes

2018-03-19 Thread GitBox
WillemJiang closed pull request #611: [SCB-414] fix releaseNotes URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/611 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this i

[GitHub] WillemJiang commented on a change in pull request #612: [SCB-413] fix pojo consumer sample bean xml

2018-03-19 Thread GitBox
WillemJiang commented on a change in pull request #612: [SCB-413] fix pojo consumer sample bean xml URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/612#discussion_r175358825 ## File path: samples/pojo-sample/pojo-consumer/src/main/resources/META-INF/spring/p

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

2018-03-19 Thread Willem Jiang
As the SCB-413 introduced some trouble for the user to run the example, I think we need to fix this issue before release. So I changed my vote to -1, we need to fix this issue before release. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) T

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

2018-03-19 Thread Zen Lin
+1 Non Binding 2018-03-19 15:14 GMT+08:00 Bin Ma : > +1 Non Binding Checked the demo > > > 2018-03-19 13:06 GMT+08:00 Mahesh Raju Somalaraju < > maheshraju.o...@gmail.com > >: > > > +1 Non Binding > > > > - Ran java-chassis demos using service-center release binary. > > - Run the rat to verify t

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

2018-03-19 Thread Zen Lin
+1 non binding 2018-03-19 15:09 GMT+08:00 Bin Ma : > +1 non binding > > Ran the service-center release binary successfully > > 2018-03-19 13:05 GMT+08:00 Mahesh Raju Somalaraju < > maheshraju.o...@gmail.com > >: > > > +1 Non Binding > > > > - Ran java-chassis demos using service-center release

[GitHub] zhengyangyong opened a new pull request #612: [SCB-413] fix pojo consumer sample bean xml

2018-03-19 Thread GitBox
zhengyangyong opened a new pull request #612: [SCB-413] fix pojo consumer sample bean xml URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/612 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] zhengyangyong closed pull request #572: [SCB-370] Improve latency and max precision

2018-03-19 Thread GitBox
zhengyangyong closed pull request #572: [SCB-370] Improve latency and max precision URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/572 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pr

[GitHub] zhengyangyong opened a new pull request #611: [SCB-414] fix releaseNotes

2018-03-19 Thread GitBox
zhengyangyong opened a new pull request #611: [SCB-414] fix releaseNotes URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/611 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure

[GitHub] zhengyangyong opened a new pull request #610: [SCB-415] change cluster value from "test-cluster" to "default"

2018-03-19 Thread GitBox
zhengyangyong opened a new pull request #610: [SCB-415] change cluster value from "test-cluster" to "default" URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/610 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickl

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

2018-03-19 Thread ??????
+0 Non Binding Built the code from Release Candidate then check all samples using Staging Repo. Run unit tests and integration tests. Problem : 1.Need Update Release notes: https://issues.apache.org/jira/browse/SCB-414 2.Pojo sample will be failed when running "mvn exec:java" : https:

Re: discussion: about performance metrics local log output format.

2018-03-19 Thread wjm wjm
just a logger to output local log periodically, not about filter. this make developers easier to know bottleneck of their system, no need to deploy any other component 2018年3月17日星期六,Willem Jiang 写道: > Hi wjm, > > It's handy feature if we can configure the filter to let the consol print > out th

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

2018-03-19 Thread Bin Ma
+1 Non Binding Build the source successfully,and unit tests and integration tests are passed 2018-03-19 13:06 GMT+08:00 Mahesh Raju Somalaraju : > +1 Non Binding > > - Ran java-chassis demos using service-center release binary. > - Run the rat to verify the License header issue. > > Thanks & Re

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

2018-03-19 Thread Bin Ma
+1 Non Binding Checked the demo 2018-03-19 13:06 GMT+08:00 Mahesh Raju Somalaraju : > +1 Non Binding > > - Ran java-chassis demos using service-center release binary. > - Run the rat to verify the License header issue. > > Thanks & Regards > -Mahesh Raju S > > > On Sat, Mar 17, 2018 at 12:31 AM,

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

2018-03-19 Thread Bin Ma
+1 non binding Ran the service-center release binary successfully 2018-03-19 13:05 GMT+08:00 Mahesh Raju Somalaraju : > +1 Non Binding > > - Ran java-chassis demos using service-center release binary. > - Run the rat to verify the License header issue. > > Thanks & Regards > -Mahesh Raju S > > O