[GitHub] liubao68 closed pull request #691: [SCB-546] refactor the schemas registry logic

2018-05-09 Thread GitBox
liubao68 closed pull request #691: [SCB-546] refactor the schemas registry logic URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/691 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of proven

[GitHub] wujimin commented on issue #678: [SCB-506]服务治理相关的需要事件上报

2018-05-09 Thread GitBox
wujimin commented on issue #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#issuecomment-387951815 why did not changed by review message and did not wrote any response? T

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-09 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r187239668 ## File path: handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/filter/TestIsolati

[GitHub] wujimin commented on issue #678: [SCB-506]服务治理相关的需要事件上报

2018-05-09 Thread GitBox
wujimin commented on issue #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#issuecomment-387951815 why did not changed by review message and did not wrote any response? T

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-09 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r187239487 ## File path: handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/filter/TestIsolati

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-09 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r187238597 ## File path: handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/event/CircutBreakerEve

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-09 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r187238232 ## File path: handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/event/CircutBreakerEve

[GitHub] wujimin commented on a change in pull request #692: [SCB-543]optimize registry procedure

2018-05-09 Thread GitBox
wujimin commented on a change in pull request #692: [SCB-543]optimize registry procedure URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/692#discussion_r187237709 ## File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/Micros

[GitHub] wujimin commented on a change in pull request #692: [SCB-543]optimize registry procedure

2018-05-09 Thread GitBox
wujimin commented on a change in pull request #692: [SCB-543]optimize registry procedure URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/692#discussion_r187237709 ## File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/Micros

Re: [Discussion]Reorganize 'demo' and 'integration-tests' modules in Java Chassis

2018-05-09 Thread Zen Lin
Yeah, It is a nice proposal about Continuous integration and acceptance testing. Best Regards, --- Zen Lin zenlintechnofr...@gmail.com Focused on Micro Service and Apache ServiceComb 2018-05-10 10:12 GMT+08:00 wjm wjm : > good > maybe we can discuss based on issue 221/JAV-507 > > 2018-05-09 16:4

[GitHub] coveralls commented on issue #188: [SCB-569] Add document for enabling SSL

2018-05-09 Thread GitBox
coveralls commented on issue #188: [SCB-569] Add document for enabling SSL URL: https://github.com/apache/incubator-servicecomb-saga/pull/188#issuecomment-387934520 [![Coverage Status](https://coveralls.io/builds/16915111/badge)](https://coveralls.io/builds/16915111) Coverage de

[GitHub] coveralls commented on issue #188: [SCB-569] Add document for enabling SSL

2018-05-09 Thread GitBox
coveralls commented on issue #188: [SCB-569] Add document for enabling SSL URL: https://github.com/apache/incubator-servicecomb-saga/pull/188#issuecomment-387934521 [![Coverage Status](https://coveralls.io/builds/16915111/badge)](https://coveralls.io/builds/16915111) Coverage de

[GitHub] wujimin closed pull request #695: [SCB-567] treat warning as errors, modify the compilerArgments

2018-05-09 Thread GitBox
wujimin closed pull request #695: [SCB-567] treat warning as errors, modify the compilerArgments URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/695 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for t

[GitHub] yangbor opened a new pull request #188: [SCB-569] Add document for enabling SSL

2018-05-09 Thread GitBox
yangbor opened a new pull request #188: [SCB-569] Add document for enabling SSL URL: https://github.com/apache/incubator-servicecomb-saga/pull/188 Add document for enabling SSL for communication between alpha and omega. Follow this checklist to help us incorporate your contribution qu

[GitHub] coveralls commented on issue #696: [SCB-533] Javassist utils create class from ct class

2018-05-09 Thread GitBox
coveralls commented on issue #696: [SCB-533] Javassist utils create class from ct class URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/696#issuecomment-387932870 [![Coverage Status](https://coveralls.io/builds/16915024/badge)](https://coveralls.io/builds/169150

Re: [Discussion]Reorganize 'demo' and 'integration-tests' modules in Java Chassis

2018-05-09 Thread wjm wjm
good maybe we can discuss based on issue 221/JAV-507 2018-05-09 16:46 GMT+08:00 郑扬勇 : > Hi all: >In java chassis there are two set of modules 'demo' and > 'integration-tests' for integration test, I think we can reorganize them > and merge into 'integration-tests' because: >1.'demo' has c

[GitHub] zhengyangyong commented on a change in pull request #693: [SCB-548] support gracefully shutdown

2018-05-09 Thread GitBox
zhengyangyong commented on a change in pull request #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#discussion_r187222993 ## File path: core/src/main/java/org/apache/servicecomb/core/handler/ShutdownHookHandler

[GitHub] zhengyangyong commented on a change in pull request #693: [SCB-548] support gracefully shutdown

2018-05-09 Thread GitBox
zhengyangyong commented on a change in pull request #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#discussion_r187222815 ## File path: core/src/main/java/org/apache/servicecomb/core/handler/ShutdownHookHandler

[GitHub] wujimin opened a new pull request #696: [SCB-533] Javassist utils create class from ct class

2018-05-09 Thread GitBox
wujimin opened a new pull request #696: [SCB-533] Javassist utils create class from ct class URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/696 still preparing for create recursive class This is an aut

[GitHub] liubao68 commented on a change in pull request #693: [SCB-548] support gracefully shutdown

2018-05-09 Thread GitBox
liubao68 commented on a change in pull request #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#discussion_r187222394 ## File path: core/src/main/java/org/apache/servicecomb/core/handler/ShutdownHookHandler.java

[GitHub] zhengyangyong opened a new pull request #84: replace 'cse' to 'servicecomb'

2018-05-09 Thread GitBox
zhengyangyong opened a new pull request #84: replace 'cse' to 'servicecomb' URL: https://github.com/apache/incubator-servicecomb-website/pull/84 Signed-off-by: zhengyangyong replace 'cse' to 'servicecomb' This is an au

[GitHub] lijasonvip closed pull request #173: [SCB-300] acceptance test for @Compensable event timeout

2018-05-09 Thread GitBox
lijasonvip closed pull request #173: [SCB-300] acceptance test for @Compensable event timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/173 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] WillemJiang commented on issue #185: [SCB-245]: add acceptance test for dubbo demo

2018-05-09 Thread GitBox
WillemJiang commented on issue #185: [SCB-245]: add acceptance test for dubbo demo URL: https://github.com/apache/incubator-servicecomb-saga/pull/185#issuecomment-387897167 We need to start the service and the db before running the cucumber test. -

[GitHub] wujimin closed pull request #689: [SCB-538] Create SwaggerToClassGenerator

2018-05-09 Thread GitBox
wujimin closed pull request #689: [SCB-538] Create SwaggerToClassGenerator URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/689 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] asifdxtreme closed pull request #346: SCB-565 Register instance with the same id will create redundant endpoint index data

2018-05-09 Thread GitBox
asifdxtreme closed pull request #346: SCB-565 Register instance with the same id will create redundant endpoint index data URL: https://github.com/apache/incubator-servicecomb-service-center/pull/346 This is a PR merged from a forked repository. As GitHub hides the original diff on merge,

[GitHub] weichao666 commented on issue #695: [SCB-567] treat warning as errors, modify the compilerArgments

2018-05-09 Thread GitBox
weichao666 commented on issue #695: [SCB-567] treat warning as errors, modify the compilerArgments URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/695#issuecomment-387723171 ``` ``` cse can't use ,it will cause error while

[GitHub] weichao666 commented on issue #695: [SCB-567] treat warning as errors, modify the compilerArgments

2018-05-09 Thread GitBox
weichao666 commented on issue #695: [SCB-567] treat warning as errors, modify the compilerArgments URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/695#issuecomment-387723171 ``` ``` cse can't use ,it will cause error while

[GitHub] weichao666 commented on issue #695: [SCB-567] treat warning as errors, modify the compilerArgments

2018-05-09 Thread GitBox
weichao666 commented on issue #695: [SCB-567] treat warning as errors, modify the compilerArgments URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/695#issuecomment-387723171 ``` ``` cse can't use ,it will cause error while

[GitHub] weichao666 commented on issue #695: [SCB-567] treat warning as errors, modify the compilerArgments

2018-05-09 Thread GitBox
weichao666 commented on issue #695: [SCB-567] treat warning as errors, modify the compilerArgments URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/695#issuecomment-387723171 cse can't use ,it will cause error while use python el

[GitHub] weichao666 commented on issue #695: [SCB-567] treat warning as errors, modify the compilerArgments

2018-05-09 Thread GitBox
weichao666 commented on issue #695: [SCB-567] treat warning as errors, modify the compilerArgments URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/695#issuecomment-387723171 cse can't use ,it will cause error while use python

[GitHub] coveralls commented on issue #695: [SCB-567] treat warning as errors, modify the compilerArgments

2018-05-09 Thread GitBox
coveralls commented on issue #695: [SCB-567] treat warning as errors, modify the compilerArgments URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/695#issuecomment-387721131 [![Coverage Status](https://coveralls.io/builds/16902044/badge)](https://coveralls.io/bui

[GitHub] weichao666 opened a new pull request #695: [SCB-567] treat warning as errors, modify the compilerArgments

2018-05-09 Thread GitBox
weichao666 opened a new pull request #695: [SCB-567] treat warning as errors, modify the compilerArgments URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/695 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure th

Re: [Discussion] Move Gitbox Notifications from dev@servicecomb.apache.org to a new maillist

2018-05-09 Thread Zen Lin
Hi I also gone through the commits mailing list about other project. It seems consistent with what Jean-Baptiste said, like an "umbrella" receiving any message related commit/code activity. Best Regards, --- Zen Lin zenlintechnofr...@gmail.com Focused on Micro Service and Apache ServiceComb 2018

[GitHub] coveralls commented on issue #691: [SCB-546] refactor the schemas registry logic

2018-05-09 Thread GitBox
coveralls commented on issue #691: [SCB-546] refactor the schemas registry logic URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/691#issuecomment-386793069 [![Coverage Status](https://coveralls.io/builds/16900703/badge)](https://coveralls.io/builds/16900703)

Re: [Discussion] Move Gitbox Notifications from dev@servicecomb.apache.org to a new maillist

2018-05-09 Thread Jean-Baptiste Onofré
The suggestion was more a kind of "umbrella" mailing list receiving any message related to commit/code activity. Regards JB On 09/05/2018 11:21, Willem Jiang wrote: Hi JB, As GitBox also post some comments and PR request which could be only part of commits? I'm not sure if it is OK to keep th

[GitHub] coveralls commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data

2018-05-09 Thread GitBox
coveralls commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data URL: https://github.com/apache/incubator-servicecomb-service-center/pull/346#issuecomment-387674520 [![Coverage Status](https://coveralls.io/builds/16900027/badge)](

[GitHub] codecov-io commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data

2018-05-09 Thread GitBox
codecov-io commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data URL: https://github.com/apache/incubator-servicecomb-service-center/pull/346#issuecomment-387674481 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-servi

Re: [Discussion] Move Gitbox Notifications from dev@servicecomb.apache.org to a new maillist

2018-05-09 Thread Willem Jiang
Hi JB, As GitBox also post some comments and PR request which could be only part of commits? I'm not sure if it is OK to keep them in the commits mailing list. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁wi

[GitHub] coveralls commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data

2018-05-09 Thread GitBox
coveralls commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data URL: https://github.com/apache/incubator-servicecomb-service-center/pull/346#issuecomment-387674520 [![Coverage Status](https://coveralls.io/builds/16899564/badge)](

[GitHub] codecov-io commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data

2018-05-09 Thread GitBox
codecov-io commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data URL: https://github.com/apache/incubator-servicecomb-service-center/pull/346#issuecomment-387674481 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-servi

[Discussion]Reorganize 'demo' and 'integration-tests' modules in Java Chassis

2018-05-09 Thread ??????
Hi all: In java chassis there are two set of modules 'demo' and 'integration-tests' for integration test, I think we can reorganize them and merge into 'integration-tests' because: 1.'demo' has caused much confusion with 'samples' 2.'demo' play some role of show how develop using Java ch

[GitHub] little-cui opened a new pull request #346: SCB-565 Register instance with the same id will create redundant endpoint index data

2018-05-09 Thread GitBox
little-cui opened a new pull request #346: SCB-565 Register instance with the same id will create redundant endpoint index data URL: https://github.com/apache/incubator-servicecomb-service-center/pull/346 Follow this checklist to help us incorporate your contribution quickly and easily:

Re: [Discussion]What Java Chassis need to do for support Gracefully Shutdown

2018-05-09 Thread Willem Jiang
Oh, let me make it clear. As Liubao said, we have two place to do the shutdown work. "Now java-chassis doing the following: 1. A shutdown hook for spring context shutdown and unregistered from service center 2. A shutdown hook waiting for all invocations to finish" My suggestion is unify the shut

Re: [Discussion] Move Gitbox Notifications from dev@servicecomb.apache.org to a new maillist

2018-05-09 Thread kirin wang
Hi Jean-Baptiste: Thank you for your suggestion, If Apache projects already have the common practice, we can also follow it~

[GitHub] coveralls commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-09 Thread GitBox
coveralls commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-387664923 [![Coverage Status](https://coveralls.io/builds/16899128/badge)](https://coveralls.io/builds/16899128) Cover

Re: [Discussion] Move Gitbox Notifications from dev@servicecomb.apache.org to a new maillist

2018-05-09 Thread Jean-Baptiste Onofré
What about comm...@servicecomb.apache.org ? Most of the Apache projects use commits mailing list. Thoughts ? Regards JB On 09/05/2018 09:42, kirin wang wrote: Hi community: Currently, Gitbox notifications are send via " dev@servicecomb.apache.org" . And it's mixed with our commu

?????? [Discussion]What Java Chassis need to do for support Gracefully Shutdown

2018-05-09 Thread ??????
Hi all: I had make some improvement base on current mechanism and PR is here : https://github.com/apache/incubator-servicecomb-java-chassis/pull/693 , I think it is enough. When user call system.exit(0),these three works will do: 1.Unregister microservice instance from Service Center: thi

[Discussion] Move Gitbox Notifications from dev@servicecomb.apache.org to a new maillist

2018-05-09 Thread kirin wang
Hi community: Currently, Gitbox notifications are send via " dev@servicecomb.apache.org" . And it's mixed with our community affaris discussion. May be we can move gitbox notifications to a new mailist like " notificat...@servicecomb.apache.org" to make the "dev" more "pure" : ) ..

Re: [Discussion]What Java Chassis need to do for support Gracefully Shutdown

2018-05-09 Thread wjm wjm
it's impossible we are a framework, we can handle shutdown work in one place but how can customer do in this places? shutdown process is ordered, if customer's shutdown work processed before us, then exists invocations maybe can not finished. 2018-05-09 14:40 GMT+08:00 Willem Jiang : > I think i