[GitHub] coveralls commented on issue #692: [SCB-543]optimize registry procedure

2018-05-10 Thread GitBox
coveralls commented on issue #692: [SCB-543]optimize registry procedure URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/692#issuecomment-386952358 [![Coverage Status](https://coveralls.io/builds/16917596/badge)](https://coveralls.io/builds/16917596)

[GitHub] jeho0815 opened a new pull request #697: [SCB-546] refactor the schemas registry logic

2018-05-10 Thread GitBox
jeho0815 opened a new pull request #697: [SCB-546] refactor the schemas registry logic URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/697 Bug fix: At fix first time register microservice, will throw IllegalStateException Follow this checklist to help us

[GitHub] wujimin commented on a change in pull request #698: [SCB-546] bug fix

2018-05-10 Thread GitBox
wujimin commented on a change in pull request #698: [SCB-546] bug fix URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/698#discussion_r187279779 ## File path:

[GitHub] yangbor commented on issue #188: [SCB-569] Add document for enabling SSL

2018-05-10 Thread GitBox
yangbor commented on issue #188: [SCB-569] Add document for enabling SSL URL: https://github.com/apache/incubator-servicecomb-saga/pull/188#issuecomment-388008417 @WillemJiang Done This is an automated message from the

[GitHub] xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-10 Thread GitBox
xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r187295182 ## File path:

[GitHub] wujimin commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-10 Thread GitBox
wujimin commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-387991593 if ContextCloseEvent and handler/ShutdownHookHandler.java is random ordered, then it's not ok

[GitHub] coveralls commented on issue #698: [SCB-546] bug fix

2018-05-10 Thread GitBox
coveralls commented on issue #698: [SCB-546] bug fix URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/698#issuecomment-388006686 [![Coverage Status](https://coveralls.io/builds/16918356/badge)](https://coveralls.io/builds/16918356) Coverage remained the

[GitHub] jeho0815 commented on a change in pull request #698: [SCB-546] bug fix

2018-05-10 Thread GitBox
jeho0815 commented on a change in pull request #698: [SCB-546] bug fix URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/698#discussion_r187299590 ## File path:

[GitHub] WillemJiang opened a new pull request #189: SCB-571 Decouple OmegaContext in the Application

2018-05-10 Thread GitBox
WillemJiang opened a new pull request #189: SCB-571 Decouple OmegaContext in the Application URL: https://github.com/apache/incubator-servicecomb-saga/pull/189 Now the demo application can use enableOmega or not. This is an

[GitHub] liubao68 closed pull request #692: [SCB-543]optimize registry procedure

2018-05-10 Thread GitBox
liubao68 closed pull request #692: [SCB-543]optimize registry procedure URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/692 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] jeho0815 opened a new pull request #698: [SCB-546] bug fix

2018-05-10 Thread GitBox
jeho0815 opened a new pull request #698: [SCB-546] bug fix URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/698 in production enviroment, first time register microservice, schemas's summary is null, registerSchemas will throw exception. if the summary is null,

[GitHub] coveralls commented on issue #698: [SCB-546] bug fix

2018-05-10 Thread GitBox
coveralls commented on issue #698: [SCB-546] bug fix URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/698#issuecomment-388006686 [![Coverage Status](https://coveralls.io/builds/16919419/badge)](https://coveralls.io/builds/16919419) Coverage remained the

[GitHub] wujimin commented on a change in pull request #698: [SCB-546] bug fix

2018-05-10 Thread GitBox
wujimin commented on a change in pull request #698: [SCB-546] bug fix URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/698#discussion_r187280085 ## File path:

[GitHub] little-cui opened a new pull request #347: SCB-572 Can not convert error to status code

2018-05-10 Thread GitBox
little-cui opened a new pull request #347: SCB-572 Can not convert error to status code URL: https://github.com/apache/incubator-servicecomb-service-center/pull/347 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[GitHub] coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis

2018-05-10 Thread GitBox
coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-381568126 [![Coverage Status](https://coveralls.io/builds/16920459/badge)](https://coveralls.io/builds/16920459)

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-10 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r187330052 ## File path:

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-10 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r187329270 ## File path:

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-10 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r187329477 ## File path:

[GitHub] codecov-io commented on issue #347: SCB-572 Can not convert error to status code

2018-05-10 Thread GitBox
codecov-io commented on issue #347: SCB-572 Can not convert error to status code URL: https://github.com/apache/incubator-servicecomb-service-center/pull/347#issuecomment-388067455 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/347?src=pr=h1) Report

[GitHub] coveralls commented on issue #696: [SCB-533] Javassist utils create class from ct class

2018-05-09 Thread GitBox
coveralls commented on issue #696: [SCB-533] Javassist utils create class from ct class URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/696#issuecomment-387932870 [![Coverage

[GitHub] wujimin closed pull request #695: [SCB-567] treat warning as errors, modify the compilerArgments

2018-05-09 Thread GitBox
wujimin closed pull request #695: [SCB-567] treat warning as errors, modify the compilerArgments URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/695 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] wujimin commented on a change in pull request #692: [SCB-543]optimize registry procedure

2018-05-09 Thread GitBox
wujimin commented on a change in pull request #692: [SCB-543]optimize registry procedure URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/692#discussion_r187237709 ## File path:

[GitHub] liubao68 closed pull request #691: [SCB-546] refactor the schemas registry logic

2018-05-10 Thread GitBox
liubao68 closed pull request #691: [SCB-546] refactor the schemas registry logic URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/691 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] yangbor opened a new pull request #188: [SCB-569] Add document for enabling SSL

2018-05-09 Thread GitBox
yangbor opened a new pull request #188: [SCB-569] Add document for enabling SSL URL: https://github.com/apache/incubator-servicecomb-saga/pull/188 Add document for enabling SSL for communication between alpha and omega. Follow this checklist to help us incorporate your contribution

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-09 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r187238597 ## File path:

[GitHub] wujimin commented on issue #678: [SCB-506]服务治理相关的需要事件上报

2018-05-09 Thread GitBox
wujimin commented on issue #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#issuecomment-387951815 why did not changed by review message and did not wrote any response?

[GitHub] wujimin commented on issue #678: [SCB-506]服务治理相关的需要事件上报

2018-05-09 Thread GitBox
wujimin commented on issue #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#issuecomment-387951815 why did not changed by review message and did not wrote any response?

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-09 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r187239668 ## File path:

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-09 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r187238232 ## File path:

[GitHub] liubao68 closed pull request #693: [SCB-548] support gracefully shutdown

2018-05-10 Thread GitBox
liubao68 closed pull request #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] zhengyangyong opened a new pull request #693: [SCB-548] support gracefully shutdown

2018-05-10 Thread GitBox
zhengyangyong opened a new pull request #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution

[GitHub] coveralls commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-10 Thread GitBox
coveralls commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-387664923 [![Coverage Status](https://coveralls.io/builds/16917467/badge)](https://coveralls.io/builds/16917467)

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-09 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r187239487 ## File path:

[GitHub] zhengyangyong closed pull request #693: [SCB-548] support gracefully shutdown

2018-05-10 Thread GitBox
zhengyangyong closed pull request #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] WillemJiang closed pull request #189: SCB-571 Decouple OmegaContext in the Application

2018-05-10 Thread GitBox
WillemJiang closed pull request #189: SCB-571 Decouple OmegaContext in the Application URL: https://github.com/apache/incubator-servicecomb-saga/pull/189 This is an automated message from the Apache Git Service. To respond

[GitHub] codecov-io commented on issue #348: SCB-491 Add the Test Schema Feature

2018-05-10 Thread GitBox
codecov-io commented on issue #348: SCB-491 Add the Test Schema Feature URL: https://github.com/apache/incubator-servicecomb-service-center/pull/348#issuecomment-388149405 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/348?src=pr=h1) Report >

[GitHub] asifdxtreme opened a new pull request #348: SCB-491 Add the Test Schema Feature

2018-05-10 Thread GitBox
asifdxtreme opened a new pull request #348: SCB-491 Add the Test Schema Feature URL: https://github.com/apache/incubator-servicecomb-service-center/pull/348 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[GitHub] wujimin closed pull request #689: [SCB-538] Create SwaggerToClassGenerator

2018-05-09 Thread GitBox
wujimin closed pull request #689: [SCB-538] Create SwaggerToClassGenerator URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/689 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] wujimin commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-11 Thread GitBox
wujimin commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388522879 and CI failed, it's about trace, i can find what happened, it seems that did not print error test case name?

[GitHub] wujimin commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-11 Thread GitBox
wujimin commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388522824 ShutdownHookHandler is not so good, sometimes will block shutdown process cause of wrong statistics, must depend on

[GitHub] wujimin commented on a change in pull request #699: [SCB-532] Support recursive dependency

2018-05-11 Thread GitBox
wujimin commented on a change in pull request #699: [SCB-532] Support recursive dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/699#discussion_r187761407 ## File path:

[GitHub] jliu666 opened a new issue #700: Why not speak English on github?

2018-05-12 Thread GitBox
jliu666 opened a new issue #700: Why not speak English on github? URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/700 In order to better promote this project, I think we should speak English. This is

[GitHub] codecov-io commented on issue #349: SCB-491 Fix the broken links for China Region

2018-05-12 Thread GitBox
codecov-io commented on issue #349: SCB-491 Fix the broken links for China Region URL: https://github.com/apache/incubator-servicecomb-service-center/pull/349#issuecomment-388586915 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/349?src=pr=h1) Report

[GitHub] coveralls commented on issue #349: SCB-491 Fix the broken links for China Region

2018-05-12 Thread GitBox
coveralls commented on issue #349: SCB-491 Fix the broken links for China Region URL: https://github.com/apache/incubator-servicecomb-service-center/pull/349#issuecomment-388586929 [![Coverage Status](https://coveralls.io/builds/16954899/badge)](https://coveralls.io/builds/16954899)

[GitHub] asifdxtreme opened a new pull request #349: SCB-491 Fix the broken links for China Region

2018-05-12 Thread GitBox
asifdxtreme opened a new pull request #349: SCB-491 Fix the broken links for China Region URL: https://github.com/apache/incubator-servicecomb-service-center/pull/349 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a

[GitHub] WillemJiang commented on issue #185: [SCB-245]: add acceptance test for dubbo demo

2018-05-13 Thread GitBox
WillemJiang commented on issue #185: [SCB-245]: add acceptance test for dubbo demo URL: https://github.com/apache/incubator-servicecomb-saga/pull/185#issuecomment-388609597 @wuzunqian yeah, you r right. In this way we can run the test by using mvn clean install.

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-12 Thread GitBox
zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388599489 @wujimin failed by 'ExecutionException Error occurred in starting fork, check output in log', and I do not change

[GitHub] zhengyangyong closed pull request #693: [SCB-548] support gracefully shutdown

2018-05-12 Thread GitBox
zhengyangyong closed pull request #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] zhengyangyong opened a new pull request #693: [SCB-548] support gracefully shutdown

2018-05-12 Thread GitBox
zhengyangyong opened a new pull request #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution

[GitHub] coveralls commented on issue #188: [SCB-569] Add document for enabling SSL

2018-05-13 Thread GitBox
coveralls commented on issue #188: [SCB-569] Add document for enabling SSL URL: https://github.com/apache/incubator-servicecomb-saga/pull/188#issuecomment-387934521 [![Coverage Status](https://coveralls.io/builds/16956328/badge)](https://coveralls.io/builds/16956328) Coverage

[GitHub] wuzunqian commented on issue #185: [SCB-245]: add acceptance test for dubbo demo

2018-05-13 Thread GitBox
wuzunqian commented on issue #185: [SCB-245]: add acceptance test for dubbo demo URL: https://github.com/apache/incubator-servicecomb-saga/pull/185#issuecomment-388605896 I think It's same with acceptance-pack? This is an

[GitHub] coveralls commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-13 Thread GitBox
coveralls commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-387664923 [![Coverage Status](https://coveralls.io/builds/16956713/badge)](https://coveralls.io/builds/16956713)

[GitHub] WillemJiang commented on a change in pull request #699: [SCB-532] Support recursive dependency

2018-05-11 Thread GitBox
WillemJiang commented on a change in pull request #699: [SCB-532] Support recursive dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/699#discussion_r187755264 ## File path:

[GitHub] WillemJiang commented on a change in pull request #699: [SCB-532] Support recursive dependency

2018-05-11 Thread GitBox
WillemJiang commented on a change in pull request #699: [SCB-532] Support recursive dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/699#discussion_r187755431 ## File path:

[GitHub] liubao68 commented on a change in pull request #693: [SCB-548] support gracefully shutdown

2018-05-13 Thread GitBox
liubao68 commented on a change in pull request #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#discussion_r187825075 ## File path:

[GitHub] liubao68 commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-13 Thread GitBox
liubao68 commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388681843 @wujimin ShutdownHookHandler is not so good, sometimes will block shutdown process cause of wrong statistics,

[GitHub] liubao68 commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-13 Thread GitBox
liubao68 commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388681843 @wujimin ShutdownHookHandler is not so good, sometimes will block shutdown process cause of wrong statistics,

[GitHub] wujimin commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-13 Thread GitBox
wujimin commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388683495 in performance test, ShutdownHookHandler will always block shutdown process for many seconds (wait for timeout for wrong

[GitHub] coveralls commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-11 Thread GitBox
coveralls commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-387664923 [![Coverage Status](https://coveralls.io/builds/16935269/badge)](https://coveralls.io/builds/16935269)

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-11 Thread GitBox
zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388301667 improve gracefully shutdown process order ```java private void gracefullyShutdown() { //Step 1:

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-11 Thread GitBox
zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388286655 Rebase on latest master This is an automated

[GitHub] liubao68 closed pull request #698: [SCB-546] bug fix

2018-05-10 Thread GitBox
liubao68 closed pull request #698: [SCB-546] bug fix URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/698 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] liubao68 commented on a change in pull request #698: [SCB-546] bug fix

2018-05-10 Thread GitBox
liubao68 commented on a change in pull request #698: [SCB-546] bug fix URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/698#discussion_r187506459 ## File path:

[GitHub] codecov-io commented on issue #348: SCB-491 Add the Test Schema Feature

2018-05-10 Thread GitBox
codecov-io commented on issue #348: SCB-491 Add the Test Schema Feature URL: https://github.com/apache/incubator-servicecomb-service-center/pull/348#issuecomment-388149405 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/348?src=pr=h1) Report >

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-11 Thread GitBox
zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388278489 I had used a Semaphore in order to sync all invocation had finished.now gracefully shutdown had fixed below :

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-11 Thread GitBox
zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388278489 I had used a Semaphore in order to sync all invocation had finished.now gracefully shutdown had fixed below order

[GitHub] liubao68 closed pull request #648: [SCB-482] Http2 support for java-chassis

2018-05-10 Thread GitBox
liubao68 closed pull request #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] WillemJiang commented on issue #190: SCB-573 Split the docker-compose file for debugging easily

2018-05-10 Thread GitBox
WillemJiang commented on issue #190: SCB-573 Split the docker-compose file for debugging easily URL: https://github.com/apache/incubator-servicecomb-saga/pull/190#issuecomment-388245364 @zhanglongchun Thanks for the PR, do you mind updated the document for the new added two options?

[GitHub] coveralls commented on issue #190: SCB-573 Split the docker-compose file for debugging easily

2018-05-10 Thread GitBox
coveralls commented on issue #190: SCB-573 Split the docker-compose file for debugging easily URL: https://github.com/apache/incubator-servicecomb-saga/pull/190#issuecomment-388244167 [![Coverage

[GitHub] zhanglongchun opened a new pull request #190: SCB-573 Split the docker-compose file for debugging easily

2018-05-10 Thread GitBox
zhanglongchun opened a new pull request #190: SCB-573 Split the docker-compose file for debugging easily URL: https://github.com/apache/incubator-servicecomb-saga/pull/190 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a

[GitHub] wujimin opened a new pull request #699: [SCB-532] Support recursive dependency

2018-05-11 Thread GitBox
wujimin opened a new pull request #699: [SCB-532] Support recursive dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/699 support create recursive dependency class ``` 1. class A { A a; } 2. class A { B b; } class B { A a;

[GitHub] coveralls commented on issue #699: [SCB-532] Support recursive dependency

2018-05-11 Thread GitBox
coveralls commented on issue #699: [SCB-532] Support recursive dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/699#issuecomment-388288890 [![Coverage Status](https://coveralls.io/builds/16934947/badge)](https://coveralls.io/builds/16934947)

[GitHub] little-cui closed pull request #348: SCB-491 Add the Test Schema Feature

2018-05-11 Thread GitBox
little-cui closed pull request #348: SCB-491 Add the Test Schema Feature URL: https://github.com/apache/incubator-servicecomb-service-center/pull/348 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] coveralls commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-11 Thread GitBox
coveralls commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-387664923 [![Coverage Status](https://coveralls.io/builds/16934683/badge)](https://coveralls.io/builds/16934683)

[GitHub] codecov-io commented on issue #348: SCB-491 Add the Test Schema Feature

2018-05-10 Thread GitBox
codecov-io commented on issue #348: SCB-491 Add the Test Schema Feature URL: https://github.com/apache/incubator-servicecomb-service-center/pull/348#issuecomment-388149405 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/348?src=pr=h1) Report >

[GitHub] little-cui commented on a change in pull request #348: SCB-491 Add the Test Schema Feature

2018-05-10 Thread GitBox
little-cui commented on a change in pull request #348: SCB-491 Add the Test Schema Feature URL: https://github.com/apache/incubator-servicecomb-service-center/pull/348#discussion_r187499074 ## File path: frontend/schema/schemahandler.go ## @@ -36,8 +36,7 @@ func

[GitHub] little-cui commented on a change in pull request #348: SCB-491 Add the Test Schema Feature

2018-05-10 Thread GitBox
little-cui commented on a change in pull request #348: SCB-491 Add the Test Schema Feature URL: https://github.com/apache/incubator-servicecomb-service-center/pull/348#discussion_r187500146 ## File path: frontend/app/scripts/modules/serviceCenter/controllers/schemaCtrl.js

[GitHub] wujimin commented on a change in pull request #698: [SCB-546] bug fix

2018-05-10 Thread GitBox
wujimin commented on a change in pull request #698: [SCB-546] bug fix URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/698#discussion_r187500931 ## File path:

[GitHub] little-cui closed pull request #347: SCB-572 Can not convert error to status code

2018-05-10 Thread GitBox
little-cui closed pull request #347: SCB-572 Can not convert error to status code URL: https://github.com/apache/incubator-servicecomb-service-center/pull/347 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] coveralls commented on issue #343: SCB-561 Support ipv6

2018-05-08 Thread GitBox
coveralls commented on issue #343: SCB-561 Support ipv6 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/343#issuecomment-387397571 [![Coverage Status](https://coveralls.io/builds/16883841/badge)](https://coveralls.io/builds/16883841) Coverage decreased

[GitHub] zhengyangyong opened a new pull request #693: [SCB-548] support gracefully shutdown

2018-05-08 Thread GitBox
zhengyangyong opened a new pull request #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution

[GitHub] coveralls commented on issue #343: SCB-561 Support ipv6

2018-05-08 Thread GitBox
coveralls commented on issue #343: SCB-561 Support ipv6 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/343#issuecomment-387397571 [![Coverage Status](https://coveralls.io/builds/16883745/badge)](https://coveralls.io/builds/16883745) Coverage increased

[GitHub] codecov-io commented on issue #343: SCB-561 Support ipv6

2018-05-08 Thread GitBox
codecov-io commented on issue #343: SCB-561 Support ipv6 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/343#issuecomment-387397666 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/343?src=pr=h1) Report > Merging

[GitHub] little-cui opened a new pull request #343: SCB-561 Support ipv6

2018-05-08 Thread GitBox
little-cui opened a new pull request #343: SCB-561 Support ipv6 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/343 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[GitHub] codecov-io commented on issue #343: SCB-561 Support ipv6

2018-05-08 Thread GitBox
codecov-io commented on issue #343: SCB-561 Support ipv6 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/343#issuecomment-387397666 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/343?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #343: SCB-561 Support ipv6

2018-05-08 Thread GitBox
codecov-io commented on issue #343: SCB-561 Support ipv6 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/343#issuecomment-387397666 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/343?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #343: SCB-561 Support ipv6

2018-05-08 Thread GitBox
codecov-io commented on issue #343: SCB-561 Support ipv6 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/343#issuecomment-387397666 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/343?src=pr=h1) Report > Merging

[GitHub] coveralls commented on issue #343: SCB-561 Support ipv6

2018-05-08 Thread GitBox
coveralls commented on issue #343: SCB-561 Support ipv6 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/343#issuecomment-387397571 [![Coverage Status](https://coveralls.io/builds/16883914/badge)](https://coveralls.io/builds/16883914) Coverage decreased

[GitHub] liubao68 commented on issue #295: request.getinputstream获取不到request body

2018-05-08 Thread GitBox
liubao68 commented on issue #295: request.getinputstream获取不到request body URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/295#issuecomment-387374046 ServiceComb-java-chassis不是j2EE的实现,和Servlet的有关的内容还是会有差异的,这里介绍了一些差异:

[GitHub] zhengyangyong commented on a change in pull request #77: Add Notes for providers and fix FAQ mistakes

2018-05-06 Thread GitBox
zhengyangyong commented on a change in pull request #77: Add Notes for providers and fix FAQ mistakes URL: https://github.com/apache/incubator-servicecomb-website/pull/77#discussion_r186284441 ## File path: _users/develop-with-transparent-rpc.md ## @@ -122,6 +129,10 @@

[GitHub] zhengyangyong opened a new pull request #77: Add Notes for providers and fix FAQ mistakes

2018-05-04 Thread GitBox
zhengyangyong opened a new pull request #77: Add Notes for providers and fix FAQ mistakes URL: https://github.com/apache/incubator-servicecomb-website/pull/77 Signed-off-by: zhengyangyong 在编程模型文档中增加注意事项说明,并且修复FAQ中这方面错误的说法。

[GitHub] zhengyangyong opened a new pull request #76: Add Notes for providers and fix FAQ mistakes

2018-05-04 Thread GitBox
zhengyangyong opened a new pull request #76: Add Notes for providers and fix FAQ mistakes URL: https://github.com/apache/incubator-servicecomb-website/pull/76 在编程模型文档中增加注意事项说明,并且修复FAQ中这方面错误的说法。 This is an automated message

[GitHub] wenj91 commented on issue #182: ERROR: value too long for type character varying(16)

2018-05-04 Thread GitBox
wenj91 commented on issue #182: ERROR: value too long for type character varying(16) URL: https://github.com/apache/incubator-servicecomb-saga/issues/182#issuecomment-386572542 this file is 16

[GitHub] wenj91 commented on issue #182: ERROR: value too long for type character varying(16)

2018-05-04 Thread GitBox
wenj91 commented on issue #182: ERROR: value too long for type character varying(16) URL: https://github.com/apache/incubator-servicecomb-saga/issues/182#issuecomment-386613188 sure, i will do it tonight This is an

[GitHub] xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-04 Thread GitBox
xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186032008 ## File path:

[GitHub] WillemJiang commented on a change in pull request #77: Add Notes for providers and fix FAQ mistakes

2018-05-04 Thread GitBox
WillemJiang commented on a change in pull request #77: Add Notes for providers and fix FAQ mistakes URL: https://github.com/apache/incubator-servicecomb-website/pull/77#discussion_r186083950 ## File path: _users/cn/develop-with-transparent-rpc.md ## @@ -130,6 +137,10 @@

[GitHub] wenj91 commented on issue #179: Wenj91 saga branch test

2018-05-04 Thread GitBox
wenj91 commented on issue #179: Wenj91 saga branch test URL: https://github.com/apache/incubator-servicecomb-saga/pull/179#issuecomment-386627170 感谢,这个分支我已经看过了,我自己也调整了自己的代码,现在测试暂时没什么大问题 This is an automated message from the

[GitHub] WillemJiang commented on issue #76: JDK9 not supported when unit testing while doc showing JDK8+

2018-04-30 Thread GitBox
WillemJiang commented on issue #76: JDK9 not supported when unit testing while doc showing JDK8+ URL: https://github.com/apache/incubator-servicecomb-saga/issues/76#issuecomment-385546343 @kenail2002 Now you can use -Pspring-boot-2 to build the Application with Spring Boot2. Do you

[GitHub] WillemJiang commented on issue #177: saga support dubbo or not?

2018-04-30 Thread GitBox
WillemJiang commented on issue #177: saga support dubbo or not? URL: https://github.com/apache/incubator-servicecomb-saga/issues/177#issuecomment-385545823 You need to make sure the omega context is rightly inject into dubbo invocation, you can find the some examples

[GitHub] WillemJiang opened a new pull request #178: SCB-20 Build ServiceComb-Saga with Java

2018-05-02 Thread GitBox
WillemJiang opened a new pull request #178: SCB-20 Build ServiceComb-Saga with Java URL: https://github.com/apache/incubator-servicecomb-saga/pull/178 Now Saga can build with Java9 by using the spring-boot-2 profile. This is

<    1   2   3   4   5   6   7   8   9   10   >