[GitHub] wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r159656429 ## File path: pom.xml ## @@ -264,5 +264,11 @@ +

[GitHub] wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r159656724 ## File path: service-registry/src/test/java/io/servicecomb/serviceregistry/api/re

[GitHub] wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r159656972 ## File path: service-registry/src/test/java/io/servicecomb/serviceregistry/api/re

[GitHub] wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r159657096 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistry/api/re

[GitHub] wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r159657536 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistry/api/re

[GitHub] wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r159657898 ## File path: service-registry/src/test/java/io/servicecomb/serviceregistry/api/re

[GitHub] wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r159661862 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistry/api/Co

[GitHub] wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r159657536 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistry/api/re

[GitHub] wujimin commented on issue #460: [JAV-566] report type/version when register to SC

2018-01-04 Thread GitBox
wujimin commented on issue #460: [JAV-566] report type/version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#issuecomment-355354274 maybe this is simpler and not depend on jackson Deprecated method: ``` org.apache.mav

[GitHub] WillemJiang closed pull request #100: [SCB-100] async support

2018-01-04 Thread GitBox
WillemJiang closed pull request #100: [SCB-100] async support URL: https://github.com/apache/incubator-servicecomb-saga/pull/100 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] WillemJiang commented on a change in pull request #100: [SCB-100] async support

2018-01-04 Thread GitBox
WillemJiang commented on a change in pull request #100: [SCB-100] async support URL: https://github.com/apache/incubator-servicecomb-saga/pull/100#discussion_r159793996 ## File path: omega/omega-spring-tx/src/main/java/org/apache/servicecomb/saga/omega/transaction/spring/ExecutorFi

[GitHub] WillemJiang commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
WillemJiang commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r159589113 ## File path: metrics/metrics-extension/metrics-write-file/src/main/

[GitHub] WillemJiang commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
WillemJiang commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r15954 ## File path: metrics/metrics-extension/metrics-write-file/src/main/

[GitHub] WillemJiang commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
WillemJiang commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r159589512 ## File path: samples/metrics-write-file-sample/metrics-write-file-lo

[GitHub] WillemJiang commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
WillemJiang commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r159589366 ## File path: samples/metrics-write-file-sample/metrics-write-file-l

[GitHub] WillemJiang commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
WillemJiang commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r159589006 ## File path: metrics/metrics-extension/metrics-write-file/src/main/

[GitHub] zhengyangyong opened a new pull request #24: [SCB-132] Metrics MD

2018-01-04 Thread GitBox
zhengyangyong opened a new pull request #24: [SCB-132] Metrics MD URL: https://github.com/apache/incubator-servicecomb-website/pull/24 add en version and sync cn version This is an automated message from the Apache Git Service

[GitHub] wujimin commented on a change in pull request #482: JAV-579 support dataStrArray

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #482: JAV-579 support dataStrArray URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/482#discussion_r159804420 ## File path: common/common-rest/src/main/java/io/servicecomb/common/rest/codec/param/QueryProcessorCrea

[GitHub] wujimin commented on a change in pull request #482: JAV-579 support dataStrArray

2018-01-04 Thread GitBox
wujimin commented on a change in pull request #482: JAV-579 support dataStrArray URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/482#discussion_r159804420 ## File path: common/common-rest/src/main/java/io/servicecomb/common/rest/codec/param/QueryProcessorCrea

[GitHub] WillemJiang opened a new pull request #102: SCB-157 Updated the pom setting for apache release

2018-01-04 Thread GitBox
WillemJiang opened a new pull request #102: SCB-157 Updated the pom setting for apache release URL: https://github.com/apache/incubator-servicecomb-saga/pull/102 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA iss

[GitHub] coveralls commented on issue #102: SCB-157 Updated the pom setting for apache release

2018-01-04 Thread GitBox
coveralls commented on issue #102: SCB-157 Updated the pom setting for apache release URL: https://github.com/apache/incubator-servicecomb-saga/pull/102#issuecomment-355468256 [![Coverage Status](https://coveralls.io/builds/14911229/badge)](https://coveralls.io/builds/14911229)

[GitHub] zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r159815856 ## File path: metrics/metrics-extension/metrics-write-file/src/mai

[GitHub] zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r159816044 ## File path: metrics/metrics-extension/metrics-write-file/src/mai

[GitHub] zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r159816060 ## File path: samples/metrics-write-file-sample/metrics-write-file

[GitHub] zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r159816095 ## File path: samples/metrics-write-file-sample/metrics-write-file-

[GitHub] zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r159816054 ## File path: metrics/metrics-extension/metrics-write-file/src/mai

[GitHub] coveralls commented on issue #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1

2018-01-04 Thread GitBox
coveralls commented on issue #476: [SCB-85] Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#issuecomment-355486600 [![Coverage Status](https://coveralls.io/builds/14912349/badge)](https://coveralls.io/builds

[GitHub] seanyinx opened a new pull request #103: [SCB-167] proper connection & disconnection

2018-01-04 Thread GitBox
seanyinx opened a new pull request #103: [SCB-167] proper connection & disconnection URL: https://github.com/apache/incubator-servicecomb-saga/pull/103 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https:

[GitHub] seanyinx commented on issue #103: [SCB-167] proper connection & disconnection

2018-01-04 Thread GitBox
seanyinx commented on issue #103: [SCB-167] proper connection & disconnection URL: https://github.com/apache/incubator-servicecomb-saga/pull/103#issuecomment-355490972 @eric-lee-ltk please review This is an automated message

[GitHub] coveralls commented on issue #486: [SCB-165] Service registry not given proper instances

2018-01-04 Thread GitBox
coveralls commented on issue #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#issuecomment-355492490 [![Coverage Status](https://coveralls.io/builds/14912718/badge)](https://coveralls.io/builds/14912

[GitHub] coveralls commented on issue #103: [SCB-167] proper connection & disconnection

2018-01-04 Thread GitBox
coveralls commented on issue #103: [SCB-167] proper connection & disconnection URL: https://github.com/apache/incubator-servicecomb-saga/pull/103#issuecomment-355492518 [![Coverage Status](https://coveralls.io/builds/14912699/badge)](https://coveralls.io/builds/14912699) Coverag

[GitHub] little-cui opened a new pull request #243: SCB-181 Unused instance index key is stored in backend.

2018-01-04 Thread GitBox
little-cui opened a new pull request #243: SCB-181 Unused instance index key is stored in backend. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/243 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there i

[GitHub] yangbor opened a new pull request #488: [SCB-172] upgrade zipkin libraries to zipkin2

2018-01-05 Thread GitBox
yangbor opened a new pull request #488: [SCB-172] upgrade zipkin libraries to zipkin2 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/488 Upgraded zipkin to zipkin2:2.4.2 and zipkin-reporter to zipkin-reporter2:2.2.2. The zipkin2.Span changed a lot from the old zi

[GitHub] lijasonvip opened a new pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

2018-01-05 Thread GitBox
lijasonvip opened a new pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489 ?Apollo. Signed-off-by: lijasonvip Follow this checklist to help us incorporate y

[GitHub] codecov-io commented on issue #243: SCB-181 Unused instance index key is stored in backend.

2018-01-05 Thread GitBox
codecov-io commented on issue #243: SCB-181 Unused instance index key is stored in backend. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/243#issuecomment-355497057 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/243?src=pr&el=

[GitHub] coveralls commented on issue #243: SCB-181 Unused instance index key is stored in backend.

2018-01-05 Thread GitBox
coveralls commented on issue #243: SCB-181 Unused instance index key is stored in backend. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/243#issuecomment-355496987 [![Coverage Status](https://coveralls.io/builds/14912937/badge)](https://coveralls.io/builds/1

[GitHub] little-cui closed pull request #243: SCB-181 Unused instance index key is stored in backend.

2018-01-05 Thread GitBox
little-cui closed pull request #243: SCB-181 Unused instance index key is stored in backend. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/243 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] eric-lee-ltk commented on issue #103: [SCB-167] proper connection & disconnection

2018-01-05 Thread GitBox
eric-lee-ltk commented on issue #103: [SCB-167] proper connection & disconnection URL: https://github.com/apache/incubator-servicecomb-saga/pull/103#issuecomment-355498726 LGTM This is an automated message from the Apache Gi

[GitHub] coveralls commented on issue #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

2018-01-05 Thread GitBox
coveralls commented on issue #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#issuecomment-355499238 [![Coverage Status](https://coveralls.io/builds/14913037/badge)](https://co

[GitHub] WillemJiang closed pull request #103: [SCB-167] proper connection & disconnection

2018-01-05 Thread GitBox
WillemJiang closed pull request #103: [SCB-167] proper connection & disconnection URL: https://github.com/apache/incubator-servicecomb-saga/pull/103 This is an automated message from the Apache Git Service. To respond to the

[GitHub] WillemJiang commented on issue #488: [SCB-172] upgrade zipkin libraries to zipkin2

2018-01-05 Thread GitBox
WillemJiang commented on issue #488: [SCB-172] upgrade zipkin libraries to zipkin2 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/488#issuecomment-355502907 @yangbor ZipkinTracingIntegrationTest is failed, can you double check it? -

[GitHub] WillemJiang commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

2018-01-05 Thread GitBox
WillemJiang commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r159831078 ## File path: metrics/metrics-core/src/main/java/io/servicecomb/metrics/core/health/Defaul

[GitHub] WillemJiang commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

2018-01-05 Thread GitBox
WillemJiang commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r159831312 ## File path: samples/metrics-extend-healthcheck/pom.xml ## @@ -0,0 +1,53 @@ + +

[GitHub] WillemJiang commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

2018-01-05 Thread GitBox
WillemJiang commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r159831628 ## File path: samples/metrics-extend-healthcheck/src/main/java/io/servicecomb/samples/metr

[GitHub] WillemJiang commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

2018-01-05 Thread GitBox
WillemJiang commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r159831873 ## File path: samples/metrics-extend-healthcheck/src/main/java/io/servicecomb/samples/metr

[GitHub] WillemJiang commented on a change in pull request #486: [SCB-165] Service registry not given proper instances

2018-01-05 Thread GitBox
WillemJiang commented on a change in pull request #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#discussion_r159832477 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistr

[GitHub] WillemJiang commented on a change in pull request #486: [SCB-165] Service registry not given proper instances

2018-01-05 Thread GitBox
WillemJiang commented on a change in pull request #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#discussion_r159832305 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistr

[GitHub] WillemJiang commented on a change in pull request #486: [SCB-165] Service registry not given proper instances

2018-01-05 Thread GitBox
WillemJiang commented on a change in pull request #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#discussion_r159832585 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistr

[GitHub] little-cui opened a new pull request #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function.

2018-01-05 Thread GitBox
little-cui opened a new pull request #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/244 (cherry picked from commit 894c251) Follow this checkl

[GitHub] WillemJiang commented on issue #485: [SCB-176] Generate traceId

2018-01-05 Thread GitBox
WillemJiang commented on issue #485: [SCB-176] Generate traceId URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/485#issuecomment-355508581 Just a quick question, what's the relationship between this change and the old zipkin tracing code. AFAIK, ZipkinTracingHand

[GitHub] codecov-io commented on issue #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function.

2018-01-05 Thread GitBox
codecov-io commented on issue #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/244#issuecomment-355509350 # [Codecov](https://codecov.io/gh/apache/incubator-

[GitHub] coveralls commented on issue #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function.

2018-01-05 Thread GitBox
coveralls commented on issue #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/244#issuecomment-355509456 [![Coverage Status](https://coveralls.io/builds/

[GitHub] coveralls commented on issue #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function.

2018-01-05 Thread GitBox
coveralls commented on issue #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/244#issuecomment-355512610 [![Coverage Status](https://coveralls.io/builds/

[GitHub] codecov-io commented on issue #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function.

2018-01-05 Thread GitBox
codecov-io commented on issue #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/244#issuecomment-355509350 # [Codecov](https://codecov.io/gh/apache/incubator-

[GitHub] little-cui closed pull request #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function.

2018-01-05 Thread GitBox
little-cui closed pull request #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/244 This is a PR merged from a forked repository. As GitHub hides the origina

[GitHub] mojieshui opened a new pull request #490: [SCB-180] Hystrixcommand setter not set by dynamic configuration

2018-01-05 Thread GitBox
mojieshui opened a new pull request #490: [SCB-180] Hystrixcommand setter not set by dynamic configuration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/490 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure t

[GitHub] mojieshui commented on issue #490: [SCB-180] Hystrixcommand setter not set by dynamic configuration

2018-01-05 Thread GitBox
mojieshui commented on issue #490: [SCB-180] Hystrixcommand setter not set by dynamic configuration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/490#issuecomment-355513038 @wujimin @liubao68 @WillemJiang --

[GitHub] seanyinx closed pull request #102: SCB-157 Updated the pom setting for apache release

2018-01-05 Thread GitBox
seanyinx closed pull request #102: SCB-157 Updated the pom setting for apache release URL: https://github.com/apache/incubator-servicecomb-saga/pull/102 This is an automated message from the Apache Git Service. To respond to

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

2018-01-05 Thread GitBox
eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159839601 ## File path: dynamic-config/config-apollo/pom.xml

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

2018-01-05 Thread GitBox
eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159839297 ## File path: dynamic-config/config-apollo/pom.xml

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

2018-01-05 Thread GitBox
eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159842616 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

2018-01-05 Thread GitBox
eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159840446 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

2018-01-05 Thread GitBox
eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159839799 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

2018-01-05 Thread GitBox
eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159840995 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

2018-01-05 Thread GitBox
eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159840126 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

2018-01-05 Thread GitBox
eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159842886 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

2018-01-05 Thread GitBox
eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159841366 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

2018-01-05 Thread GitBox
eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159839958 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

2018-01-05 Thread GitBox
eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159841081 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

2018-01-05 Thread GitBox
eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159843224 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

2018-01-05 Thread GitBox
eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159842972 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] seanyinx opened a new pull request #104: [SCB-183] callback cleanup on connection loss

2018-01-05 Thread GitBox
seanyinx opened a new pull request #104: [SCB-183] callback cleanup on connection loss URL: https://github.com/apache/incubator-servicecomb-saga/pull/104 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](http

[GitHub] coveralls commented on issue #104: [SCB-183] callback cleanup on connection loss

2018-01-05 Thread GitBox
coveralls commented on issue #104: [SCB-183] callback cleanup on connection loss URL: https://github.com/apache/incubator-servicecomb-saga/pull/104#issuecomment-355527143 [![Coverage Status](https://coveralls.io/builds/14914608/badge)](https://coveralls.io/builds/14914608) Cover

[GitHub] coveralls commented on issue #488: [SCB-172] upgrade zipkin libraries to zipkin2

2018-01-05 Thread GitBox
coveralls commented on issue #488: [SCB-172] upgrade zipkin libraries to zipkin2 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/488#issuecomment-355528157 [![Coverage Status](https://coveralls.io/builds/14914717/badge)](https://coveralls.io/builds/14914717)

[GitHub] yangbor commented on issue #488: [SCB-172] upgrade zipkin libraries to zipkin2

2018-01-05 Thread GitBox
yangbor commented on issue #488: [SCB-172] upgrade zipkin libraries to zipkin2 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/488#issuecomment-355528416 @WillemJiang The integration test is fixed. This

[GitHub] acsukesh opened a new pull request #491: SCB-179 support -(java identifiers) as parameter name with RequestParam

2018-01-05 Thread GitBox
acsukesh opened a new pull request #491: SCB-179 support -(java identifiers) as parameter name with RequestParam URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/491 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make

[GitHub] coveralls commented on issue #491: SCB-179 support -(java identifiers) as parameter name with RequestParam

2018-01-05 Thread GitBox
coveralls commented on issue #491: SCB-179 support -(java identifiers) as parameter name with RequestParam URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/491#issuecomment-355543306 [![Coverage Status](https://coveralls.io/builds/14915693/badge)](https://coveral

[GitHub] liubao68 commented on a change in pull request #486: [SCB-165] Service registry not given proper instances

2018-01-05 Thread GitBox
liubao68 commented on a change in pull request #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#discussion_r159877061 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistry/c

[GitHub] liubao68 commented on a change in pull request #486: [SCB-165] Service registry not given proper instances

2018-01-05 Thread GitBox
liubao68 commented on a change in pull request #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#discussion_r159877164 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistry/c

[GitHub] liubao68 commented on a change in pull request #486: [SCB-165] Service registry not given proper instances

2018-01-05 Thread GitBox
liubao68 commented on a change in pull request #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#discussion_r159877427 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistry/c

[GitHub] liubao68 commented on a change in pull request #486: [SCB-165] Service registry not given proper instances

2018-01-05 Thread GitBox
liubao68 commented on a change in pull request #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#discussion_r159877061 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistry/c

[GitHub] wujimin commented on issue #485: [SCB-176] Generate traceId

2018-01-05 Thread GitBox
wujimin commented on issue #485: [SCB-176] Generate traceId URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/485#issuecomment-355711634 we always generate traceId, trace solution will based on this please ensure zipkin no problem, then i will approve this PR ---

[GitHub] liubao68 opened a new pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

2018-01-05 Thread GitBox
liubao68 opened a new pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492 Follow this checklist to help us incorporate your contribution quickly and easily

[GitHub] liubao68 commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

2018-01-05 Thread GitBox
liubao68 commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r160013520 ## File path: metrics/metrics-common/src/main/java/io/servicecomb/metrics/common/HealthCheckR

[GitHub] coveralls commented on issue #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

2018-01-05 Thread GitBox
coveralls commented on issue #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#issuecomment-355718284 [![Coverage Status](https://coveralls.io/builds/14926816/badge)](ht

[GitHub] wujimin commented on a change in pull request #482: JAV-579 support dataStrArray

2018-01-05 Thread GitBox
wujimin commented on a change in pull request #482: JAV-579 support dataStrArray URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/482#discussion_r160015868 ## File path: swagger/swagger-generator/generator-core/src/main/java/io/servicecomb/swagger/extend/annot

[GitHub] zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

2018-01-05 Thread GitBox
zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r160016073 ## File path: metrics/metrics-core/src/main/java/io/servicecomb/metrics/core/health/Defa

[GitHub] zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

2018-01-05 Thread GitBox
zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r160016085 ## File path: samples/metrics-extend-healthcheck/pom.xml ## @@ -0,0 +1,53 @@ +

[GitHub] zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

2018-01-05 Thread GitBox
zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r160016112 ## File path: samples/metrics-extend-healthcheck/src/main/java/io/servicecomb/samples/me

[GitHub] zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

2018-01-05 Thread GitBox
zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r160016106 ## File path: samples/metrics-extend-healthcheck/src/main/java/io/servicecomb/samples/me

[GitHub] zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

2018-01-05 Thread GitBox
zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r160016136 ## File path: metrics/metrics-common/src/main/java/io/servicecomb/metrics/common/HealthC

[GitHub] coveralls commented on issue #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

2018-01-05 Thread GitBox
coveralls commented on issue #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#issuecomment-355721880 [![Coverage Status](https://coveralls.io/builds/14927276/badge)](ht

[GitHub] coveralls commented on issue #487: [SCB-166] Metrics Support HealthCheck

2018-01-05 Thread GitBox
coveralls commented on issue #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#issuecomment-355722095 [![Coverage Status](https://coveralls.io/builds/14927359/badge)](https://coveralls.io/builds/14927359) Cover

[GitHub] coveralls commented on issue #490: [SCB-180] Hystrixcommand setter not set by dynamic configuration

2018-01-05 Thread GitBox
coveralls commented on issue #490: [SCB-180] Hystrixcommand setter not set by dynamic configuration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/490#issuecomment-355727974 [![Coverage Status](https://coveralls.io/builds/14928000/badge)](https://coveralls.io/b

[GitHub] WillemJiang closed pull request #104: [SCB-183] callback cleanup on connection loss

2018-01-06 Thread GitBox
WillemJiang closed pull request #104: [SCB-183] callback cleanup on connection loss URL: https://github.com/apache/incubator-servicecomb-saga/pull/104 This is an automated message from the Apache Git Service. To respond to t

[GitHub] coveralls commented on issue #490: [SCB-180] Hystrixcommand setter not set by dynamic configuration

2018-01-06 Thread GitBox
coveralls commented on issue #490: [SCB-180] Hystrixcommand setter not set by dynamic configuration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/490#issuecomment-355735442 [![Coverage Status](https://coveralls.io/builds/14928625/badge)](https://coveralls.io/b

[GitHub] eric-lee-ltk opened a new pull request #105: SCB-174 add kryo serializer

2018-01-06 Thread GitBox
eric-lee-ltk opened a new pull request #105: SCB-174 add kryo serializer URL: https://github.com/apache/incubator-servicecomb-saga/pull/105 Signed-off-by: Eric Lee Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [

[GitHub] coveralls commented on issue #105: SCB-174 add kryo serializer

2018-01-06 Thread GitBox
coveralls commented on issue #105: SCB-174 add kryo serializer URL: https://github.com/apache/incubator-servicecomb-saga/pull/105#issuecomment-355741676 [![Coverage Status](https://coveralls.io/builds/14929173/badge)](https://coveralls.io/builds/14929173) Coverage increased (+0.

[GitHub] WillemJiang commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

2018-01-06 Thread GitBox
WillemJiang commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#discussion_r160025475 ## File path: spring-boot-starter/spring-bo

[GitHub] WillemJiang commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

2018-01-06 Thread GitBox
WillemJiang commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#discussion_r160025526 ## File path: spring-boot-starter/spring-bo

<    2   3   4   5   6   7   8   9   10   11   >