[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-12 Thread GitBox
zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388599489 @wujimin failed by 'ExecutionException Error occurred in starting fork, check output in log', and I do not change

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-11 Thread GitBox
zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388301667 improve gracefully shutdown process order ```java private void gracefullyShutdown() { //Step 1:

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-11 Thread GitBox
zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388286655 Rebase on latest master This is an automated

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-11 Thread GitBox
zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388278489 I had used a Semaphore in order to sync all invocation had finished.now gracefully shutdown had fixed below order

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-11 Thread GitBox
zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388278489 I had used a Semaphore in order to sync all invocation had finished.now gracefully shutdown had fixed below :

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-08 Thread GitBox
zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-387588768 Springmvc it test failed because we had fully shutdown and re-init seems do not init transport again,I will try