[GitHub] maxiaoguang64 commented on issue #1756: INSERT ON DUPLICATE KEY UPDATE with dynamic parameters

maxiaoguang64 commented on issue #1756: INSERT ON DUPLICATE KEY UPDATE with dynamic parameters URL: https://github.com/apache/incubator-shardingsphere/issues/1756#issuecomment-454680689 sorry, we think about it carefully and get back to you later.

[GitHub] cherrylzhao commented on issue #1694: Refactor design of sharding transaction 2PC XA

cherrylzhao commented on issue #1694: Refactor design of sharding transaction 2PC XA URL: https://github.com/apache/incubator-shardingsphere/issues/1694#issuecomment-454670244 hi, zhfeng >Why does it introduce the SingleXAResource ? >Why does it need the enlistResource method ?

[GitHub] joooohnli commented on issue #1756: INSERT ON DUPLICATE KEY UPDATE with dynamic parameters

jhnli commented on issue #1756: INSERT ON DUPLICATE KEY UPDATE with dynamic parameters URL: https://github.com/apache/incubator-shardingsphere/issues/1756#issuecomment-454669936 I'v read all related issues and your explanation and I think it's a little arbitrary to mark them **won't

[GitHub] maxiaoguang64 commented on issue #1756: INSERT ON DUPLICATE KEY UPDATE with dynamic parameters

maxiaoguang64 commented on issue #1756: INSERT ON DUPLICATE KEY UPDATE with dynamic parameters URL: https://github.com/apache/incubator-shardingsphere/issues/1756#issuecomment-454667028 [please see 1066](https://github.com/apache/incubator-shardingsphere/issues/1066)

[GitHub] zhfeng commented on issue #1694: Refactor design of sharding transaction 2PC XA

zhfeng commented on issue #1694: Refactor design of sharding transaction 2PC XA URL: https://github.com/apache/incubator-shardingsphere/issues/1694#issuecomment-454666844 Thanks @cherrylzhao and I will take a look. For the SPI, I have the following questions: 1. Why does it

[GitHub] terrymanu merged pull request #1761: for checkstyle

terrymanu merged pull request #1761: for checkstyle URL: https://github.com/apache/incubator-shardingsphere/pull/1761 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@shardingsphere.apache.org

[GitHub] tuohai666 commented on issue #1741: DatabaseMetaData's getTables didn't return the data

tuohai666 commented on issue #1741: DatabaseMetaData's getTables didn't return the data URL: https://github.com/apache/incubator-shardingsphere/issues/1741#issuecomment-454650417 I'll check later. This is an automated

[GitHub] tuohai666 opened a new pull request #1761: for checkstyle

tuohai666 opened a new pull request #1761: for checkstyle URL: https://github.com/apache/incubator-shardingsphere/pull/1761 Fixes #ISSUSE_ID. Changes proposed in this pull request: - - - This is an

Re: [apache/incubator-shardingsphere] #1754 failed to get string sharding value (#1760)

Thanks for your proposal, i have checked my name in gitHub already. Juan Pan (Trista) Apache ShardingSphere Craig Russell 于2019年1月16日周三 上午11:19写道： > Can everyone in shardingsphere community please change your name in github > to include your Latin-character

Fwd: [apache/incubator-shardingsphere] #1754 failed to get string sharding value (#1760)

Can everyone in shardingsphere community please change your name in github to include your Latin-character name? Having only the Chinese name is distracting. Thanks, Craig > Begin forwarded message: > > From: 张亮 > Subject: Re: [apache/incubator-shardingsphere] #1754 failed to get string >

[GitHub] terrymanu merged pull request #1747: use pattern replace the try/catch determine database driver class

terrymanu merged pull request #1747: use pattern replace the try/catch determine database driver class URL: https://github.com/apache/incubator-shardingsphere/pull/1747 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list,

[GitHub] terrymanu merged pull request #1760: #1754 failed to get string sharding value

terrymanu merged pull request #1760: #1754 failed to get string sharding value URL: https://github.com/apache/incubator-shardingsphere/pull/1760 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@shardingsphere.apache.org

[GitHub] terrymanu merged pull request #1751: Get random data source for unicast

terrymanu merged pull request #1751: Get random data source for unicast URL: https://github.com/apache/incubator-shardingsphere/pull/1751 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@shardingsphere.apache.org

[GitHub] terrymanu merged pull request #1758: Modify table rule configuration

terrymanu merged pull request #1758: Modify table rule configuration URL: https://github.com/apache/incubator-shardingsphere/pull/1758 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@shardingsphere.apache.org

[GitHub] codefairy08 opened a new pull request #1760: #1754 failed to get string sharding value

codefairy08 opened a new pull request #1760: #1754 failed to get string sharding value URL: https://github.com/apache/incubator-shardingsphere/pull/1760 Fixes #ISSUSE_ID. Changes proposed in this pull request: - - -

[GitHub] tuohai666 edited a comment on issue #1759: The result list return wrong size when there's limit sub clause for single routing

tuohai666 edited a comment on issue #1759: The result list return wrong size when there's limit sub clause for single routing URL: https://github.com/apache/incubator-shardingsphere/issues/1759#issuecomment-454614347 Known issue. Please refer to

[GitHub] tuohai666 commented on issue #1759: The result list return wrong size when there's limit sub clause for single routing

tuohai666 commented on issue #1759: The result list return wrong size when there's limit sub clause for single routing URL: https://github.com/apache/incubator-shardingsphere/issues/1759#issuecomment-454614347 Know issue. Please refer to

[GitHub] tuohai666 closed issue #1759: The result list return wrong size when there's limit sub clause for single routing

tuohai666 closed issue #1759: The result list return wrong size when there's limit sub clause for single routing URL: https://github.com/apache/incubator-shardingsphere/issues/1759 This is an automated message from the

[GitHub] codefairy08 commented on issue #1754: can't get partition key value

codefairy08 commented on issue #1754: can't get partition key value URL: https://github.com/apache/incubator-shardingsphere/issues/1754#issuecomment-454609225 wrong initial value cause this issue This is an automated