[GitHub] [incubator-shardingsphere] fdlzp commented on issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase

2019-04-01 Thread GitBox
fdlzp commented on issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase URL: https://github.com/apache/incubator-shardingsphere/issues/2138#issuecomment-478855938 One more question. The same

[GitHub] [incubator-shardingsphere] fdlzp opened a new issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase

2019-04-01 Thread GitBox
fdlzp opened a new issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase URL: https://github.com/apache/incubator-shardingsphere/issues/2138 ![图片](https://user-images.githubusercontent.com/44960833/55270434-7ec91900-52d9-11e9-8fb5-ff1b56d3f0b7.png)

Re: [DISCUSS] ShardingSphere 4.0.0-RC1 release [ROUND 2]

2019-04-01 Thread ???? Sheng Wu
I think we need other PPMC members feedback. I am OK w/ or w/o dependency libs in sharding-jdbc binary. -- Sheng Wu Apache SkyWalking, ShardingSphere, Zipkin Twitter, wusheng1108 -- Original -- From: "apache.clr"; Date: Tue, Apr 2,

[GitHub] [incubator-shardingsphere-doc] tristaZero closed pull request #122: Performance Test Report Revision

2019-04-01 Thread GitBox
tristaZero closed pull request #122: Performance Test Report Revision URL: https://github.com/apache/incubator-shardingsphere-doc/pull/122 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere-doc] tristaZero merged pull request #125: table adjustment

2019-04-01 Thread GitBox
tristaZero merged pull request #125: table adjustment URL: https://github.com/apache/incubator-shardingsphere-doc/pull/125 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere-doc] Harper0122 opened a new pull request #125: table adjustment

2019-04-01 Thread GitBox
Harper0122 opened a new pull request #125: table adjustment URL: https://github.com/apache/incubator-shardingsphere-doc/pull/125 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2136: (mybatis + shardingjdbc ) multithreading paging query Incorrect result

2019-04-01 Thread GitBox
tuohai666 commented on issue #2136: (mybatis + shardingjdbc ) multithreading paging query Incorrect result URL: https://github.com/apache/incubator-shardingsphere/issues/2136#issuecomment-478833391 Thanks for your professional report, I am about to fix it.

[GitHub] [incubator-shardingsphere] xfyang1989 opened a new issue #2150: How to distinguish between a query statement or an updated statement in the fragmentation algorithm

2019-04-01 Thread GitBox
xfyang1989 opened a new issue #2150: How to distinguish between a query statement or an updated statement in the fragmentation algorithm URL: https://github.com/apache/incubator-shardingsphere/issues/2150 How to distinguish between a query statement or an updated statement in the

[GitHub] [incubator-shardingsphere] RaigorStonehoof commented on issue #2136: (mybatis + shardingjdbc ) multithreading paging query Incorrect result

2019-04-01 Thread GitBox
RaigorStonehoof commented on issue #2136: (mybatis + shardingjdbc ) multithreading paging query Incorrect result URL: https://github.com/apache/incubator-shardingsphere/issues/2136#issuecomment-478824784 H, I hava met the same situation. When I use a single thread to perform paging

[GitHub] [incubator-shardingsphere] neil4dong opened a new issue #2149: How about support HintShardingStrategy with other ShardingStrategy at same time?

2019-04-01 Thread GitBox
neil4dong opened a new issue #2149: How about support HintShardingStrategy with other ShardingStrategy at same time? URL: https://github.com/apache/incubator-shardingsphere/issues/2149 ## Feature Request ### Is your feature request related to a problem? I was upgrading from

[GitHub] [incubator-shardingsphere] codefairy08 commented on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column.

2019-04-01 Thread GitBox
codefairy08 commented on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column. URL: https://github.com/apache/incubator-shardingsphere/issues/2101#issuecomment-478819961 @AlbertTao this issue was fixed at

[GitHub] [incubator-shardingsphere] qinnnyul opened a new issue #2148: how to pass mapping logic into sharding-algorithm?

2019-04-01 Thread GitBox
qinnnyul opened a new issue #2148: how to pass mapping logic into sharding-algorithm? URL: https://github.com/apache/incubator-shardingsphere/issues/2148 ## we would like to do table sharding by tenant id, however, it is not good to split data by hash mod, it will be nicer if we can use

Re: [DISCUSS] ShardingSphere 4.0.0-RC1 release [ROUND 2]

2019-04-01 Thread Craig Russell
Hi, > On Mar 31, 2019, at 11:00 AM, 吴晟 Sheng Wu wrote: > >> How do you if we think remove file [2], and release a new zip for > Sharding-JDBC jars only? > > I support this change. > > > Just one question for mentors, do we need include all dependency jars for > sharding-jdbc in bin, which

Re: [DISCUSS] ShardingSphere 4.0.0-RC1 release [ROUND 2]

2019-04-01 Thread zhangli...@apache.org
I have already update source code for assembly the release zip package for src, sharding-jdbc-bin and sharding-proxy-bin. I will release them tomorrow and then we can start to discuss whether release for 3rd round. -- Liang Zhang (John) Apache ShardingSphere & Dubbo guangyuan

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2146: Support SpringNameSpace for encryptDataSource

2019-04-01 Thread GitBox
terrymanu merged pull request #2146: Support SpringNameSpace for encryptDataSource URL: https://github.com/apache/incubator-shardingsphere/pull/2146 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere-example] taojintianxia commented on issue #117: enhance sharding-proxy example

2019-04-01 Thread GitBox
taojintianxia commented on issue #117: enhance sharding-proxy example URL: https://github.com/apache/incubator-shardingsphere-example/issues/117#issuecomment-478570293 @cherrylzhao please decompose the task, make this task tiny and detail. I'd like to take some missions. since I

Re: [Feature Enhancement] Provide Spring Configuration method to use the feature of Data Masking

2019-04-01 Thread guangyuan wang
It is a good idea to provide another way to configure data masking. Could you explain more clearly about the difference between Java code and spring configuration. Does spring configuration like class with @Configuration? juan pan 于2019年4月1日周一 下午7:00写道: > Hi, everyone. > > This email is to

[GitHub] [incubator-shardingsphere] AlbertTao edited a comment on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column.

2019-04-01 Thread GitBox
AlbertTao edited a comment on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column. URL: https://github.com/apache/incubator-shardingsphere/issues/2101#issuecomment-478517102 Result in

[Feature Enhancement] Provide Spring Configuration method to use the feature of Data Masking

2019-04-01 Thread juan pan
Hi, everyone. This email is to discuss to schedule to provide Spring configuration method for the dataSource of Data masking. *Current Situation* * ShardingSphere can provide Java code and Yaml file for users to use the feature of data masking. * The feature of data masking is in the process of

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2147: Release distribution

2019-04-01 Thread GitBox
terrymanu closed issue #2147: Release distribution URL: https://github.com/apache/incubator-shardingsphere/issues/2147 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere] trojanliu removed a comment on issue #2125: not support count if, database will be the default , not the true

2019-04-01 Thread GitBox
trojanliu removed a comment on issue #2125: not support count if, database will be the default , not the true URL: https://github.com/apache/incubator-shardingsphere/issues/2125#issuecomment-478527704 i change the position, data-source-names="user,common". it change to user.

[GitHub] [incubator-shardingsphere] trojanliu commented on issue #2125: not support count if, database will be the default , not the true

2019-04-01 Thread GitBox
trojanliu commented on issue #2125: not support count if, database will be the default , not the true URL: https://github.com/apache/incubator-shardingsphere/issues/2125#issuecomment-478527704 i change the position, data-source-names="user,common". it change to user. tx_user.

[GitHub] [incubator-shardingsphere] AlbertTao edited a comment on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column.

2019-04-01 Thread GitBox
AlbertTao edited a comment on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column. URL: https://github.com/apache/incubator-shardingsphere/issues/2101#issuecomment-478517102 Java code Result in

[GitHub] [incubator-shardingsphere] codefairy08 commented on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column.

2019-04-01 Thread GitBox
codefairy08 commented on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column. URL: https://github.com/apache/incubator-shardingsphere/issues/2101#issuecomment-478521567 thanks , i will try it again using

[GitHub] [incubator-shardingsphere] codefairy08 commented on issue #2125: not support count if, database will be the default , not the true

2019-04-01 Thread GitBox
codefairy08 commented on issue #2125: not support count if, database will be the default , not the true URL: https://github.com/apache/incubator-shardingsphere/issues/2125#issuecomment-478519021 use this version 4.0.0-RC1-SNAPSHOT, compile it by yourself using source code,,just mvn

[GitHub] [incubator-shardingsphere] AlbertTao edited a comment on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column.

2019-04-01 Thread GitBox
AlbertTao edited a comment on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column. URL: https://github.com/apache/incubator-shardingsphere/issues/2101#issuecomment-478517102 Java code ```java

[GitHub] [incubator-shardingsphere] trojanliu commented on issue #2125: not support count if, database will be the default , not the true

2019-04-01 Thread GitBox
trojanliu commented on issue #2125: not support count if, database will be the default , not the true URL: https://github.com/apache/incubator-shardingsphere/issues/2125#issuecomment-478517539 i use 3.1.0. dev branch code is ok? i try it later .

[GitHub] [incubator-shardingsphere] AlbertTao commented on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column.

2019-04-01 Thread GitBox
AlbertTao commented on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column. URL: https://github.com/apache/incubator-shardingsphere/issues/2101#issuecomment-478517102 Java code ```java

[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #2147: Release distribution

2019-04-01 Thread GitBox
terrymanu opened a new issue #2147: Release distribution URL: https://github.com/apache/incubator-shardingsphere/issues/2147 Release distribution task: - [ ] add `shardingsphere-distribution` module - [ ] src dist zip - [ ] Sharding-JDBC jar dist tar.gz - [ ] Sharding-Proxy

[GitHub] [incubator-shardingsphere-doc] tristaZero opened a new pull request #124: modify spring name space for encrypt data source

2019-04-01 Thread GitBox
tristaZero opened a new pull request #124: modify spring name space for encrypt data source URL: https://github.com/apache/incubator-shardingsphere-doc/pull/124 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere-doc] tristaZero merged pull request #124: modify spring name space for encrypt data source

2019-04-01 Thread GitBox
tristaZero merged pull request #124: modify spring name space for encrypt data source URL: https://github.com/apache/incubator-shardingsphere-doc/pull/124 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere-doc] tristaZero opened a new pull request #123: modify spring name space for encrypt data source

2019-04-01 Thread GitBox
tristaZero opened a new pull request #123: modify spring name space for encrypt data source URL: https://github.com/apache/incubator-shardingsphere-doc/pull/123 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere-doc] tristaZero merged pull request #123: modify spring name space for encrypt data source

2019-04-01 Thread GitBox
tristaZero merged pull request #123: modify spring name space for encrypt data source URL: https://github.com/apache/incubator-shardingsphere-doc/pull/123 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere-doc] Harper0122 opened a new pull request #122: Performance Test Report Revision

2019-04-01 Thread GitBox
Harper0122 opened a new pull request #122: Performance Test Report Revision URL: https://github.com/apache/incubator-shardingsphere-doc/pull/122 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #2146: Support SpringNameSpace for encryptDataSource

2019-04-01 Thread GitBox
tristaZero opened a new pull request #2146: Support SpringNameSpace for encryptDataSource URL: https://github.com/apache/incubator-shardingsphere/pull/2146 Fixes #2091. This is an automated message from the Apache

[GitHub] [incubator-shardingsphere] fdlzp edited a comment on issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase

2019-04-01 Thread GitBox
fdlzp edited a comment on issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase URL: https://github.com/apache/incubator-shardingsphere/issues/2138#issuecomment-478419676 You are brilliant! NB Thanks again!!!

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2085: Weekly Report of ShardingSphere (2019-3-8 to 2019-3-15)

2019-04-01 Thread GitBox
terrymanu closed issue #2085: Weekly Report of ShardingSphere (2019-3-8 to 2019-3-15) URL: https://github.com/apache/incubator-shardingsphere/issues/2085 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] Harper0122 opened a new issue #2145: Weekly Report of ShardingSphere (2019-3-8 to 2019-3-15)

2019-04-01 Thread GitBox
Harper0122 opened a new issue #2145: Weekly Report of ShardingSphere (2019-3-8 to 2019-3-15) URL: https://github.com/apache/incubator-shardingsphere/issues/2145 This report is to review recent changes and developments of ShardingSphere. ## Basic Data Basic data shows how the

[GitHub] [incubator-shardingsphere] codefairy08 commented on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column.

2019-04-01 Thread GitBox
codefairy08 commented on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column. URL: https://github.com/apache/incubator-shardingsphere/issues/2101#issuecomment-478488556 @AlbertTao Please describe in detail,

[GitHub] [incubator-shardingsphere] codefairy08 commented on issue #2125: not support count if, database will be the default , not the true

2019-04-01 Thread GitBox
codefairy08 commented on issue #2125: not support count if, database will be the default , not the true URL: https://github.com/apache/incubator-shardingsphere/issues/2125#issuecomment-478476965 @trojanliu which shardingsphere version do you use? have a try using dev branch code , i

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2091: Spring framework for encrypt data source

2019-04-01 Thread GitBox
terrymanu closed issue #2091: Spring framework for encrypt data source URL: https://github.com/apache/incubator-shardingsphere/issues/2091 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2143: Support SpringBoot for encryptDataSource

2019-04-01 Thread GitBox
coveralls commented on issue #2143: Support SpringBoot for encryptDataSource URL: https://github.com/apache/incubator-shardingsphere/pull/2143#issuecomment-478462352 ## Pull Request Test Coverage Report for [Build 7422](https://coveralls.io/builds/22515718) * **8** of **9**

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2139: #2126 add SQLLoggerTest

2019-04-01 Thread GitBox
terrymanu merged pull request #2139: #2126 add SQLLoggerTest URL: https://github.com/apache/incubator-shardingsphere/pull/2139 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2126: SQLLogger should have a junit test

2019-04-01 Thread GitBox
terrymanu closed issue #2126: SQLLogger should have a junit test URL: https://github.com/apache/incubator-shardingsphere/issues/2126 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2139: #2126 add SQLLoggerTest

2019-04-01 Thread GitBox
terrymanu commented on issue #2139: #2126 add SQLLoggerTest URL: https://github.com/apache/incubator-shardingsphere/pull/2139#issuecomment-478461043 That's prefect, I will merge them This is an automated message from the

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #2139: #2126 add SQLLoggerTest

2019-04-01 Thread GitBox
coveralls edited a comment on issue #2139: #2126 add SQLLoggerTest URL: https://github.com/apache/incubator-shardingsphere/pull/2139#issuecomment-478215864 ## Pull Request Test Coverage Report for [Build 7421](https://coveralls.io/builds/22515340) * **0** of **0** changed or

[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #2144: Orchestration for encryptDataSource

2019-04-01 Thread GitBox
tristaZero opened a new issue #2144: Orchestration for encryptDataSource URL: https://github.com/apache/incubator-shardingsphere/issues/2144 To make the setting for encryptDataSource stored in registry, and refreshed the setting online. - [ ] Add orchestrationEncryptDataSource - [ ]

[GitHub] [incubator-shardingsphere] codefairy08 commented on issue #2130: supported hibernate insert values ( )

2019-04-01 Thread GitBox
codefairy08 commented on issue #2130: supported hibernate insert values ( ) URL: https://github.com/apache/incubator-shardingsphere/issues/2130#issuecomment-478449661 @LinXinHun It is not valid sql, please see [INSERT Syntax](https://dev.mysql.com/doc/refman/8.0/en/insert.html),

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2139: #2126 add SQLLoggerTest

2019-04-01 Thread GitBox
betterjava commented on issue #2139: #2126 add SQLLoggerTest URL: https://github.com/apache/incubator-shardingsphere/pull/2139#issuecomment-478449334 I am sorry to set the wrong property for checkstyle. I have checked the code with the correct checkstyle config.