[GitHub] [incubator-shardingsphere] michaeljinxq commented on issue #2222: Incorrect integer value: 'NULL' for column

2019-04-16 Thread GitBox
michaeljinxq commented on issue #: Incorrect integer value: 'NULL' for column URL: https://github.com/apache/incubator-shardingsphere/issues/#issuecomment-483943057 apache-shardingsphere-incubating-4.0.0-RC1-SNAPSHOT-sharding-proxy-bin.tar

[GitHub] [incubator-shardingsphere] michaeljinxq opened a new issue #2222: Incorrect integer value: 'NULL' for column

2019-04-16 Thread GitBox
michaeljinxq opened a new issue #: Incorrect integer value: 'NULL' for column URL: https://github.com/apache/incubator-shardingsphere/issues/ 【 int 】 (1)create table tb1 (id int); (2)insert into tb1 values (null); ERROR 1366 (HY000): Incorrect integer value: 'NULL' for

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2221: update readme for how to build

2019-04-16 Thread GitBox
coveralls commented on issue #2221: update readme for how to build URL: https://github.com/apache/incubator-shardingsphere/pull/2221#issuecomment-483935747 ## Pull Request Test Coverage Report for [Build 7671](https://coveralls.io/builds/22859731) * **0** of **0** changed or

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2220: revise UpdateStatement for revert-sql usage.

2019-04-16 Thread GitBox
coveralls commented on issue #2220: revise UpdateStatement for revert-sql usage. URL: https://github.com/apache/incubator-shardingsphere/pull/2220#issuecomment-483928483 ## Pull Request Test Coverage Report for [Build 7669](https://coveralls.io/builds/22859311) * **0** of **0**

[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #2221: update readme for how to build

2019-04-16 Thread GitBox
tuohai666 opened a new pull request #2221: update readme for how to build URL: https://github.com/apache/incubator-shardingsphere/pull/2221 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] cherrylzhao opened a new pull request #2220: revise UpdateStatement for revert-sql usage.

2019-04-16 Thread GitBox
cherrylzhao opened a new pull request #2220: revise UpdateStatement for revert-sql usage. URL: https://github.com/apache/incubator-shardingsphere/pull/2220 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2218: add extension support for sharding master slave router

2019-04-16 Thread GitBox
terrymanu edited a comment on issue #2218: add extension support for sharding master slave router URL: https://github.com/apache/incubator-shardingsphere/issues/2218#issuecomment-483920615 Hi, I don't think add so many extensions is necessary, and we don't have any evidence to prove

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2218: add extension support for sharding master slave router

2019-04-16 Thread GitBox
terrymanu commented on issue #2218: add extension support for sharding master slave router URL: https://github.com/apache/incubator-shardingsphere/issues/2218#issuecomment-483920615 Hi, I don't think add so many extension is necessary, and we don't have any evidence to prove enduser need

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2158: support for SQL route extension

2019-04-16 Thread GitBox
terrymanu closed issue #2158: support for SQL route extension URL: https://github.com/apache/incubator-shardingsphere/issues/2158 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-shardingsphere] lucy3399 commented on issue #2204: select a.id , c.id order by a.id, the result can not sort by designated column

2019-04-16 Thread GitBox
lucy3399 commented on issue #2204: select a.id ,c.id order by a.id, the result can not sort by designated column URL: https://github.com/apache/incubator-shardingsphere/issues/2204#issuecomment-483917150 Yes this is my problem

[GitHub] [incubator-shardingsphere] lucy3399 removed a comment on issue #2204: select a.id , c.id order by a.id, the result can not sort by designated column

2019-04-16 Thread GitBox
lucy3399 removed a comment on issue #2204: select a.id ,c.id order by a.id, the result can not sort by designated column URL: https://github.com/apache/incubator-shardingsphere/issues/2204#issuecomment-483915436 Yes,this is my problem | | 朱婷 | |

[GitHub] [incubator-shardingsphere] lucy3399 commented on issue #2204: select a.id , c.id order by a.id, the result can not sort by designated column

2019-04-16 Thread GitBox
lucy3399 commented on issue #2204: select a.id ,c.id order by a.id, the result can not sort by designated column URL: https://github.com/apache/incubator-shardingsphere/issues/2204#issuecomment-483915436 Yes,this is my problem | | 朱婷 | |

[GitHub] [incubator-shardingsphere] traceless opened a new issue #2219: SnowflakeShardingKeyGenerator hava a bug

2019-04-16 Thread GitBox
traceless opened a new issue #2219: SnowflakeShardingKeyGenerator hava a bug URL: https://github.com/apache/incubator-shardingsphere/issues/2219 ## Bug Report i have found a bug when i review code in SnowflakeShardingKeyGenerator.java ### Which version of Sharding-Sphere do

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #2204: select a.id , c.id order by a.id, the result can not sort by designated column

2019-04-16 Thread GitBox
KomachiSion commented on issue #2204: select a.id ,c.id order by a.id, the result can not sort by designated column URL: https://github.com/apache/incubator-shardingsphere/issues/2204#issuecomment-483904891 OK, I understand your problem. In your demo, if `user_id` in **t_order** and

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #2204: select a.id , c.id order by a.id, the result can not sort by designated column

2019-04-16 Thread GitBox
KomachiSion commented on issue #2204: select a.id ,c.id order by a.id, the result can not sort by designated column URL: https://github.com/apache/incubator-shardingsphere/issues/2204#issuecomment-483903278 @lucy3399 sorry, what's your correct result and SQL? I run your demo code,

[GitHub] [incubator-shardingsphere] lalicw opened a new issue #2218: add extension support for sharding master slave router

2019-04-16 Thread GitBox
lalicw opened a new issue #2218: add extension support for sharding master slave router URL: https://github.com/apache/incubator-shardingsphere/issues/2218 ## Feature Request we suggest to add extension support like spi for sharding master slave router. in some scenario we many

[GitHub] [incubator-shardingsphere-doc] wgy8283335 commented on issue #148: delete 'routing.cn.md' and update 'route.cn.md'.

2019-04-16 Thread GitBox
wgy8283335 commented on issue #148: delete 'routing.cn.md' and update 'route.cn.md'. URL: https://github.com/apache/incubator-shardingsphere-doc/pull/148#issuecomment-483899123 @terrymanu. Thank you for revising the document, especially for modifying syntax. Do I need to translate the

[GitHub] [incubator-shardingsphere-doc] wgy8283335 commented on issue #148: delete 'routing.cn.md' and update 'route.cn.md'.

2019-04-16 Thread GitBox
wgy8283335 commented on issue #148: delete 'routing.cn.md' and update 'route.cn.md'. URL: https://github.com/apache/incubator-shardingsphere-doc/pull/148#issuecomment-483899143 @terrymanu. Thank you for revising the document, especially for modifying syntax. Do I need to translate the

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #1775: Leaf key generator implementation for Apache ShardingSphere

2019-04-16 Thread GitBox
terrymanu commented on issue #1775: Leaf key generator implementation for Apache ShardingSphere URL: https://github.com/apache/incubator-shardingsphere/issues/1775#issuecomment-483650093 Yes, you can reference https://tech.meituan.com/MT_Leaf.html

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2110: how to use shardingsphere multiple databases store different tables sharding?

2019-04-16 Thread GitBox
terrymanu commented on issue #2110: how to use shardingsphere multiple databases store different tables sharding? URL: https://github.com/apache/incubator-shardingsphere/issues/2110#issuecomment-483649333 Close because no reply by creator.

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2110: how to use shardingsphere multiple databases store different tables sharding?

2019-04-16 Thread GitBox
terrymanu closed issue #2110: how to use shardingsphere multiple databases store different tables sharding? URL: https://github.com/apache/incubator-shardingsphere/issues/2110 This is an automated message from the Apache

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2211: mysql insert decimal error

2019-04-16 Thread GitBox
terrymanu closed issue #2211: mysql insert decimal error URL: https://github.com/apache/incubator-shardingsphere/issues/2211 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2216: #2211 bug fixs and add test case

2019-04-16 Thread GitBox
terrymanu merged pull request #2216: #2211 bug fixs and add test case URL: https://github.com/apache/incubator-shardingsphere/pull/2216 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #2214: Review the DCL Parsing rules for different databases

2019-04-16 Thread GitBox
tristaZero opened a new issue #2214: Review the DCL Parsing rules for different databases URL: https://github.com/apache/incubator-shardingsphere/issues/2214 Tasks are as following: - [x] Review the DCL Parsing rule for MySQL - [x] Review the DCL Parsing rule for Oracle - [ ]

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #2216: #2211 bug fixs and add test case

2019-04-16 Thread GitBox
coveralls edited a comment on issue #2216: #2211 bug fixs and add test case URL: https://github.com/apache/incubator-shardingsphere/pull/2216#issuecomment-483555997 ## Pull Request Test Coverage Report for [Build 7653](https://coveralls.io/builds/22840044) * **1** of **3**

Re: [VOTE]: Release Apache ShardingSphere (Incubating) 4.0.0-RC1

2019-04-16 Thread Willem Jiang
+1 (binding) Forward my VOTE from dev@ list Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Tue, Apr 16, 2019 at 4:33 PM zhangli...@apache.org wrote: > > Hello all, > > This is a call for vote to release Apache ShardingSphere (Incubating) > version 4.0.0-RC1. > > The Apache

[GitHub] [incubator-shardingsphere] cherrylzhao merged pull request #2217: use EnumMap replace HashMap

2019-04-16 Thread GitBox
cherrylzhao merged pull request #2217: use EnumMap replace HashMap URL: https://github.com/apache/incubator-shardingsphere/pull/2217 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2217: use EnumMap replace HashMap

2019-04-16 Thread GitBox
coveralls commented on issue #2217: use EnumMap replace HashMap URL: https://github.com/apache/incubator-shardingsphere/pull/2217#issuecomment-483592931 ## Pull Request Test Coverage Report for [Build 7650](https://coveralls.io/builds/22837517) * **1** of **1** **(100.0%)**

[GitHub] [incubator-shardingsphere] mfeng-ya opened a new pull request #2217: use EnumMap replace HashMap

2019-04-16 Thread GitBox
mfeng-ya opened a new pull request #2217: use EnumMap replace HashMap URL: https://github.com/apache/incubator-shardingsphere/pull/2217 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2193: Table doesn't exist when sharding value in different datasource with in expression

2019-04-16 Thread GitBox
terrymanu closed issue #2193: Table doesn't exist when sharding value in different datasource with in expression URL: https://github.com/apache/incubator-shardingsphere/issues/2193 This is an automated message from the

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2210: fix #2193

2019-04-16 Thread GitBox
terrymanu merged pull request #2210: fix #2193 URL: https://github.com/apache/incubator-shardingsphere/pull/2210 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-shardingsphere-example] betterjava commented on issue #131: add broadcast-table-raw-jdbc-multi

2019-04-16 Thread GitBox
betterjava commented on issue #131: add broadcast-table-raw-jdbc-multi URL: https://github.com/apache/incubator-shardingsphere-example/pull/131#issuecomment-483565832 have a good day . This is an automated message from the

[GitHub] [incubator-shardingsphere-example] cherrylzhao closed issue #115: Add a broadcast-table example for sharding-jdbc

2019-04-16 Thread GitBox
cherrylzhao closed issue #115: Add a broadcast-table example for sharding-jdbc URL: https://github.com/apache/incubator-shardingsphere-example/issues/115 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere-example] cherrylzhao merged pull request #131: add broadcast-table-raw-jdbc-multi

2019-04-16 Thread GitBox
cherrylzhao merged pull request #131: add broadcast-table-raw-jdbc-multi URL: https://github.com/apache/incubator-shardingsphere-example/pull/131 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere-example] cherrylzhao commented on issue #131: add broadcast-table-raw-jdbc-multi

2019-04-16 Thread GitBox
cherrylzhao commented on issue #131: add broadcast-table-raw-jdbc-multi URL: https://github.com/apache/incubator-shardingsphere-example/pull/131#issuecomment-483564870 it seems ok now, let merge your PR, thanks~ This is an

[VOTE]: Release Apache ShardingSphere (Incubating) 4.0.0-RC1

2019-04-16 Thread zhangli...@apache.org
Hello all, This is a call for vote to release Apache ShardingSphere (Incubating) version 4.0.0-RC1. The Apache ShardingSphere community has voted on and approved a proposal to release Apache ShardingSphere (Incubating) version 4.0.0-RC1. We now kindly request the Incubator PMC members review

[GitHub] [incubator-shardingsphere-example] betterjava commented on a change in pull request #131: add broadcast-table-raw-jdbc-multi

2019-04-16 Thread GitBox
betterjava commented on a change in pull request #131: add broadcast-table-raw-jdbc-multi URL: https://github.com/apache/incubator-shardingsphere-example/pull/131#discussion_r275684250 ## File path: sharding-jdbc-example/broadcast-table-example/pom.xml ## @@ -25,6 +25,7

[GitHub] [incubator-shardingsphere-example] cherrylzhao commented on a change in pull request #131: add broadcast-table-raw-jdbc-multi

2019-04-16 Thread GitBox
cherrylzhao commented on a change in pull request #131: add broadcast-table-raw-jdbc-multi URL: https://github.com/apache/incubator-shardingsphere-example/pull/131#discussion_r275682155 ## File path: sharding-jdbc-example/broadcast-table-example/pom.xml ## @@ -25,6 +25,7

Re: [VOTE]: Release Apache ShardingSphere (Incubating) 4.0.0-RC1 [ROUND 3]

2019-04-16 Thread zhangli...@apache.org
We’ve received 6 +1 binding votes and 1 0 non-binding vote: +1 binding, Juan Pan +1 binding, Hongjun Du +1 binding, Yonglun Zhang +1 binding, Yi Yang +1 binding, Jun Zhao +1 binding, Willen Jiang +0 non-binding, Guangyuan Wang Thank you everyone for taking the time to review the release and

[GitHub] [incubator-shardingsphere-doc] tristaZero merged pull request #152: properties

2019-04-16 Thread GitBox
tristaZero merged pull request #152: properties URL: https://github.com/apache/incubator-shardingsphere-doc/pull/152 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere-doc] tristaZero opened a new pull request #152: properties

2019-04-16 Thread GitBox
tristaZero opened a new pull request #152: properties URL: https://github.com/apache/incubator-shardingsphere-doc/pull/152 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2216: #2211 bug fixs and add test case

2019-04-16 Thread GitBox
coveralls commented on issue #2216: #2211 bug fixs and add test case URL: https://github.com/apache/incubator-shardingsphere/pull/2216#issuecomment-483555997 ## Pull Request Test Coverage Report for [Build 7647](https://coveralls.io/builds/22835358) * **0** of **4** **(0.0%)**

[GitHub] [incubator-shardingsphere] 125964590 commented on issue #234: Welcome to leave your company's info when using Sharding-Sphere(欢迎使用Sharding-Sphere的公司在此登记)

2019-04-16 Thread GitBox
125964590 commented on issue #234: Welcome to leave your company's info when using Sharding-Sphere(欢迎使用Sharding-Sphere的公司在此登记) URL: https://github.com/apache/incubator-shardingsphere/issues/234#issuecomment-48322 好未来

[GitHub] [incubator-shardingsphere-example] betterjava commented on a change in pull request #131: add broadcast-table-raw-jdbc-multi

2019-04-16 Thread GitBox
betterjava commented on a change in pull request #131: add broadcast-table-raw-jdbc-multi URL: https://github.com/apache/incubator-shardingsphere-example/pull/131#discussion_r275669140 ## File path: sharding-jdbc-example/broadcast-table-example/pom.xml ## @@ -25,6 +25,7

[GitHub] [incubator-shardingsphere] codefairy08 opened a new pull request #2216: #2211 bug fixs and add test case

2019-04-16 Thread GitBox
codefairy08 opened a new pull request #2216: #2211 bug fixs and add test case URL: https://github.com/apache/incubator-shardingsphere/pull/2216 Fixes #ISSUSE_ID. Changes proposed in this pull request: - - -

[GitHub] [incubator-shardingsphere] codefairy08 commented on issue #2211: mysql insert decimal error

2019-04-16 Thread GitBox
codefairy08 commented on issue #2211: mysql insert decimal error URL: https://github.com/apache/incubator-shardingsphere/issues/2211#issuecomment-483546738 it could not convert double string value to number, it must convert to double

Re: [VOTE]: Release Apache ShardingSphere (Incubating) 4.0.0-RC1 [ROUND 3]

2019-04-16 Thread Willem Jiang
+1. (Binding) I checked * The signed key and checksum look good * Incubating is in the release artifacts name. * DISCLAIMER is included in the artifacts * LICENSE and NOTICE files are good * I can build from source release * No binary files in the source release kit. Willem Jiang Twitter:

[GitHub] [incubator-shardingsphere-example] cherrylzhao commented on a change in pull request #131: add broadcast-table-raw-jdbc-multi

2019-04-16 Thread GitBox
cherrylzhao commented on a change in pull request #131: add broadcast-table-raw-jdbc-multi URL: https://github.com/apache/incubator-shardingsphere-example/pull/131#discussion_r275650020 ## File path: sharding-jdbc-example/broadcast-table-example/pom.xml ## @@ -25,6 +25,7

[GitHub] [incubator-shardingsphere-example] betterjava opened a new pull request #131: add broadcast-table-raw-jdbc-multi

2019-04-16 Thread GitBox
betterjava opened a new pull request #131: add broadcast-table-raw-jdbc-multi URL: https://github.com/apache/incubator-shardingsphere-example/pull/131 Fixes #115 . Changes proposed in this pull request: - add a example for use broadcast-table (left join)

[GitHub] [incubator-shardingsphere-doc] cherrylzhao closed issue #133: hint-example related page could not be found.

2019-04-16 Thread GitBox
cherrylzhao closed issue #133: hint-example related page could not be found. URL: https://github.com/apache/incubator-shardingsphere-doc/issues/133 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] wgy8283335 commented on issue #2213: ProxyMain in sharding-proxy-example. The connection to sharding-proxy server refused.

2019-04-16 Thread GitBox
wgy8283335 commented on issue #2213: ProxyMain in sharding-proxy-example. The connection to sharding-proxy server refused. URL: https://github.com/apache/incubator-shardingsphere/issues/2213#issuecomment-483523645 @tuohai666 link: