Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-02 Thread Craig Russell
Hi, +1 (IPMC) can be carried over to general incubator release vote I checked: [x] incubating in names. [x] Download links are valid. [x] Checksums and PGP signatures are valid (I checked src) [x] DISCLAIMER is included. [x] Source code artifacts have correct names matching the current

回复: Discussion of pluggable platform of ShardingSphere

2020-01-02 Thread Sun Kane
I personally recommend solution A, just like the current hardware system,although the hardware outside the mainboard is pluggable, users rarely plug hardware such like graphics cards or CPU. reduce the difficulty for users to get started will the best 发件人:

Re:Re: Discussion of pluggable platform of ShardingSphere

2020-01-02 Thread Sion Yang
I prefer Plan A too. -- Yi Yang(Sion) Apache ShardingSphere At 2020-01-03 00:13:07, "zhangli...@apache.org" wrote: >I have 2 ideas for the pluggable platform. > >Plan A: > >Design a unify DataSource to process all rules, it should be a transparent >DataSource if no rule provided (but

Re: Discussion of pluggable platform of ShardingSphere

2020-01-02 Thread zhangli...@apache.org
I have 2 ideas for the pluggable platform. Plan A: Design a unify DataSource to process all rules, it should be a transparent DataSource if no rule provided (but it should be valid). We can name it as `ShardingSphereDataSource`. There are lots of hooks in `ShardingSphereDataSource`, such as: -

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-02 Thread Zhang Yonglun
+1 Checked: Download links are valid. PGP checked. DISCLAIMER is included. LICENSE and NOTICE files are correct for each ShardingSphere repo. All files have license headers if necessary. mvn install succeed. -- Zhang Yonglun Apache ShardingSphere Juan Pan 于2020年1月2日周四 下午6:44写道: > +1, it is

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-02 Thread Juan Pan
+1, it is ok for me My check list, Download links are valid. Checksums and PGP signatures are valid. DISCLAIMER is included. LICENSE and NOTICE files are correct for each ShardingSphere repo. All files have license headers if necessary. Install source files successfully. Juan Pan (Trista)