Re: Example generator is completed nearly

nice job ! Regards, cherrylzhao --- Email：zhao...@apache.org Jun Zhao(cherrylzhao) Apache ShardingSphere zhangli...@apache.org 于2022年3月26日周六 19:53写道： > Hi Commnumity, > > May I have your attention please. > Our new example system - automatic

Re: Re:[VOTE] Release Apache ShardingSphere ElasticJob UI 3.0.0-beta

+1 binding [x] Download links are valid. [x] Checksums and PGP signatures are valid. [x] Source code distributions have correct names matching the current release. [x] LICENSE and NOTICE files are correct for each ShardingSphere repo. [x] All files have license headers if necessary. Regards,

Re: [VOTE] Release Apache ShardingSphere 5.0.0-alpha

+1 binding [x] Download links are valid. [x] Checksums and PGP signatures are valid. [x] Source code distributions have correct names matching the current release. [x] LICENSE and NOTICE files are correct for each ShardingSphere repo. [x] All files have license headers if necessary. [x] No

Re: [VOTE] Release Apache ShardingSphere ElasticJob-3.0.0-beta

+1 binding [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] Source code distributions have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have license headers if necessary. [X] No

Re: [DISCUSS] Rename MasterSlave module to ReadWriteSplit

Replicate is usually response of switching to master in failover stage, maybe ReadOnlyDataSource is better for shardingsphere. Regards, cherrylzhao --- Email：zhao...@apache.org Jun Zhao(cherrylzhao) Apache ShardingSphere zhangli...@apache.org

Re: [VOTE] Release Apache ShardingSphere UI 4.1.1

+1， I checked: [x] Download links are valid. [x] Checksums and GPG signatures are valid. [x] Source code distributions have correct names matching the current release. [x] LICENSE and NOTICE files are correct for each ShardingSphere repo. [x] All files have license headers if necessary. [x]

Re: [VOTE] Release Apache ShardingSphere 4.1.1

binding +1, I checked [X] Download links are valid. [X] Checksums and GPG signatures are valid. [X] Source code distributions have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have license headers if

Re: Re: [Vote] ElasticJob donation

+1 binding Regards, cherrylzhao --- Email：zhao...@apache.org Jun Zhao(cherrylzhao) Apache ShardingSphere KimmKing 于2020年5月26日周二 下午4:32写道： > It always be famous distributed schedule framework. > And we will make it the most popular one. > > >

Re: Aggregate and redesign modules for ShardingSphere 5.x

LGTM, it looks jdbc and proxy is light enough after pluggable platform complete. Regards, cherrylzhao --- Email：zhao...@apache.org Jun Zhao(cherrylzhao) Apache ShardingSphere zhangli...@apache.org 于2020年5月14日周四 下午10:35写道： > Hi all, > >

Re: [DISCUSS]About a hotfix release version 4.1.1

+1, I found another mysql8 compatible issue[1], it's better to release it in 4.1.1. since theMySQLServerInfo.SERVER_VERSION is fixed at 5.6.4, so jdbc-driver will send the sql contains query_cache_size, we should dynamically judge it based on the physical database version, also i'have made some

Re: [VOTE] Release Apache ShardingSphere UI 4.1.0

+1, binding I checked: [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] Source code distributions have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have license headers if necessary.

Re: [VOTE] Release Apache ShardingSphere 4.1.0 Round 2

+1, binding I checked: [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] Source code distributions have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have license headers if

Re: [VOTE] Release Apache ShardingSphere UI 4.1.0

shardingsphere-ui-4.1.0 tag in github contains entire ShardingSphere source, should we keep only ui source？ Regards, cherrylzhao --- Email：zhao...@apache.org Jun Zhao(cherrylzhao) Apache ShardingSphere zhangli...@apache.org 于2020年4月27日周一

Re: [DISCUSS] 4.1.0 release plan

Hi, Yonglun sharding-transaction have completed these features in dev-4.x branch: 1. Support integrate with spring using @ShardingTransactionType (issue#4937) 2. Enhance ShardingDataSource to compatiable with Seata in micro-sevice distribution transaction (issue#4991） -- Zhao

[ANNOUNCE] Apache ShardingSphere 4.0.1 available

Hi all, Apache ShardingSphere (incubating) Team is glad to announce the first release of Apache ShardingSphere Incubating 4.0.1. ShardingSphere is an open-source ecosystem consisted of a set of distributed database middleware solutions, including 2 independent products, Sharding-JDBC &

Re: [VOTE] Graduate Apache ShardingSphere (incubating)

+1 Hope developer around world will join us in the near future. -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb > On Mar 5, 2020, at 1:44 PM, Sheng Wu wrote: > > +1 > > Look forward to the ShardingSphere becomes to my 3rd involved TLP. > > Sheng Wu 吴晟 >

[RESULT] [VOTE] Release Apache ShardingSphere (Incubating) 4.0.1

The vote to release Apache ShardingSphere (Incubating) 4.0.1 has passed. 5 PPMC member +1 votes: Yi Yang Liang Zhang Juan Pan Craig Russell (mentor) Willem Jiang (mentor) 3 community +1 vote: kimmking Guangyuan Wang Zonglei Dong Thank you everyone for taking the time to review the release

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.1

Thank you for all participants, the vote had finished successfully, I will send a new email to statistics the vote result. -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.1

> I found there is a small issue about the copyright year on the NOTICE > file, it should be 2018-2020 instead of 2019-2020, we can fix it in > the next release. Got it, we will revise the copyright to 2018-2020 in the next version -- Zhao Jun (cherrylzhao) Apache ShardingSphere

[VOTE] Release Apache ShardingSphere (Incubating) 4.0.1

Hello ShardingSphere Community, This is a call for vote to release Apache ShardingSphere (Incubating) version 4.0.1 Release notes: https://github.com/apache/incubator-shardingsphere/blob/dev-4.x/RELEASE-NOTES.md

Re: [PROPOSAL]ShardingShpere Cloud on Kubernetes(SSCK)

That’s a excellent idea ! I have learned a lot from your proposal, cloud-native is currently one of the biggest trends in the software industry. It became clear that we can leverage Kubernetes resources and sdk to develop SSCK. Also we should follow up sharding-sidecar to keep pace with SSCK.

Re: Will give a talk at DTCC 2020

OK, looking forward to your proposal -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb > On Feb 12, 2020, at 10:29 AM, Hongtao Gao wrote: > > Glade to hear that, you can review the proposal next week to get more > details about it. > > zhaojun

Re: Will give a talk at DTCC 2020

Hi, Hongtao I’m very interested in this topic, learn more about ShardingSphere on Kubernetes. -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb > On Feb 11, 2020, at 10:41 PM, Hongtao Gao wrote: > > Hi > I'm invited to give a talk at DTCC June 2020

Re: [IMPORTANT][PPMC] Invitation to be ShardingSphere PMC member

YES -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb

Re: [DISCUSS] 4.0.1 stable version release plan

> I and yonglun/tuohai666 had added travis ci config to 4.0.1 several days ago > with PR#4203. > But I don't know it should be added to change logs or not. Thanks for contribution, ci config was not a function issue, so I think it could not be included in change logs.

Re: [DISCUSS] 4.0.1 stable version release plan

Hi, all The latest change logs is as below ## Bug fixes 3956 using guava cache to fix parsing deadlock probleam 3975 oracle insert SQL could not work in encrypt mode 3997 proxy for PostgreSQL decode parameters error in all types except String 4004 COM_STM_EXECUTE of MySQL could not support

Re: [DISCUSS] 4.0.1 stable version release plan

> Should we add the fix of Issue#4182[1] into 4.0.1? Thanks for feedback, tuohai666 have just merged it to 4.0.1, I will update the change log later -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb

Re: [DISCUSS] 4.0.1 stable version release plan

> I suggest we can merge the 3918’s PR and not care of the Metadata model’s > redesign right now, > because if we don’t merge it, user may be always meet this bug in 4.x’s > version. In fact, get resultsSet using logicTable will lead to sharding-encrypt not available. See the bug issue 3995

Re: [DISCUSS] 4.0.1 stable version release plan

> We can change issues #3956 and #4004 as bug, and keep #4054 and #4205 as > enhancement. Agree with it -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb

Re: [DISCUSS] 4.0.1 stable version release plan

> Agree with the principle. > Do we have substantial changes? From changelog, literally, there is. I have review these optimize code, the code change scope is small, so I think it was not a substantial changes. -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb

Re: [DISCUSS] 4.0.1 stable version release plan

ere/issues/3922> -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb > On Feb 9, 2020, at 8:18 PM, 蒋晓峰 wrote: > > Hi zhaojun, > what about the pull request of > https://github.com/apache/incubator-shardingsphere/pull/3918? I thought > that this pu

Re: [DISCUSS] 4.0.1 stable version release plan

gt; Sheng Wu 吴晟 > Twitter, wusheng1108 > > > zhangli...@apache.org 于2020年2月9日周日 下午5:34写道： > >> +1. >> Great. There are no missing tasks from my side. >> >> -- >> >> Liang Zhang (John) >> Apache ShardingSphere &

[DISCUSS] 4.0.1 stable version release plan

Hi, ShardingSphere community, I’d like to be the release manager of 4.0.1 version. We have done some bug fixes and performance optimization in past month based on 4.0.0. If there is no other requirement, I think we can start to release 4.0.1 recently. ## Bug fixes 3975 oracle insert SQL

Re: HA of Apache ShardingSphere(incubator) work plans

sure, kim and haoran will follow the metadata issue in future -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb > On Feb 8, 2020, at 10:59 AM, guangyuan wang wrote: > > 4. Design Metadata model, integrate with Config and Registry. > Zhaojun has menti

Re: Talk about graduation as TLP for Apache ShardingSphere(Incubator)

+1 It’s better to include our docs, example, benchmark repository for statistics, not just the shardngspere branch -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb > On Feb 6, 2020, at 11:47 AM, Juan Pan wrote: > > I think it is ok. > > > If one PPMC was not

Re: [DISCUSS] Optimize model of ColumnMetaData

an wang wrote: > > For byte[] value, I think we could find a way to resolve. > But refresh metadata without affecting running instance, I am not sure. > Registry Center provides a watching function, does it could be used to > refresh metadata? > > zhaojun 于2020年1月20日周一 下午5

Re: [DISCUSS] Optimize model of ColumnMetaData

(cherrylzhao) Apache ShardingSphere & ServiceComb > On Jan 20, 2020, at 5:02 PM, guangyuan wang wrote: > > What kind of help do you need in the orchestration module? The > orchestration module provides functions: writing and reading key-value pair. > > Nicholas 于2020年1月17日周五 下午4:

Re: [DISCUSS] merge docs and example repos into trunk repo

+1 -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb > On Jan 17, 2020, at 12:18 PM, Raigor Jiang wrote: > > It will be nice! agree +1 > > > > > On 01/17/2020 12:15，zhangli...@apache.org wrote： > Hi ShardingSphere community, > > I'd like to discuss about merge

[DISCUSS] Optimize model of ColumnMetaData

Hi, all I have created a issue[1] for discussing about optimizing metadata model. Currently ShardingSphere metadata was only used by sharding & encrypt scenario, master-slave case have to get them from underlying ResultSet meta in sharding-proxy. It is better to establish an global MetaData

Re: [ANNOUNCE] New committer: Xiaofeng Jiang

Congratulations! -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb > On Jan 8, 2020, at 2:02 PM, Juan Pan wrote: > > Hi everyone, > > TheProjectManagementCommittee(PMC)forApache ShardingSphere hasinvited > Xiaofeng Jiang

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

+1 I have checked: [OK] Download links are valid. [OK] Checksums and PGP signatures are valid. [OK] DISCLAIMER is included. [OK] Source code artifacts have correct names matching the current release. [OK] All files have license headers if necessary. [OK] No compiled archives bundled in source

Re: shardingsphere-spi-impl项目变异报错

Sorry, the picture in the mail could not present. indeed we have not keep the spi project synchronized with ShardingSphere branch, you can try to downgrade the version to 4.0.0-RC2 or more earlier. -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb > On Dec 18, 2019,

Re: [Discuss] Shadow Database Configuration Yaml

il: yanick@gmail.com > Website: blog.yanick.site > > On Dec 10, 2019, 17:27 +0800, zhaojun , wrote: >> It seems difficult to understand, shall we create datasource groups >> distinguished with >> actual and shadow then rewrite the actualDataNodes based on shadow sw

Re: [Discuss] Shadow Database Configuration Yaml

It seems difficult to understand, shall we create datasource groups distinguished with actual and shadow then rewrite the actualDataNodes based on shadow switch configuration? -- Zhao Jun (cherrylzhao) Apache Sharding-Sphere & ServiceComb > On Dec 10, 2019, at 3:46 PM, xia

Re: Discussion of pluggable platform of ShardingSphere

+1 Pluggable data platform would be a brand new start. Looking forward to combining variety powerful features through SPI, not just inside the sharding-core. -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb > On Dec 9, 2019, at 1:29 PM, zhangli...@apache.org

Re: 4.0.0 stable version release plan

It looks good to me, but it’s better we have a mechanism to verify whether 4.0.0 is stable or not. -- Zhao Jun (cherrylzhao) Apache Sharding-Sphere & ServiceComb > On Dec 9, 2019, at 10:53 AM, Sheng Wu wrote: > > zhaojun 于2019年12月9日周一 上午10:21写道： > >> @

Re: 4.0.0 stable version release plan

Acceptance-test framework will make release workflow more smoothly. We will spend a lot of time (maybe months) to verify the function manually on every release time. In fact, we could not release a version ASAP now. -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb >

Re: [VOTE] Accept ShardingScaling Donation ROUND2

+1 -- Zhao Jun (cherrylzhao) Apache Sharding-Sphere & ServiceComb > On Nov 13, 2019, at 4:22 PM, Willem Jiang wrote: > > +1. > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Wed, Nov 13, 2019 at 9:57 AM Sion Yang wrote: >> >> Dear Apache ShardingSphere

Re: How to finish release vote's checklist work?

Please refer to [Check Release] part from release guide[1] [1]: https://shardingsphere.apache.org/community/en/contribute/release/ -- Zhao Jun (cherrylzhao) Apache Sharding-Sphere & ServiceComb > On Nov 15,

Re: [VOTE] Accept ShardingScaling Donation

+1, LGTM The url in proposal page could not open directly, should we fix it later? -- Zhao Jun (cherrylzhao) Apache Sharding-Sphere & ServiceComb > On Nov 12, 2019, at 6:23 PM, Sion Yang wrote: > > Proposal has updated in wiki. >

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

+1, I checked: [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have license

Re: [Discuss] What does ShardingSphere 4.0.0's final API look like?

I think DistributeTransactionDataSource is not necessary, our distribute transaction for ShardingSphere was just integration, but not an independent product, it can only works on sharding scenario right now -- Zhao Jun Apache Sharding-Sphere & ServiceComb > On Sep 29, 2019, at

Re: [DISCUSS] Set up new work flow for ShardingSphere

+1 We should build a work flow that people outside JD can also complete a core feature. As initial committer, we should share our knowledge on how to resolve problems, Break requirements down into small pieces that can do pull request and review by others. -- Zhao Jun Apache

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 2]

+1 approve, I checked: [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have

Re: sharding-jdbc trasaction problem

Hi Please send mail to dev@shardingsphere.apache.org , we’ll check it everyday. You should set transaction type before datasource.getConnection, or you can use our @TransactionType annotation integrated with spring. Example is here:

Re: XA example for narayana

and I think you have to exclude this artifact when doing the > release. > > zhaojun 于2019年5月30日周四 上午9:32写道： > >> Hi, zheng >> >> FYI, I have moved sharding-transaction-xa-narayana to our dev branch. >> >> You can see here: >> >> https://gi

Re: XA example for narayana

Sharding-Sphere & ServiceComb > On May 28, 2019, at 9:49 AM, zhaojun wrote: > > I have just created another issue[1] for extend atomikos persistence. > > [1]https://github.com/apache/incubator-shardingsphere/issues/2455 > > -- > Zhao Jun > Apach

Re: XA example for narayana

s/openshift environment. The most important thing is that we have >> to make sure the restart pod has the same nodeIdentifier in the narayana >> configuration. >> >> zhaojun 于2019年5月27日周一 下午9:40写道： >> >>> For cloud native architecture, if one instance have crash

Re: XA example for narayana

nd > database by using the jdbc configuration. I will take a loo at the issue. > Also why does the sharding sphere need this feature ? > > zhaojun 于2019年5月27日周一 下午4:08写道： > >> Hi, zheng >> >> I have hear of narayana-trnasaction manager have provided a power

XA example for narayana

Hi, zheng I have hear of narayana-trnasaction manager have provided a powerful feature that persisting transaction log into database. So we prefer you write an example for using it, you can reference the atomikos example from here[1]. Also I have created a issue for that, please see here[2]

Re: How to do database level horizontal sharding bases on table key

Hi, Eric For your question, you can config the yaml like this: shardingRule: tables: employee: actualDataNodes: database${0..1}.employee databaseStrategy: inline: shardingColumn: emp_id algorithmExpression: database${emp_id % 2} keyGenerator:

Re: [saga-actuator]consider about adding StreamBasedSaga engine to integrate with shardingsphere

I have just created a issue[1] in JIRA [1]: https://issues.apache.org/jira/browse/SCB-1276 <https://issues.apache.org/jira/browse/SCB-1276> -- Zhao Jun Apache Sharding-Sphere & ServiceComb > On May 5, 2019, at 8:46 AM, zhaojun wrote: > > OK, I’ll try to

Re: [saga-actuator]consider about adding StreamBasedSaga engine to integrate with shardingsphere

Willem Jiang wrote: >>> >>> We could do some enhancement on it. >>> From my understanding, We could create a calling graph which has three >>> sub graph of it, or we could let the SQL executor running the command >>> one by one. >>> Any tho

Re: [saga-actuator]consider about adding StreamBasedSaga engine to integrate with shardingsphere

: 姜宁willem > > On Mon, Apr 29, 2019 at 7:58 PM zhaojun wrote: >> >> Hi, Willem >> >> Saga actuator could not compatible with ShardingSphere currently, there are >> 2 main problem exist. >> 1. If sql execute in saga transport instead of Shardi

Re: [saga-actuator]consider about adding StreamBasedSaga engine to integrate with shardingsphere

of the distributed transaction. But that introduce another > endpoint(Alpha) to shardingsphere. > > From my understanding, Saga actuator is most efficient way to execute > the SQL across different data nodes. > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem >

Re: [saga-actuator]consider about adding StreamBasedSaga engine to integrate with shardingsphere

ithub.com/seata/seata/issues/714 >> >> Sheng Wu 于2019年4月26日周五 下午6:47写道： >> >>> Please be advised, SkyWalking and seata integration are ongoing too. >>> >>> https://github.com/seata/seata/issues/714 >>> >>> SkyWalking agent even will

[saga-actuator]consider about adding StreamBasedSaga engine to integrate with shardingsphere

Hi, all currently, we have integrated with saga using graph based engine in shardingsphere[1] it need us to collect all participated actual SQL, then submit to saga actuator in commit/rollback phase. if application crashed before invoking saga actuator, undo log of branch transaction SQL will

Re: [VOTE]: Release Apache ShardingSphere (Incubating) 4.0.0-RC1 [ROUND 3]

+1 Checked: [√] Download links are valid. [√] Checksums and PGP signatures are valid. [√] DISCLAIMER is included. [√] Source code artifacts have correct names matching the current release. [√] LICENSE and NOTICE files are correct for each ShardingSphere repo. [√] All files have license

Re: [DISCUSS] ShardingSphere 4.0.0-RC1 release [ROUND 3]

Agree for release +1 -- Zhao Jun Apache Sharding-Sphere & ServiceComb > On Apr 8, 2019, at 10:54 AM, duhongjun wrote: > > I fixed some sql parsing issues, very looking forwarding to this release > > > > -- > > - > > HongJun Du > Apache

Re: [DISCUSS] ShardingSphere 4.0.0-RC1 release [ROUND 2]

Agree to release +1 I have checked all item, it is ok 1. sha512 hash. 2. gpg Signature. 3. Items for source package. 4. Items for binary packages. Also ,the result of shardingsphere-accept-test is ok -- Zhao Jun Apache Sharding-Sphere & ServiceComb > On Mar 30, 2019, at 8:53

Re: [Discuss] Acceptance test for ShardingSphere 4.0.0 [RC1] release

Agree to release +1 -- Zhao Jun Apache Sharding-Sphere & ServiceComb > On Mar 27, 2019, at 11:34 AM, zhangli...@apache.org wrote: > > I summarize the issues we received on this thread: > > 1. PR for [1], missing some licenses, already merged. > 2. Sharding-proxy can’t run for

Re: [Discuss] Acceptance test for ShardingSphere 4.0.0 [RC1] release

Hi all I have checked below feature, the result is ok. I think we can release 4.0.0 [RC1] 1. check sharding/orchestration/transaction function for sharding-jdbc. see https://github.com/sharding-sphere/shardingsphere-accept-test/tree/dev/sharding-jdbc-test

Re: Say hi

Welcome on board! -- Zhao Jun Apache Sharding-Sphere & ServiceComb > On Feb 12, 2019, at 10:07 AM, Gosling Von wrote: > > Welcome hongjun ~ > > > Best Regards, > Von Gosling > >> 在 2019年2月11日，下午4:33，duhongjun 写道： >> >> Hi All >> I am Du Hongjun, I am honored to be

[Refactor]Sharding-transaction-2pc XA design

Hi, all I'll refactor sharding-transaction-2pc-xa, here[1] is the detail design, please feel free to give me some advices. changes faced to XA DataSource to handle XA Connection instead of AtomikosDataSourceBean adapt Connection to XAConnection if needed Get XAResource, then inject it into XA

Re: Recommand to open `Squash and merge` as default merge inGitHubrepo

I have changed mail setting :) Let us try to use `Squash and merge` & `Rebase and merge` , we’d like to share the experience each other. -- Zhao Jun Apache Sharding-Sphere & ServiceComb > On Nov 23, 2018, at 12:07 PM, 吴晟 Sheng Wu wrote: > > I am not sure whether `rebase and