Re:[DISCUSS]About a hotfix release version 4.1.1

2020-05-15 Thread KimmKing
Hi, community. There are 9 PMCs/Committers reply on this thread so far and all agree with version 4.1.1, and also suggest carry several PRs to this new release version. So we will get these PRs merged done, and then launch to release ASAP. At 2020-05-14 14:46:23, "KimmKing" wrote: >Hi,

Re: [DISCUSS]About a hotfix release version 4.1.1

2020-05-15 Thread Zhang Yonglun
+1. I will carry two other PRs to 4.1.1 for Sharding-Proxy fixed in 5.0.0. #3555, fix postgresql proxy return redundant command complete packet https://github.com/apache/shardingsphere/pull/5178 #3556, affect rows is always zero when using sharding-proxy postgresq

Re: [DISCUSS]About a hotfix release version 4.1.1

2020-05-14 Thread avalon566
+1, LGTM! YangWen Ou(avalon566) Apache ShardingSphere On 5/14/2020 14:46,KimmKing wrote: Hi, community. After the latest version 4.1.0 release, there is a bug[1] found during loading Oracle tables metadata and cause sharding-jdbc/proxy can't bootstrap. And it had fixed in master by a community

Re:Re: [DISCUSS]About a hotfix release version 4.1.1

2020-05-14 Thread Sion Yang
+1 , I think we should solve some sharding-scaling bug and issue in 4.1.1 version. And there is a enhancement in scaling for 5.0.0 before, I think it also can be enhance in 4.1.1 list: [1] https://github.com/apache/shardingsphere/issues/5390 [2]

Re: [DISCUSS]About a hotfix release version 4.1.1

2020-05-14 Thread zhaojun
+1, I found another mysql8 compatible issue[1], it's better to release it in 4.1.1. since theMySQLServerInfo.SERVER_VERSION is fixed at 5.6.4, so jdbc-driver will send the sql contains query_cache_size, we should dynamically judge it based on the physical database version, also i'have made some

Re: [DISCUSS]About a hotfix release version 4.1.1

2020-05-14 Thread Zhiyi Yan
Good idea. Zhiyi Yan (Zhyee) Apache ShardingSphere zhangli...@apache.org 于2020年5月14日周四 下午5:55写道: > +1, release 4.1.1 is necessary and we at least need to include #5436 which > is break all Oracle dialect. > > IMO, release this one issue only is good enough. > >

Re: [DISCUSS]About a hotfix release version 4.1.1

2020-05-14 Thread Zonglei Dong
+1, for Oracle user, It is very necessary. Zonglei Dong Apache ShardingSphere On 05/14/2020 17:54,zhangli...@apache.org wrote: +1, release 4.1.1 is necessary and we at least need to include #5436 which is break all Oracle dialect. IMO, release this one issue only is good enough.

Re:[DISCUSS]About a hotfix release version 4.1.1

2020-05-14 Thread TaoZhi
In my opnion, the releasing of the version 4.1.1 is better. TaoZhi At 2020-05-14 14:46:23, "KimmKing" wrote: >Hi, community. > After the latest version 4.1.0 release, there is a bug[1] found during > loading Oracle tables metadata and cause sharding-jdbc/proxy can't bootstrap. > And

Re: [DISCUSS]About a hotfix release version 4.1.1

2020-05-14 Thread Sheng Wu
hotfix for a blocking issue, makes sense to me. Sheng Wu 吴晟 Twitter, wusheng1108 KimmKing 于2020年5月14日周四 下午2:46写道: > Hi, community. > After the latest version 4.1.0 release, there is a bug[1] found > during loading Oracle tables metadata and cause sharding-jdbc/proxy can't > bootstrap. >