Re:[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0

2019-12-24 Thread Sion Yang
+1I checked the LICENSE, NOTICE, Checksums, PGP signatures and installing source code.No problem happened. Checklist: [x] Download links are valid. [x] Checksums and PGP signatures are valid. [x] DISCLAIMER is included. [x] Source code artifacts have correct names matching the current release.

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0

2019-12-24 Thread avalon566
+1 approve [x] Download links are valid. [x] Checksums and PGP signatures are valid. [x] DISCLAIMER is included. [x] Source code artifacts have correct names matching the current release. [x] LICENSE and NOTICE files are correct for each ShardingSphere repo. [x] All files have license

Re: 4.0.0 stable version release plan

2019-12-24 Thread Rimaljit Kaur
Is RC3 production environment stable? On Wed, Dec 25, 2019, 8:19 AM zhangli...@apache.org wrote: > Hi Rimaljit, > > Thank you for pay attention for us. Maybe you can try to use 4.0.0-RC3. > > We have some API changes from 3.x to 4.x > > -- > > Liang Zhang (John) > Apache

Re: opentracing dependency upgrade to 0.31.0

2019-12-24 Thread Zhang Yonglun
Hi sanmu, 1. ShardingSphere now keeps consistent with SkyWalking use the ot 0.30.0. 2. Yes, there's no spi now. But I thinks #2478 will not influence you when using 0.31.0. 3. Welcome you to submit a PR. It will be perfect if you finish the test ahead. Sanmu Wang 于2019年12月25日周三 上午10:58写道: >

Re: opentracing dependency upgrade to 0.31.0

2019-12-24 Thread Zhang Yonglun
I agree with you. -- Zhang Yonglun Apache ShardingSphere Sheng Wu 于2019年12月25日周三 下午3:32写道: > Hi > > Feedback on behalf of SkyWalking PMC and ShardingSphere PPMC. > > OpenTracing is not widely used today. And 0.31 breaks many APIs in 0.30, > and causes a lot of confusion. > SkyWalking

Re: 4.0.0 stable version release plan

2019-12-24 Thread zhangli...@apache.org
> Is RC3 production environment stable? No, but the API is same, you can try to study the API first. -- Liang Zhang (John) Apache ShardingSphere & Dubbo Rimaljit Kaur 于2019年12月25日周三 上午11:55写道: > Is RC3 production environment stable? > > On Wed, Dec 25, 2019, 8:19 AM

Re: opentracing dependency upgrade to 0.31.0

2019-12-24 Thread Sheng Wu
Hi Feedback on behalf of SkyWalking PMC and ShardingSphere PPMC. OpenTracing is not widely used today. And 0.31 breaks many APIs in 0.30, and causes a lot of confusion. SkyWalking community has no one following this update and no user feedback about this. An update, OpenTracing and OpenCensus