[GitHub] [incubator-shardingsphere] codefairy08 commented on issue #2241: Left join get more data then expected

2019-04-22 Thread GitBox
codefairy08 commented on issue #2241: Left join get more data then expected URL: https://github.com/apache/incubator-shardingsphere/issues/2241#issuecomment-485652756 The sql has two sharding tables ts_order and ts_order_address, but only has one sharding column,ts_order_address table

[GitHub] [incubator-shardingsphere] codefairy08 edited a comment on issue #2241: Left join get more data then expected

2019-04-22 Thread GitBox
codefairy08 edited a comment on issue #2241: Left join get more data then expected URL: https://github.com/apache/incubator-shardingsphere/issues/2241#issuecomment-485623735 The description is very clear This is an

[GitHub] [incubator-shardingsphere-doc] wgy8283335 closed issue #113: Some terms need explanation

2019-04-22 Thread GitBox
wgy8283335 closed issue #113: Some terms need explanation URL: https://github.com/apache/incubator-shardingsphere-doc/issues/113 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-shardingsphere] wgy8283335 commented on issue #2213: ProxyMain in sharding-proxy-example. The connection to sharding-proxy server refused.

2019-04-22 Thread GitBox
wgy8283335 commented on issue #2213: ProxyMain in sharding-proxy-example. The connection to sharding-proxy server refused. URL: https://github.com/apache/incubator-shardingsphere/issues/2213#issuecomment-485641126 @tuohai666. Beacuse, the issue has been resolved, after modified

Refine the Release Guide

2019-04-22 Thread Zhang Yonglun
Hi, I'm colleting comments for refine the Release Guide[1] of ShardingSphere. Here are some from the VOTE list[2] and ANNOUNCE list[3]. For the VOTE part: 1. Send the VOTE mail only to gene...@incubator.apache.org for IPMC vote in case of confusing. For the ANNOUNCE part: 1. Add disclaimer. 2.

[GitHub] [incubator-shardingsphere] traceless removed a comment on issue #2219: SnowflakeShardingKeyGenerator hava a bug

2019-04-22 Thread GitBox
traceless removed a comment on issue #2219: SnowflakeShardingKeyGenerator hava a bug URL: https://github.com/apache/incubator-shardingsphere/issues/2219#issuecomment-485632532 @tristaZero oh, i just kown why you design the method vibrateSequenceOffset.

[GitHub] [incubator-shardingsphere] traceless commented on issue #2219: SnowflakeShardingKeyGenerator hava a bug

2019-04-22 Thread GitBox
traceless commented on issue #2219: SnowflakeShardingKeyGenerator hava a bug URL: https://github.com/apache/incubator-shardingsphere/issues/2219#issuecomment-485633211 @tristaZero so , it no problem in you code. Because I misunderstood it ('vibrateSequenceOffset')

[GitHub] [incubator-shardingsphere] traceless commented on issue #2219: SnowflakeShardingKeyGenerator hava a bug

2019-04-22 Thread GitBox
traceless commented on issue #2219: SnowflakeShardingKeyGenerator hava a bug URL: https://github.com/apache/incubator-shardingsphere/issues/2219#issuecomment-485632532 @tristaZero oh, i just kown why you design the method vibrateSequenceOffset.

[GitHub] [incubator-shardingsphere-doc] terrymanu commented on issue #113: Some terms need explanation

2019-04-22 Thread GitBox
terrymanu commented on issue #113: Some terms need explanation URL: https://github.com/apache/incubator-shardingsphere-doc/issues/113#issuecomment-485631756 Any other update or can we close this issue? This is an automated

[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #155: Sharding Concept SQL revision

2019-04-22 Thread GitBox
terrymanu merged pull request #155: Sharding Concept SQL revision URL: https://github.com/apache/incubator-shardingsphere-doc/pull/155 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] traceless commented on issue #2219: SnowflakeShardingKeyGenerator hava a bug

2019-04-22 Thread GitBox
traceless commented on issue #2219: SnowflakeShardingKeyGenerator hava a bug URL: https://github.com/apache/incubator-shardingsphere/issues/2219#issuecomment-485631673 @tristaZero Hi I thought the 'SequenceOffset' was designed for the sequence offset ,but i can find anyway to set the

[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #154: Update document for sharing-transaction-spring

2019-04-22 Thread GitBox
terrymanu merged pull request #154: Update document for sharing-transaction-spring URL: https://github.com/apache/incubator-shardingsphere-doc/pull/154 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere-doc] terrymanu commented on issue #153: Update 'route.en.md'

2019-04-22 Thread GitBox
terrymanu commented on issue #153: Update 'route.en.md' URL: https://github.com/apache/incubator-shardingsphere-doc/pull/153#issuecomment-485631370 This pr is fine, I just merge it This is an automated message from the

[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #153: Update 'route.en.md'

2019-04-22 Thread GitBox
terrymanu merged pull request #153: Update 'route.en.md' URL: https://github.com/apache/incubator-shardingsphere-doc/pull/153 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2219: SnowflakeShardingKeyGenerator hava a bug

2019-04-22 Thread GitBox
tristaZero edited a comment on issue #2219: SnowflakeShardingKeyGenerator hava a bug URL: https://github.com/apache/incubator-shardingsphere/issues/2219#issuecomment-485624089 @traceless Hi, There two scenarios that we need to jump to next millSecond. First, sequences in one

[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2219: SnowflakeShardingKeyGenerator hava a bug

2019-04-22 Thread GitBox
tristaZero edited a comment on issue #2219: SnowflakeShardingKeyGenerator hava a bug URL: https://github.com/apache/incubator-shardingsphere/issues/2219#issuecomment-485624089 @traceless Hi, There two scenarios, we will change to next millSecond. First, sequences are used up, i.e,

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2219: SnowflakeShardingKeyGenerator hava a bug

2019-04-22 Thread GitBox
tristaZero commented on issue #2219: SnowflakeShardingKeyGenerator hava a bug URL: https://github.com/apache/incubator-shardingsphere/issues/2219#issuecomment-485624089 @traceless Hi, If we want to vibrateSequenceOffset() for every sequence, i think the better solution is, ```

[GitHub] [incubator-shardingsphere] a137872798 commented on issue #2245: I can't find class MySQLStatementParser

2019-04-22 Thread GitBox
a137872798 commented on issue #2245: I can't find class MySQLStatementParser URL: https://github.com/apache/incubator-shardingsphere/issues/2245#issuecomment-485623807 thank you for your answer 发自我的iPhone -- Original -- From: duhongjun

[GitHub] [incubator-shardingsphere] codefairy08 commented on issue #2241: Left join get more data then expected

2019-04-22 Thread GitBox
codefairy08 commented on issue #2241: Left join get more data then expected URL: https://github.com/apache/incubator-shardingsphere/issues/2241#issuecomment-485623735 Good issue,The description is very clear This is an

[GitHub] [incubator-shardingsphere] codefairy08 commented on issue #2245: I can't find class MySQLStatementParser

2019-04-22 Thread GitBox
codefairy08 commented on issue #2245: I can't find class MySQLStatementParser URL: https://github.com/apache/incubator-shardingsphere/issues/2245#issuecomment-485623076 please execute mvn clean install in root directory of shardingsphere

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2213: ProxyMain in sharding-proxy-example. The connection to sharding-proxy server refused.

2019-04-22 Thread GitBox
tuohai666 commented on issue #2213: ProxyMain in sharding-proxy-example. The connection to sharding-proxy server refused. URL: https://github.com/apache/incubator-shardingsphere/issues/2213#issuecomment-485405491 @wgy8283335 Could you tell why close this issue?

[GitHub] [incubator-shardingsphere] wgy8283335 closed issue #2213: ProxyMain in sharding-proxy-example. The connection to sharding-proxy server refused.

2019-04-22 Thread GitBox
wgy8283335 closed issue #2213: ProxyMain in sharding-proxy-example. The connection to sharding-proxy server refused. URL: https://github.com/apache/incubator-shardingsphere/issues/2213 This is an automated message from the

[GitHub] [incubator-shardingsphere] wgy8283335 commented on issue #2213: ProxyMain in sharding-proxy-example. The connection to sharding-proxy server refused.

2019-04-22 Thread GitBox
wgy8283335 commented on issue #2213: ProxyMain in sharding-proxy-example. The connection to sharding-proxy server refused. URL: https://github.com/apache/incubator-shardingsphere/issues/2213#issuecomment-485403417 @tuohai666 . Thanks for your help.

[GitHub] [incubator-shardingsphere] sofay commented on issue #2231: OrConditionFiller#getTableName error

2019-04-22 Thread GitBox
sofay commented on issue #2231: OrConditionFiller#getTableName error URL: https://github.com/apache/incubator-shardingsphere/issues/2231#issuecomment-485397183 customer and customer_account_change_record all use shardingDataSource.

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2249: Add unit tests for authentication of proxy

2019-04-22 Thread GitBox
coveralls commented on issue #2249: Add unit tests for authentication of proxy URL: https://github.com/apache/incubator-shardingsphere/pull/2249#issuecomment-485390757 ## Pull Request Test Coverage Report for [Build 7729](https://coveralls.io/builds/22944918) * **0** of **0**

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2249: Add unit tests for authentication of proxy

2019-04-22 Thread GitBox
terrymanu merged pull request #2249: Add unit tests for authentication of proxy URL: https://github.com/apache/incubator-shardingsphere/pull/2249 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #2249: Add unit tests for authentication of proxy

2019-04-22 Thread GitBox
tristaZero opened a new pull request #2249: Add unit tests for authentication of proxy URL: https://github.com/apache/incubator-shardingsphere/pull/2249 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] codefairy08 commented on issue #2231: OrConditionFiller#getTableName error

2019-04-22 Thread GitBox
codefairy08 commented on issue #2231: OrConditionFiller#getTableName error URL: https://github.com/apache/incubator-shardingsphere/issues/2231#issuecomment-485385432 customer is in default data source ? customer_account_change_record is in sharding da.ta source? sharding column is in

[GitHub] [incubator-shardingsphere] tristaZero closed issue #2247: Wrong Batch Comment

2019-04-22 Thread GitBox
tristaZero closed issue #2247: Wrong Batch Comment URL: https://github.com/apache/incubator-shardingsphere/issues/2247 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #2248: #2247, fix Batch Comment in Sharding-Proxy start.bat

2019-04-22 Thread GitBox
tristaZero merged pull request #2248: #2247, fix Batch Comment in Sharding-Proxy start.bat URL: https://github.com/apache/incubator-shardingsphere/pull/2248 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2247: Wrong Batch Comment

2019-04-22 Thread GitBox
tristaZero commented on issue #2247: Wrong Batch Comment URL: https://github.com/apache/incubator-shardingsphere/issues/2247#issuecomment-485379139 Thanks for your issue. This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] Moriadry commented on issue #2235: Return error result for `select database(); `

2019-04-22 Thread GitBox
Moriadry commented on issue #2235: Return error result for `select database();` URL: https://github.com/apache/incubator-shardingsphere/issues/2235#issuecomment-485378137 Get it. This is an automated message from the Apache

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2235: Return error result for `select database(); `

2019-04-22 Thread GitBox
tuohai666 commented on issue #2235: Return error result for `select database();` URL: https://github.com/apache/incubator-shardingsphere/issues/2235#issuecomment-485377617 @Moriadry Download sharding-proxy from:

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2240: Feature/bug fix

2019-04-22 Thread GitBox
tuohai666 commented on issue #2240: Feature/bug fix URL: https://github.com/apache/incubator-shardingsphere/pull/2240#issuecomment-485376975 Let's talk in that issue instead of this place. This is an automated message from

[GitHub] [incubator-shardingsphere] xlongshu opened a new pull request #2248: #2247, fix Batch Comment in Sharding-Proxy start.bat

2019-04-22 Thread GitBox
xlongshu opened a new pull request #2248: #2247, fix Batch Comment in Sharding-Proxy start.bat URL: https://github.com/apache/incubator-shardingsphere/pull/2248 Fixes #2247. Changes proposed in this pull request: -

[GitHub] [incubator-shardingsphere] tuohai666 edited a comment on issue #2195: Support Stored Procedure for Sharding-Proxy IF not sharding

2019-04-22 Thread GitBox
tuohai666 edited a comment on issue #2195: Support Stored Procedure for Sharding-Proxy IF not sharding URL: https://github.com/apache/incubator-shardingsphere/issues/2195#issuecomment-485374983 CREATE PROCEDURE and CREATE FUNCTION Syntax both supported. Here are the test cases:

[GitHub] [incubator-shardingsphere] tuohai666 edited a comment on issue #2195: Support Stored Procedure for Sharding-Proxy IF not sharding

2019-04-22 Thread GitBox
tuohai666 edited a comment on issue #2195: Support Stored Procedure for Sharding-Proxy IF not sharding URL: https://github.com/apache/incubator-shardingsphere/issues/2195#issuecomment-485374983 CREATE PROCEDURE and CREATE FUNCTION Syntax both supported. Here are the test cases:

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2195: Support Stored Procedure for Sharding-Proxy IF not sharding

2019-04-22 Thread GitBox
tuohai666 commented on issue #2195: Support Stored Procedure for Sharding-Proxy IF not sharding URL: https://github.com/apache/incubator-shardingsphere/issues/2195#issuecomment-485374983 CREATE PROCEDURE and CREATE FUNCTION Syntax both supported. Here are the test cases: For

[GitHub] [incubator-shardingsphere] xlongshu opened a new issue #2247: Wrong Batch Comment

2019-04-22 Thread GitBox
xlongshu opened a new issue #2247: Wrong Batch Comment URL: https://github.com/apache/incubator-shardingsphere/issues/2247 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you have: - Searched open and closed [GitHub

[GitHub] [incubator-shardingsphere] Moriadry commented on issue #2240: Feature/bug fix

2019-04-22 Thread GitBox
Moriadry commented on issue #2240: Feature/bug fix URL: https://github.com/apache/incubator-shardingsphere/pull/2240#issuecomment-485367410 @tuohai666 one more thing, I'm trying to help with some sharding-proxy bug like this: https://github.com/apache/incubator-shardingsphere/issues/2235

[GitHub] [incubator-shardingsphere] Moriadry edited a comment on issue #2240: Feature/bug fix

2019-04-22 Thread GitBox
Moriadry edited a comment on issue #2240: Feature/bug fix URL: https://github.com/apache/incubator-shardingsphere/pull/2240#issuecomment-485367410 @tuohai666 one more thing, I'm trying to help with some sharding-proxy bug like this:

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2207: Weekly Report of ShardingSphere (2019.4.8 to 2019.4.12)

2019-04-22 Thread GitBox
terrymanu closed issue #2207: Weekly Report of ShardingSphere (2019.4.8 to 2019.4.12) URL: https://github.com/apache/incubator-shardingsphere/issues/2207 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2195: Support Stored Procedure for Sharding-Proxy IF not sharding

2019-04-22 Thread GitBox
terrymanu closed issue #2195: Support Stored Procedure for Sharding-Proxy IF not sharding URL: https://github.com/apache/incubator-shardingsphere/issues/2195 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2244: #2195, identify call statement

2019-04-22 Thread GitBox
terrymanu merged pull request #2244: #2195, identify call statement URL: https://github.com/apache/incubator-shardingsphere/pull/2244 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #2240: Feature/bug fix

2019-04-22 Thread GitBox
tuohai666 merged pull request #2240: Feature/bug fix URL: https://github.com/apache/incubator-shardingsphere/pull/2240 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere] tuohai666 closed issue #2142: OpenTracingSQLExecutionHook.toStringList NullPointerException

2019-04-22 Thread GitBox
tuohai666 closed issue #2142: OpenTracingSQLExecutionHook.toStringList NullPointerException URL: https://github.com/apache/incubator-shardingsphere/issues/2142 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2243: Review dcl parsing for sqlserver

2019-04-22 Thread GitBox
terrymanu merged pull request #2243: Review dcl parsing for sqlserver URL: https://github.com/apache/incubator-shardingsphere/pull/2243 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2240: Feature/bug fix

2019-04-22 Thread GitBox
tuohai666 commented on issue #2240: Feature/bug fix URL: https://github.com/apache/incubator-shardingsphere/pull/2240#issuecomment-485363211 @Moriadry Accept. Thanks for your effort. This is an automated message from the

[GitHub] [incubator-shardingsphere] limeng546364 commented on issue #2233: Canonical names should be kebab-case ('-' separated), lowercase alpha-numeric characters and must start with a letter

2019-04-22 Thread GitBox
limeng546364 commented on issue #2233: Canonical names should be kebab-case ('-' separated), lowercase alpha-numeric characters and must start with a letter URL: https://github.com/apache/incubator-shardingsphere/issues/2233#issuecomment-485356057 I am using Spring boot 2.1.4 supported

[GitHub] [incubator-shardingsphere-doc] Harper0122 closed issue #158: Weekly Report of ShardingSphere (2019.4.15 to 2019.4.19)

2019-04-22 Thread GitBox
Harper0122 closed issue #158: Weekly Report of ShardingSphere (2019.4.15 to 2019.4.19) URL: https://github.com/apache/incubator-shardingsphere-doc/issues/158 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] Harper0122 opened a new issue #2246: Weekly Report of ShardingSphere (2019.4.15 to 2019.4.19)

2019-04-22 Thread GitBox
Harper0122 opened a new issue #2246: Weekly Report of ShardingSphere (2019.4.15 to 2019.4.19) URL: https://github.com/apache/incubator-shardingsphere/issues/2246 This report is to review recent changes and developments of ShardingSphere. ## Basic Data Basic data shows how the

[GitHub] [incubator-shardingsphere] Moriadry edited a comment on issue #2240: Feature/bug fix

2019-04-22 Thread GitBox
Moriadry edited a comment on issue #2240: Feature/bug fix URL: https://github.com/apache/incubator-shardingsphere/pull/2240#issuecomment-485346535 @tuohai666 I Already fixed it. This is an automated message from the Apache

[GitHub] [incubator-shardingsphere] Moriadry commented on issue #2240: Feature/bug fix

2019-04-22 Thread GitBox
Moriadry commented on issue #2240: Feature/bug fix URL: https://github.com/apache/incubator-shardingsphere/pull/2240#issuecomment-485346535 Already fix it. This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #2240: Feature/bug fix

2019-04-22 Thread GitBox
coveralls edited a comment on issue #2240: Feature/bug fix URL: https://github.com/apache/incubator-shardingsphere/pull/2240#issuecomment-485246055 ## Pull Request Test Coverage Report for [Build 7720](https://coveralls.io/builds/22942474) * **3** of **3** **(100.0%)** changed

[GitHub] [incubator-shardingsphere] cherrylzhao closed issue #2170: Integrate mongodb transaction conflict error

2019-04-22 Thread GitBox
cherrylzhao closed issue #2170: Integrate mongodb transaction conflict error URL: https://github.com/apache/incubator-shardingsphere/issues/2170 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #2170: Integrate mongodb transaction conflict error

2019-04-22 Thread GitBox
cherrylzhao commented on issue #2170: Integrate mongodb transaction conflict error URL: https://github.com/apache/incubator-shardingsphere/issues/2170#issuecomment-485343558 we'll close this issue due to no response more than 7 days.

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #2244: #2195, identify call statement

2019-04-22 Thread GitBox
coveralls edited a comment on issue #2244: #2195, identify call statement URL: https://github.com/apache/incubator-shardingsphere/pull/2244#issuecomment-485332686 ## Pull Request Test Coverage Report for [Build 7719](https://coveralls.io/builds/22942218) * **2** of **2**

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #2227: sharding-sphere 3.1.0 , Tables not configured with sharding rules will not choice the defaultDataSrouces,and will choice the

2019-04-22 Thread GitBox
KomachiSion commented on issue #2227: sharding-sphere 3.1.0 , Tables not configured with sharding rules will not choice the defaultDataSrouces,and will choice the first dataSource in dataSourcesMap. URL: https://github.com/apache/incubator-shardingsphere/issues/2227#issuecomment-485339733

[GitHub] [incubator-shardingsphere] KomachiSion closed issue #2227: sharding-sphere 3.1.0 , Tables not configured with sharding rules will not choice the defaultDataSrouces,and will choice the first

2019-04-22 Thread GitBox
KomachiSion closed issue #2227: sharding-sphere 3.1.0 , Tables not configured with sharding rules will not choice the defaultDataSrouces,and will choice the first dataSource in dataSourcesMap. URL: https://github.com/apache/incubator-shardingsphere/issues/2227

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #2227: sharding-sphere 3.1.0 , Tables not configured with sharding rules will not choice the defaultDataSrouces,and will choice the

2019-04-22 Thread GitBox
KomachiSion commented on issue #2227: sharding-sphere 3.1.0 , Tables not configured with sharding rules will not choice the defaultDataSrouces,and will choice the first dataSource in dataSourcesMap. URL: https://github.com/apache/incubator-shardingsphere/issues/2227#issuecomment-485339086