[
https://issues.apache.org/jira/browse/SHIRO-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francois Papon resolved SHIRO-722.
--
Resolution: Resolved
[~boris-petrov] thanks!
> Add SameSite option to cookies
> ---
fpapon merged pull request #67: [SHIRO-722] Add SameSite option to cookies
URL: https://github.com/apache/shiro/pull/67
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
asf-ci commented on issue #67: [SHIRO-722] Add SameSite option to cookies
URL: https://github.com/apache/shiro/pull/67#issuecomment-530872542
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/159/
---
bdemers commented on issue #67: [SHIRO-722] Add SameSite option to cookies
URL: https://github.com/apache/shiro/pull/67#issuecomment-530867864
Thanks!!
This is an automated message from the Apache Git Service.
To respond to th
boris-petrov opened a new pull request #48: Add info about the SameSite cookie
flag
URL: https://github.com/apache/shiro-site/pull/48
Implementation of the flag is
[here](https://github.com/apache/shiro/pull/67).
This is an
boris-petrov commented on issue #67: [SHIRO-722] Add SameSite option to cookies
URL: https://github.com/apache/shiro/pull/67#issuecomment-530864987
@bdemers - done for both points.
This is an automated message from the Apache
bdemers commented on issue #67: [SHIRO-722] Add SameSite option to cookies
URL: https://github.com/apache/shiro/pull/67#issuecomment-530858412
@boris-petrov great point on the default, it sounds like LAX might be the
way to go, a quick google shows it's that will be the default starting wit
[
https://issues.apache.org/jira/browse/SHIRO-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francois Papon updated SHIRO-722:
-
Fix Version/s: 1.5.0
> Add SameSite option to cookies
> --
>
>
asf-ci commented on issue #67: Add SameSite option to cookies
URL: https://github.com/apache/shiro/pull/67#issuecomment-530750236
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/158/
---
fpapon commented on issue #67: Add SameSite option to cookies
URL: https://github.com/apache/shiro/pull/67#issuecomment-530732144
@boris-petrov for me the `getSameSite` and `setSameSite` are not a problem.
This is an automated
boris-petrov commented on issue #67: Add SameSite option to cookies
URL: https://github.com/apache/shiro/pull/67#issuecomment-530730949
Also, what about the added methods? The test is failing because of that
also. I can overload the `addCookieHeader` and call the new one from the old
one,
boris-petrov edited a comment on issue #67: Add SameSite option to cookies
URL: https://github.com/apache/shiro/pull/67#issuecomment-530730949
Also, what about the added methods? The test is failing because of that
also. I can overload the `buildHeaderValue` and call the new one from the ol
boris-petrov commented on issue #67: Add SameSite option to cookies
URL: https://github.com/apache/shiro/pull/67#issuecomment-530730424
Do we want `NONE` as the default? Chrome is making `LAX` the default and
that is more secure than `NONE`. Perhaps Shiro should do the same?
--
13 matches
Mail list logo