weltonrodrigo commented on pull request #82:
URL: https://github.com/apache/shiro-site/pull/82#issuecomment-843144004
> @weltonrodrigo thanks a lot for your PR!
> I think you could squash the commits, they are short enough.
Done.
--
This is an automated message from the Apache
bmarwell commented on pull request #82:
URL: https://github.com/apache/shiro-site/pull/82#issuecomment-842871696
@weltonrodrigo thanks a lot for your PR!
I think you could squash the commits, they are short enough.
--
This is an automated message from the Apache Git Service.
To
weltonrodrigo opened a new pull request #82:
URL: https://github.com/apache/shiro-site/pull/82
This is a very useful feature for the docker world, but couldn't find any
information about it in the docs.
Also, please note that the footer link "Edit this Page on Github" is
pointing
pitjazz commented on pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#issuecomment-842217904
> @pitjazz can you squash the commits please?
Rebase done: commits squashed as requested. Ping @fpapon
--
This is an automated message from the Apache Git Service.
To
fpapon commented on pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#issuecomment-842288870
@bmarwell is it ok for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bmarwell commented on a change in pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#discussion_r633743708
##
File path: how-to-contribute.md
##
@@ -1,177 +1,198 @@
-#Contributing to Apache Shiro
-
-* [Introduction](#HowtoContribute-introduction)
-*
fpapon merged pull request #80:
URL: https://github.com/apache/shiro-site/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
fpapon commented on pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#issuecomment-842288870
@bmarwell is it ok for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pitjazz commented on pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#issuecomment-842217904
> @pitjazz can you squash the commits please?
Rebase done: commits squashed as requested. Ping @fpapon
--
This is an automated message from the Apache Git Service.
To
fpapon merged pull request #80:
URL: https://github.com/apache/shiro-site/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
bmarwell commented on pull request #80:
URL: https://github.com/apache/shiro-site/pull/80#issuecomment-841609848
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
fpapon commented on pull request #80:
URL: https://github.com/apache/shiro-site/pull/80#issuecomment-841605489
@bmarwell @bdemers Are we good with this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
weltonrodrigo opened a new pull request #81:
URL: https://github.com/apache/shiro-site/pull/81
Thanks for the maintenance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
bdemers merged pull request #79:
URL: https://github.com/apache/shiro-site/pull/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
fpapon commented on a change in pull request #80:
URL: https://github.com/apache/shiro-site/pull/80#discussion_r619705144
##
File path: spring-boot.md.vtl
##
@@ -9,7 +9,7 @@ Shiro's Spring-Boot integration is the easiest way to integrate
Shiro into a Spr
Web Applications
fpapon commented on a change in pull request #80:
URL: https://github.com/apache/shiro-site/pull/80#discussion_r619705144
##
File path: spring-boot.md.vtl
##
@@ -9,7 +9,7 @@ Shiro's Spring-Boot integration is the easiest way to integrate
Shiro into a Spr
Web Applications
bmarwell commented on a change in pull request #80:
URL: https://github.com/apache/shiro-site/pull/80#discussion_r619465672
##
File path: spring-boot.md.vtl
##
@@ -9,7 +9,7 @@ Shiro's Spring-Boot integration is the easiest way to integrate
Shiro into a Spr
Web Applications
pitjazz commented on pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#issuecomment-824736821
> @pitjazz you may need to sign the CLA for his one (if you haven't already)
https://apache.org/licenses/contributor-agreements.html
@bdemers, signed CLA contract is now
fpapon opened a new pull request #80:
URL: https://github.com/apache/shiro-site/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
pitjazz commented on pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#issuecomment-822361884
> @pitjazz you may need to sign the CLA for his one (if you haven't already)
https://apache.org/licenses/contributor-agreements.html
Ok, I'll take a look at it
--
This
bdemers commented on pull request #79:
URL: https://github.com/apache/shiro-site/pull/79#issuecomment-821579786
Thanks, @BR-Nicholas-Prado!
I think I found a related issue (copypasta) over here:
https://github.com/apache/shiro/pull/294
--
This is an automated message from the Apache
BR-Nicholas-Prado opened a new pull request #79:
URL: https://github.com/apache/shiro-site/pull/79
This changes two misspellings of wield as weild. I allege this is
a misspelling because it does not match the corresponding code [0]
[0]
bdemers commented on pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#issuecomment-821533523
@pitjazz you may need to sign the CLA for his one (if you haven't already)
https://apache.org/licenses/contributor-agreements.html
--
This is an automated message from the
bdemers commented on a change in pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#discussion_r615094161
##
File path: how-to-contribute.md
##
@@ -1,177 +1,198 @@
-#Contributing to Apache Shiro
-
-* [Introduction](#HowtoContribute-introduction)
-* [Help
bdemers commented on a change in pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#discussion_r615093364
##
File path: how-to-contribute.md
##
@@ -1,177 +1,198 @@
-#Contributing to Apache Shiro
-
-* [Introduction](#HowtoContribute-introduction)
-* [Help
bdemers commented on a change in pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#discussion_r615092216
##
File path: how-to-contribute.md
##
@@ -1,177 +1,198 @@
-#Contributing to Apache Shiro
-
-* [Introduction](#HowtoContribute-introduction)
-* [Help
bdemers commented on a change in pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#discussion_r615091838
##
File path: how-to-contribute.md
##
@@ -1,177 +1,198 @@
-#Contributing to Apache Shiro
-
-* [Introduction](#HowtoContribute-introduction)
-* [Help
bdemers commented on a change in pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#discussion_r615091664
##
File path: how-to-contribute.md
##
@@ -1,177 +1,198 @@
-#Contributing to Apache Shiro
-
-* [Introduction](#HowtoContribute-introduction)
-* [Help
bdemers commented on a change in pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#discussion_r615090800
##
File path: how-to-contribute.md
##
@@ -1,177 +1,198 @@
-#Contributing to Apache Shiro
-
-* [Introduction](#HowtoContribute-introduction)
-* [Help
pitjazz commented on pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#issuecomment-821503515
@bdemers, please take a look at this review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
bdemers merged pull request #78:
URL: https://github.com/apache/shiro-site/pull/78
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
pitjazz edited a comment on pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#issuecomment-781284848
@bmarwell, please take a look at pull request again, modifications made
based on your comments.
This is
pitjazz edited a comment on pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#issuecomment-781284848
@bmarwell, please take a look at pull request again, modifications made
based on your comments!
This is
pitjazz commented on pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#issuecomment-781284848
Please take a look to pull request again. Modifications made based on
comments.
This is an automated message
pitjazz commented on a change in pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#discussion_r578349161
##
File path: how-to-contribute.md
##
@@ -104,74 +99,101 @@ If you want to add a feature, you should bring it up for
discussion on the dev@s
In short,
bmarwell commented on a change in pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#discussion_r577397594
##
File path: how-to-contribute.md
##
@@ -50,51 +68,28 @@ The Roadmap is the best way to get an overview. The
Unscheduled list also needs
When
bmarwell commented on a change in pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#discussion_r578201872
##
File path: how-to-contribute.md
##
@@ -30,17 +44,21 @@ Document writers are usually the most wanted people so if
you like to help but y
You can be a
bdemers commented on a change in pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#discussion_r577902053
##
File path: how-to-contribute.md
##
@@ -30,17 +44,21 @@ Document writers are usually the most wanted people so if
you like to help but y
You can be a
bmarwell commented on a change in pull request #77:
URL: https://github.com/apache/shiro-site/pull/77#discussion_r577395053
##
File path: how-to-contribute.md
##
@@ -104,74 +99,101 @@ If you want to add a feature, you should bring it up for
discussion on the dev@s
In
pitjazz opened a new pull request #77:
URL: https://github.com/apache/shiro-site/pull/77
Simplified and modified contribute page so that more people would read it
and volunteer.
This is an automated message from the Apache
bmarwell commented on pull request #76:
URL: https://github.com/apache/shiro-site/pull/76#issuecomment-775188816
Thanks, I would like to create a v1 first before we merge:
```
scms/scms-github-action@main is not allowed to be used in apache/shiro-site.
Actions in this workflow
bdemers commented on a change in pull request #76:
URL: https://github.com/apache/shiro-site/pull/76#discussion_r572077919
##
File path: .github/workflows/scms.yml
##
@@ -0,0 +1,30 @@
+# This is a basic workflow to help you get started with Actions
+
+name: CI
+
+# Controls
bmarwell opened a new pull request #76:
URL: https://github.com/apache/shiro-site/pull/76
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fpapon merged pull request #75:
URL: https://github.com/apache/shiro-site/pull/75
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
fpapon opened a new pull request #75:
URL: https://github.com/apache/shiro-site/pull/75
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fpapon merged pull request #74:
URL: https://github.com/apache/shiro-site/pull/74
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bmarwell opened a new pull request #74:
URL: https://github.com/apache/shiro-site/pull/74
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fpapon merged pull request #73:
URL: https://github.com/apache/shiro-site/pull/73
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lprimak opened a new pull request #73:
URL: https://github.com/apache/shiro-site/pull/73
Update Flow Logix Jakarta EE integration
This is an automated message from the Apache Git Service.
To respond to the message, please
fpapon merged pull request #72:
URL: https://github.com/apache/shiro-site/pull/72
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ivvve opened a new pull request #72:
URL: https://github.com/apache/shiro-site/pull/72
I just found a tiny little typo and fixed it!
This is an automated message from the Apache Git Service.
To respond to the message, please
fpapon opened a new pull request #71:
URL: https://github.com/apache/shiro-site/pull/71
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fpapon merged pull request #71:
URL: https://github.com/apache/shiro-site/pull/71
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
fpapon merged pull request #70:
URL: https://github.com/apache/shiro-site/pull/70
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
fpapon closed pull request #69:
URL: https://github.com/apache/shiro-site/pull/69
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ratan325 opened a new pull request #69:
URL: https://github.com/apache/shiro-site/pull/69
Created my new md file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
bdemers closed pull request #68:
URL: https://github.com/apache/shiro-site/pull/68
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bdemers commented on pull request #68:
URL: https://github.com/apache/shiro-site/pull/68#issuecomment-703101476
I love Hacktoberfest, the rule just changes to help prevent this type of
issue
This is an automated message
mayank161001 opened a new pull request #68:
URL: https://github.com/apache/shiro-site/pull/68
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
fpapon commented on pull request #67:
URL: https://github.com/apache/shiro-site/pull/67#issuecomment-702645618
another spam
This is an automated message from the Apache Git Service.
To respond to the message, please log on
fpapon closed pull request #67:
URL: https://github.com/apache/shiro-site/pull/67
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
arshad699 opened a new pull request #67:
URL: https://github.com/apache/shiro-site/pull/67
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
fpapon commented on pull request #66:
URL: https://github.com/apache/shiro-site/pull/66#issuecomment-702634927
spam
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
fpapon closed pull request #66:
URL: https://github.com/apache/shiro-site/pull/66
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
infoguru19 opened a new pull request #66:
URL: https://github.com/apache/shiro-site/pull/66
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
bdemers commented on pull request #65:
URL: https://github.com/apache/shiro-site/pull/65#issuecomment-702214940
@Nek- I understand some folks are gaming the system, but as long as it's a
valid fix, we will take it.
Now... if we had to PRs to handle, that's a different problem ;)
Nek- edited a comment on pull request #65:
URL: https://github.com/apache/shiro-site/pull/65#issuecomment-702123236
@fpapon this PR is useless. As well as many other the guy did. Checkout its
account and contributions of the last day. Also be careful on other
repositories. This year is
Nek- commented on pull request #65:
URL: https://github.com/apache/shiro-site/pull/65#issuecomment-702123236
@fpapon this PR is useless. As well as many other the guy did. Checkout its
account and contributions of the last day.
fpapon commented on pull request #65:
URL: https://github.com/apache/shiro-site/pull/65#issuecomment-702121085
@Nek- not shure to understand because the PR seems to be good.
This is an automated message from the Apache Git
Nek- commented on pull request #65:
URL: https://github.com/apache/shiro-site/pull/65#issuecomment-702116735
@fpapon this user is known as spammer for hacktoberfest. Please add the
label `spam` to this PR.
Learn more: https://hacktoberfest.digitalocean.com/details#spam
fpapon merged pull request #65:
URL: https://github.com/apache/shiro-site/pull/65
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Amitsharma0201 opened a new pull request #65:
URL: https://github.com/apache/shiro-site/pull/65
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
fpapon opened a new pull request #64:
URL: https://github.com/apache/shiro-site/pull/64
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fpapon merged pull request #64:
URL: https://github.com/apache/shiro-site/pull/64
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
fpapon merged pull request #63:
URL: https://github.com/apache/shiro-site/pull/63
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
evfool opened a new pull request #63:
URL: https://github.com/apache/shiro-site/pull/63
Use sources instead of soucres.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
fpapon merged pull request #62:
URL: https://github.com/apache/shiro-site/pull/62
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
fpapon commented on pull request #62:
URL: https://github.com/apache/shiro-site/pull/62#issuecomment-652652069
I will merge and publish on the website.
This is an automated message from the Apache Git Service.
To respond to
mpfz0r opened a new pull request #62:
URL: https://github.com/apache/shiro-site/pull/62
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
bdemers closed pull request #30:
URL: https://github.com/apache/shiro-site/pull/30
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bdemers commented on pull request #30:
URL: https://github.com/apache/shiro-site/pull/30#issuecomment-632269135
I'm going to close this issue. Translations are welcome! but let's move to
the developer list to figure out how to organize this:
https://shiro.apache.org/mailing-lists.html
bdemers merged pull request #55:
URL: https://github.com/apache/shiro-site/pull/55
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bdemers merged pull request #60:
URL: https://github.com/apache/shiro-site/pull/60
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bdemers merged pull request #61:
URL: https://github.com/apache/shiro-site/pull/61
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bdemers commented on pull request #61:
URL: https://github.com/apache/shiro-site/pull/61#issuecomment-631676921
Thanks @rbowen!
I think we should probably make an SEO related pass on the site:
- scan for dead links
- https://securityheaders.com/
- etc
rbowen opened a new pull request #61:
URL: https://github.com/apache/shiro-site/pull/61
Sorry, folks, here's another 404'ed link.
This is an automated message from the Apache Git Service.
To respond to the message, please
rbowen opened a new pull request #60:
URL: https://github.com/apache/shiro-site/pull/60
Removes 404'ed link. Perhaps someone knows where the article lives now?
This is an automated message from the Apache Git Service.
To
fpapon opened a new pull request #59:
URL: https://github.com/apache/shiro-site/pull/59
…e compliance for the annou...@apache.org mailing list
This is an automated message from the Apache Git Service.
To respond to the
fpapon opened a new pull request #58:
URL: https://github.com/apache/shiro-site/pull/58
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mookkiah commented on a change in pull request #219:
URL: https://github.com/apache/shiro/pull/219#discussion_r418543929
##
File path: web/src/main/java/org/apache/shiro/web/filter/authz/IpFilter.java
##
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation
fpapon commented on a change in pull request #219:
URL: https://github.com/apache/shiro/pull/219#discussion_r418504044
##
File path: web/src/main/java/org/apache/shiro/web/filter/authz/IpFilter.java
##
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
bmhm opened a new pull request #221:
URL: https://github.com/apache/shiro/pull/221
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bmhm opened a new pull request #220:
URL: https://github.com/apache/shiro/pull/220
Fixes SHIRO-551.
I used StringJoiner instead of StringUtils.ToString, because the dependency
to StringUtils is probably not needed anymore since Java 8.
mookkiah commented on a change in pull request #219:
URL: https://github.com/apache/shiro/pull/219#discussion_r418409785
##
File path: web/src/main/java/org/apache/shiro/web/filter/authz/IpFilter.java
##
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation
mookkiah commented on pull request #219:
URL: https://github.com/apache/shiro/pull/219#issuecomment-622170327
> > Don't we loose the original contributor (@rswheeldon) name when we
squash? I don't see option in the github UI to squash. Do you want me to
recreate another PR by squashing
fpapon commented on pull request #219:
URL: https://github.com/apache/shiro/pull/219#issuecomment-622130244
> Don't we loose the original contributor (@rswheeldon) name when we squash?
I don't see option in the github UI to squash. Do you want me to recreate
another PR by squashing all
fpapon commented on pull request #219:
URL: https://github.com/apache/shiro/pull/219#issuecomment-622129989
You can choose the commits that you want to squash, not all.
There is no Github button but you can do it in command line like:
`git rebase -i HEAD~7`
The number is the
mookkiah commented on pull request #219:
URL: https://github.com/apache/shiro/pull/219#issuecomment-622122038
Don't we loose the original contributor (@rswheeldon) name when we squash? I
don't see option in the github UI to squash. Do you want me to recreate another
PR by squashing all
fpapon commented on pull request #219:
URL: https://github.com/apache/shiro/pull/219#issuecomment-622092680
@mookkiah thanks for the PR!
Can you squash the commits please?
This is an automated message from the Apache Git
fpapon commented on pull request #57:
URL: https://github.com/apache/shiro/pull/57#issuecomment-622092303
@mookkiah thanks! I close this one.
This is an automated message from the Apache Git Service.
To respond to the
201 - 300 of 1017 matches
Mail list logo
