[GitHub] [shiro] fpapon commented on issue #58: [SHIRO-337] basic cdi support

fpapon commented on issue #58: [SHIRO-337] basic cdi support URL: https://github.com/apache/shiro/pull/58#issuecomment-499796951 Hi @rmannibucau thanks for this PR! I will make some test case with the current master (1.5.0).

[GitHub] [shiro] fpapon commented on issue #85: [SHIRO-687] Adding Spring's Filters to ShiroFilterFactorBean when using Java config

fpapon commented on issue #85: [SHIRO-687] Adding Spring's Filters to ShiroFilterFactorBean when using Java config URL: https://github.com/apache/shiro/pull/85#issuecomment-499780938 @bdemers the license header is missing in

[GitHub] [shiro] fpapon merged pull request #143: [SHIRO-696] Use root pom Jetty version in Jaxrs sample

fpapon merged pull request #143: [SHIRO-696] Use root pom Jetty version in Jaxrs sample URL: https://github.com/apache/shiro/pull/143 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [shiro] asfgit commented on issue #85: [SHIRO-687] Adding Spring's Filters to ShiroFilterFactorBean when using Java config

asfgit commented on issue #85: [SHIRO-687] Adding Spring's Filters to ShiroFilterFactorBean when using Java config URL: https://github.com/apache/shiro/pull/85#issuecomment-499654080 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] asfgit commented on issue #135: [SHIRO-699] Fix maven warning for exec-maven-plugin and upgrade to 1.6.0

asfgit commented on issue #135: [SHIRO-699] Fix maven warning for exec-maven-plugin and upgrade to 1.6.0 URL: https://github.com/apache/shiro/pull/135#issuecomment-499650716 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] asfgit commented on issue #137: [SHIRO-698] Improve build with maven profile

asfgit commented on issue #137: [SHIRO-698] Improve build with maven profile URL: https://github.com/apache/shiro/pull/137#issuecomment-499639460 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/106/

[GitHub] [shiro] asfgit commented on issue #140: [SHIRO-697] Reduce shiro test logging level to INFO

asfgit commented on issue #140: [SHIRO-697] Reduce shiro test logging level to INFO URL: https://github.com/apache/shiro/pull/140#issuecomment-499630688 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/105/

[GitHub] [shiro] asfgit commented on issue #143: [SHIRO-696] Use root pom Jetty version in Jaxrs sample

asfgit commented on issue #143: [SHIRO-696] Use root pom Jetty version in Jaxrs sample URL: https://github.com/apache/shiro/pull/143#issuecomment-499621809 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/104/

[GitHub] [shiro] fpapon commented on issue #85: [SHIRO-687] Adding Spring's Filters to ShiroFilterFactorBean when using Java config

fpapon commented on issue #85: [SHIRO-687] Adding Spring's Filters to ShiroFilterFactorBean when using Java config URL: https://github.com/apache/shiro/pull/85#issuecomment-499607074 retest this please This is an automated

[GitHub] [shiro] fpapon opened a new pull request #143: [SHIRO-696] Use root pom Jetty version in Jaxrs sample

fpapon opened a new pull request #143: [SHIRO-696] Use root pom Jetty version in Jaxrs sample URL: https://github.com/apache/shiro/pull/143 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shiro] fpapon merged pull request #140: Reduce shiro test logging level to INFO

fpapon merged pull request #140: Reduce shiro test logging level to INFO URL: https://github.com/apache/shiro/pull/140 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] fpapon merged pull request #142: SHIRO-696 - Upgrade Jetty

fpapon merged pull request #142: SHIRO-696 - Upgrade Jetty URL: https://github.com/apache/shiro/pull/142 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [shiro] asfgit commented on issue #142: SHIRO-696 - Upgrade Jetty

asfgit commented on issue #142: SHIRO-696 - Upgrade Jetty URL: https://github.com/apache/shiro/pull/142#issuecomment-499478206 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/103/

[GitHub] [shiro] coheigea opened a new pull request #142: SHIRO-696 - Upgrade Jetty

coheigea opened a new pull request #142: SHIRO-696 - Upgrade Jetty URL: https://github.com/apache/shiro/pull/142 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shiro] fpapon merged pull request #141: SHIRO-695 - Update Hazelcast

fpapon merged pull request #141: SHIRO-695 - Update Hazelcast URL: https://github.com/apache/shiro/pull/141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [shiro] asfgit commented on issue #141: SHIRO-695 - Update Hazelcast

asfgit commented on issue #141: SHIRO-695 - Update Hazelcast URL: https://github.com/apache/shiro/pull/141#issuecomment-498629013 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/102/

[GitHub] [shiro] coheigea opened a new pull request #141: SHIRO-695 - Update Hazelcast

coheigea opened a new pull request #141: SHIRO-695 - Update Hazelcast URL: https://github.com/apache/shiro/pull/141 Hazelcast should be updated as it carries a CVE: hazelcast-3.7.2.jar (pkg:maven/com.hazelcast/hazelcast@3.7.2, cpe:2.3:a:hazelcast:hazelcast:3.7.2:::*) :

[GitHub] [shiro] asfgit commented on issue #59: [SHIRO-617] ShiroFilter initialize WebEnvironment on startup

asfgit commented on issue #59: [SHIRO-617] ShiroFilter initialize WebEnvironment on startup URL: https://github.com/apache/shiro/pull/59#issuecomment-497965629 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/101/Build

[GitHub] [shiro] asfgit commented on issue #129: [SHIRO-694] Adds BearerToken support

asfgit commented on issue #129: [SHIRO-694] Adds BearerToken support URL: https://github.com/apache/shiro/pull/129#issuecomment-497965237 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/100/

[GitHub] [shiro] fpapon commented on issue #59: [SHIRO-617] ShiroFilter initialize WebEnvironment on startup

fpapon commented on issue #59: [SHIRO-617] ShiroFilter initialize WebEnvironment on startup URL: https://github.com/apache/shiro/pull/59#issuecomment-497964395 @col-panic Hi, thanks for your PR, I'm actually working about OSGi in Shiro, I will take a look.

[GitHub] [shiro] fpapon commented on issue #140: Reduce shiro test logging level to INFO

fpapon commented on issue #140: Reduce shiro test logging level to INFO URL: https://github.com/apache/shiro/pull/140#issuecomment-497919046 @bdemers I think we should also put the root logger to `INFO` in the `samples/guice/src/main/resources/log4j.properties`

[GitHub] [shiro] fpapon commented on issue #140: Reduce shiro test logging level to INFO

fpapon commented on issue #140: Reduce shiro test logging level to INFO URL: https://github.com/apache/shiro/pull/140#issuecomment-497917934 @bdemers full agree, we only have to put in `TRACE` or `DEBUG` when we have some errors and help to fix.

[GitHub] [shiro] fpapon merged pull request #137: Build

fpapon merged pull request #137: Build URL: https://github.com/apache/shiro/pull/137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [shiro] asfgit commented on issue #140: Reduce shiro test logging level to INFO

asfgit commented on issue #140: Reduce shiro test logging level to INFO URL: https://github.com/apache/shiro/pull/140#issuecomment-497857314 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/99/

[GitHub] [shiro] bdemers commented on issue #140: Reduce shiro test logging level to INFO

bdemers commented on issue #140: Reduce shiro test logging level to INFO URL: https://github.com/apache/shiro/pull/140#issuecomment-497839283 @fpapon, related to your build cleanup PRs I have mixed feelings about this, as generally I think extra logging is useful for CI, but in general

[GitHub] [shiro] asfgit commented on issue #137: Build

asfgit commented on issue #137: Build URL: https://github.com/apache/shiro/pull/137#issuecomment-497836128 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/98/

[GitHub] [shiro] bdemers commented on a change in pull request #137: Build

bdemers commented on a change in pull request #137: Build URL: https://github.com/apache/shiro/pull/137#discussion_r289524251 ## File path: pom.xml ## @@ -1457,6 +1468,9 @@ ci + +false + Review

[GitHub] [shiro] fpapon commented on a change in pull request #137: Build

fpapon commented on a change in pull request #137: Build URL: https://github.com/apache/shiro/pull/137#discussion_r289519208 ## File path: pom.xml ## @@ -1354,6 +1355,16 @@ + +fast + +true +true

[GitHub] [shiro] bdemers commented on a change in pull request #137: Build

bdemers commented on a change in pull request #137: Build URL: https://github.com/apache/shiro/pull/137#discussion_r289518821 ## File path: pom.xml ## @@ -1457,6 +1468,9 @@ ci + +false + Review

[GitHub] [shiro] bdemers commented on a change in pull request #137: Build

bdemers commented on a change in pull request #137: Build URL: https://github.com/apache/shiro/pull/137#discussion_r289518585 ## File path: pom.xml ## @@ -1354,6 +1355,16 @@ + +fast + +true +true

[GitHub] [shiro] fpapon commented on issue #137: Build

fpapon commented on issue #137: Build URL: https://github.com/apache/shiro/pull/137#issuecomment-497822375 @bdemers are you ok with the lastest changes? This is an automated message from the Apache Git Service. To respond to

[GitHub] [shiro] fpapon commented on a change in pull request #66: [SHIRO 625] Update 10 minute Tutorial

fpapon commented on a change in pull request #66: [SHIRO 625] Update 10 minute Tutorial URL: https://github.com/apache/shiro/pull/66#discussion_r289263089 ## File path: core/src/main/java/org/apache/shiro/env/BasicIniEnvironment.java ## @@ -0,0 +1,22 @@ +package

[GitHub] [shiro] asfgit commented on issue #66: [SHIRO 625] Update 10 minute Tutorial

asfgit commented on issue #66: [SHIRO 625] Update 10 minute Tutorial URL: https://github.com/apache/shiro/pull/66#issuecomment-497573238 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/97/Build result:

[GitHub] [shiro] fpapon commented on issue #66: [SHIRO 625] Update 10 minute Tutorial

fpapon commented on issue #66: [SHIRO 625] Update 10 minute Tutorial URL: https://github.com/apache/shiro/pull/66#issuecomment-497565847 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] [shiro] fpapon commented on issue #129: Adds BearerToken support

fpapon commented on issue #129: Adds BearerToken support URL: https://github.com/apache/shiro/pull/129#issuecomment-497424418 Thanks @bdemers ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shiro] bdemers merged pull request #78: Adding another WildcardPermission test case

bdemers merged pull request #78: Adding another WildcardPermission test case URL: https://github.com/apache/shiro/pull/78 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] fpapon commented on issue #78: Adding another WildcardPermission test case

fpapon commented on issue #78: Adding another WildcardPermission test case URL: https://github.com/apache/shiro/pull/78#issuecomment-497423173 @bdemers can we merge this? This is an automated message from the Apache Git

[GitHub] [shiro] bdemers commented on issue #138: Support base64 encoded salt in JdbcRealm

bdemers commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-497347975 @steinarb yup, you should be all set! Thanks again!! This is an automated

[GitHub] [shiro] steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm

steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-497344471 > @steinarb Looks good to me! can you sign an Apache CLA? https://www.apache.org/licenses/#contributor-license-agreements @bdemers I have

[GitHub] [shiro] asfgit commented on issue #138: Support base64 encoded salt in JdbcRealm

asfgit commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-497334871 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/96/

[GitHub] [shiro] bdemers commented on issue #138: Support base64 encoded salt in JdbcRealm

bdemers commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-497328346 @steinarb Looks good to me! can you sign an Apache CLA? https://www.apache.org/licenses/#contributor-license-agreements

[GitHub] [shiro] bdemers commented on a change in pull request #138: Support base64 encoded salt in JdbcRealm

bdemers commented on a change in pull request #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#discussion_r288985987 ## File path: core/src/main/java/org/apache/shiro/realm/jdbc/JdbcRealm.java ## @@ -247,7 +261,11 @@ protected

[GitHub] [shiro] bdemers commented on issue #138: Support base64 encoded salt in JdbcRealm

bdemers commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-497325189 Thanks @steinarb! I just retargeted the PR against `master` (it was 1.4 previously)

[GitHub] [shiro] bdemers commented on issue #139: SHIRO-693 - Update plugins

bdemers commented on issue #139: SHIRO-693 - Update plugins URL: https://github.com/apache/shiro/pull/139#issuecomment-497323818 Thanks @coheigea !! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shiro] bdemers merged pull request #139: SHIRO-693 - Update plugins

bdemers merged pull request #139: SHIRO-693 - Update plugins URL: https://github.com/apache/shiro/pull/139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [shiro] asfgit commented on issue #139: SHIRO-693 - Update plugins

asfgit commented on issue #139: SHIRO-693 - Update plugins URL: https://github.com/apache/shiro/pull/139#issuecomment-497293824 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/95/

[GitHub] [shiro] coheigea opened a new pull request #139: SHIRO-693 - Update plugins

coheigea opened a new pull request #139: SHIRO-693 - Update plugins URL: https://github.com/apache/shiro/pull/139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shiro] asfgit commented on issue #138: Support base64 encoded salt in JdbcRealm

asfgit commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-497153211 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/94/

[GitHub] [shiro] asfgit commented on issue #138: Support base64 encoded salt in JdbcRealm

asfgit commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-497142120 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/93/

[GitHub] [shiro] asfgit commented on issue #138: Support base64 encoded salt in JdbcRealm

asfgit commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-497134073 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/92/

[GitHub] [shiro] asfgit commented on issue #138: Support base64 encoded salt in JdbcRealm

asfgit commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-497120236 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/91/

[GitHub] [shiro] bdemers commented on issue #138: Support base64 encoded salt in JdbcRealm

bdemers commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-497101348 @steinarb can you rebase your branch against master? This is an automated message

[GitHub] [shiro] steinarb opened a new pull request #138: Support base64 encoded salt in JdbcRealm

steinarb opened a new pull request #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138 This fixes [SPAP-552](https://issues.apache.org/jira/browse/SHIRO-552) The change has been tested in https://github.com/steinarb/authservice/ and worked

[GitHub] [shiro] bdemers merged pull request #129: Adds BearerToken support

bdemers merged pull request #129: Adds BearerToken support URL: https://github.com/apache/shiro/pull/129 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [shiro] asfgit commented on issue #129: Adds BearerToken support

asfgit commented on issue #129: Adds BearerToken support URL: https://github.com/apache/shiro/pull/129#issuecomment-497078820 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/90/

[GitHub] [shiro] bdemers commented on issue #129: Adds BearerToken support

bdemers commented on issue #129: Adds BearerToken support URL: https://github.com/apache/shiro/pull/129#issuecomment-497058433 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shiro] fpapon commented on issue #137: Build

fpapon commented on issue #137: Build URL: https://github.com/apache/shiro/pull/137#issuecomment-496823457 I made changes: - deactivate `jacoco` by default - activate `jacoco` with the `ci` profile - add a `fast` profile with unit tests and ITtests deactivated

[GitHub] [shiro] asfgit commented on issue #137: Build

asfgit commented on issue #137: Build URL: https://github.com/apache/shiro/pull/137#issuecomment-496822686 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/87/

[GitHub] [shiro] fpapon commented on issue #137: Build

fpapon commented on issue #137: Build URL: https://github.com/apache/shiro/pull/137#issuecomment-496602102 > Thanks for taking this on! > > I think we should try to simplify this a little more to make this easier for contributors. > Maybe ending with something like `mvn clean

[GitHub] [shiro] fpapon commented on a change in pull request #137: Build

fpapon commented on a change in pull request #137: Build URL: https://github.com/apache/shiro/pull/137#discussion_r288206310 ## File path: pom.xml ## @@ -1474,5 +1478,54 @@ + +samples + +

[GitHub] [shiro] bdemers commented on issue #137: Build

bdemers commented on issue #137: Build URL: https://github.com/apache/shiro/pull/137#issuecomment-496511288 Thanks for taking this on! I think we should try to simplify this a little more to make this easier for contributors. Maybe ending with something like `mvn clean install

[GitHub] [shiro] asfgit commented on issue #137: Build

asfgit commented on issue #137: Build URL: https://github.com/apache/shiro/pull/137#issuecomment-496322335 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/83/

[GitHub] [shiro] asfgit commented on issue #137: Build

asfgit commented on issue #137: Build URL: https://github.com/apache/shiro/pull/137#issuecomment-496321836 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/82/

[GitHub] [shiro] fpapon opened a new pull request #137: Build

fpapon opened a new pull request #137: Build URL: https://github.com/apache/shiro/pull/137 Hi @bdemers, I made some changes on the maven build: - move `integration-tests` and `test-coverage` to the `ci` profile - add a `samples` profile and move the module `sample`into This can

[GitHub] [shiro] fpapon merged pull request #135: Fix maven warning for exec-maven-plugin and upgrade to 1.6.0

fpapon merged pull request #135: Fix maven warning for exec-maven-plugin and upgrade to 1.6.0 URL: https://github.com/apache/shiro/pull/135 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shiro] asfgit commented on issue #135: Fix maven warning for exec-maven-plugin and upgrade to 1.6.0

asfgit commented on issue #135: Fix maven warning for exec-maven-plugin and upgrade to 1.6.0 URL: https://github.com/apache/shiro/pull/135#issuecomment-495938395 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/80/

[GitHub] [shiro] fpapon opened a new pull request #135: Fix maven warning for exec-maven-plugin and upgrade to 1.6.0

fpapon opened a new pull request #135: Fix maven warning for exec-maven-plugin and upgrade to 1.6.0 URL: https://github.com/apache/shiro/pull/135 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shiro] fpapon merged pull request #134: [SHIRO-691] Upgrade to maven-jar-plugin 3.1.1

fpapon merged pull request #134: [SHIRO-691] Upgrade to maven-jar-plugin 3.1.1 URL: https://github.com/apache/shiro/pull/134 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [shiro] asfgit commented on issue #134: [SHIRO-691] Upgrade to maven-jar-plugin 3.1.1

asfgit commented on issue #134: [SHIRO-691] Upgrade to maven-jar-plugin 3.1.1 URL: https://github.com/apache/shiro/pull/134#issuecomment-495933628 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/79/

[GitHub] [shiro] fpapon opened a new pull request #134: [SHIRO-691] Upgrade to maven-jar-plugin 3.1.1

fpapon opened a new pull request #134: [SHIRO-691] Upgrade to maven-jar-plugin 3.1.1 URL: https://github.com/apache/shiro/pull/134 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [shiro] fpapon merged pull request #90: [SHIRO-661] Add check for the principal of subject whether is null

fpapon merged pull request #90: [SHIRO-661] Add check for the principal of subject whether is null URL: https://github.com/apache/shiro/pull/90 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shiro] fpapon commented on issue #90: [SHIRO-661] Add check for the principal of subject whether is null

fpapon commented on issue #90: [SHIRO-661] Add check for the principal of subject whether is null URL: https://github.com/apache/shiro/pull/90#issuecomment-493051625 I think we could add `&& hasPrincipals()` here:

[GitHub] [shiro] fpapon commented on issue #90: [SHIRO-661] Add check for the principal of subject whether is null

fpapon commented on issue #90: [SHIRO-661] Add check for the principal of subject whether is null URL: https://github.com/apache/shiro/pull/90#issuecomment-492897172 Yes I think so :) This is an automated message from the

[GitHub] [shiro] bdemers commented on issue #90: [SHIRO-661] Add check for the principal of subject whether is null

bdemers commented on issue #90: [SHIRO-661] Add check for the principal of subject whether is null URL: https://github.com/apache/shiro/pull/90#issuecomment-492819583 AHH!! maybe adding the null check to `isAuthenticated()` is the way to go then?

[GitHub] [shiro] fpapon commented on issue #90: [SHIRO-661] Add check for the principal of subject whether is null

fpapon commented on issue #90: [SHIRO-661] Add check for the principal of subject whether is null URL: https://github.com/apache/shiro/pull/90#issuecomment-492774048 @bdemers ok, if I understand the use case, this is about the serialization of the `Principal`. Sometimes it cannot be

[GitHub] [shiro] bdemers commented on issue #90: [SHIRO-661] Add check for the principal of subject whether is null

bdemers commented on issue #90: [SHIRO-661] Add check for the principal of subject whether is null URL: https://github.com/apache/shiro/pull/90#issuecomment-492765167 @fpapon i think we would want to figure out how/why a subject is authenticated without a principal. Possibly making

[GitHub] [shiro] fpapon commented on issue #90: [SHIRO-661] Add check for the principal of subject whether is null

fpapon commented on issue #90: [SHIRO-661] Add check for the principal of subject whether is null URL: https://github.com/apache/shiro/pull/90#issuecomment-492758890 @bdemers as we have no update about the user, can I merge this and made the update in the `Subject` `isAuthenticated`

[GitHub] [shiro] fpapon merged pull request #133: [SHIRO-689] Upgrade to commons-codec 1.12

fpapon merged pull request #133: [SHIRO-689] Upgrade to commons-codec 1.12 URL: https://github.com/apache/shiro/pull/133 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] asfgit commented on issue #133: [SHIRO-689] Upgrade to commons-codec 1.12

asfgit commented on issue #133: [SHIRO-689] Upgrade to commons-codec 1.12 URL: https://github.com/apache/shiro/pull/133#issuecomment-491529508 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/77/

[GitHub] [shiro] fpapon opened a new pull request #133: [SHIRO-689] Upgrade to commons-codec 1.12

fpapon opened a new pull request #133: [SHIRO-689] Upgrade to commons-codec 1.12 URL: https://github.com/apache/shiro/pull/133 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [shiro] fpapon merged pull request #132: [SHIRO-685] Potential NullPointerException if PermissionResolver retu…

fpapon merged pull request #132: [SHIRO-685] Potential NullPointerException if PermissionResolver retu… URL: https://github.com/apache/shiro/pull/132 This is an automated message from the Apache Git Service. To respond to

[GitHub] [shiro] asfgit commented on issue #132: [SHIRO-685] Potential NullPointerException if PermissionResolver retu…

asfgit commented on issue #132: [SHIRO-685] Potential NullPointerException if PermissionResolver retu… URL: https://github.com/apache/shiro/pull/132#issuecomment-491001863 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] fpapon commented on a change in pull request #132: [SHIRO-685] Potential NullPointerException if PermissionResolver retu…

fpapon commented on a change in pull request #132: [SHIRO-685] Potential NullPointerException if PermissionResolver retu… URL: https://github.com/apache/shiro/pull/132#discussion_r282588719 ## File path: core/src/test/java/org/apache/shiro/realm/AuthorizingRealmTest.java

[GitHub] [shiro] asfgit commented on issue #132: [SHIRO-685] Potential NullPointerException if PermissionResolver retu…

asfgit commented on issue #132: [SHIRO-685] Potential NullPointerException if PermissionResolver retu… URL: https://github.com/apache/shiro/pull/132#issuecomment-490680337 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] bdemers commented on a change in pull request #132: [SHIRO-685] Potential NullPointerException if PermissionResolver retu…

bdemers commented on a change in pull request #132: [SHIRO-685] Potential NullPointerException if PermissionResolver retu… URL: https://github.com/apache/shiro/pull/132#discussion_r282270904 ## File path: core/src/test/java/org/apache/shiro/realm/AuthorizingRealmTest.java

[GitHub] [shiro] fpapon opened a new pull request #132: [SHIRO-685] Potential NullPointerException if PermissionResolver retu…

fpapon opened a new pull request #132: [SHIRO-685] Potential NullPointerException if PermissionResolver retu… URL: https://github.com/apache/shiro/pull/132 …rn null/empty string. Made changes according to the JIRA and I added a test case. @bdemers can you review please?

[GitHub] [shiro] fpapon merged pull request #131: [SHIRO-688] Upgrade to commons-cli 1.4

fpapon merged pull request #131: [SHIRO-688] Upgrade to commons-cli 1.4 URL: https://github.com/apache/shiro/pull/131 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] asfgit commented on issue #131: [SHIRO-688] Upgrade to commons-cli 1.4

asfgit commented on issue #131: [SHIRO-688] Upgrade to commons-cli 1.4 URL: https://github.com/apache/shiro/pull/131#issuecomment-490586968 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/74/

[GitHub] [shiro] fpapon opened a new pull request #131: [SHIRO-688] Upgrade to commons-cli 1.4

fpapon opened a new pull request #131: [SHIRO-688] Upgrade to commons-cli 1.4 URL: https://github.com/apache/shiro/pull/131 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [shiro] fpapon merged pull request #130: [SHIRO-681] Upgrade to compiler Java 8

fpapon merged pull request #130: [SHIRO-681] Upgrade to compiler Java 8 URL: https://github.com/apache/shiro/pull/130 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] fpapon opened a new pull request #130: [SHIRO-681] Upgrade to compiler Java 8

fpapon opened a new pull request #130: [SHIRO-681] Upgrade to compiler Java 8 URL: https://github.com/apache/shiro/pull/130 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [shiro] asfgit commented on issue #129: Adds BearerToken support

asfgit commented on issue #129: Adds BearerToken support URL: https://github.com/apache/shiro/pull/129#issuecomment-489774012 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/72/

[GitHub] [shiro] asfgit commented on issue #129: Adds BearerToken support

asfgit commented on issue #129: Adds BearerToken support URL: https://github.com/apache/shiro/pull/129#issuecomment-489759648 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/71/Build result: FAILURE[...truncated

[GitHub] [shiro] bdemers opened a new pull request #129: Adds BearerToken support

bdemers opened a new pull request #129: Adds BearerToken support URL: https://github.com/apache/shiro/pull/129 Abstracts the HTTP header processing out of BasicHttpAuthenticationFilter into HttpAuthenticationFilter (to support both BASIC and Bearer tokens) Adds `authcBearer` to

[GitHub] [shiro] asfgit commented on issue #85: Adding Spring's Filters to ShiroFilterFactorBean when using Java config

asfgit commented on issue #85: Adding Spring's Filters to ShiroFilterFactorBean when using Java config URL: https://github.com/apache/shiro/pull/85#issuecomment-489734717 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] asfgit commented on issue #85: Adding Spring's Filters to ShiroFilterFactorBean when using Java config

asfgit commented on issue #85: Adding Spring's Filters to ShiroFilterFactorBean when using Java config URL: https://github.com/apache/shiro/pull/85#issuecomment-489734369 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro-site] fpapon merged pull request #44: Release Shiro 1.4.1

fpapon merged pull request #44: Release Shiro 1.4.1 URL: https://github.com/apache/shiro-site/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [shiro-site] fpapon opened a new pull request #44: Release Shiro 1.4.1

fpapon opened a new pull request #44: Release Shiro 1.4.1 URL: https://github.com/apache/shiro-site/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [shiro-site] fpapon merged pull request #43: Update java-authentication-guide.md.vtl

fpapon merged pull request #43: Update java-authentication-guide.md.vtl URL: https://github.com/apache/shiro-site/pull/43 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro-site] fpapon commented on issue #43: Update java-authentication-guide.md.vtl

fpapon commented on issue #43: Update java-authentication-guide.md.vtl URL: https://github.com/apache/shiro-site/pull/43#issuecomment-487899404 Good catch ;) LGTM! Thanks This is an automated message from the Apache Git

<    4   5   6   7   8   9   10   11   >