[GitHub] [shiro] bdemers commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment

2019-07-02 Thread GitBox
bdemers commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment URL: https://github.com/apache/shiro/pull/156#issuecomment-507768223 Thanks for catching that @fpapon, I thought I had already changed my vote This is

[GitHub] [shiro] bdemers commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment

2019-06-27 Thread GitBox
bdemers commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment URL: https://github.com/apache/shiro/pull/156#issuecomment-506345743 Thanks!! Sorry one more nit, Can you add a `@deprecated` javadoc tag? Maybe say something about will remove in the next major version? or