> Brian Demers :
> I'm guessing in your case you might want to do something similar to what we
> do for Guice (create a WebEnvironment implementation)
> https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/WebGuiceEnvironment.java
> For the
fpapon commented on a change in pull request #157: SHIRO-712 - Add
BasicIniEnvironment
URL: https://github.com/apache/shiro/pull/157#discussion_r298365728
##
File path: core/src/main/java/org/apache/shiro/env/BasicIniEnvironment.java
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed
We should have added the javadoc tag leaving instructions on what to do.
I'm guessing in your case you might want to do something similar to what we
do for Guice (create a WebEnvironment implementation)
In my Shiro-in-OSGi-configured-by-code solutions I ended up using
the deprecated WebIniSecurityManagerFactory, with some tricks to find
the shiro.ini file in the OSGi classpath:
asfgit commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment
URL: https://github.com/apache/shiro/pull/156#issuecomment-506364456
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/130/
bdemers commented on a change in pull request #157: SHIRO-712 - Add
BasicIniEnvironment
URL: https://github.com/apache/shiro/pull/157#discussion_r298182745
##
File path: core/src/main/java/org/apache/shiro/env/BasicIniEnvironment.java
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed
bdemers commented on issue #157: SHIRO-712 - Add BasicIniEnvironment
URL: https://github.com/apache/shiro/pull/157#issuecomment-506350727
Nice!
This is an automated message from the Apache Git Service.
To respond to the
bdemers commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment
URL: https://github.com/apache/shiro/pull/156#issuecomment-506345743
Thanks!!
Sorry one more nit, Can you add a `@deprecated` javadoc tag? Maybe say
something about will remove in the next major version? or
coheigea commented on issue #156: SHIRO-711 - Remove JavaEnvironment
URL: https://github.com/apache/shiro/pull/156#issuecomment-506341305
@bdemers Yes, done.
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/SHIRO-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh updated SHIRO-711:
--
Summary: Deprecate JavaEnvironment (was: Remove JavaEnvironment)
> Deprecate
asfgit commented on issue #157: SHIRO-712 - Add BasicIniEnvironment
URL: https://github.com/apache/shiro/pull/157#issuecomment-506290933
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/129/
coheigea opened a new pull request #157: SHIRO-712 - Add BasicIniEnvironment
URL: https://github.com/apache/shiro/pull/157
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Colm O hEigeartaigh created SHIRO-712:
-
Summary: Add BasicIniEnvironment
Key: SHIRO-712
URL: https://issues.apache.org/jira/browse/SHIRO-712
Project: Shiro
Issue Type: Improvement
asfgit commented on issue #156: SHIRO-711 - Remove JavaEnvironment
URL: https://github.com/apache/shiro/pull/156#issuecomment-506288273
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/128/
Colm O hEigeartaigh created SHIRO-711:
-
Summary: Remove JavaEnvironment
Key: SHIRO-711
URL: https://issues.apache.org/jira/browse/SHIRO-711
Project: Shiro
Issue Type: Improvement
coheigea opened a new pull request #156: SHIRO-711 - Remove JavaEnvironment
URL: https://github.com/apache/shiro/pull/156
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
16 matches
Mail list logo