Re: What should deprecated class WebIniSecurityManagerFactory be replaced with in OSGi?

2019-06-27 Thread Steinar Bang
> Brian Demers : > I'm guessing in your case you might want to do something similar to what we > do for Guice (create a WebEnvironment implementation) > https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/WebGuiceEnvironment.java > For the

[GitHub] [shiro] fpapon commented on a change in pull request #157: SHIRO-712 - Add BasicIniEnvironment

2019-06-27 Thread GitBox
fpapon commented on a change in pull request #157: SHIRO-712 - Add BasicIniEnvironment URL: https://github.com/apache/shiro/pull/157#discussion_r298365728 ## File path: core/src/main/java/org/apache/shiro/env/BasicIniEnvironment.java ## @@ -0,0 +1,42 @@ +/* + * Licensed

Re: What should deprecated class WebIniSecurityManagerFactory be replaced with in OSGi?

2019-06-27 Thread Brian Demers
We should have added the javadoc tag leaving instructions on what to do. I'm guessing in your case you might want to do something similar to what we do for Guice (create a WebEnvironment implementation)

What should deprecated class WebIniSecurityManagerFactory be replaced with in OSGi?

2019-06-27 Thread Steinar Bang
In my Shiro-in-OSGi-configured-by-code solutions I ended up using the deprecated WebIniSecurityManagerFactory, with some tricks to find the shiro.ini file in the OSGi classpath:

[GitHub] [shiro] asfgit commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment

2019-06-27 Thread GitBox
asfgit commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment URL: https://github.com/apache/shiro/pull/156#issuecomment-506364456 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/130/

[GitHub] [shiro] bdemers commented on a change in pull request #157: SHIRO-712 - Add BasicIniEnvironment

2019-06-27 Thread GitBox
bdemers commented on a change in pull request #157: SHIRO-712 - Add BasicIniEnvironment URL: https://github.com/apache/shiro/pull/157#discussion_r298182745 ## File path: core/src/main/java/org/apache/shiro/env/BasicIniEnvironment.java ## @@ -0,0 +1,42 @@ +/* + * Licensed

[GitHub] [shiro] bdemers commented on issue #157: SHIRO-712 - Add BasicIniEnvironment

2019-06-27 Thread GitBox
bdemers commented on issue #157: SHIRO-712 - Add BasicIniEnvironment URL: https://github.com/apache/shiro/pull/157#issuecomment-506350727 Nice! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shiro] bdemers commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment

2019-06-27 Thread GitBox
bdemers commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment URL: https://github.com/apache/shiro/pull/156#issuecomment-506345743 Thanks!! Sorry one more nit, Can you add a `@deprecated` javadoc tag? Maybe say something about will remove in the next major version? or

[GitHub] [shiro] coheigea commented on issue #156: SHIRO-711 - Remove JavaEnvironment

2019-06-27 Thread GitBox
coheigea commented on issue #156: SHIRO-711 - Remove JavaEnvironment URL: https://github.com/apache/shiro/pull/156#issuecomment-506341305 @bdemers Yes, done. This is an automated message from the Apache Git Service. To

[jira] [Updated] (SHIRO-711) Deprecate JavaEnvironment

2019-06-27 Thread Colm O hEigeartaigh (JIRA)
[ https://issues.apache.org/jira/browse/SHIRO-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated SHIRO-711: -- Summary: Deprecate JavaEnvironment (was: Remove JavaEnvironment) > Deprecate

[GitHub] [shiro] asfgit commented on issue #157: SHIRO-712 - Add BasicIniEnvironment

2019-06-27 Thread GitBox
asfgit commented on issue #157: SHIRO-712 - Add BasicIniEnvironment URL: https://github.com/apache/shiro/pull/157#issuecomment-506290933 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/129/

[GitHub] [shiro] coheigea opened a new pull request #157: SHIRO-712 - Add BasicIniEnvironment

2019-06-27 Thread GitBox
coheigea opened a new pull request #157: SHIRO-712 - Add BasicIniEnvironment URL: https://github.com/apache/shiro/pull/157 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (SHIRO-712) Add BasicIniEnvironment

2019-06-27 Thread Colm O hEigeartaigh (JIRA)
Colm O hEigeartaigh created SHIRO-712: - Summary: Add BasicIniEnvironment Key: SHIRO-712 URL: https://issues.apache.org/jira/browse/SHIRO-712 Project: Shiro Issue Type: Improvement

[GitHub] [shiro] asfgit commented on issue #156: SHIRO-711 - Remove JavaEnvironment

2019-06-27 Thread GitBox
asfgit commented on issue #156: SHIRO-711 - Remove JavaEnvironment URL: https://github.com/apache/shiro/pull/156#issuecomment-506288273 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/128/

[jira] [Created] (SHIRO-711) Remove JavaEnvironment

2019-06-27 Thread Colm O hEigeartaigh (JIRA)
Colm O hEigeartaigh created SHIRO-711: - Summary: Remove JavaEnvironment Key: SHIRO-711 URL: https://issues.apache.org/jira/browse/SHIRO-711 Project: Shiro Issue Type: Improvement

[GitHub] [shiro] coheigea opened a new pull request #156: SHIRO-711 - Remove JavaEnvironment

2019-06-27 Thread GitBox
coheigea opened a new pull request #156: SHIRO-711 - Remove JavaEnvironment URL: https://github.com/apache/shiro/pull/156 This is an automated message from the Apache Git Service. To respond to the message, please log on to