[GitHub] [shiro] fpapon commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-09-22 Thread GitBox
fpapon commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168#issuecomment-533906738 Ok, I will add more tests. This is an automated message

[GitHub] [shiro] bdemers commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-09-22 Thread GitBox
bdemers commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168#issuecomment-533905138 This seems fine to me, but we might want to add a few more test cases around the escape?

[jira] [Commented] (SHIRO-679) Shiro modules have split packages

2019-09-22 Thread Steinar Bang (Jira)
[ https://issues.apache.org/jira/browse/SHIRO-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935377#comment-16935377 ] Steinar Bang commented on SHIRO-679: This is a possible duplicate of (or at least overlapping with)

[GitHub] [shiro] asf-ci commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-09-22 Thread GitBox
asf-ci commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168#issuecomment-533885094 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] fpapon opened a new pull request #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-09-22 Thread GitBox
fpapon opened a new pull request #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168 When fixing this issue, I found a bug in the `isCharEscaped` method and the `index` usage.

[jira] [Updated] (SHIRO-679) Shiro modules have split packages

2019-09-22 Thread Francois Papon (Jira)
[ https://issues.apache.org/jira/browse/SHIRO-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francois Papon updated SHIRO-679: - Fix Version/s: (was: 1.5.0) 2.0.0 > Shiro modules have split packages >