[GitHub] [shiro] fpapon merged pull request #179: Remove maven-gpg-plugin to force using apache pom parent settings

2019-11-15 Thread GitBox
fpapon merged pull request #179: Remove maven-gpg-plugin to force using apache pom parent settings URL: https://github.com/apache/shiro/pull/179 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shiro] asf-ci commented on issue #179: Remove maven-gpg-plugin to force using apache pom parent settings

2019-11-15 Thread GitBox
asf-ci commented on issue #179: Remove maven-gpg-plugin to force using apache pom parent settings URL: https://github.com/apache/shiro/pull/179#issuecomment-554564988 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] asf-ci commented on issue #179: Remove maven-gpg-plugin to force using apache pom parent settings

2019-11-15 Thread GitBox
asf-ci commented on issue #179: Remove maven-gpg-plugin to force using apache pom parent settings URL: https://github.com/apache/shiro/pull/179#issuecomment-554550714 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] fpapon opened a new pull request #179: Remove maven-gpg-plugin to force using apache pom parent settings

2019-11-15 Thread GitBox
fpapon opened a new pull request #179: Remove maven-gpg-plugin to force using apache pom parent settings URL: https://github.com/apache/shiro/pull/179 This is an automated message from the Apache Git Service. To respond to

[GitHub] [shiro] fpapon merged pull request #178: SHIRO-729 - Updating Quartz to 2.3.2

2019-11-15 Thread GitBox
fpapon merged pull request #178: SHIRO-729 - Updating Quartz to 2.3.2 URL: https://github.com/apache/shiro/pull/178 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shiro] asf-ci commented on issue #178: SHIRO-729 - Updating Quartz to 2.3.2

2019-11-15 Thread GitBox
asf-ci commented on issue #178: SHIRO-729 - Updating Quartz to 2.3.2 URL: https://github.com/apache/shiro/pull/178#issuecomment-554321102 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/175/

[GitHub] [shiro] asf-ci commented on issue #178: SHIRO-729 - Updating Quartz to 2.3.2

2019-11-15 Thread GitBox
asf-ci commented on issue #178: SHIRO-729 - Updating Quartz to 2.3.2 URL: https://github.com/apache/shiro/pull/178#issuecomment-554314582 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr-jdk11/4/

[GitHub] [shiro] coheigea opened a new pull request #178: SHIRO-729 - Updating Quartz to 2.3.2

2019-11-15 Thread GitBox
coheigea opened a new pull request #178: SHIRO-729 - Updating Quartz to 2.3.2 URL: https://github.com/apache/shiro/pull/178 Tested the feature loads on Karaf as well. This is an automated message from the Apache Git Service.

[GitHub] [shiro] asf-ci commented on issue #177: Get build working with JDK11

2019-11-13 Thread GitBox
asf-ci commented on issue #177: Get build working with JDK11 URL: https://github.com/apache/shiro/pull/177#issuecomment-553401239 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/174/

[GitHub] [shiro] fpapon commented on issue #177: Get build working with JDK11

2019-11-13 Thread GitBox
fpapon commented on issue #177: Get build working with JDK11 URL: https://github.com/apache/shiro/pull/177#issuecomment-553383574 @coheigea Yes I didn't see your commit before merge, it was just in time :-) I will resolve the issue in Jira. Thanks for fixing this!

[GitHub] [shiro] coheigea commented on issue #177: Get build working with JDK11

2019-11-13 Thread GitBox
coheigea commented on issue #177: Get build working with JDK11 URL: https://github.com/apache/shiro/pull/177#issuecomment-553382687 @fpapon Looks like you merged just after I pushed an update to the branch :-) The update was to fix the javadoc stuff for JDK11, so I think we can resolve

[GitHub] [shiro] fpapon merged pull request #177: Get build working with JDK11

2019-11-13 Thread GitBox
fpapon merged pull request #177: Get build working with JDK11 URL: https://github.com/apache/shiro/pull/177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [shiro] fpapon commented on issue #127: [SHIRO-682] fix the potential threat when use "uri = uri + '/' " to bypassed shi…

2019-11-12 Thread GitBox
fpapon commented on issue #127: [SHIRO-682] fix the potential threat when use "uri = uri + '/' " to bypassed shi… URL: https://github.com/apache/shiro/pull/127#issuecomment-552906478 @Staryjir We are actually adding some unit tests, it will be available next week in the 1.5.0 release.

[GitHub] [shiro] asf-ci commented on issue #127: [SHIRO-682] fix the potential threat when use "uri = uri + '/' " to bypassed shi…

2019-11-12 Thread GitBox
asf-ci commented on issue #127: [SHIRO-682] fix the potential threat when use "uri = uri + '/' " to bypassed shi… URL: https://github.com/apache/shiro/pull/127#issuecomment-552903516 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] Staryjir commented on issue #127: [SHIRO-682] fix the potential threat when use "uri = uri + '/' " to bypassed shi…

2019-11-12 Thread GitBox
Staryjir commented on issue #127: [SHIRO-682] fix the potential threat when use "uri = uri + '/' " to bypassed shi… URL: https://github.com/apache/shiro/pull/127#issuecomment-552901652 Any updates about fix for this issue? I can confirm that this issue is a problem for apache shiro

[GitHub] [shiro] asf-ci commented on issue #177: Get build working with JDK11

2019-11-12 Thread GitBox
asf-ci commented on issue #177: Get build working with JDK11 URL: https://github.com/apache/shiro/pull/177#issuecomment-552878338 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr-jdk11/1/Build result:

[GitHub] [shiro] asf-ci commented on issue #177: Get build working with JDK11

2019-11-12 Thread GitBox
asf-ci commented on issue #177: Get build working with JDK11 URL: https://github.com/apache/shiro/pull/177#issuecomment-552877957 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/173/

[GitHub] [shiro] fpapon commented on issue #177: Get build working with JDK11

2019-11-12 Thread GitBox
fpapon commented on issue #177: Get build working with JDK11 URL: https://github.com/apache/shiro/pull/177#issuecomment-552876823 @coheigea Thanks! There is a JIRA about building on JDK11: https://issues.apache.org/jira/browse/SHIRO-690 And I add some specific builds on Jenkins

[GitHub] [shiro] coheigea opened a new pull request #177: Get build working with JDK11

2019-11-12 Thread GitBox
coheigea opened a new pull request #177: Get build working with JDK11 URL: https://github.com/apache/shiro/pull/177 I couldn't get two of the samples working with JDK11, so this patch disables running those two samples with JDK11. I also updated the dependencies in the JAX-RS demo.

[GitHub] [shiro] fpapon merged pull request #176: SHIRO-728 - Update Spring Boot to 2.1.10

2019-11-11 Thread GitBox
fpapon merged pull request #176: SHIRO-728 - Update Spring Boot to 2.1.10 URL: https://github.com/apache/shiro/pull/176 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] asf-ci commented on issue #176: SHIRO-728 - Update Spring Boot to 2.1.10

2019-11-11 Thread GitBox
asf-ci commented on issue #176: SHIRO-728 - Update Spring Boot to 2.1.10 URL: https://github.com/apache/shiro/pull/176#issuecomment-552543836 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/172/

[GitHub] [shiro] coheigea opened a new pull request #176: SHIRO-728 - Update Spring Boot to 2.1.10

2019-11-11 Thread GitBox
coheigea opened a new pull request #176: SHIRO-728 - Update Spring Boot to 2.1.10 URL: https://github.com/apache/shiro/pull/176 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [shiro] fpapon merged pull request #175: Fixing spring_hibernate sample with JDK11

2019-11-11 Thread GitBox
fpapon merged pull request #175: Fixing spring_hibernate sample with JDK11 URL: https://github.com/apache/shiro/pull/175 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] asf-ci commented on issue #175: Fixing spring_hibernate sample with JDK11

2019-11-11 Thread GitBox
asf-ci commented on issue #175: Fixing spring_hibernate sample with JDK11 URL: https://github.com/apache/shiro/pull/175#issuecomment-552391427 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/171/

[GitHub] [shiro] coheigea opened a new pull request #175: Fixing spring_hibernate sample with JDK11

2019-11-11 Thread GitBox
coheigea opened a new pull request #175: Fixing spring_hibernate sample with JDK11 URL: https://github.com/apache/shiro/pull/175 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [shiro] fpapon merged pull request #174: Add javax.annotation dependency to get guice + some of the samples wo…

2019-11-08 Thread GitBox
fpapon merged pull request #174: Add javax.annotation dependency to get guice + some of the samples wo… URL: https://github.com/apache/shiro/pull/174 This is an automated message from the Apache Git Service. To respond to

[GitHub] [shiro] asf-ci commented on issue #174: Add javax.annotation dependency to get guice + some of the samples wo…

2019-11-08 Thread GitBox
asf-ci commented on issue #174: Add javax.annotation dependency to get guice + some of the samples wo… URL: https://github.com/apache/shiro/pull/174#issuecomment-551581488 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] coheigea opened a new pull request #174: Add javax.annotation dependency to get guice + some of the samples wo…

2019-11-08 Thread GitBox
coheigea opened a new pull request #174: Add javax.annotation dependency to get guice + some of the samples wo… URL: https://github.com/apache/shiro/pull/174 …rking with JDK11 This is an automated message from the Apache Git

[GitHub] [shiro] fpapon merged pull request #173: Get the aspectj modules passing with JDK 11

2019-11-07 Thread GitBox
fpapon merged pull request #173: Get the aspectj modules passing with JDK 11 URL: https://github.com/apache/shiro/pull/173 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] asf-ci commented on issue #173: Get the aspectj modules passing with JDK 11

2019-11-07 Thread GitBox
asf-ci commented on issue #173: Get the aspectj modules passing with JDK 11 URL: https://github.com/apache/shiro/pull/173#issuecomment-551028011 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/169/

[GitHub] [shiro] coheigea opened a new pull request #173: Get the aspectj modules passing with JDK 11

2019-11-07 Thread GitBox
coheigea opened a new pull request #173: Get the aspectj modules passing with JDK 11 URL: https://github.com/apache/shiro/pull/173 The current aspectj maven plugin appears dead - so switch to use a fork which supports JDK 11

[GitHub] [shiro] fpapon merged pull request #172: Switch to gmavenplus and update groovy

2019-11-06 Thread GitBox
fpapon merged pull request #172: Switch to gmavenplus and update groovy URL: https://github.com/apache/shiro/pull/172 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] asf-ci commented on issue #172: Switch to gmavenplus and update groovy

2019-11-06 Thread GitBox
asf-ci commented on issue #172: Switch to gmavenplus and update groovy URL: https://github.com/apache/shiro/pull/172#issuecomment-550309920 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/168/

[GitHub] [shiro] coheigea opened a new pull request #172: Switch to gmavenplus and update groovy

2019-11-06 Thread GitBox
coheigea opened a new pull request #172: Switch to gmavenplus and update groovy URL: https://github.com/apache/shiro/pull/172 This means we can now run the groovy tests with JDK 11. This is an automated message from the

[GitHub] [shiro] fpapon merged pull request #171: Updating remaining Groovy tests to Junit4

2019-11-05 Thread GitBox
fpapon merged pull request #171: Updating remaining Groovy tests to Junit4 URL: https://github.com/apache/shiro/pull/171 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] asf-ci commented on issue #171: Updating remaining Groovy tests to Junit4

2019-11-05 Thread GitBox
asf-ci commented on issue #171: Updating remaining Groovy tests to Junit4 URL: https://github.com/apache/shiro/pull/171#issuecomment-549783254 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/167/

[GitHub] [shiro] coheigea opened a new pull request #171: Updating remaining Groovy tests to Junit4

2019-11-05 Thread GitBox
coheigea opened a new pull request #171: Updating remaining Groovy tests to Junit4 URL: https://github.com/apache/shiro/pull/171 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [shiro] coheigea closed pull request #84: 1.3.x

2019-11-05 Thread GitBox
coheigea closed pull request #84: 1.3.x URL: https://github.com/apache/shiro/pull/84 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [shiro] asf-ci commented on issue #59: [SHIRO-617] ShiroFilter initialize WebEnvironment on startup

2019-11-02 Thread GitBox
asf-ci commented on issue #59: [SHIRO-617] ShiroFilter initialize WebEnvironment on startup URL: https://github.com/apache/shiro/pull/59#issuecomment-549029047 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/166/Build

[GitHub] [shiro] fpapon commented on issue #59: [SHIRO-617] ShiroFilter initialize WebEnvironment on startup

2019-11-02 Thread GitBox
fpapon commented on issue #59: [SHIRO-617] ShiroFilter initialize WebEnvironment on startup URL: https://github.com/apache/shiro/pull/59#issuecomment-549028478 retest this please This is an automated message from the Apache

[GitHub] [shiro] jbonofre commented on issue #170: [SHIRO-726] Add dynamic import package

2019-10-31 Thread GitBox
jbonofre commented on issue #170: [SHIRO-726] Add dynamic import package URL: https://github.com/apache/shiro/pull/170#issuecomment-548234236 Sorry for the delay in the review. This is an automated message from the Apache Git

[GitHub] [shiro] fpapon merged pull request #170: [SHIRO-726] Add dynamic import package

2019-10-31 Thread GitBox
fpapon merged pull request #170: [SHIRO-726] Add dynamic import package URL: https://github.com/apache/shiro/pull/170 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] asf-ci commented on issue #170: [SHIRO-726] Add dynamic import package

2019-10-30 Thread GitBox
asf-ci commented on issue #170: [SHIRO-726] Add dynamic import package URL: https://github.com/apache/shiro/pull/170#issuecomment-548095846 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/165/

[GitHub] [shiro] fpapon opened a new pull request #170: [SHIRO-726] Add dynamic import package

2019-10-30 Thread GitBox
fpapon opened a new pull request #170: [SHIRO-726] Add dynamic import package URL: https://github.com/apache/shiro/pull/170 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [shiro] zhengyanbin closed pull request #86: replacement of "request.getRemoteHost()" by "WebUtils.getRemoteAddr()"

2019-10-27 Thread GitBox
zhengyanbin closed pull request #86: replacement of "request.getRemoteHost()" by "WebUtils.getRemoteAddr()" URL: https://github.com/apache/shiro/pull/86 This is an automated message from the Apache Git Service. To respond

[GitHub] [shiro] fpapon commented on issue #127: [SHIRO-682] fix the potential threat when use "uri = uri + '/' " to bypassed shi…

2019-10-23 Thread GitBox
fpapon commented on issue #127: [SHIRO-682] fix the potential threat when use "uri = uri + '/' " to bypassed shi… URL: https://github.com/apache/shiro/pull/127#issuecomment-545427664 @bdemers have you some additional check to do on this one? I think we could merge it.

[GitHub] [shiro] fpapon commented on issue #58: [SHIRO-337] basic cdi support

2019-10-23 Thread GitBox
fpapon commented on issue #58: [SHIRO-337] basic cdi support URL: https://github.com/apache/shiro/pull/58#issuecomment-545318247 @rmannibucau thanks for take a look! I agree to skip cdi1 and also to test with owb as it's an asf project ;)

[GitHub] [shiro] rmannibucau edited a comment on issue #58: [SHIRO-337] basic cdi support

2019-10-22 Thread GitBox
rmannibucau edited a comment on issue #58: [SHIRO-337] basic cdi support URL: https://github.com/apache/shiro/pull/58#issuecomment-545142038 Checked out quickly other PRs, seems they miss tests on user beans with a normal scope and producers should likely be active only if not overriden by

[GitHub] [shiro] rmannibucau commented on issue #58: [SHIRO-337] basic cdi support

2019-10-22 Thread GitBox
rmannibucau commented on issue #58: [SHIRO-337] basic cdi support URL: https://github.com/apache/shiro/pull/58#issuecomment-545142038 Checked out quickly other PRs, seems they miss tests on user beans with a normal scope and producers should likely be active only if not overriden by the

[GitHub] [shiro] asf-ci commented on issue #86: replacement of "request.getRemoteHost()" by "WebUtils.getRemoteAddr()"

2019-10-22 Thread GitBox
asf-ci commented on issue #86: replacement of "request.getRemoteHost()" by "WebUtils.getRemoteAddr()" URL: https://github.com/apache/shiro/pull/86#issuecomment-545124519 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] fpapon commented on issue #86: replacement of "request.getRemoteHost()" by "WebUtils.getRemoteAddr()"

2019-10-22 Thread GitBox
fpapon commented on issue #86: replacement of "request.getRemoteHost()" by "WebUtils.getRemoteAddr()" URL: https://github.com/apache/shiro/pull/86#issuecomment-545119225 @zhengyanbin Can you fix the comments please? We can add this PR into the next release.

[GitHub] [shiro] fpapon commented on issue #58: [SHIRO-337] basic cdi support

2019-10-22 Thread GitBox
fpapon commented on issue #58: [SHIRO-337] basic cdi support URL: https://github.com/apache/shiro/pull/58#issuecomment-545116989 @bdemers I see 2 PR related to this one: https://github.com/apache/shiro/pull/24 https://github.com/apache/shiro/pull/56 How can we deal with it? I can

[GitHub] [shiro] bdemers commented on issue #55: SslFilter with HTTP Strict Transport Security (HSTS)

2019-10-21 Thread GitBox
bdemers commented on issue #55: SslFilter with HTTP Strict Transport Security (HSTS) URL: https://github.com/apache/shiro/pull/55#issuecomment-544591551 @fpapon Sure, I can add that! This is an automated message

[GitHub] [shiro] asf-ci commented on issue #55: SslFilter with HTTP Strict Transport Security (HSTS)

2019-10-21 Thread GitBox
asf-ci commented on issue #55: SslFilter with HTTP Strict Transport Security (HSTS) URL: https://github.com/apache/shiro/pull/55#issuecomment-544401629 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/163/

[GitHub] [shiro] fpapon commented on issue #55: SslFilter with HTTP Strict Transport Security (HSTS)

2019-10-21 Thread GitBox
fpapon commented on issue #55: SslFilter with HTTP Strict Transport Security (HSTS) URL: https://github.com/apache/shiro/pull/55#issuecomment-544392034 @bdemers I would like to add this PR to the next release. I also like the ShiroPrioritizedFilterChainResolver from Stormpath that you

[GitHub] [shiro] fpapon merged pull request #169: SHIRO-724 - Update Jetty, Spring, Spring Boot, Htmlunit dependencies

2019-10-17 Thread GitBox
fpapon merged pull request #169: SHIRO-724 - Update Jetty, Spring, Spring Boot, Htmlunit dependencies URL: https://github.com/apache/shiro/pull/169 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shiro] asf-ci commented on issue #169: SHIRO-724 - Update Jetty, Spring, Spring Boot, Htmlunit dependencies

2019-10-17 Thread GitBox
asf-ci commented on issue #169: SHIRO-724 - Update Jetty, Spring, Spring Boot, Htmlunit dependencies URL: https://github.com/apache/shiro/pull/169#issuecomment-543165040 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] coheigea opened a new pull request #169: SHIRO-724 - Update Jetty, Spring, Spring Boot, Htmlunit dependencies

2019-10-17 Thread GitBox
coheigea opened a new pull request #169: SHIRO-724 - Update Jetty, Spring, Spring Boot, Htmlunit dependencies URL: https://github.com/apache/shiro/pull/169 This is an automated message from the Apache Git Service. To

[GitHub] [shiro] fpapon merged pull request #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-10-10 Thread GitBox
fpapon merged pull request #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shiro] fpapon commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-10-10 Thread GitBox
fpapon commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168#issuecomment-540638529 @bdemers Travis build is ok, I can merge ;) Thanks!

[GitHub] [shiro] fpapon commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-10-10 Thread GitBox
fpapon commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168#issuecomment-540441367 @bdemers I add some tests and also add the escape char check on the value. The Travis build failed because of a missing

[GitHub] [shiro] asf-ci commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-10-09 Thread GitBox
asf-ci commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168#issuecomment-540027279 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro-site] fpapon merged pull request #49: Fixed a typo

2019-09-27 Thread GitBox
fpapon merged pull request #49: Fixed a typo URL: https://github.com/apache/shiro-site/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shiro-site] IlyaGerasimets opened a new pull request #49: Fixed a typo

2019-09-27 Thread GitBox
IlyaGerasimets opened a new pull request #49: Fixed a typo URL: https://github.com/apache/shiro-site/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [shiro] fpapon commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-09-22 Thread GitBox
fpapon commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168#issuecomment-533906738 Ok, I will add more tests. This is an automated message

[GitHub] [shiro] bdemers commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-09-22 Thread GitBox
bdemers commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168#issuecomment-533905138 This seems fine to me, but we might want to add a few more test cases around the escape?

[GitHub] [shiro] asf-ci commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-09-22 Thread GitBox
asf-ci commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168#issuecomment-533885094 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] fpapon opened a new pull request #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-09-22 Thread GitBox
fpapon opened a new pull request #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168 When fixing this issue, I found a bug in the `isCharEscaped` method and the `index` usage.

[GitHub] [shiro] fpapon merged pull request #67: [SHIRO-722] Add SameSite option to cookies

2019-09-12 Thread GitBox
fpapon merged pull request #67: [SHIRO-722] Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] asf-ci commented on issue #67: [SHIRO-722] Add SameSite option to cookies

2019-09-12 Thread GitBox
asf-ci commented on issue #67: [SHIRO-722] Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530872542 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/159/

[GitHub] [shiro] bdemers commented on issue #67: [SHIRO-722] Add SameSite option to cookies

2019-09-12 Thread GitBox
bdemers commented on issue #67: [SHIRO-722] Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530867864 Thanks!! This is an automated message from the Apache Git Service. To respond to

[GitHub] [shiro-site] boris-petrov opened a new pull request #48: Add info about the SameSite cookie flag

2019-09-12 Thread GitBox
boris-petrov opened a new pull request #48: Add info about the SameSite cookie flag URL: https://github.com/apache/shiro-site/pull/48 Implementation of the flag is [here](https://github.com/apache/shiro/pull/67). This is an

[GitHub] [shiro] boris-petrov commented on issue #67: [SHIRO-722] Add SameSite option to cookies

2019-09-12 Thread GitBox
boris-petrov commented on issue #67: [SHIRO-722] Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530864987 @bdemers - done for both points. This is an automated message from the Apache

[GitHub] [shiro] bdemers commented on issue #67: [SHIRO-722] Add SameSite option to cookies

2019-09-12 Thread GitBox
bdemers commented on issue #67: [SHIRO-722] Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530858412 @boris-petrov great point on the default, it sounds like LAX might be the way to go, a quick google shows it's that will be the default starting

[GitHub] [shiro] asf-ci commented on issue #67: Add SameSite option to cookies

2019-09-12 Thread GitBox
asf-ci commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530750236 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/158/

[GitHub] [shiro] fpapon commented on issue #67: Add SameSite option to cookies

2019-09-12 Thread GitBox
fpapon commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530732144 @boris-petrov for me the `getSameSite` and `setSameSite` are not a problem. This is an

[GitHub] [shiro] boris-petrov commented on issue #67: Add SameSite option to cookies

2019-09-12 Thread GitBox
boris-petrov commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530730949 Also, what about the added methods? The test is failing because of that also. I can overload the `addCookieHeader` and call the new one from the old one,

[GitHub] [shiro] boris-petrov edited a comment on issue #67: Add SameSite option to cookies

2019-09-12 Thread GitBox
boris-petrov edited a comment on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530730949 Also, what about the added methods? The test is failing because of that also. I can overload the `buildHeaderValue` and call the new one from the

[GitHub] [shiro] boris-petrov commented on issue #67: Add SameSite option to cookies

2019-09-12 Thread GitBox
boris-petrov commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530730424 Do we want `NONE` as the default? Chrome is making `LAX` the default and that is more secure than `NONE`. Perhaps Shiro should do the same?

[GitHub] [shiro] bdemers commented on issue #67: Add SameSite option to cookies

2019-09-11 Thread GitBox
bdemers commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530392705 @fpapon @boris-petrov Agreed, Your best bet is to overload the existing method with a new one, and just make the old call the new with the previous

[GitHub] [shiro] boris-petrov commented on issue #67: Add SameSite option to cookies

2019-09-11 Thread GitBox
boris-petrov commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530387875 @fpapon - I've [created a JIRA issue](https://issues.apache.org/jira/browse/SHIRO-722). Please tell me what to do with the failing test and I'll do

[GitHub] [shiro] fpapon commented on issue #67: Add SameSite option to cookies

2019-09-11 Thread GitBox
fpapon commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530366347 @boris-petrov I can't see a Jira about this issue, may be I missed it :) This is an automated

[GitHub] [shiro] fpapon edited a comment on issue #67: Add SameSite option to cookies

2019-09-11 Thread GitBox
fpapon edited a comment on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530351620 @boris-petrov Hi! we have the `japicmp` maven plugin failed on the build because of backward incompatibility: ``` [ERROR] Failed to execute

[GitHub] [shiro] fpapon commented on issue #67: Add SameSite option to cookies

2019-09-11 Thread GitBox
fpapon commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530351620 @boris-petrov Hi! we have the `japicmp` maven plugin failed on the build because of backward incompatibility: ``` [ERROR] Failed to execute goal

[GitHub] [shiro] asf-ci commented on issue #67: Add SameSite option to cookies

2019-09-11 Thread GitBox
asf-ci commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530300637 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/157/Build result: FAILURE[...truncated

[GitHub] [shiro] boris-petrov commented on issue #67: Add SameSite option to cookies

2019-09-11 Thread GitBox
boris-petrov commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530297751 I updated the PR and added also the `None` option. According to [this](https://scotthelme.co.uk/csrf-is-really-dead/) `SameSite` is going to be the

[GitHub] [shiro-site] fpapon merged pull request #47: Fix typo to format inline code properly

2019-09-04 Thread GitBox
fpapon merged pull request #47: Fix typo to format inline code properly URL: https://github.com/apache/shiro-site/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro-site] bdemers commented on issue #47: Fix typo to format inline code properly

2019-09-03 Thread GitBox
bdemers commented on issue #47: Fix typo to format inline code properly URL: https://github.com/apache/shiro-site/pull/47#issuecomment-527614685 Thanks @Binney ! This is an automated message from the Apache Git Service. To

[GitHub] [shiro-site] Binney opened a new pull request #47: Fix typo to format inline code properly

2019-08-31 Thread GitBox
Binney opened a new pull request #47: Fix typo to format inline code properly URL: https://github.com/apache/shiro-site/pull/47 Remove a couple of stray backticks! This is an automated message from the Apache Git Service. To

[GitHub] [shiro] fpapon merged pull request #167: SHIRO-720 - Update Commons BeanUtils

2019-08-15 Thread GitBox
fpapon merged pull request #167: SHIRO-720 - Update Commons BeanUtils URL: https://github.com/apache/shiro/pull/167 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shiro] asf-ci commented on issue #167: SHIRO-720 - Update Commons BeanUtils

2019-08-15 Thread GitBox
asf-ci commented on issue #167: SHIRO-720 - Update Commons BeanUtils URL: https://github.com/apache/shiro/pull/167#issuecomment-521609246 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/156/

[GitHub] [shiro] coheigea opened a new pull request #167: SHIRO-720 - Update Commons BeanUtils

2019-08-15 Thread GitBox
coheigea opened a new pull request #167: SHIRO-720 - Update Commons BeanUtils URL: https://github.com/apache/shiro/pull/167 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [shiro] bdemers commented on issue #162: Adding .travis.yml for PR builds

2019-08-07 Thread GitBox
bdemers commented on issue #162: Adding .travis.yml for PR builds URL: https://github.com/apache/shiro/pull/162#issuecomment-519104169 Done!! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shiro] bdemers merged pull request #162: Adding .travis.yml for PR builds

2019-08-07 Thread GitBox
bdemers merged pull request #162: Adding .travis.yml for PR builds URL: https://github.com/apache/shiro/pull/162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shiro] fpapon commented on issue #162: Adding .travis.yml for PR builds

2019-08-07 Thread GitBox
fpapon commented on issue #162: Adding .travis.yml for PR builds URL: https://github.com/apache/shiro/pull/162#issuecomment-518980367 @bdemers Can we merge it? This is an automated message from the Apache Git Service. To

[GitHub] [shiro] fpapon merged pull request #138: [SHIRO-552] Support base64 encoded salt in JdbcRealm

2019-08-02 Thread GitBox
fpapon merged pull request #138: [SHIRO-552] Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [shiro] asf-ci commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-08-02 Thread GitBox
asf-ci commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-517761803 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/155/

[GitHub] [shiro] steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-08-02 Thread GitBox
steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-517752959 @fpapon rebased, conflict resolved, built with "mvn clean install" with no errors, and branch force-pushed

[GitHub] [shiro] fpapon commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-08-02 Thread GitBox
fpapon commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-517708156 @steinarb yes, thanks! This is an automated message from the Apache Git Service. To

[GitHub] [shiro] steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-08-02 Thread GitBox
steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-517705111 @bdemers @fpapon Should I resolve the conflict and re-push? This is an

  1   2   3   4   5   >