asfgit commented on issue #118: [SHIRO-667] Upgrade to Spring 4.3.22-RELEASE
URL: https://github.com/apache/shiro/pull/118#issuecomment-464425704
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/45/Build result:
fpapon commented on issue #118: [SHIRO-667] Upgrade to Spring 4.3.22-RELEASE
URL: https://github.com/apache/shiro/pull/118#issuecomment-464819472
retest this please
This is an automated message from the Apache Git Service.
To
asfgit commented on issue #118: [SHIRO-667] Upgrade to Spring 4.3.22-RELEASE
URL: https://github.com/apache/shiro/pull/118#issuecomment-464828124
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/46/
fpapon commented on issue #118: [SHIRO-667] Upgrade to Spring 4.3.22-RELEASE
URL: https://github.com/apache/shiro/pull/118#issuecomment-464298946
retest this please
This is an automated message from the Apache Git Service.
To
asfgit commented on issue #118: [SHIRO-667] Upgrade to Spring 4.3.22-RELEASE
URL: https://github.com/apache/shiro/pull/118#issuecomment-464302077
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/43/Build result:
fpapon commented on issue #118: [SHIRO-667] Upgrade to Spring 4.3.22-RELEASE
URL: https://github.com/apache/shiro/pull/118#issuecomment-464344722
retest this please
This is an automated message from the Apache Git Service.
To
asfgit commented on issue #118: [SHIRO-667] Upgrade to Spring 4.3.22-RELEASE
URL: https://github.com/apache/shiro/pull/118#issuecomment-464347944
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/44/Build result:
fpapon commented on issue #49: New AuthenticationStrategy -
ShortCircuitFirstSuccessfulStrategy
URL: https://github.com/apache/shiro/pull/49#issuecomment-465434404
retest please
This is an automated message from the Apache
asfgit commented on issue #49: New AuthenticationStrategy -
ShortCircuitFirstSuccessfulStrategy
URL: https://github.com/apache/shiro/pull/49#issuecomment-465442705
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/49/
fpapon commented on issue #49: New AuthenticationStrategy -
ShortCircuitFirstSuccessfulStrategy
URL: https://github.com/apache/shiro/pull/49#issuecomment-465443881
@bdemers is this PR can be add to the 1.4.1?
This is an
asfgit commented on issue #117: Fix typo in javadoc for Permission
URL: https://github.com/apache/shiro/pull/117#issuecomment-462001537
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/40/Build result:
asfgit commented on issue #117: Fix typo in javadoc for Permission
URL: https://github.com/apache/shiro/pull/117#issuecomment-462009639
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/41/
fpapon merged pull request #117: Fix typo in javadoc for Permission
URL: https://github.com/apache/shiro/pull/117
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and
fpapon commented on issue #117: Fix typo in javadoc for Permission
URL: https://github.com/apache/shiro/pull/117#issuecomment-462008447
retest this please
This is an automated message from the Apache Git Service.
To respond
asfgit commented on issue #71: Catch unexpected errors which can lead to oom
URL: https://github.com/apache/shiro/pull/71#issuecomment-465280167
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/48/
fpapon commented on issue #90: [SHIRO-661] Add check for the principal of
subject whether is null
URL: https://github.com/apache/shiro/pull/90#issuecomment-492758890
@bdemers as we have no update about the user, can I merge this and made the
update in the `Subject` `isAuthenticated`
fpapon commented on issue #90: [SHIRO-661] Add check for the principal of
subject whether is null
URL: https://github.com/apache/shiro/pull/90#issuecomment-492774048
@bdemers ok, if I understand the use case, this is about the serialization
of the `Principal`. Sometimes it cannot be
bdemers commented on issue #90: [SHIRO-661] Add check for the principal of
subject whether is null
URL: https://github.com/apache/shiro/pull/90#issuecomment-492765167
@fpapon i think we would want to figure out how/why a subject is
authenticated without a principal.
Possibly making
bdemers commented on issue #90: [SHIRO-661] Add check for the principal of
subject whether is null
URL: https://github.com/apache/shiro/pull/90#issuecomment-492819583
AHH!! maybe adding the null check to `isAuthenticated()` is the way to go
then?
fpapon merged pull request #90: [SHIRO-661] Add check for the principal of
subject whether is null
URL: https://github.com/apache/shiro/pull/90
This is an automated message from the Apache Git Service.
To respond to the
fpapon commented on issue #90: [SHIRO-661] Add check for the principal of
subject whether is null
URL: https://github.com/apache/shiro/pull/90#issuecomment-492897172
Yes I think so :)
This is an automated message from the
fpapon opened a new pull request #137: Build
URL: https://github.com/apache/shiro/pull/137
Hi @bdemers, I made some changes on the maven build:
- move `integration-tests` and `test-coverage` to the `ci` profile
- add a `samples` profile and move the module `sample`into
This can
asfgit commented on issue #137: Build
URL: https://github.com/apache/shiro/pull/137#issuecomment-496322335
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/83/
asfgit commented on issue #137: Build
URL: https://github.com/apache/shiro/pull/137#issuecomment-496321836
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/82/
fpapon opened a new pull request #134: [SHIRO-691] Upgrade to maven-jar-plugin
3.1.1
URL: https://github.com/apache/shiro/pull/134
This is an automated message from the Apache Git Service.
To respond to the message, please
fpapon merged pull request #134: [SHIRO-691] Upgrade to maven-jar-plugin 3.1.1
URL: https://github.com/apache/shiro/pull/134
This is an automated message from the Apache Git Service.
To respond to the message, please log on
asfgit commented on issue #134: [SHIRO-691] Upgrade to maven-jar-plugin 3.1.1
URL: https://github.com/apache/shiro/pull/134#issuecomment-495933628
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/79/
fpapon merged pull request #135: Fix maven warning for exec-maven-plugin and
upgrade to 1.6.0
URL: https://github.com/apache/shiro/pull/135
This is an automated message from the Apache Git Service.
To respond to the
fpapon opened a new pull request #135: Fix maven warning for exec-maven-plugin
and upgrade to 1.6.0
URL: https://github.com/apache/shiro/pull/135
This is an automated message from the Apache Git Service.
To respond to the
asfgit commented on issue #135: Fix maven warning for exec-maven-plugin and
upgrade to 1.6.0
URL: https://github.com/apache/shiro/pull/135#issuecomment-495938395
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/80/
coheigea opened a new pull request #141: SHIRO-695 - Update Hazelcast
URL: https://github.com/apache/shiro/pull/141
Hazelcast should be updated as it carries a CVE:
hazelcast-3.7.2.jar (pkg:maven/com.hazelcast/hazelcast@3.7.2,
cpe:2.3:a:hazelcast:hazelcast:3.7.2:::*) :
asfgit commented on issue #141: SHIRO-695 - Update Hazelcast
URL: https://github.com/apache/shiro/pull/141#issuecomment-498629013
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/102/
fpapon merged pull request #141: SHIRO-695 - Update Hazelcast
URL: https://github.com/apache/shiro/pull/141
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
fpapon commented on a change in pull request #66: [SHIRO 625] Update 10 minute
Tutorial
URL: https://github.com/apache/shiro/pull/66#discussion_r289263089
##
File path: core/src/main/java/org/apache/shiro/env/BasicIniEnvironment.java
##
@@ -0,0 +1,22 @@
+package
fpapon commented on issue #66: [SHIRO 625] Update 10 minute Tutorial
URL: https://github.com/apache/shiro/pull/66#issuecomment-497565847
retest this please
This is an automated message from the Apache Git Service.
To respond
asfgit commented on issue #66: [SHIRO 625] Update 10 minute Tutorial
URL: https://github.com/apache/shiro/pull/66#issuecomment-497573238
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/97/Build result:
bdemers commented on a change in pull request #137: Build
URL: https://github.com/apache/shiro/pull/137#discussion_r289518585
##
File path: pom.xml
##
@@ -1354,6 +1355,16 @@
+
+fast
+
+true
+true
bdemers commented on a change in pull request #137: Build
URL: https://github.com/apache/shiro/pull/137#discussion_r289518821
##
File path: pom.xml
##
@@ -1457,6 +1468,9 @@
ci
+
+false
+
Review
asfgit commented on issue #140: Reduce shiro test logging level to INFO
URL: https://github.com/apache/shiro/pull/140#issuecomment-497857314
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/99/
fpapon commented on a change in pull request #137: Build
URL: https://github.com/apache/shiro/pull/137#discussion_r289519208
##
File path: pom.xml
##
@@ -1354,6 +1355,16 @@
+
+fast
+
+true
+true
asfgit commented on issue #137: Build
URL: https://github.com/apache/shiro/pull/137#issuecomment-497836128
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/98/
fpapon commented on issue #137: Build
URL: https://github.com/apache/shiro/pull/137#issuecomment-497822375
@bdemers are you ok with the lastest changes?
This is an automated message from the Apache Git Service.
To respond to
bdemers commented on issue #140: Reduce shiro test logging level to INFO
URL: https://github.com/apache/shiro/pull/140#issuecomment-497839283
@fpapon, related to your build cleanup PRs
I have mixed feelings about this, as generally I think extra logging is
useful for CI, but in general
bdemers commented on a change in pull request #137: Build
URL: https://github.com/apache/shiro/pull/137#discussion_r289524251
##
File path: pom.xml
##
@@ -1457,6 +1468,9 @@
ci
+
+false
+
Review
fpapon commented on issue #85: [SHIRO-687] Adding Spring's Filters to
ShiroFilterFactorBean when using Java config
URL: https://github.com/apache/shiro/pull/85#issuecomment-499780938
@bdemers the license header is missing in
fpapon merged pull request #143: [SHIRO-696] Use root pom Jetty version in
Jaxrs sample
URL: https://github.com/apache/shiro/pull/143
This is an automated message from the Apache Git Service.
To respond to the message,
fpapon commented on issue #58: [SHIRO-337] basic cdi support
URL: https://github.com/apache/shiro/pull/58#issuecomment-499796951
Hi @rmannibucau thanks for this PR! I will make some test case with the
current master (1.5.0).
asfgit commented on issue #58: [SHIRO-337] basic cdi support
URL: https://github.com/apache/shiro/pull/58#issuecomment-499800190
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/109/Build result:
FAILURE[...truncated
coheigea opened a new pull request #144: SHIRO-700 - Minor version updates to
Spring, Spring Boot + SLF4J
URL: https://github.com/apache/shiro/pull/144
Also removed an unused old hibernate dependency.
This is an automated
asfgit commented on issue #144: SHIRO-700 - Minor version updates to Spring,
Spring Boot + SLF4J
URL: https://github.com/apache/shiro/pull/144#issuecomment-499867477
Refer to this link for build results (access rights to CI server needed):
fpapon merged pull request #144: SHIRO-700 - Minor version updates to Spring,
Spring Boot + SLF4J
URL: https://github.com/apache/shiro/pull/144
This is an automated message from the Apache Git Service.
To respond to the
coheigea opened a new pull request #139: SHIRO-693 - Update plugins
URL: https://github.com/apache/shiro/pull/139
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
asfgit commented on issue #139: SHIRO-693 - Update plugins
URL: https://github.com/apache/shiro/pull/139#issuecomment-497293824
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/95/
fpapon commented on issue #137: Build
URL: https://github.com/apache/shiro/pull/137#issuecomment-496823457
I made changes:
- deactivate `jacoco` by default
- activate `jacoco` with the `ci` profile
- add a `fast` profile with unit tests and ITtests deactivated
asfgit commented on issue #137: Build
URL: https://github.com/apache/shiro/pull/137#issuecomment-496822686
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/87/
bdemers commented on issue #138: Support base64 encoded salt in JdbcRealm
URL: https://github.com/apache/shiro/pull/138#issuecomment-497325189
Thanks @steinarb! I just retargeted the PR against `master` (it was 1.4
previously)
asfgit commented on issue #138: Support base64 encoded salt in JdbcRealm
URL: https://github.com/apache/shiro/pull/138#issuecomment-497334871
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/96/
steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm
URL: https://github.com/apache/shiro/pull/138#issuecomment-497344471
> @steinarb Looks good to me! can you sign an Apache CLA?
https://www.apache.org/licenses/#contributor-license-agreements
@bdemers I have
bdemers commented on issue #139: SHIRO-693 - Update plugins
URL: https://github.com/apache/shiro/pull/139#issuecomment-497323818
Thanks @coheigea !!
This is an automated message from the Apache Git Service.
To respond to the
bdemers merged pull request #139: SHIRO-693 - Update plugins
URL: https://github.com/apache/shiro/pull/139
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
bdemers commented on a change in pull request #138: Support base64 encoded salt
in JdbcRealm
URL: https://github.com/apache/shiro/pull/138#discussion_r288985987
##
File path: core/src/main/java/org/apache/shiro/realm/jdbc/JdbcRealm.java
##
@@ -247,7 +261,11 @@ protected
bdemers commented on issue #138: Support base64 encoded salt in JdbcRealm
URL: https://github.com/apache/shiro/pull/138#issuecomment-497328346
@steinarb Looks good to me! can you sign an Apache CLA?
https://www.apache.org/licenses/#contributor-license-agreements
bdemers commented on issue #138: Support base64 encoded salt in JdbcRealm
URL: https://github.com/apache/shiro/pull/138#issuecomment-497347975
@steinarb yup, you should be all set!
Thanks again!!
This is an automated
bdemers commented on issue #129: Adds BearerToken support
URL: https://github.com/apache/shiro/pull/129#issuecomment-497058433
retest this please
This is an automated message from the Apache Git Service.
To respond to the
asfgit commented on issue #129: Adds BearerToken support
URL: https://github.com/apache/shiro/pull/129#issuecomment-497078820
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/90/
bdemers commented on issue #137: Build
URL: https://github.com/apache/shiro/pull/137#issuecomment-496511288
Thanks for taking this on!
I think we should try to simplify this a little more to make this easier for
contributors.
Maybe ending with something like `mvn clean install
fpapon commented on issue #140: Reduce shiro test logging level to INFO
URL: https://github.com/apache/shiro/pull/140#issuecomment-497917934
@bdemers full agree, we only have to put in `TRACE` or `DEBUG` when we have
some errors and help to fix.
fpapon commented on issue #59: [SHIRO-617] ShiroFilter initialize
WebEnvironment on startup
URL: https://github.com/apache/shiro/pull/59#issuecomment-497964395
@col-panic Hi, thanks for your PR, I'm actually working about OSGi in Shiro,
I will take a look.
fpapon merged pull request #137: Build
URL: https://github.com/apache/shiro/pull/137
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
fpapon commented on issue #140: Reduce shiro test logging level to INFO
URL: https://github.com/apache/shiro/pull/140#issuecomment-497919046
@bdemers I think we should also put the root logger to `INFO` in the
`samples/guice/src/main/resources/log4j.properties`
asfgit commented on issue #59: [SHIRO-617] ShiroFilter initialize
WebEnvironment on startup
URL: https://github.com/apache/shiro/pull/59#issuecomment-497965629
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/101/Build
asfgit commented on issue #129: [SHIRO-694] Adds BearerToken support
URL: https://github.com/apache/shiro/pull/129#issuecomment-497965237
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/100/
asfgit commented on issue #142: SHIRO-696 - Upgrade Jetty
URL: https://github.com/apache/shiro/pull/142#issuecomment-499478206
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/103/
fpapon merged pull request #142: SHIRO-696 - Upgrade Jetty
URL: https://github.com/apache/shiro/pull/142
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
coheigea opened a new pull request #142: SHIRO-696 - Upgrade Jetty
URL: https://github.com/apache/shiro/pull/142
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
fpapon opened a new pull request #143: [SHIRO-696] Use root pom Jetty version
in Jaxrs sample
URL: https://github.com/apache/shiro/pull/143
This is an automated message from the Apache Git Service.
To respond to the
fpapon merged pull request #140: Reduce shiro test logging level to INFO
URL: https://github.com/apache/shiro/pull/140
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
fpapon commented on issue #85: [SHIRO-687] Adding Spring's Filters to
ShiroFilterFactorBean when using Java config
URL: https://github.com/apache/shiro/pull/85#issuecomment-499607074
retest this please
This is an automated
asfgit commented on issue #135: [SHIRO-699] Fix maven warning for
exec-maven-plugin and upgrade to 1.6.0
URL: https://github.com/apache/shiro/pull/135#issuecomment-499650716
Refer to this link for build results (access rights to CI server needed):
asfgit commented on issue #85: [SHIRO-687] Adding Spring's Filters to
ShiroFilterFactorBean when using Java config
URL: https://github.com/apache/shiro/pull/85#issuecomment-499654080
Refer to this link for build results (access rights to CI server needed):
asfgit commented on issue #143: [SHIRO-696] Use root pom Jetty version in Jaxrs
sample
URL: https://github.com/apache/shiro/pull/143#issuecomment-499621809
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/104/
asfgit commented on issue #140: [SHIRO-697] Reduce shiro test logging level to
INFO
URL: https://github.com/apache/shiro/pull/140#issuecomment-499630688
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/105/
asfgit commented on issue #137: [SHIRO-698] Improve build with maven profile
URL: https://github.com/apache/shiro/pull/137#issuecomment-499639460
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/106/
fpapon commented on issue #78: Adding another WildcardPermission test case
URL: https://github.com/apache/shiro/pull/78#issuecomment-497423173
@bdemers can we merge this?
This is an automated message from the Apache Git
fpapon commented on issue #129: Adds BearerToken support
URL: https://github.com/apache/shiro/pull/129#issuecomment-497424418
Thanks @bdemers !
This is an automated message from the Apache Git Service.
To respond to the
bdemers merged pull request #78: Adding another WildcardPermission test case
URL: https://github.com/apache/shiro/pull/78
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
bdemers commented on issue #138: Support base64 encoded salt in JdbcRealm
URL: https://github.com/apache/shiro/pull/138#issuecomment-497101348
@steinarb can you rebase your branch against master?
This is an automated message
asfgit commented on issue #138: Support base64 encoded salt in JdbcRealm
URL: https://github.com/apache/shiro/pull/138#issuecomment-497120236
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/91/
asfgit commented on issue #138: Support base64 encoded salt in JdbcRealm
URL: https://github.com/apache/shiro/pull/138#issuecomment-497134073
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/92/
fpapon commented on issue #137: Build
URL: https://github.com/apache/shiro/pull/137#issuecomment-496602102
> Thanks for taking this on!
>
> I think we should try to simplify this a little more to make this easier
for contributors.
> Maybe ending with something like `mvn clean
fpapon commented on a change in pull request #137: Build
URL: https://github.com/apache/shiro/pull/137#discussion_r288206310
##
File path: pom.xml
##
@@ -1474,5 +1478,54 @@
+
+samples
+
+
bdemers merged pull request #129: Adds BearerToken support
URL: https://github.com/apache/shiro/pull/129
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
steinarb opened a new pull request #138: Support base64 encoded salt in
JdbcRealm
URL: https://github.com/apache/shiro/pull/138
This fixes [SPAP-552](https://issues.apache.org/jira/browse/SHIRO-552)
The change has been tested in https://github.com/steinarb/authservice/ and
worked
asfgit commented on issue #138: Support base64 encoded salt in JdbcRealm
URL: https://github.com/apache/shiro/pull/138#issuecomment-497142120
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/93/
asfgit commented on issue #138: Support base64 encoded salt in JdbcRealm
URL: https://github.com/apache/shiro/pull/138#issuecomment-497153211
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/94/
coheigea opened a new pull request #147: SHIRO-703 - Update HSQL
URL: https://github.com/apache/shiro/pull/147
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
fpapon commented on issue #148: SHIRO-704 - Update Spring, Spring Boot +
Hibernate
URL: https://github.com/apache/shiro/pull/148#issuecomment-502342203
retest this please
This is an automated message from the Apache Git
asfgit commented on issue #148: SHIRO-704 - Update Spring, Spring Boot +
Hibernate
URL: https://github.com/apache/shiro/pull/148#issuecomment-502347333
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/116/
fpapon merged pull request #148: SHIRO-704 - Update Spring, Spring Boot +
Hibernate
URL: https://github.com/apache/shiro/pull/148
This is an automated message from the Apache Git Service.
To respond to the message, please
asfgit commented on issue #149: SHIRO-705 - Update Easymock + Powermock
URL: https://github.com/apache/shiro/pull/149#issuecomment-502647190
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/117/
101 - 200 of 1017 matches
Mail list logo
