[GitHub] [shiro] fpapon merged pull request #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-10-10 Thread GitBox
fpapon merged pull request #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shiro] fpapon commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-10-10 Thread GitBox
fpapon commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168#issuecomment-540638529 @bdemers Travis build is ok, I can merge ;) Thanks!

[GitHub] [shiro] fpapon commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-10-10 Thread GitBox
fpapon commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168#issuecomment-540441367 @bdemers I add some tests and also add the escape char check on the value. The Travis build failed because of a missing

[GitHub] [shiro] asf-ci commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-10-09 Thread GitBox
asf-ci commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168#issuecomment-540027279 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro-site] fpapon merged pull request #49: Fixed a typo

2019-09-27 Thread GitBox
fpapon merged pull request #49: Fixed a typo URL: https://github.com/apache/shiro-site/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shiro-site] IlyaGerasimets opened a new pull request #49: Fixed a typo

2019-09-27 Thread GitBox
IlyaGerasimets opened a new pull request #49: Fixed a typo URL: https://github.com/apache/shiro-site/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [shiro] fpapon commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-09-22 Thread GitBox
fpapon commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168#issuecomment-533906738 Ok, I will add more tests. This is an automated message

[GitHub] [shiro] bdemers commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-09-22 Thread GitBox
bdemers commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168#issuecomment-533905138 This seems fine to me, but we might want to add a few more test cases around the escape?

[GitHub] [shiro] asf-ci commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-09-22 Thread GitBox
asf-ci commented on issue #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168#issuecomment-533885094 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] fpapon opened a new pull request #168: [SHIRO-684] INI parser keeps escape characters in keys and values

2019-09-22 Thread GitBox
fpapon opened a new pull request #168: [SHIRO-684] INI parser keeps escape characters in keys and values URL: https://github.com/apache/shiro/pull/168 When fixing this issue, I found a bug in the `isCharEscaped` method and the `index` usage.

[GitHub] [shiro] fpapon merged pull request #67: [SHIRO-722] Add SameSite option to cookies

2019-09-12 Thread GitBox
fpapon merged pull request #67: [SHIRO-722] Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] asf-ci commented on issue #67: [SHIRO-722] Add SameSite option to cookies

2019-09-12 Thread GitBox
asf-ci commented on issue #67: [SHIRO-722] Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530872542 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/159/

[GitHub] [shiro] bdemers commented on issue #67: [SHIRO-722] Add SameSite option to cookies

2019-09-12 Thread GitBox
bdemers commented on issue #67: [SHIRO-722] Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530867864 Thanks!! This is an automated message from the Apache Git Service. To respond to

[GitHub] [shiro-site] boris-petrov opened a new pull request #48: Add info about the SameSite cookie flag

2019-09-12 Thread GitBox
boris-petrov opened a new pull request #48: Add info about the SameSite cookie flag URL: https://github.com/apache/shiro-site/pull/48 Implementation of the flag is [here](https://github.com/apache/shiro/pull/67). This is an

[GitHub] [shiro] boris-petrov commented on issue #67: [SHIRO-722] Add SameSite option to cookies

2019-09-12 Thread GitBox
boris-petrov commented on issue #67: [SHIRO-722] Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530864987 @bdemers - done for both points. This is an automated message from the Apache

[GitHub] [shiro] bdemers commented on issue #67: [SHIRO-722] Add SameSite option to cookies

2019-09-12 Thread GitBox
bdemers commented on issue #67: [SHIRO-722] Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530858412 @boris-petrov great point on the default, it sounds like LAX might be the way to go, a quick google shows it's that will be the default starting

[GitHub] [shiro] asf-ci commented on issue #67: Add SameSite option to cookies

2019-09-12 Thread GitBox
asf-ci commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530750236 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/158/

[GitHub] [shiro] fpapon commented on issue #67: Add SameSite option to cookies

2019-09-12 Thread GitBox
fpapon commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530732144 @boris-petrov for me the `getSameSite` and `setSameSite` are not a problem. This is an

[GitHub] [shiro] boris-petrov commented on issue #67: Add SameSite option to cookies

2019-09-12 Thread GitBox
boris-petrov commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530730949 Also, what about the added methods? The test is failing because of that also. I can overload the `addCookieHeader` and call the new one from the old one,

[GitHub] [shiro] boris-petrov edited a comment on issue #67: Add SameSite option to cookies

2019-09-12 Thread GitBox
boris-petrov edited a comment on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530730949 Also, what about the added methods? The test is failing because of that also. I can overload the `buildHeaderValue` and call the new one from the

[GitHub] [shiro] boris-petrov commented on issue #67: Add SameSite option to cookies

2019-09-12 Thread GitBox
boris-petrov commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530730424 Do we want `NONE` as the default? Chrome is making `LAX` the default and that is more secure than `NONE`. Perhaps Shiro should do the same?

[GitHub] [shiro] bdemers commented on issue #67: Add SameSite option to cookies

2019-09-11 Thread GitBox
bdemers commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530392705 @fpapon @boris-petrov Agreed, Your best bet is to overload the existing method with a new one, and just make the old call the new with the previous

[GitHub] [shiro] boris-petrov commented on issue #67: Add SameSite option to cookies

2019-09-11 Thread GitBox
boris-petrov commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530387875 @fpapon - I've [created a JIRA issue](https://issues.apache.org/jira/browse/SHIRO-722). Please tell me what to do with the failing test and I'll do

[GitHub] [shiro] fpapon commented on issue #67: Add SameSite option to cookies

2019-09-11 Thread GitBox
fpapon commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530366347 @boris-petrov I can't see a Jira about this issue, may be I missed it :) This is an automated

[GitHub] [shiro] fpapon edited a comment on issue #67: Add SameSite option to cookies

2019-09-11 Thread GitBox
fpapon edited a comment on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530351620 @boris-petrov Hi! we have the `japicmp` maven plugin failed on the build because of backward incompatibility: ``` [ERROR] Failed to execute

[GitHub] [shiro] fpapon commented on issue #67: Add SameSite option to cookies

2019-09-11 Thread GitBox
fpapon commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530351620 @boris-petrov Hi! we have the `japicmp` maven plugin failed on the build because of backward incompatibility: ``` [ERROR] Failed to execute goal

[GitHub] [shiro] asf-ci commented on issue #67: Add SameSite option to cookies

2019-09-11 Thread GitBox
asf-ci commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530300637 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/157/Build result: FAILURE[...truncated

[GitHub] [shiro] boris-petrov commented on issue #67: Add SameSite option to cookies

2019-09-11 Thread GitBox
boris-petrov commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530297751 I updated the PR and added also the `None` option. According to [this](https://scotthelme.co.uk/csrf-is-really-dead/) `SameSite` is going to be the

[GitHub] [shiro-site] fpapon merged pull request #47: Fix typo to format inline code properly

2019-09-04 Thread GitBox
fpapon merged pull request #47: Fix typo to format inline code properly URL: https://github.com/apache/shiro-site/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro-site] bdemers commented on issue #47: Fix typo to format inline code properly

2019-09-03 Thread GitBox
bdemers commented on issue #47: Fix typo to format inline code properly URL: https://github.com/apache/shiro-site/pull/47#issuecomment-527614685 Thanks @Binney ! This is an automated message from the Apache Git Service. To

[GitHub] [shiro-site] Binney opened a new pull request #47: Fix typo to format inline code properly

2019-08-31 Thread GitBox
Binney opened a new pull request #47: Fix typo to format inline code properly URL: https://github.com/apache/shiro-site/pull/47 Remove a couple of stray backticks! This is an automated message from the Apache Git Service. To

[GitHub] [shiro] fpapon merged pull request #167: SHIRO-720 - Update Commons BeanUtils

2019-08-15 Thread GitBox
fpapon merged pull request #167: SHIRO-720 - Update Commons BeanUtils URL: https://github.com/apache/shiro/pull/167 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shiro] asf-ci commented on issue #167: SHIRO-720 - Update Commons BeanUtils

2019-08-15 Thread GitBox
asf-ci commented on issue #167: SHIRO-720 - Update Commons BeanUtils URL: https://github.com/apache/shiro/pull/167#issuecomment-521609246 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/156/

[GitHub] [shiro] coheigea opened a new pull request #167: SHIRO-720 - Update Commons BeanUtils

2019-08-15 Thread GitBox
coheigea opened a new pull request #167: SHIRO-720 - Update Commons BeanUtils URL: https://github.com/apache/shiro/pull/167 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [shiro] bdemers commented on issue #162: Adding .travis.yml for PR builds

2019-08-07 Thread GitBox
bdemers commented on issue #162: Adding .travis.yml for PR builds URL: https://github.com/apache/shiro/pull/162#issuecomment-519104169 Done!! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shiro] bdemers merged pull request #162: Adding .travis.yml for PR builds

2019-08-07 Thread GitBox
bdemers merged pull request #162: Adding .travis.yml for PR builds URL: https://github.com/apache/shiro/pull/162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shiro] fpapon commented on issue #162: Adding .travis.yml for PR builds

2019-08-07 Thread GitBox
fpapon commented on issue #162: Adding .travis.yml for PR builds URL: https://github.com/apache/shiro/pull/162#issuecomment-518980367 @bdemers Can we merge it? This is an automated message from the Apache Git Service. To

[GitHub] [shiro] fpapon merged pull request #138: [SHIRO-552] Support base64 encoded salt in JdbcRealm

2019-08-02 Thread GitBox
fpapon merged pull request #138: [SHIRO-552] Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [shiro] asf-ci commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-08-02 Thread GitBox
asf-ci commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-517761803 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/155/

[GitHub] [shiro] steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-08-02 Thread GitBox
steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-517752959 @fpapon rebased, conflict resolved, built with "mvn clean install" with no errors, and branch force-pushed

[GitHub] [shiro] fpapon commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-08-02 Thread GitBox
fpapon commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-517708156 @steinarb yes, thanks! This is an automated message from the Apache Git Service. To

[GitHub] [shiro] steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-08-02 Thread GitBox
steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-517705111 @bdemers @fpapon Should I resolve the conflict and re-push? This is an

[GitHub] [shiro] fpapon commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-07-27 Thread GitBox
fpapon commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-515671550 @steinarb ok, thanks! This is an automated message from the Apache Git Service. To

[GitHub] [shiro] fpapon merged pull request #165: [SHIRO-717] Upgrade to maven-pmd-plugin 3.12.0

2019-07-27 Thread GitBox
fpapon merged pull request #165: [SHIRO-717] Upgrade to maven-pmd-plugin 3.12.0 URL: https://github.com/apache/shiro/pull/165 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [shiro] steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-07-27 Thread GitBox
steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-515669920 > Hi @steinarb , any update about the ICLA? Hi @fpapon I understood from the comment by @bdemers above that it was OK...? In my

[GitHub] [shiro] fpapon commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-07-27 Thread GitBox
fpapon commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-515659895 Hi @steinarb , any update about the ICLA? This is an automated message from the

[GitHub] [shiro] asf-ci commented on issue #165: [SHIRO-717] Upgrade to maven-pmd-plugin 3.12.0

2019-07-26 Thread GitBox
asf-ci commented on issue #165: [SHIRO-717] Upgrade to maven-pmd-plugin 3.12.0 URL: https://github.com/apache/shiro/pull/165#issuecomment-515420605 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/154/

[GitHub] [shiro] fpapon commented on issue #165: [SHIRO-717] Upgrade to maven-pmd-plugin 3.12.0

2019-07-26 Thread GitBox
fpapon commented on issue #165: [SHIRO-717] Upgrade to maven-pmd-plugin 3.12.0 URL: https://github.com/apache/shiro/pull/165#issuecomment-515416407 There is a test error on the build but for me it's not related to this PR.

[GitHub] [shiro] fpapon commented on issue #165: [SHIRO-717] Upgrade to maven-pmd-plugin 3.12.0

2019-07-26 Thread GitBox
fpapon commented on issue #165: [SHIRO-717] Upgrade to maven-pmd-plugin 3.12.0 URL: https://github.com/apache/shiro/pull/165#issuecomment-515384784 retest this please This is an automated message from the Apache Git Service.

[GitHub] [shiro] asfgit commented on issue #162: Adding .travis.yml for PR builds

2019-07-25 Thread GitBox
asfgit commented on issue #162: Adding .travis.yml for PR builds URL: https://github.com/apache/shiro/pull/162#issuecomment-515270858 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/152/

[GitHub] [shiro] fpapon merged pull request #166: [SHIRO-719] Upgrade to Karaf 4.2.6

2019-07-25 Thread GitBox
fpapon merged pull request #166: [SHIRO-719] Upgrade to Karaf 4.2.6 URL: https://github.com/apache/shiro/pull/166 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shiro] fpapon commented on issue #165: [SHIRO-717] Upgrade to maven-pmd-plugin 3.12.0

2019-07-25 Thread GitBox
fpapon commented on issue #165: [SHIRO-717] Upgrade to maven-pmd-plugin 3.12.0 URL: https://github.com/apache/shiro/pull/165#issuecomment-514981564 retest this please This is an automated message from the Apache Git Service.

[GitHub] [shiro] asfgit commented on issue #166: [SHIRO-719] Upgrade to Karaf 4.2.6

2019-07-25 Thread GitBox
asfgit commented on issue #166: [SHIRO-719] Upgrade to Karaf 4.2.6 URL: https://github.com/apache/shiro/pull/166#issuecomment-514969026 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/151/

[GitHub] [shiro] jbonofre opened a new pull request #166: [SHIRO-719] Upgrade to Karaf 4.2.6

2019-07-25 Thread GitBox
jbonofre opened a new pull request #166: [SHIRO-719] Upgrade to Karaf 4.2.6 URL: https://github.com/apache/shiro/pull/166 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] jbonofre commented on issue #166: [SHIRO-719] Upgrade to Karaf 4.2.6

2019-07-25 Thread GitBox
jbonofre commented on issue #166: [SHIRO-719] Upgrade to Karaf 4.2.6 URL: https://github.com/apache/shiro/pull/166#issuecomment-514931184 R: @fpapon This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shiro] asfgit commented on issue #162: Adding .travis.yml for PR builds

2019-07-24 Thread GitBox
asfgit commented on issue #162: Adding .travis.yml for PR builds URL: https://github.com/apache/shiro/pull/162#issuecomment-514852318 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/150/

[GitHub] [shiro] asfgit commented on issue #165: [SHIRO-717] Upgrade to maven-pmd-plugin 3.12.0

2019-07-24 Thread GitBox
asfgit commented on issue #165: [SHIRO-717] Upgrade to maven-pmd-plugin 3.12.0 URL: https://github.com/apache/shiro/pull/165#issuecomment-514824262 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/149/Build result:

[GitHub] [shiro] fpapon merged pull request #164: [SHIRO-718] Upgrade to xmlsec 2.1.4

2019-07-24 Thread GitBox
fpapon merged pull request #164: [SHIRO-718] Upgrade to xmlsec 2.1.4 URL: https://github.com/apache/shiro/pull/164 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shiro] asfgit commented on issue #164: [SHIRO-718] Upgrade to xmlsec 2.1.4

2019-07-24 Thread GitBox
asfgit commented on issue #164: [SHIRO-718] Upgrade to xmlsec 2.1.4 URL: https://github.com/apache/shiro/pull/164#issuecomment-514740126 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/148/

[GitHub] [shiro] jbonofre commented on issue #165: [SHIRO-717] Upgrade to maven-pmd-plugin 3.12.0

2019-07-24 Thread GitBox
jbonofre commented on issue #165: [SHIRO-717] Upgrade to maven-pmd-plugin 3.12.0 URL: https://github.com/apache/shiro/pull/165#issuecomment-514676785 R: @fpapon This is an automated message from the Apache Git Service. To

[GitHub] [shiro] jbonofre opened a new pull request #165: [SHIRO-717] Upgrade to maven-pmd-plugin 3.12.0

2019-07-24 Thread GitBox
jbonofre opened a new pull request #165: [SHIRO-717] Upgrade to maven-pmd-plugin 3.12.0 URL: https://github.com/apache/shiro/pull/165 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [shiro] jbonofre commented on issue #164: [SHIRO-718] Upgrade to xmlsec 2.1.4

2019-07-24 Thread GitBox
jbonofre commented on issue #164: [SHIRO-718] Upgrade to xmlsec 2.1.4 URL: https://github.com/apache/shiro/pull/164#issuecomment-514675620 R: @fpapon This is an automated message from the Apache Git Service. To respond to

[GitHub] [shiro] jbonofre opened a new pull request #164: [SHIRO-718] Upgrade to xmlsec 2.1.4

2019-07-24 Thread GitBox
jbonofre opened a new pull request #164: [SHIRO-718] Upgrade to xmlsec 2.1.4 URL: https://github.com/apache/shiro/pull/164 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] fpapon merged pull request #163: [SHIRO-716] Upgrade to commons-codec 1.13

2019-07-24 Thread GitBox
fpapon merged pull request #163: [SHIRO-716] Upgrade to commons-codec 1.13 URL: https://github.com/apache/shiro/pull/163 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] asfgit commented on issue #163: [SHIRO-716] Upgrade to commons-codec 1.13

2019-07-24 Thread GitBox
asfgit commented on issue #163: [SHIRO-716] Upgrade to commons-codec 1.13 URL: https://github.com/apache/shiro/pull/163#issuecomment-514612871 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/147/

[GitHub] [shiro] fpapon commented on issue #163: [SHIRO-716] Upgrade to commons-codec 1.13

2019-07-24 Thread GitBox
fpapon commented on issue #163: [SHIRO-716] Upgrade to commons-codec 1.13 URL: https://github.com/apache/shiro/pull/163#issuecomment-514565256 LGTM! @jbonofre thanks! waiting for Jenkins build result for merging This is

[GitHub] [shiro] jbonofre commented on issue #163: [SHIRO-716] Upgrade to commons-codec 1.13

2019-07-24 Thread GitBox
jbonofre commented on issue #163: [SHIRO-716] Upgrade to commons-codec 1.13 URL: https://github.com/apache/shiro/pull/163#issuecomment-514550925 R: @fpapon This is an automated message from the Apache Git Service. To respond

[GitHub] [shiro] jbonofre opened a new pull request #163: [SHIRO-716] Upgrade to commons-codec 1.13

2019-07-24 Thread GitBox
jbonofre opened a new pull request #163: [SHIRO-716] Upgrade to commons-codec 1.13 URL: https://github.com/apache/shiro/pull/163 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [shiro] asfgit commented on issue #162: Adding .travis.yml for PR builds

2019-07-23 Thread GitBox
asfgit commented on issue #162: Adding .travis.yml for PR builds URL: https://github.com/apache/shiro/pull/162#issuecomment-514436431 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/146/

[GitHub] [shiro] fpapon commented on issue #162: Adding .travis.yml for PR builds

2019-07-23 Thread GitBox
fpapon commented on issue #162: Adding .travis.yml for PR builds URL: https://github.com/apache/shiro/pull/162#issuecomment-514378332 @bdemers good idea! +1 This is an automated message from the Apache Git Service. To

[GitHub] [shiro] asfgit commented on issue #162: Adding .travis.yml for PR builds

2019-07-23 Thread GitBox
asfgit commented on issue #162: Adding .travis.yml for PR builds URL: https://github.com/apache/shiro/pull/162#issuecomment-514375537 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/145/Build result:

[GitHub] [shiro] asfgit commented on issue #162: Adding .travis.yml for PR builds

2019-07-23 Thread GitBox
asfgit commented on issue #162: Adding .travis.yml for PR builds URL: https://github.com/apache/shiro/pull/162#issuecomment-514355681 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/144/Build result:

[GitHub] [shiro] asfgit commented on issue #162: Adding .travis.yml for PR builds

2019-07-23 Thread GitBox
asfgit commented on issue #162: Adding .travis.yml for PR builds URL: https://github.com/apache/shiro/pull/162#issuecomment-514319094 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/143/Build result:

[GitHub] [shiro] jbonofre commented on issue #162: Adding .travis.yml for PR builds

2019-07-23 Thread GitBox
jbonofre commented on issue #162: Adding .travis.yml for PR builds URL: https://github.com/apache/shiro/pull/162#issuecomment-514270476 @bdemers nice ! Thanks for that. Let me take a look ! This is an automated message from

[GitHub] [shiro-site] fpapon merged pull request #46: Update java-authentication-guide.md.vtl

2019-07-19 Thread GitBox
fpapon merged pull request #46: Update java-authentication-guide.md.vtl URL: https://github.com/apache/shiro-site/pull/46 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro-site] superhq opened a new pull request #46: Update java-authentication-guide.md.vtl

2019-07-19 Thread GitBox
superhq opened a new pull request #46: Update java-authentication-guide.md.vtl URL: https://github.com/apache/shiro-site/pull/46 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [shiro] bdemers commented on issue #155: org.apache.shiro.authz.AuthorizationException: Not authorized to invoke method:

2019-07-15 Thread GitBox
bdemers commented on issue #155: org.apache.shiro.authz.AuthorizationException: Not authorized to invoke method: URL: https://github.com/apache/shiro/pull/155#issuecomment-511463630 Closing for now. @zhuyouzhufu, please open a new PR with your changes against master. Thanks!

[GitHub] [shiro] bdemers closed pull request #155: org.apache.shiro.authz.AuthorizationException: Not authorized to invoke method:

2019-07-15 Thread GitBox
bdemers closed pull request #155: org.apache.shiro.authz.AuthorizationException: Not authorized to invoke method: URL: https://github.com/apache/shiro/pull/155 This is an automated message from the Apache Git Service. To

[GitHub] [shiro] fpapon merged pull request #161: Remove com.sun Base64 import

2019-07-15 Thread GitBox
fpapon merged pull request #161: Remove com.sun Base64 import URL: https://github.com/apache/shiro/pull/161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [shiro] fpapon merged pull request #160: Remove old junit.framework imports

2019-07-15 Thread GitBox
fpapon merged pull request #160: Remove old junit.framework imports URL: https://github.com/apache/shiro/pull/160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shiro] asfgit commented on issue #161: Remove com.sun Base64 import

2019-07-15 Thread GitBox
asfgit commented on issue #161: Remove com.sun Base64 import URL: https://github.com/apache/shiro/pull/161#issuecomment-511386638 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/142/

[GitHub] [shiro] asfgit commented on issue #160: Remove old junit.framework imports

2019-07-15 Thread GitBox
asfgit commented on issue #160: Remove old junit.framework imports URL: https://github.com/apache/shiro/pull/160#issuecomment-511380431 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/141/

[GitHub] [shiro] coheigea opened a new pull request #161: Remove com.sun Base64 import

2019-07-15 Thread GitBox
coheigea opened a new pull request #161: Remove com.sun Base64 import URL: https://github.com/apache/shiro/pull/161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shiro] fpapon commented on issue #160: Remove old junit.framework imports

2019-07-15 Thread GitBox
fpapon commented on issue #160: Remove old junit.framework imports URL: https://github.com/apache/shiro/pull/160#issuecomment-511364741 waiting for Jenkins build before merging This is an automated message from the Apache Git

[GitHub] [shiro] coheigea opened a new pull request #160: Remove old junit.framework imports

2019-07-15 Thread GitBox
coheigea opened a new pull request #160: Remove old junit.framework imports URL: https://github.com/apache/shiro/pull/160 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] asfgit commented on issue #155: org.apache.shiro.authz.AuthorizationException: Not authorized to invoke method:

2019-07-02 Thread GitBox
asfgit commented on issue #155: org.apache.shiro.authz.AuthorizationException: Not authorized to invoke method: URL: https://github.com/apache/shiro/pull/155#issuecomment-507789006 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] fpapon commented on issue #155: org.apache.shiro.authz.AuthorizationException: Not authorized to invoke method:

2019-07-02 Thread GitBox
fpapon commented on issue #155: org.apache.shiro.authz.AuthorizationException: Not authorized to invoke method: URL: https://github.com/apache/shiro/pull/155#issuecomment-507775253 Hi @zhuyouzhufu, do you need some help to fix your branch issue? I can create a new PR based on yours if you

[GitHub] [shiro] bdemers merged pull request #156: SHIRO-711 - Deprecate JavaEnvironment

2019-07-02 Thread GitBox
bdemers merged pull request #156: SHIRO-711 - Deprecate JavaEnvironment URL: https://github.com/apache/shiro/pull/156 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] bdemers commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment

2019-07-02 Thread GitBox
bdemers commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment URL: https://github.com/apache/shiro/pull/156#issuecomment-507768223 Thanks for catching that @fpapon, I thought I had already changed my vote This is

[GitHub] [shiro] asfgit commented on issue #159: [SHIRO-715] Remove old JSTL jars

2019-07-01 Thread GitBox
asfgit commented on issue #159: [SHIRO-715] Remove old JSTL jars URL: https://github.com/apache/shiro/pull/159#issuecomment-507436594 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/139/

[GitHub] [shiro] fpapon commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment

2019-07-01 Thread GitBox
fpapon commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment URL: https://github.com/apache/shiro/pull/156#issuecomment-507428849 Hi @bdemers, are you now ok to approve this PR? This is an automated message from the

[GitHub] [shiro] fpapon commented on issue #159: [SHIRO-715] Remove old JSTL jars

2019-07-01 Thread GitBox
fpapon commented on issue #159: [SHIRO-715] Remove old JSTL jars URL: https://github.com/apache/shiro/pull/159#issuecomment-507428398 @coheigea Thanks for the PR! I created a Jira for tracing : https://issues.apache.org/jira/browse/SHIRO-715

[GitHub] [shiro] asfgit commented on issue #155: org.apache.shiro.authz.AuthorizationException: Not authorized to invoke method:

2019-07-01 Thread GitBox
asfgit commented on issue #155: org.apache.shiro.authz.AuthorizationException: Not authorized to invoke method: URL: https://github.com/apache/shiro/pull/155#issuecomment-507305222 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] bdemers commented on issue #159: Remove old JSTL jars

2019-07-01 Thread GitBox
bdemers commented on issue #159: Remove old JSTL jars URL: https://github.com/apache/shiro/pull/159#issuecomment-507281475 Thanks again! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [shiro] bdemers merged pull request #159: Remove old JSTL jars

2019-07-01 Thread GitBox
bdemers merged pull request #159: Remove old JSTL jars URL: https://github.com/apache/shiro/pull/159 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [shiro] asfgit commented on issue #159: Remove old JSTL jars

2019-07-01 Thread GitBox
asfgit commented on issue #159: Remove old JSTL jars URL: https://github.com/apache/shiro/pull/159#issuecomment-507225667 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/137/

[GitHub] [shiro] coheigea opened a new pull request #159: Remove old JSTL jars

2019-07-01 Thread GitBox
coheigea opened a new pull request #159: Remove old JSTL jars URL: https://github.com/apache/shiro/pull/159 Remove old JSTL jars and replace with up-to-date Apache version, which doesn't have a CVE associated with it. This

[GitHub] [shiro] asfgit commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment

2019-06-28 Thread GitBox
asfgit commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment URL: https://github.com/apache/shiro/pull/156#issuecomment-506852513 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/136/

[GitHub] [shiro] asfgit commented on issue #155: org.apache.shiro.authz.AuthorizationException: Not authorized to invoke method:

2019-06-28 Thread GitBox
asfgit commented on issue #155: org.apache.shiro.authz.AuthorizationException: Not authorized to invoke method: URL: https://github.com/apache/shiro/pull/155#issuecomment-506847475 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] asfgit commented on issue #155: org.apache.shiro.authz.AuthorizationException: Not authorized to invoke method:

2019-06-28 Thread GitBox
asfgit commented on issue #155: org.apache.shiro.authz.AuthorizationException: Not authorized to invoke method: URL: https://github.com/apache/shiro/pull/155#issuecomment-506841853 Refer to this link for build results (access rights to CI server needed):

  1   2   3   4   5   >