XJDKC commented on a change in pull request #708:
URL: https://github.com/apache/singa/pull/708#discussion_r429511478
##########
File path: src/core/scheduler/scheduler.cc
##########
@@ -325,9 +337,10 @@ void Graph::RunGraph() {
}
}
+ EvaluateTimeElapsed();
Review comment:
I think we should call the step function before EvaluateTimeElapsed.
Otherwise, it may have problems when dividing the time if the skip_iteration is
zero.
##########
File path: src/core/scheduler/scheduler.cc
##########
@@ -325,9 +337,10 @@ void Graph::RunGraph() {
}
}
+ EvaluateTimeElapsed();
+
// increment iteration counter
step();
Review comment:
Remember to clear the elapsed time and the iteration when resetting the
graph.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
