[jira] [Commented] (SINGA-485) Code Coverage Analysis

2019-09-02 Thread wangwei (Jira)


[ 
https://issues.apache.org/jira/browse/SINGA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921099#comment-16921099
 ] 

wangwei commented on SINGA-485:
---

In fact, the current travis configuration will run the unit tests for python 
via conda test 
[https://github.com/apache/incubator-singa/blob/master/tool/conda/singa/meta.yaml#L74]

Does the code coverage analysis give us a report on how to improve the code?

> Code Coverage Analysis
> --
>
> Key: SINGA-485
> URL: https://issues.apache.org/jira/browse/SINGA-485
> Project: Singa
>  Issue Type: Improvement
>Reporter: Moaz Reyad
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> SINGA development and testing can be improved by using a [code 
> coverage|https://en.wikipedia.org/wiki/Code_coverage] tool.
> Some Apache projects use [codecov|https://codecov.io/gh/apache?page=1], while 
> others use [coverall|https://coveralls.io/github/apache?page=1].
> This issue is open to choose a code coverage tool and add it to SINGA build 
> and test pipeline.
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (SINGA-485) Code Coverage Analysis

2019-09-02 Thread Moaz Reyad (Jira)


[ 
https://issues.apache.org/jira/browse/SINGA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920922#comment-16920922
 ] 

Moaz Reyad commented on SINGA-485:
--

Currently the Travis CI configuration performs only the build but no test is 
enabled. It does not compile with {code:bash} ENABLE_TEST {code} option enabled.

To perform code coverage analysis, we need to:
* Enable the build of unit tests using -DENABLE_TEST=ON
* Run the unit tests

Note that the current configuration is for C++ only since it has the line 
{code:bash} language: cpp {code}
It builds python and conda packages, but this does not help in the unit test of 
C++ code. Later we need to add language:python to the travis build matrix and 
move the python build/test under that item.

Any comments or discussion is welcome.

> Code Coverage Analysis
> --
>
> Key: SINGA-485
> URL: https://issues.apache.org/jira/browse/SINGA-485
> Project: Singa
>  Issue Type: Improvement
>Reporter: Moaz Reyad
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> SINGA development and testing can be improved by using a [code 
> coverage|https://en.wikipedia.org/wiki/Code_coverage] tool.
> Some Apache projects use [codecov|https://codecov.io/gh/apache?page=1], while 
> others use [coverall|https://coveralls.io/github/apache?page=1].
> This issue is open to choose a code coverage tool and add it to SINGA build 
> and test pipeline.
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


Re: [Discuss] Graduate Apache SINGA (incubating) as a TLP

2019-09-02 Thread Moaz Reyad
The PPMC reached a conclusion on the discussion [1] that there is no need
for SGA.

Please let me know if there is anything else required. Otherwise, we start
the vote.

Thank you,
Moaz

[1]
https://lists.apache.org/thread.html/b8b2979a870784ce04f87572e0f44311a1338bc9365e955a80d5248b@1427941853@%3Cprivate.singa.apache.org%3E

On Sun, Sep 1, 2019 at 5:00 AM Dave Fisher  wrote:

> Hi -
>
> I see the discussion that an SGA is not needed about 4/2/2015. [1]
>
> I don’t necessarily see the there was a conclusion to that discussion on
> private@singa. I certainly don’t see anything related to Singapore in the
> grants index in the foundation records. There are plenty of other sgas
> recorded from universities.
>
> Regards,
> Dave
>
> [1]
> https://lists.apache.org/thread.html/b8b2979a870784ce04f87572e0f44311a1338bc9365e955a80d5248b@1427941853@%3Cprivate.singa.apache.org%3E
>
> > On Aug 31, 2019, at 7:35 PM, Alan Gates  wrote:
> >
> > Yes, I saw that, but I can't find those papers.  They should have been
> > filed by the Apache secretary on the page I referenced.  Either they were
> > properly transferred and we need to find them so that they are properly
> > posted in case anyone ever needs them, or, if they weren't sent, then we
> > need to make sure a copy of them is sent.
> >
> > I guess the next step is to email the secretary and ask if he's aware of
> > that transfer having taken place, unless anyone knows somewhere else I
> > should be looking for them.
> >
> > Alan.
> >
> > On Sat, Aug 31, 2019 at 3:48 AM Moaz Reyad  wrote:
> >
> >> Dear Alan,
> >>
> >> The copyright section in the project page [1] has the following item :
> >>
> >> Date: 2015-03-31
> >> Item: Check and make sure that the papers that transfer rights to the
> ASF
> >> been received. It is only necessary to transfer rights for the package,
> the
> >> core code, and any new code produced by the project.
> >>
> >> I believe this answers your question about the transfer rights of the
> code.
> >> Please let me know if there is anything else required.
> >>
> >> We will proceed to vote if no one objects.
> >>
> >> Thank you,
> >> Moaz
> >>
> >> [1] http://incubator.apache.org/projects/singa.html
> >>
> >> On Tue, Aug 27, 2019 at 8:48 PM Alan Gates 
> wrote:
> >>
> >>> Sorry, I brought this up earlier on the dev list but didn't follow
> up.  I
> >>> can't find a copy of the code grant for the code that Singa brought
> into
> >>> the Incubator.  When I look at the Secretary's page[1] that lists all
> of
> >>> the code grants I don't see one for Singa.  Per the initial proposal[2]
> >>> there was code imported from an existing github repo [3], which means
> we
> >>> need to have a code grant from whom ever owned that code (National
> >>> University of Singapore would be my guess).
> >>>
> >>> We need to clear this up before Singa graduates to assure that the ASF
> >> has
> >>> the right to this code.
> >>>
> >>> Alan.
> >>>
> >>> [1] https://incubator.apache.org/ip-clearance/index.html
> >>> [2]
> https://cwiki.apache.org/confluence/display/INCUBATOR/SingaProposal
> >>> [3] https://github.com/nusinga/singa
> >>>
> >>> On Tue, Aug 27, 2019 at 1:34 AM Moaz Reyad  wrote:
> >>>
>  Hi all,
> 
>  In the four and a half years that Apache SINGA (incubating) has
>  been a part of the Apache incubator, the community has grown,
> >>> diversified,
>  and adapted to the Apache Way. We believe that the project is ready to
>  graduate to a TLP.
> 
>  As a community, we have discussed [1] and voted [2] to graduate to a
>  TLP, we have worked through the maturity model [3], notified the IPMC
> >>> that
>  we have the intention to graduate [4] and proposed PMC chair [5].
> 
>  Please see the draft resolution appended below and provide any
>  comments or feedback you have on it.
> 
>  We would like to continue the graduation process and hereby ask you
>  all for your opinion on this. The discussion is open for 72 hours,
> >> after
>  which we will start a [VOTE] on graduation here.
> 
>  Thanks,
> 
>  --moaz
>  on behalf of the Apache SINGA PPMC
> 
>  [1]
> 
> 
> >>>
> >>
> https://lists.apache.org/thread.html/fd2fe639f3314ff22d2e47d39bd6d4126d61d10e8628fa26f71ef01d@%3Cdev.singa.apache.org%3E
>  [2]
> 
> 
> >>>
> >>
> https://lists.apache.org/thread.html/cb40b73b3fd685b44a129601abd5967e4150db245b3fc6552f106faf@%3Cdev.singa.apache.org%3E
>  [3]
> 
> >>>
> >>
> https://cwiki.apache.org/confluence/display/SINGA/Maturity+model+assessment
>  [4]
> 
> 
> >>>
> >>
> https://lists.apache.org/thread.html/5b5ebefe705084e0a9d67cfaf56f17ff27518273366f8088be19273e@%3Cgeneral.incubator.apache.org%3E
>  [5]
> 
> 
> >>>
> >>
> https://lists.apache.org/thread.html/2903ea94da1b862acf8d706dd4f7cd9ecbc434166d4381d170be731f@%3Cprivate.singa.apache.org%3E
> 
>  Proposed Resolution for the Apache SINGA project for the ASF Board:
>