[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-06 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r311068821 ## File path: src/api/config.i ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-06 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r311074176 ## File path: src/api/config.i ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-06 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r311056639 ## File path: src/api/config.i ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [incubator-singa] joddiy commented on issue #498: SINGA-475 add Pow operator

2019-08-05 Thread GitBox
joddiy commented on issue #498: SINGA-475 add Pow operator URL: https://github.com/apache/incubator-singa/pull/498#issuecomment-518464766 ready for merge This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-06 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r311068821 ## File path: src/api/config.i ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [incubator-singa] nudles merged pull request #493: SINGA-473 Autograd Trigonometry: Backward Test

2019-08-06 Thread GitBox
nudles merged pull request #493: SINGA-473 Autograd Trigonometry: Backward Test URL: https://github.com/apache/incubator-singa/pull/493 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-singa] nudles merged pull request #498: SINGA-475 add Pow operator

2019-08-09 Thread GitBox
nudles merged pull request #498: SINGA-475 add Pow operator URL: https://github.com/apache/incubator-singa/pull/498 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-singa] nudles merged pull request #494: SINGA-475 add SoftPlus operator

2019-08-09 Thread GitBox
nudles merged pull request #494: SINGA-475 add SoftPlus operator URL: https://github.com/apache/incubator-singa/pull/494 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-singa] nudles merged pull request #500: SINGA-478 (Python 3 uses __itruediv__ instead of __idiv__)

2019-08-09 Thread GitBox
nudles merged pull request #500: SINGA-478 (Python 3 uses __itruediv__ instead of __idiv__) URL: https://github.com/apache/incubator-singa/pull/500 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-singa] chrishkchris commented on issue #488: SINGA -475 add Sign operator to singa

2019-08-09 Thread GitBox
chrishkchris commented on issue #488: SINGA -475 add Sign operator to singa URL: https://github.com/apache/incubator-singa/pull/488#issuecomment-519856801 In my opinion: For the function y=sign(x) , y = 1 when x > 0, y = -1 when x < 0. Therefore, the derivative is 0 except x = 0.

[GitHub] [incubator-singa] nudles commented on a change in pull request #488: SINGA -475 add Sign operator to singa

2019-08-09 Thread GitBox
nudles commented on a change in pull request #488: SINGA -475 add Sign operator to singa URL: https://github.com/apache/incubator-singa/pull/488#discussion_r312397599 ## File path: python/singa/autograd.py ## @@ -1828,3 +1828,21 @@ def backward(self, dy): def

[GitHub] [incubator-singa] nudles commented on issue #500: SINGA-478 (Python 3 uses __itruediv__ instead of __idiv__)

2019-08-08 Thread GitBox
nudles commented on issue #500: SINGA-478 (Python 3 uses __itruediv__ instead of __idiv__) URL: https://github.com/apache/incubator-singa/pull/500#issuecomment-519736627 Should we need to remove `__idiv__` if it is not used by Py3?

[GitHub] [incubator-singa] nudles edited a comment on issue #500: SINGA-478 (Python 3 uses __itruediv__ instead of __idiv__)

2019-08-08 Thread GitBox
nudles edited a comment on issue #500: SINGA-478 (Python 3 uses __itruediv__ instead of __idiv__) URL: https://github.com/apache/incubator-singa/pull/500#issuecomment-519736627 Should we remove `__idiv__` if it is not used by Py3?

[GitHub] [incubator-singa] chrishkchris commented on issue #500: SINGA-478 (Python 3 uses __itruediv__ instead of __idiv__)

2019-08-08 Thread GitBox
chrishkchris commented on issue #500: SINGA-478 (Python 3 uses __itruediv__ instead of __idiv__) URL: https://github.com/apache/incubator-singa/pull/500#issuecomment-519749290 Yes, I guess py2 is not used by us anymore for long time (e.g. the new dockerfile uses Miniconda3 py36 and py37).

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #500: SINGA-478 (Python 3 uses __itruediv__ instead of __idiv__)

2019-08-08 Thread GitBox
chrishkchris edited a comment on issue #500: SINGA-478 (Python 3 uses __itruediv__ instead of __idiv__) URL: https://github.com/apache/incubator-singa/pull/500#issuecomment-519749290 Yes, I guess py2 is not used by us anymore for long time (e.g. the new dockerfile uses Miniconda3 py36 and

[GitHub] [incubator-singa] nudles merged pull request #492: Make singa use multiple memory pools

2019-08-08 Thread GitBox
nudles merged pull request #492: Make singa use multiple memory pools URL: https://github.com/apache/incubator-singa/pull/492 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-singa] nudles merged pull request #485: SINGA -475 add Sub operator implementation to singa

2019-08-08 Thread GitBox
nudles merged pull request #485: SINGA -475 add Sub operator implementation to singa URL: https://github.com/apache/incubator-singa/pull/485 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #500: SINGA-478 (Python 3 uses __itruediv__ instead of __idiv__)

2019-08-08 Thread GitBox
chrishkchris edited a comment on issue #500: SINGA-478 (Python 3 uses __itruediv__ instead of __idiv__) URL: https://github.com/apache/incubator-singa/pull/500#issuecomment-519749290 Yes, I guess py2 is not used by us anymore for long time (e.g. the new dockerfile uses Miniconda3 py36 and

[GitHub] [incubator-singa] nudles merged pull request #486: SINGA -475 add Sqrt operator to singa

2019-08-08 Thread GitBox
nudles merged pull request #486: SINGA -475 add Sqrt operator to singa URL: https://github.com/apache/incubator-singa/pull/486 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-singa] nudles commented on issue #487: SINGA -475 add Log operator to singa

2019-08-08 Thread GitBox
nudles commented on issue #487: SINGA -475 add Log operator to singa URL: https://github.com/apache/incubator-singa/pull/487#issuecomment-519785209 there are conflicts.. two solutions: 1. [merge this branch with the latest

[GitHub] [incubator-singa] chrishkchris commented on issue #488: SINGA -475 add Sign operator to singa

2019-08-09 Thread GitBox
chrishkchris commented on issue #488: SINGA -475 add Sign operator to singa URL: https://github.com/apache/incubator-singa/pull/488#issuecomment-519876368 there are conflicts and there are two solutions (same as what happened in log operator): 1. merge this branch with the latest

[GitHub] [incubator-singa] chrishkchris commented on issue #499: SINGA -475 add Div operator

2019-08-09 Thread GitBox
chrishkchris commented on issue #499: SINGA -475 add Div operator URL: https://github.com/apache/incubator-singa/pull/499#issuecomment-519877683 There are conflicts and there are two solutions (same as what happened in log operator): 1. merge this branch with the latest master 2.

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #488: SINGA -475 add Sign operator to singa

2019-08-09 Thread GitBox
chrishkchris edited a comment on issue #488: SINGA -475 add Sign operator to singa URL: https://github.com/apache/incubator-singa/pull/488#issuecomment-519876368 there are conflicts and there are two solutions (same as what happened in log operator): 1. merge this branch with the

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #488: SINGA -475 add Sign operator to singa

2019-08-09 Thread GitBox
chrishkchris edited a comment on issue #488: SINGA -475 add Sign operator to singa URL: https://github.com/apache/incubator-singa/pull/488#issuecomment-519876368 there are conflicts and there are two solutions (same as what happened in log operator): 1. merge this branch with the

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #499: SINGA -475 add Div operator

2019-08-09 Thread GitBox
chrishkchris edited a comment on issue #499: SINGA -475 add Div operator URL: https://github.com/apache/incubator-singa/pull/499#issuecomment-519877683 There are conflicts and there are two solutions (same as what happened in log operator): 1. merge this branch with the latest master

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #488: SINGA -475 add Sign operator to singa

2019-08-09 Thread GitBox
chrishkchris edited a comment on issue #488: SINGA -475 add Sign operator to singa URL: https://github.com/apache/incubator-singa/pull/488#issuecomment-519856801 In my opinion: For the function y=sign(x) , y = 1 when x > 0, y = -1 when x < 0. Therefore, the derivative is 0 except x =

[GitHub] [incubator-singa] chrishkchris commented on issue #488: SINGA -475 add Sign operator to singa

2019-08-09 Thread GitBox
chrishkchris commented on issue #488: SINGA -475 add Sign operator to singa URL: https://github.com/apache/incubator-singa/pull/488#issuecomment-519866518 This is what tensorflow use: ```cpp Status SignGrad(const Scope& scope, const Operation& op, const std::vector&

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #488: SINGA -475 add Sign operator to singa

2019-08-09 Thread GitBox
chrishkchris edited a comment on issue #488: SINGA -475 add Sign operator to singa URL: https://github.com/apache/incubator-singa/pull/488#issuecomment-519866518 This is what tensorflow use: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/cc/gradients/math_grad.cc#L268

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #488: SINGA -475 add Sign operator to singa

2019-08-09 Thread GitBox
chrishkchris edited a comment on issue #488: SINGA -475 add Sign operator to singa URL: https://github.com/apache/incubator-singa/pull/488#issuecomment-519866518 This is what tensorflow uses: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/cc/gradients/math_grad.cc#L268

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #488: SINGA -475 add Sign operator to singa

2019-08-09 Thread GitBox
chrishkchris commented on a change in pull request #488: SINGA -475 add Sign operator to singa URL: https://github.com/apache/incubator-singa/pull/488#discussion_r311838195 ## File path: python/singa/autograd.py ## @@ -1828,3 +1828,18 @@ def backward(self, dy): def

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #488: SINGA -475 add Sign operator to singa

2019-08-09 Thread GitBox
chrishkchris edited a comment on issue #488: SINGA -475 add Sign operator to singa URL: https://github.com/apache/incubator-singa/pull/488#issuecomment-519866518 This is what tensorflow use: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/cc/gradients/math_grad.cc#L268

[GitHub] [incubator-singa] chrishkchris commented on issue #487: SINGA -475 add Log operator to singa

2019-08-09 Thread GitBox
chrishkchris commented on issue #487: SINGA -475 add Log operator to singa URL: https://github.com/apache/incubator-singa/pull/487#issuecomment-519882837 Yes, could pinpom please merge your branch with master branch, or send a new pr after copying the new codes. I guess this maybe

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #488: SINGA -475 add Sign operator to singa

2019-08-09 Thread GitBox
chrishkchris edited a comment on issue #488: SINGA -475 add Sign operator to singa URL: https://github.com/apache/incubator-singa/pull/488#issuecomment-519866518 This is what tensorflow use: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/cc/gradients/math_grad.cc#L268

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #499: SINGA -475 add Div operator

2019-08-09 Thread GitBox
chrishkchris edited a comment on issue #499: SINGA -475 add Div operator URL: https://github.com/apache/incubator-singa/pull/499#issuecomment-519877683 There are conflicts and there are two solutions (same as what happened in log operator): 1. merge this branch with the latest master

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #487: SINGA -475 add Log operator to singa

2019-08-09 Thread GitBox
chrishkchris edited a comment on issue #487: SINGA -475 add Log operator to singa URL: https://github.com/apache/incubator-singa/pull/487#issuecomment-519882837 Yes, could pinpom please merge your branch with latest master branch, or send a new pr after copying the new codes. I

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #499: SINGA -475 add Div operator

2019-08-09 Thread GitBox
chrishkchris edited a comment on issue #499: SINGA -475 add Div operator URL: https://github.com/apache/incubator-singa/pull/499#issuecomment-519877683 There are conflicts and there are two solutions (same as what happened in log operator): 1. merge this branch with the latest master

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-01 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r309709702 ## File path: src/api/config.i ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [incubator-singa] ShichengChen opened a new pull request #496: Mean

2019-07-31 Thread GitBox
ShichengChen opened a new pull request #496: Mean URL: https://github.com/apache/incubator-singa/pull/496 Implement ONNX Operators following https://github.com/onnx/onnx/blob/master/docs/Operators.md This is an automated

[GitHub] [incubator-singa] joddiy commented on a change in pull request #484: SINGA -475 add Div operator implementation to singa

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #484: SINGA -475 add Div operator implementation to singa URL: https://github.com/apache/incubator-singa/pull/484#discussion_r309663843 ## File path: test/python/test_operation.py ## @@ -322,6 +322,21 @@ def

[GitHub] [incubator-singa] joddiy commented on a change in pull request #484: SINGA -475 add Div operator implementation to singa

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #484: SINGA -475 add Div operator implementation to singa URL: https://github.com/apache/incubator-singa/pull/484#discussion_r309663270 ## File path: python/singa/autograd.py ## @@ -1787,6 +1787,22 @@ def abs(a): return

[GitHub] [incubator-singa] joddiy commented on issue #491: SINGA-474 less operator

2019-08-01 Thread GitBox
joddiy commented on issue #491: SINGA-474 less operator URL: https://github.com/apache/incubator-singa/pull/491#issuecomment-517262483 I'm not very sure whether logical operators should have gradients. please refer to

[GitHub] [incubator-singa] joddiy commented on issue #490: SINGA-474 equal operator

2019-08-01 Thread GitBox
joddiy commented on issue #490: SINGA-474 equal operator URL: https://github.com/apache/incubator-singa/pull/490#issuecomment-517262568 I'm not very sure whether logical operators should have gradients. please refer to

[GitHub] [incubator-singa] joddiy commented on issue #481: SINGA-474 greater operator

2019-08-01 Thread GitBox
joddiy commented on issue #481: SINGA-474 greater operator URL: https://github.com/apache/incubator-singa/pull/481#issuecomment-517262583 I'm not very sure whether logical operators should have gradients. please refer to

[GitHub] [incubator-singa] joddiy commented on a change in pull request #482: SINGA-474 hardsigmoid operator

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #482: SINGA-474 hardsigmoid operator URL: https://github.com/apache/incubator-singa/pull/482#discussion_r309685974 ## File path: python/singa/autograd.py ## @@ -358,6 +358,51 @@ def relu(x): return ReLU()(x)[0] +class

[GitHub] [incubator-singa] joddiy commented on a change in pull request #482: SINGA-474 hardsigmoid operator

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #482: SINGA-474 hardsigmoid operator URL: https://github.com/apache/incubator-singa/pull/482#discussion_r309671456 ## File path: python/singa/autograd.py ## @@ -358,6 +358,51 @@ def relu(x): return ReLU()(x)[0] +class

[GitHub] [incubator-singa] joddiy commented on a change in pull request #487: SINGA -475 add Log operator to singa

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #487: SINGA -475 add Log operator to singa URL: https://github.com/apache/incubator-singa/pull/487#discussion_r309652140 ## File path: test/python/test_operation.py ## @@ -610,6 +610,18 @@ def test_Atanh_gpu(self):

[GitHub] [incubator-singa] joddiy commented on a change in pull request #485: SINGA -475 add Sub operator implementation to singa

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #485: SINGA -475 add Sub operator implementation to singa URL: https://github.com/apache/incubator-singa/pull/485#discussion_r309661987 ## File path: test/python/test_operation.py ## @@ -322,6 +322,21 @@ def

[GitHub] [incubator-singa] joddiy commented on a change in pull request #483: SINGA-474 identity operator

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #483: SINGA-474 identity operator URL: https://github.com/apache/incubator-singa/pull/483#discussion_r309664724 ## File path: test/python/test_operation.py ## @@ -322,6 +322,27 @@ def test_LeakyRelu(self):

[GitHub] [incubator-singa] joddiy commented on a change in pull request #483: SINGA-474 identity operator

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #483: SINGA-474 identity operator URL: https://github.com/apache/incubator-singa/pull/483#discussion_r309664758 ## File path: test/python/test_operation.py ## @@ -322,6 +322,27 @@ def test_LeakyRelu(self):

[GitHub] [incubator-singa] joddiy commented on a change in pull request #482: SINGA-474 hardsigmoid operator

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #482: SINGA-474 hardsigmoid operator URL: https://github.com/apache/incubator-singa/pull/482#discussion_r309685974 ## File path: python/singa/autograd.py ## @@ -358,6 +358,51 @@ def relu(x): return ReLU()(x)[0] +class

[GitHub] [incubator-singa] joddiy commented on a change in pull request #480: SINGA-474 ELU operator

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #480: SINGA-474 ELU operator URL: https://github.com/apache/incubator-singa/pull/480#discussion_r309704143 ## File path: test/python/test_operation.py ## @@ -322,6 +336,34 @@ def test_LeakyRelu(self):

[GitHub] [incubator-singa] joddiy commented on a change in pull request #480: SINGA-474 ELU operator

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #480: SINGA-474 ELU operator URL: https://github.com/apache/incubator-singa/pull/480#discussion_r309687031 ## File path: python/singa/autograd.py ## @@ -358,6 +358,48 @@ def relu(x): return ReLU()(x)[0] +class

[GitHub] [incubator-singa] joddiy commented on a change in pull request #480: SINGA-474 ELU operator

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #480: SINGA-474 ELU operator URL: https://github.com/apache/incubator-singa/pull/480#discussion_r309702428 ## File path: python/singa/autograd.py ## @@ -358,6 +358,48 @@ def relu(x): return ReLU()(x)[0] +class

[GitHub] [incubator-singa] joddiy commented on a change in pull request #480: SINGA-474 ELU operator

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #480: SINGA-474 ELU operator URL: https://github.com/apache/incubator-singa/pull/480#discussion_r309702428 ## File path: python/singa/autograd.py ## @@ -358,6 +358,48 @@ def relu(x): return ReLU()(x)[0] +class

[GitHub] [incubator-singa] joddiy commented on a change in pull request #480: SINGA-474 ELU operator

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #480: SINGA-474 ELU operator URL: https://github.com/apache/incubator-singa/pull/480#discussion_r309766405 ## File path: python/singa/autograd.py ## @@ -358,6 +358,48 @@ def relu(x): return ReLU()(x)[0] +class

[GitHub] [incubator-singa] joddiy commented on a change in pull request #480: SINGA-474 ELU operator

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #480: SINGA-474 ELU operator URL: https://github.com/apache/incubator-singa/pull/480#discussion_r309766714 ## File path: python/singa/autograd.py ## @@ -358,6 +358,48 @@ def relu(x): return ReLU()(x)[0] +class

[GitHub] [incubator-singa] joddiy commented on a change in pull request #480: SINGA-474 ELU operator

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #480: SINGA-474 ELU operator URL: https://github.com/apache/incubator-singa/pull/480#discussion_r309704143 ## File path: test/python/test_operation.py ## @@ -322,6 +336,34 @@ def test_LeakyRelu(self):

[GitHub] [incubator-singa] joddiy commented on a change in pull request #489: SINGA-474 selu operator

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #489: SINGA-474 selu operator URL: https://github.com/apache/incubator-singa/pull/489#discussion_r309771204 ## File path: python/singa/autograd.py ## @@ -357,6 +357,52 @@ def backward(self, dy): def relu(x): return

[GitHub] [incubator-singa] joddiy commented on a change in pull request #480: SINGA-474 ELU operator

2019-08-01 Thread GitBox
joddiy commented on a change in pull request #480: SINGA-474 ELU operator URL: https://github.com/apache/incubator-singa/pull/480#discussion_r309687031 ## File path: python/singa/autograd.py ## @@ -358,6 +358,48 @@ def relu(x): return ReLU()(x)[0] +class

[GitHub] [incubator-singa] chrishkchris opened a new pull request #500: SINGA-478 (Python 3 uses __itruediv__ instead of __idiv__)

2019-08-08 Thread GitBox
chrishkchris opened a new pull request #500: SINGA-478 (Python 3 uses __itruediv__ instead of __idiv__) URL: https://github.com/apache/incubator-singa/pull/500 We need to add `__itruediv__` for python 3 in tensor.py because the original `__idiv__` is not supported by python 3 anymore.

[GitHub] [incubator-singa] dcslin opened a new pull request #477: used shared module to manage device creation to avoid singleton error

2019-07-19 Thread GitBox
dcslin opened a new pull request #477: used shared module to manage device creation to avoid singleton error URL: https://github.com/apache/incubator-singa/pull/477 This is an automated message from the Apache Git Service.

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-07-19 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r305247134 ## File path: src/api/config.i ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [incubator-singa] chrishkchris opened a new pull request #478: Singa 473 (Implement ONNX Operators in Autograd: Trigonometry functions)

2019-07-25 Thread GitBox
chrishkchris opened a new pull request #478: Singa 473 (Implement ONNX Operators in Autograd: Trigonometry functions) URL: https://github.com/apache/incubator-singa/pull/478 This PR corresponds to JIRA ticket SINGA-473 (Implement ONNX Operators in Autograd: Trigonometry functions).

[GitHub] [incubator-singa] chrishkchris commented on issue #478: SINGA-473 (Implement ONNX Operators in Autograd: Trigonometry functions)

2019-07-25 Thread GitBox
chrishkchris commented on issue #478: SINGA-473 (Implement ONNX Operators in Autograd: Trigonometry functions) URL: https://github.com/apache/incubator-singa/pull/478#issuecomment-515286829 The test in my ncre docker development environment:

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #478: SINGA-473 (Implement ONNX Operators in Autograd: Trigonometry functions)

2019-07-25 Thread GitBox
chrishkchris edited a comment on issue #478: SINGA-473 (Implement ONNX Operators in Autograd: Trigonometry functions) URL: https://github.com/apache/incubator-singa/pull/478#issuecomment-515286829 The test in my ncrf docker development environment:

[GitHub] [incubator-singa] nudles merged pull request #477: used shared module to manage device creation to avoid singleton error

2019-07-21 Thread GitBox
nudles merged pull request #477: used shared module to manage device creation to avoid singleton error URL: https://github.com/apache/incubator-singa/pull/477 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-singa] nudles merged pull request #533: fixed operation add assertion for convolution

2019-09-19 Thread GitBox
nudles merged pull request #533: fixed operation add assertion for convolution URL: https://github.com/apache/incubator-singa/pull/533 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-singa] nudles merged pull request #535: SINGA-490 Optimize performance of stochastic gradient descent (SGD)

2019-09-19 Thread GitBox
nudles merged pull request #535: SINGA-490 Optimize performance of stochastic gradient descent (SGD) URL: https://github.com/apache/incubator-singa/pull/535 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-singa] dcslin commented on issue #533: fixed operation add assertion for convolution

2019-09-19 Thread GitBox
dcslin commented on issue #533: fixed operation add assertion for convolution URL: https://github.com/apache/incubator-singa/pull/533#issuecomment-533383280 Hi @nudles , this is ready for merge. thanks to @chrishkchris

[GitHub] [incubator-singa] nudles merged pull request #529: SINGA-484 Code analysis with LGTM

2019-09-19 Thread GitBox
nudles merged pull request #529: SINGA-484 Code analysis with LGTM URL: https://github.com/apache/incubator-singa/pull/529 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-singa] moazreyad commented on issue #536: SINGA-491 Code Cleaning with the Reference of LGTM Analysis Result

2019-09-20 Thread GitBox
moazreyad commented on issue #536: SINGA-491 Code Cleaning with the Reference of LGTM Analysis Result URL: https://github.com/apache/incubator-singa/pull/536#issuecomment-533497942 Thank you. In future we should not accept only the compile output alone, we should also run the unit

[GitHub] [incubator-singa] dcslin opened a new pull request #538: add Cudnn mode as optional param to batch norm and softmax

2019-09-26 Thread GitBox
dcslin opened a new pull request #538: add Cudnn mode as optional param to batch norm and softmax URL: https://github.com/apache/incubator-singa/pull/538 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-singa] nudles merged pull request #537: SINGA-488 Change the path of source code for CI

2019-09-26 Thread GitBox
nudles merged pull request #537: SINGA-488 Change the path of source code for CI URL: https://github.com/apache/incubator-singa/pull/537 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-singa] nudles merged pull request #539: SINGA-491 Python Code Cleaning

2019-10-01 Thread GitBox
nudles merged pull request #539: SINGA-491 Python Code Cleaning URL: https://github.com/apache/incubator-singa/pull/539 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-singa] dcslin opened a new pull request #540: added softmax with axis

2019-10-02 Thread GitBox
dcslin opened a new pull request #540: added softmax with axis URL: https://github.com/apache/incubator-singa/pull/540 splitting https://github.com/apache/incubator-singa/pull/538 into two parts, this PR is for softmax with axis, which is compatible to onnx api

[GitHub] [incubator-singa] chrishkchris opened a new pull request #536: SINGA-491 Code Cleaning with the Reference of LGTM Analysis Result

2019-09-20 Thread GitBox
chrishkchris opened a new pull request #536: SINGA-491 Code Cleaning with the Reference of LGTM Analysis Result URL: https://github.com/apache/incubator-singa/pull/536 Since LGTM has been applied for our code analysis (see SINGA-484), I have cleaned up many of the obvious issues alerted

[GitHub] [incubator-singa] chrishkchris opened a new pull request #539: SINGA-491 Python Code Cleaning

2019-09-30 Thread GitBox
chrishkchris opened a new pull request #539: SINGA-491 Python Code Cleaning URL: https://github.com/apache/incubator-singa/pull/539 Only Python code is cleaned at this time that is likely to remove around hundred alerts in python code. Since there are lots of changes in the folders

[GitHub] [incubator-singa] dcslin opened a new pull request #471: SINGA-463

2019-06-27 Thread GitBox
dcslin opened a new pull request #471: SINGA-463 URL: https://github.com/apache/incubator-singa/pull/471 fixed bugs for python test operation abs, exp, leakyrelu ref. SINGA-463 related: SINGA-425 https://github.com/apache/incubator-singa/pull/435

[GitHub] [incubator-singa] sjs253 opened a new pull request #473: SINGA-466 Centos7 Installation instructions

2019-06-30 Thread GitBox
sjs253 opened a new pull request #473: SINGA-466 Centos7 Installation instructions URL: https://github.com/apache/incubator-singa/pull/473 Instructions for Centos7 SINGA installation added to the Installation.md file. This

[GitHub] [incubator-singa] dcslin opened a new pull request #476: fixed python test_loss

2019-07-04 Thread GitBox
dcslin opened a new pull request #476: fixed python test_loss URL: https://github.com/apache/incubator-singa/pull/476 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-singa] dcslin opened a new pull request #548: DNNL(upgrade of MKLDNN) integration and add softmax

2019-10-16 Thread GitBox
dcslin opened a new pull request #548: DNNL(upgrade of MKLDNN) integration and add softmax URL: https://github.com/apache/incubator-singa/pull/548 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-singa] chrishkchris commented on issue #536: SINGA-491 Code Cleaning with the Reference of LGTM Analysis Result

2019-09-20 Thread GitBox
chrishkchris commented on issue #536: SINGA-491 Code Cleaning with the Reference of LGTM Analysis Result URL: https://github.com/apache/incubator-singa/pull/536#issuecomment-533585944 Thanks so much for your comments. It is a great idea concerning the CI.

[GitHub] [incubator-singa] nudles merged pull request #536: SINGA-491 Code Cleaning with the Reference of LGTM Analysis Result

2019-09-24 Thread GitBox
nudles merged pull request #536: SINGA-491 Code Cleaning with the Reference of LGTM Analysis Result URL: https://github.com/apache/incubator-singa/pull/536 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-singa] nudles merged pull request #528: SINGA 475 - add logical operator: and, or, xor, not & negative, reciprocal

2019-09-24 Thread GitBox
nudles merged pull request #528: SINGA 475 - add logical operator: and, or, xor, not & negative, reciprocal URL: https://github.com/apache/incubator-singa/pull/528 This is an automated message from the Apache Git Service.

[GitHub] [incubator-singa] chrishkchris opened a new pull request #537: SINGA-488 Change the path of source code for CI

2019-09-24 Thread GitBox
chrishkchris opened a new pull request #537: SINGA-488 Change the path of source code for CI URL: https://github.com/apache/incubator-singa/pull/537 This will fix the issue in "SINGA-488 Travis CI always build from Apache master branch"

[GitHub] [incubator-singa] dcslin commented on issue #514: SINGA-482 tc comprehension integration

2019-09-23 Thread GitBox
dcslin commented on issue #514: SINGA-482 tc comprehension integration URL: https://github.com/apache/incubator-singa/pull/514#issuecomment-534047644 Integration is done except support CPU. CPU support development is done, however the behavior was not expected even in clean TC env.

[GitHub] [incubator-singa] dcslin commented on issue #540: added softmax with axis

2019-10-07 Thread GitBox
dcslin commented on issue #540: added softmax with axis URL: https://github.com/apache/incubator-singa/pull/540#issuecomment-538955169 > still has some problems, the output of multiple dimension inputs is not correct. > please check: > > ``` > x_0 = np.array([[0, 1, 2, 3],

[GitHub] [incubator-singa] joddiy commented on issue #540: added softmax with axis

2019-10-07 Thread GitBox
joddiy commented on issue #540: added softmax with axis URL: https://github.com/apache/incubator-singa/pull/540#issuecomment-538984488 > > still has some problems, the output of multiple dimension inputs is not correct. > > please check: > > ``` > > x_0 = np.array([[0, 1, 2, 3],

[GitHub] [incubator-singa] joddiy opened a new pull request #545: SINGA-494 Singa autograd improvement

2019-10-08 Thread GitBox
joddiy opened a new pull request #545: SINGA-494 Singa autograd improvement URL: https://github.com/apache/incubator-singa/pull/545 ## Background: some autograd ops cannot satisfy the onnx demand, as following: ### conv, averagepool, maxpool - only support 2d input, i.e,

[GitHub] [incubator-singa] dcslin commented on issue #541: added 4d test on batchnorm

2019-10-08 Thread GitBox
dcslin commented on issue #541: added 4d test on batchnorm URL: https://github.com/apache/incubator-singa/pull/541#issuecomment-539449929 HI @joddiy , could you please help to review this test on batchnorm value? which also showing that the required params/output by ONNX are given.

[GitHub] [incubator-singa-site] nudles merged pull request #1: SINGA-493 Update SINGA website

2019-10-09 Thread GitBox
nudles merged pull request #1: SINGA-493 Update SINGA website URL: https://github.com/apache/incubator-singa-site/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-singa] nudles merged pull request #546: SINGA-491 Remaining LGTM Python Code Cleaning

2019-10-09 Thread GitBox
nudles merged pull request #546: SINGA-491 Remaining LGTM Python Code Cleaning URL: https://github.com/apache/incubator-singa/pull/546 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-singa] dcslin closed pull request #538: [WIP] add Cudnn mode as optional param to batch norm and softmax

2019-10-10 Thread GitBox
dcslin closed pull request #538: [WIP] add Cudnn mode as optional param to batch norm and softmax URL: https://github.com/apache/incubator-singa/pull/538 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-singa] dcslin commented on issue #538: [WIP] add Cudnn mode as optional param to batch norm and softmax

2019-10-10 Thread GitBox
dcslin commented on issue #538: [WIP] add Cudnn mode as optional param to batch norm and softmax URL: https://github.com/apache/incubator-singa/pull/538#issuecomment-540511768 split to https://github.com/apache/incubator-singa/pull/540 and

[GitHub] [incubator-singa] joddiy commented on issue #540: added softmax with axis

2019-10-10 Thread GitBox
joddiy commented on issue #540: added softmax with axis URL: https://github.com/apache/incubator-singa/pull/540#issuecomment-540567614 ready to merge This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-singa] joddiy edited a comment on issue #541: added 4d test on batchnorm

2019-10-10 Thread GitBox
joddiy edited a comment on issue #541: added 4d test on batchnorm URL: https://github.com/apache/incubator-singa/pull/541#issuecomment-540600410 hi, shicong, the result still has a little error, please check with the following case: ``` def _batchnorm_test_mode(x, s, bias, mean, var,

[GitHub] [incubator-singa] joddiy commented on issue #541: added 4d test on batchnorm

2019-10-10 Thread GitBox
joddiy commented on issue #541: added 4d test on batchnorm URL: https://github.com/apache/incubator-singa/pull/541#issuecomment-540600410 hi, shicong, the result still has a little error, please check with the following case: ``` def _batchnorm_test_mode(x, s, bias, mean,

[GitHub] [incubator-singa] chrishkchris opened a new pull request #547: SINGA-493 Add an additional build path

2019-10-10 Thread GitBox
chrishkchris opened a new pull request #547: SINGA-493 Add an additional build path URL: https://github.com/apache/incubator-singa/pull/547 Add an webpage build path in build.sh This is an automated message from the Apache

[GitHub] [incubator-singa] dcslin edited a comment on issue #541: added 4d test on batchnorm

2019-10-10 Thread GitBox
dcslin edited a comment on issue #541: added 4d test on batchnorm URL: https://github.com/apache/incubator-singa/pull/541#issuecomment-540867039 HI @joddiy , could you share how did you call singa api? the test you mentioned is tested in here

[GitHub] [incubator-singa] dcslin commented on issue #541: added 4d test on batchnorm

2019-10-10 Thread GitBox
dcslin commented on issue #541: added 4d test on batchnorm URL: https://github.com/apache/incubator-singa/pull/541#issuecomment-540867039 HI @joddiy , could you share how did you call singa api? the test you mentioned is tested in here

<    2   3   4   5   6   7   8   >