[GitHub] [incubator-singa] chrishkchris commented on issue #488: SINGA -475 add Sign operator to singa

2019-08-09 Thread GitBox
chrishkchris commented on issue #488: SINGA -475 add Sign operator to singa URL: https://github.com/apache/incubator-singa/pull/488#issuecomment-519876368 there are conflicts and there are two solutions (same as what happened in log operator): 1. merge this branch with the latest

[GitHub] [incubator-singa] chrishkchris commented on issue #488: SINGA -475 add Sign operator to singa

2019-08-09 Thread GitBox
chrishkchris commented on issue #488: SINGA -475 add Sign operator to singa URL: https://github.com/apache/incubator-singa/pull/488#issuecomment-519866518 This is what tensorflow use: ```cpp Status SignGrad(const Scope& scope, const Operation& op, const std::vector&

[GitHub] [incubator-singa] chrishkchris commented on issue #488: SINGA -475 add Sign operator to singa

2019-08-09 Thread GitBox
chrishkchris commented on issue #488: SINGA -475 add Sign operator to singa URL: https://github.com/apache/incubator-singa/pull/488#issuecomment-519856801 In my opinion: For the function y=sign(x) , y = 1 when x > 0, y = -1 when x < 0. Therefore, the derivative is 0 except x = 0.