[GitHub] [incubator-singa] dcslin commented on issue #533: fixed operation add assertion for convolution

2019-09-19 Thread GitBox 
dcslin commented on issue #533: fixed operation add assertion for convolution
URL: https://github.com/apache/incubator-singa/pull/533#issuecomment-533383280
 
 
   Hi @nudles , this is ready for merge.
   thanks to @chrishkchris 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-singa] dcslin commented on issue #533: fixed operation add assertion for convolution

2019-09-11 Thread GitBox 
dcslin commented on issue #533: fixed operation add assertion for convolution
URL: https://github.com/apache/incubator-singa/pull/533#issuecomment-530344769
 
 
   after the fix, testing on `python/resnet.py` shows similar result:
   Before:
   ```
   
100%|###|
 100/100 [00:27<00:00,  3.68it/s]
   Throughput = 58.903093484671295 per second
   Total=0.27163259267807005, forward=0.028347208499908447, 
softmax=0.10690386295318603, backward=0.13638152122497554, 
sgd=0.08405628204345703
   ```
   
   After:
   ```
   
100%|###|
 100/100 [00:27<00:00,  3.69it/s]
   Throughput = 59.02303205471914 per second
   Total=0.2710806179046631, forward=0.02830531120300293, 
softmax=0.10648007154464721, backward=0.13629523515701297, 
sgd=0.08383089303970337
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-singa] dcslin commented on issue #533: fixed operation add assertion for convolution

2019-09-11 Thread GitBox 
dcslin commented on issue #533: fixed operation add assertion for convolution
URL: https://github.com/apache/incubator-singa/pull/533#issuecomment-530340346
 
 
   2nd commit fixed that "cudnn softmax is not used" mentioned in 
https://github.com/apache/incubator-singa/pull/468#issuecomment-521247206


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services